From 02ce35189669a0894bd1b16808a886f3867b1c86 Mon Sep 17 00:00:00 2001 From: Sagi Grimberg Date: Wed, 19 Aug 2020 03:31:57 -0700 Subject: [PATCH] fabrics: fix segfault when -t is not passed Need to check if transport was provided before we derefernce it. Fixes: 9da606b4afcc ("fabrics: allow traddr to be host name for ip based transports") Signed-off-by: Sagi Grimberg Reviewed-by: Chaitanya Kulkarni --- fabrics.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fabrics.c b/fabrics.c index 73bb3752..c93b752f 100644 --- a/fabrics.c +++ b/fabrics.c @@ -923,7 +923,7 @@ static bool traddr_is_hostname(struct config *cfg) { char addrstr[NVMF_TRADDR_SIZE]; - if (!cfg->traddr) + if (!cfg->traddr || !cfg->transport) return false; if (strcmp(cfg->transport, "tcp") && strcmp(cfg->transport, "rdma")) return false; -- 2.50.1