]> www.infradead.org Git - users/dwmw2/linux.git/commit
bitmap: Switch from inline to __always_inline
authorYury Norov <yury.norov@gmail.com>
Fri, 19 Jul 2024 00:50:38 +0000 (17:50 -0700)
committerYury Norov <yury.norov@gmail.com>
Sun, 18 Aug 2024 17:07:59 +0000 (10:07 -0700)
commited8cd2b3bd9f070120528fc5403a2d0b5afe07f8
tree7617939645c582f14e8caa01c7c8b7be120300e6
parentfda1dd3c54ef3c4200c2e77634a91610da973950
bitmap: Switch from inline to __always_inline

'inline' keyword is only a recommendation for compiler. If it decides to
not inline bitmap functions, the whole small_const_nbits() machinery
doesn't work.

This is how a standard GCC 11.3.0 does for my x86_64 build now. This patch
replaces 'inline' directive with unconditional '__always_inline' to make
sure that there's always a chance for compile-time optimization. It doesn't
change size of kernel image, according to bloat-o-meter.

[[ Brian: split out from:
      Subject: [PATCH 1/3] bitmap: switch from inline to __always_inline
      https://lore.kernel.org/all/20221027043810.350460-2-yury.norov@gmail.com/
   But rewritten, as there were too many conflicts. ]]

Co-developed-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Kees Cook <kees@kernel.org>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Yury Norov <yury.norov@gmail.com>
include/linux/bitmap.h