]> www.infradead.org Git - users/jedix/linux-maple.git/commit
dmaengine: at_xdmac: Fix wrongfull report of a channel as in use
authorCodrin Ciubotariu <codrin.ciubotariu@microchip.com>
Wed, 23 Jan 2019 16:33:47 +0000 (16:33 +0000)
committerVinod Koul <vkoul@kernel.org>
Sat, 2 Feb 2019 10:25:26 +0000 (15:55 +0530)
commitdc3f595b6617ebc0307e0ce151e8f2f2b2489b95
tree80b4634f6b1782a5ddab15ce39681c02c0f53ebc
parentbfeffd155283772bbe78c6a05dec7c0128ee500c
dmaengine: at_xdmac: Fix wrongfull report of a channel as in use

atchan->status variable is used to store two different information:
 - pass channel interrupts status from interrupt handler to tasklet;
 - channel information like whether it is cyclic or paused;

This causes a bug when device_terminate_all() is called,
(AT_XDMAC_CHAN_IS_CYCLIC cleared on atchan->status) and then a late End
of Block interrupt arrives (AT_XDMAC_CIS_BIS), which sets bit 0 of
atchan->status. Bit 0 is also used for AT_XDMAC_CHAN_IS_CYCLIC, so when
a new descriptor for a cyclic transfer is created, the driver reports
the channel as in use:

if (test_and_set_bit(AT_XDMAC_CHAN_IS_CYCLIC, &atchan->status)) {
dev_err(chan2dev(chan), "channel currently used\n");
return NULL;
}

This patch fixes the bug by adding a different struct member to keep
the interrupts status separated from the channel status bits.

Fixes: e1f7c9eee707 ("dmaengine: at_xdmac: creation of the atmel eXtended DMA Controller driver")
Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/at_xdmac.c