]> www.infradead.org Git - users/hch/misc.git/commit
perf tools: Fix precise_ip fallback logic
authorNamhyung Kim <namhyung@kernel.org>
Thu, 5 Dec 2024 23:15:29 +0000 (15:15 -0800)
committerNamhyung Kim <namhyung@kernel.org>
Thu, 5 Dec 2024 23:15:29 +0000 (15:15 -0800)
commitc33aea446bf555ab2b4e06deb914ba8f87cdb068
tree33d6b550af3b955a10a37a3e54a3c425afffa59b
parent968121f0a649ee2ff5ac7b29aa4d4f6b0798ea9e
perf tools: Fix precise_ip fallback logic

Sometimes it returns other than EOPNOTSUPP for invalid precise_ip so
it cannot check the error code.  Let's move the fallback after the
missing feature checks so that it can handle EINVAL as well.  This also
aligns well with the existing behavior which blindly turns off the
precise_ip but we check the missing features correctly now.

Fixes: af954f76eea56453 ("perf tools: Check fallback error and order")
Reported-by: kernel test robot <oliver.sang@intel.com>
Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Closes: https://lore.kernel.org/oe-lkp/202411301431.799e5531-lkp@intel.com
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Link: https://lore.kernel.org/r/Z1DV0lN8qHSysX7f@google.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
tools/perf/util/evsel.c