]> www.infradead.org Git - users/willy/pagecache.git/commit
ALSA: ump: Don't enumeration invalid groups for legacy rawmidi
authorTakashi Iwai <tiwai@suse.de>
Mon, 4 Nov 2024 10:07:34 +0000 (11:07 +0100)
committerTakashi Iwai <tiwai@suse.de>
Mon, 4 Nov 2024 10:08:46 +0000 (11:08 +0100)
commitc2d188e137e77294323132a760a4608321a36a70
tree316f9b0b7ba9fc61b7a4c0ea1ff8770bccc90c9c
parentc9363bbb0f68dd1ddb8be7bbfe958cdfcd38d851
ALSA: ump: Don't enumeration invalid groups for legacy rawmidi

The legacy rawmidi tries to enumerate all possible UMP groups
belonging to the UMP endpoint.  But currently it shows all 16 ports
when the UMP endpoint is configured with static blocks, although most
of them may be unused.

There was already a fix for the sequencer client side to ignore such
groups in the commit 3bfd7c0ba184 ("ALSA: seq: ump: Skip useless ports
for static blocks"), and this commit is a similar fix for UMP
rawmidi devices; it adds simply the check for the validity of each
group that has been already parsed.  (Note that the group info was
moved to snd_ump_endpoint.groups[] by the commit 0642a3c5cacc0321c755
("ALSA: ump: Update substream name from assigned FB names")).

Link: https://patch.msgid.link/20241104100735.16127-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/ump.c