]> www.infradead.org Git - users/jedix/linux-maple.git/commit
spi: Skip zero-length transfers in spi_transfer_one_message()
authorNicolas Saenz Julienne <nsaenzjulienne@suse.de>
Thu, 11 Feb 2021 18:08:20 +0000 (19:08 +0100)
committerMark Brown <broonie@kernel.org>
Fri, 12 Feb 2021 12:41:59 +0000 (12:41 +0000)
commitb306320322c9cfaa465bc2c7367acf6072b1ac0e
treed4b96f171e062dfe9e3a5ef8d1902b3fe3c316bb
parent386f771aad15dd535f2368b4adc9958c0160edd4
spi: Skip zero-length transfers in spi_transfer_one_message()

With the introduction of 26751de25d25 ("spi: bcm2835: Micro-optimise
FIFO loops") it has become apparent that some users might initiate
zero-length SPI transfers. A fact the micro-optimization omitted, and
which turned out to cause crashes[1].

Instead of changing the micro-optimization itself, use a bigger hammer
and skip zero-length transfers altogether for drivers using the default
transfer_one_message() implementation.

Reported-by: Phil Elwell <phil@raspberrypi.com>
Fixes: 26751de25d25 ("spi: bcm2835: Micro-optimise FIFO loops")
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
[1] https://github.com/raspberrypi/linux/issues/4100
Link: https://lore.kernel.org/r/20210211180820.25757-1-nsaenzjulienne@suse.de
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi.c