]> www.infradead.org Git - users/hch/misc.git/commit
tracing: tprobe-events: Fix leakage of module refcount
authorMasami Hiramatsu (Google) <mhiramat@kernel.org>
Thu, 13 Mar 2025 01:00:10 +0000 (10:00 +0900)
committerMasami Hiramatsu (Google) <mhiramat@kernel.org>
Fri, 14 Mar 2025 23:37:47 +0000 (08:37 +0900)
commitac91052f0ae5be9e46211ba92cc31c0e3b0a933a
treead38089c78a06052af51003a0eb6f4f413c17701
parent0a8bb688aa824863716fc570d818b8659a79309d
tracing: tprobe-events: Fix leakage of module refcount

When enabling the tracepoint at loading module, the target module
refcount is incremented by find_tracepoint_in_module(). But it is
unnecessary because the module is not unloaded while processing
module loading callbacks.
Moreover, the refcount is not decremented in that function.
To be clear the module refcount handling, move the try_module_get()
callsite to trace_fprobe_create_internal(), where it is actually
required.

Link: https://lore.kernel.org/all/174182761071.83274.18334217580449925882.stgit@devnote2/
Fixes: 57a7e6de9e30 ("tracing/fprobe: Support raw tracepoints on future loaded modules")
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Cc: stable@vger.kernel.org
kernel/trace/trace_fprobe.c