]> www.infradead.org Git - nvme.git/commit
cpufreq: schedutil: Fix superfluous updates caused by need_freq_update
authorSultan Alsawaf (unemployed) <sultan@kerneltoast.com>
Thu, 12 Dec 2024 01:57:32 +0000 (17:57 -0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 18 Dec 2024 15:00:29 +0000 (16:00 +0100)
commit8e461a1cb43d69d2fc8a97e61916dce571e6bb31
tree36df3037fe210d1833bd73c64c704593b9f0bb36
parentde51589f9bd98efddf4ab776d3a490e81905ef7c
cpufreq: schedutil: Fix superfluous updates caused by need_freq_update

A redundant frequency update is only truly needed when there is a policy
limits change with a driver that specifies CPUFREQ_NEED_UPDATE_LIMITS.

In spite of that, drivers specifying CPUFREQ_NEED_UPDATE_LIMITS receive a
frequency update _all the time_, not just for a policy limits change,
because need_freq_update is never cleared.

Furthermore, ignore_dl_rate_limit()'s usage of need_freq_update also leads
to a redundant frequency update, regardless of whether or not the driver
specifies CPUFREQ_NEED_UPDATE_LIMITS, when the next chosen frequency is the
same as the current one.

Fix the superfluous updates by only honoring CPUFREQ_NEED_UPDATE_LIMITS
when there's a policy limits change, and clearing need_freq_update when a
requisite redundant update occurs.

This is neatly achieved by moving up the CPUFREQ_NEED_UPDATE_LIMITS test
and instead setting need_freq_update to false in sugov_update_next_freq().

Fixes: 600f5badb78c ("cpufreq: schedutil: Don't skip freq update when limits change")
Signed-off-by: Sultan Alsawaf (unemployed) <sultan@kerneltoast.com>
Reviewed-by: Christian Loehle <christian.loehle@arm.com>
Link: https://patch.msgid.link/20241212015734.41241-2-sultan@kerneltoast.com
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
kernel/sched/cpufreq_schedutil.c