]> www.infradead.org Git - users/hch/configfs.git/commit
wifi: mac80211: fix BSS_CHANGED_UNSOL_BCAST_PROBE_RESP
authorJohannes Berg <johannes.berg@intel.com>
Thu, 27 Jun 2024 08:42:56 +0000 (10:42 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Fri, 28 Jun 2024 08:26:32 +0000 (10:26 +0200)
commit816c6bec09ed5b90a58a1e12d5a606c5b6e23f47
tree236a692ed74e1dbf757ec7b35d4dd1f8065cf5bf
parentc40ff9b662d08c86b7a46067155a97af0074bb93
wifi: mac80211: fix BSS_CHANGED_UNSOL_BCAST_PROBE_RESP

Fix the definition of BSS_CHANGED_UNSOL_BCAST_PROBE_RESP so that
not all higher bits get set, 1<<31 is a signed variable, so when
we do

  u64 changed = BSS_CHANGED_UNSOL_BCAST_PROBE_RESP;

we get sign expansion, so the value is 0xffff'ffff'8000'0000 and
that's clearly not desired. Use BIT_ULL() to make it unsigned as
well as the right type for the change flags.

Fixes: 178e9d6adc43 ("wifi: mac80211: fix unsolicited broadcast probe config")
Reviewed-by: Miriam Rachel Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20240627104257.06174d291db2.Iba0d642916eb78a61f8ab2cc5ca9280783d9c1db@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
include/net/mac80211.h