]> www.infradead.org Git - users/dwmw2/linux.git/commit
drm/xe/ct: prevent UAF in send_recv()
authorMatthew Auld <matthew.auld@intel.com>
Tue, 1 Oct 2024 08:43:47 +0000 (09:43 +0100)
committerMatthew Auld <matthew.auld@intel.com>
Thu, 3 Oct 2024 07:34:18 +0000 (08:34 +0100)
commit52789ce35c55ccd30c4b67b9cc5b2af55e0122ea
tree60800a2a1699c9b31e07f31708d90583230d3bbf
parent63e0695597a044c96bf369e4d8ba031291449d95
drm/xe/ct: prevent UAF in send_recv()

Ensure we serialize with completion side to prevent UAF with fence going
out of scope on the stack, since we have no clue if it will fire after
the timeout before we can erase from the xa. Also we have some dependent
loads and stores for which we need the correct ordering, and we lack the
needed barriers. Fix this by grabbing the ct->lock after the wait, which
is also held by the completion side.

v2 (Badal):
 - Also print done after acquiring the lock and seeing timeout.

Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Badal Nilawar <badal.nilawar@intel.com>
Cc: <stable@vger.kernel.org> # v6.8+
Reviewed-by: Badal Nilawar <badal.nilawar@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241001084346.98516-5-matthew.auld@intel.com
drivers/gpu/drm/xe/xe_guc_ct.c