]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/sched: drm_sched_job_cleanup(): correct false doc
authorPhilipp Stanner <phasta@kernel.org>
Tue, 4 Mar 2025 14:13:47 +0000 (15:13 +0100)
committerPhilipp Stanner <phasta@kernel.org>
Wed, 5 Mar 2025 13:13:59 +0000 (14:13 +0100)
commit44d2f310f008613c1dbe5e234c2cf2be90cbbfab
treea4fe7e4209729ae2cb2892240ddfcb3398e4a2f4
parentc82734fbdc50dc9e568e8686622eaa4498acb81e
drm/sched: drm_sched_job_cleanup(): correct false doc

drm_sched_job_cleanup()'s documentation claims that calling
drm_sched_job_arm() is a "point of no return", implying that afterwards
a job cannot be cancelled anymore.

This is not correct, as proven by the function's code itself, which
takes a previous call to drm_sched_job_arm() into account. In truth, the
decisive factors are whether fences have been shared (e.g., with other
processes) and if the job has been submitted to an entity already.

Correct the wrong docstring.

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Signed-off-by: Philipp Stanner <phasta@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20250304141346.102683-2-phasta@kernel.org
drivers/gpu/drm/scheduler/sched_main.c