]> www.infradead.org Git - users/dwmw2/linux.git/commit
net: phy: Immediately call adjust_link if only tx_lpi_enabled changes
authorAndrew Lunn <andrew@lunn.ch>
Sat, 2 Mar 2024 19:53:03 +0000 (20:53 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 6 Mar 2024 03:21:17 +0000 (19:21 -0800)
commit3e43b903da04927f60894a603678f761c66d6e37
tree6fff0d28765fcdb77907454d00b33fa0b60d6b83
parentfe0d4fd9285e5013b4bafbd3338847235b805a1c
net: phy: Immediately call adjust_link if only tx_lpi_enabled changes

The MAC driver changes its EEE hardware configuration in its
adjust_link callback. This is called when auto-neg
completes. Disabling EEE via eee_enabled false will trigger an
autoneg, and as a result the adjust_link callback will be called with
phydev->enable_tx_lpi set to false. Similarly, eee_enabled set to true
and with a change of advertised link modes will result in a new
autoneg, and a call the adjust_link call.

If set_eee is called with only a change to tx_lpi_enabled which does
not trigger an auto-neg, it is necessary to call the adjust_link
callback so that the MAC is reconfigured to take this change into
account.

When setting phydev->enable_tx_lpi, take both eee_enabled and
tx_lpi_enabled into account, so the MAC drivers just needs to act on
phydev->enable_tx_lpi and not the whole EEE configuration.
The same check should be done for tx_lpi_timer too.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20240302195306.3207716-5-o.rempel@pengutronix.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/phy-c45.c
drivers/net/phy/phy.c