]> www.infradead.org Git - users/dwmw2/linux.git/commit
drm/i915: mark requests for GuC virtual engines to avoid use-after-free
authorAndrzej Hajda <andrzej.hajda@intel.com>
Mon, 21 Aug 2023 15:30:35 +0000 (17:30 +0200)
committerAndi Shyti <andi.shyti@linux.intel.com>
Wed, 30 Aug 2023 12:06:50 +0000 (14:06 +0200)
commit280410677af763f3871b93e794a199cfcf6fb580
treef035e836f8881ce8729a5b68a5432a91677f81a9
parent7467e1da906468bcbd311023b30708193103ecf9
drm/i915: mark requests for GuC virtual engines to avoid use-after-free

References to i915_requests may be trapped by userspace inside a
sync_file or dmabuf (dma-resv) and held indefinitely across different
proceses. To counter-act the memory leaks, we try to not to keep
references from the request past their completion.
On the other side on fence release we need to know if rq->engine
is valid and points to hw engine (true for non-virtual requests).
To make it possible extra bit has been added to rq->execution_mask,
for marking virtual engines.

Fixes: bcb9aa45d5a0 ("Revert "drm/i915: Hold reference to intel_context over life of i915_request"")
Signed-off-by: Chris Wilson <chris.p.wilson@linux.intel.com>
Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230821153035.3903006-1-andrzej.hajda@intel.com
drivers/gpu/drm/i915/gt/intel_engine_types.h
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
drivers/gpu/drm/i915/i915_request.c