]> www.infradead.org Git - users/dwmw2/linux.git/commit
drm/sched: memset() 'job' in drm_sched_job_init()
authorPhilipp Stanner <pstanner@redhat.com>
Mon, 21 Oct 2024 10:50:28 +0000 (12:50 +0200)
committerPhilipp Stanner <pstanner@redhat.com>
Tue, 22 Oct 2024 14:08:41 +0000 (16:08 +0200)
commit2320c9e6a768d135c7b0039995182bb1a4e4fd22
treec6cb4e3cc4714066afc7938cd255d4502c63eb28
parentdf606be44c168417604a708e3d895f94b262d407
drm/sched: memset() 'job' in drm_sched_job_init()

drm_sched_job_init() has no control over how users allocate struct
drm_sched_job. Unfortunately, the function can also not set some struct
members such as job->sched.

This could theoretically lead to UB by users dereferencing the struct's
pointer members too early.

It is easier to debug such issues if these pointers are initialized to
NULL, so dereferencing them causes a NULL pointer exception.
Accordingly, drm_sched_entity_init() does precisely that and initializes
its struct with memset().

Initialize parameter "job" to 0 in drm_sched_job_init().

Signed-off-by: Philipp Stanner <pstanner@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241021105028.19794-2-pstanner@redhat.com
Reviewed-by: Christian König <christian.koenig@amd.com>
drivers/gpu/drm/scheduler/sched_main.c