Kill vmclock_remove compat hack

It's cleaned up through devres anyway now so there's no need for
compat with the old .remove method.

Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>

ptp: vmclock: Remove goto-based cleanup logic

vmclock_probe() uses an "out:" label to return from the function on
error. This indicates that some cleanup operation is necessary.
However the label does not do anything as all resources are managed
through devres, making the code slightly harder to read.

Remove the label and just return directly.

Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Reviewed-by: David Woodhouse <dwmw@amazon.co.uk>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
(cherry picked from commit b4c1fde5ced93d9f4ad89e2c940d3fd56ad82288)

ptp: vmclock: Clean up miscdev and ptp clock through devres

Most resources owned by the vmclock device are managed through devres.
Only the miscdev and ptp clock are managed manually.
This makes the code slightly harder to understand than necessary.

Switch them over to devres and remove the now unnecessary drvdata.

Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Reviewed-by: David Woodhouse <dwmw@amazon.co.uk>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
(cherry picked from commit 9a884c3800b207bac36e27be4ec7277c78a84568)

ptp: vmclock: Don't unregister misc device if it was not registered

vmclock_remove() tries to detect the successful registration of the misc
device based on the value of its minor value.
However that check is incorrect if the misc device registration was not
attempted in the first place.

Always initialize the minor number, so the check works properly.

Fixes: 205032724226 ("ptp: Add support for the AMZNC10C 'vmclock' device")
Cc: stable@vger.kernel.org
Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Reviewed-by: David Woodhouse <dwmw@amazon.co.uk>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
(cherry picked from commit 39e926c3a21b25af6cae479fbb752f193240ce03)

ptp: vmclock: Set driver data before its usage

If vmclock_ptp_register() fails during probing, vmclock_remove() is
called to clean up the ptp clock and misc device.
It uses dev_get_drvdata() to access the vmclock state.
However the driver data is not yet set at this point.

Assign the driver data earlier.

Fixes: 205032724226 ("ptp: Add support for the AMZNC10C 'vmclock' device")
Cc: stable@vger.kernel.org
Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Reviewed-by: David Woodhouse <dwmw@amazon.co.uk>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
(cherry picked from commit f7d07cd4f77d77f366c8ffbb8ba8b61f614e5fce)

ptp: vmclock: Add .owner to vmclock_miscdev_fops

Without the .owner field, the module can be unloaded while /dev/vmclock0
is open, leading to an oops.

Fixes: 205032724226 ("ptp: Add support for the AMZNC10C 'vmclock' device")
Cc: stable@vger.kernel.org
Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
(cherry picked from commit 7b07b040257c1b658ef3eca86e4b6ae02d65069c)

Clean up remove() compat

Update to v7 posting

Update to v6 posting

Update to v5 posting

Update to v4 posting

Update to non-RFC v3 posting

Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>

nanoseconds

update leap values

Update from master tree

fix unload bug

Update to struct v3

Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>

Update from upstream driver (struct closer to virtio-rtc)

Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>

Build for AL

Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>

Add Makefile

Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>

Import vmclock Linux code from commit 6635b8ca76c6 (2024-06-28)

Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>