Merge pull request #2165 from martin-gpy/warnings_verbose_level

fabrics: move hostid/hostnqn warnings to verbose level

doc: Regenerate all docs for v2.7.1

Signed-off-by: Daniel Wagner <dwagner@suse.de>

build: Update version to v2.7.1

Signed-off-by: Daniel Wagner <dwagner@suse.de>

nvme-print-json: Revert field name changes

The json refactoring and cleanup changes renamed a bunch of existing
field names which breaks existing users. Revert to the old names.

Fixes: 1d7c092f9dac ("nvme-print-json: Combine duplicated json key and val string variables")
Signed-off-by: Daniel Wagner <dwagner@suse.de>

build: checkout full repo for checkpatch

checkpatch likes to verify git references. Thus we need to checkout the
full repo to get this working.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

fabrics: move hostid/hostnqn warnings to verbose level

Currently nvme connect prints an annoying "use hostid which
does not match uuid in hostnqn" warning even for normal
scenarios when both the hostid and hostnqn files are present.
So move these warnings to verbose level instead.

Signed-off-by: Martin George <marting@netapp.com>

doc: Regenerate all docs for v2.7

Signed-off-by: Daniel Wagner <dwagner@suse.de>

build: Update version to v2.7

Signed-off-by: Daniel Wagner <dwagner@suse.de>

doc: fix lockdown document

The previous commit removed the necessary empty line between sections.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

build: Update libnvme wrap to v1.7

Update to the latest libnvme release.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

build: update json-c wrap

Update to the latest json-c release.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

nvme-print-json: include vs for identify namespace

While the spec may allow for arbitrary use of vendor-specific
data, some implementations are simply strings.  JSON will
encode the string, allowing for safe use of control characters.

The only requirement is that the there be a null-byte in the
vendor-specific field terminating the string.  Data beyond the
null-byte will be ignored.

Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
[dwagner: use d_json instead obj_add_str]
Signed-off-by: Daniel Wagner <dwagner@suse.de>

nvme-print-stdout: enhance connect message

Print a more meaningful connect message.

Signed-off-by: Martin George <marting@netapp.com>

fabrics: fix connect error if hostid file does not exist

Currently one sees a connect error during a nvme discover/connect
if the hostnqn file exists, but not the hostid file. Fix this
by ensuring the hostid is taken from the corresponding hostnqn for
such scenarios.

Signed-off-by: Martin George <marting@netapp.com>

fabrics: fix invalid output format error during nvme connect

Nvme connect currently fails with an "Invalid output format"
error if no output-format is specified to the nvme connect
command. Fix this by initializing the format string.

Signed-off-by: Martin George <marting@netapp.com>

build(deps): bump actions/upload-artifact from 3 to 4

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build(deps): bump github/codeql-action from 2 to 3

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2 to 3.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/v2...v3)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build(deps): bump dawidd6/action-download-artifact from 2 to 3

Bumps [dawidd6/action-download-artifact](https://github.com/dawidd6/action-download-artifact) from 2 to 3.
- [Release notes](https://github.com/dawidd6/action-download-artifact/releases)
- [Commits](https://github.com/dawidd6/action-download-artifact/compare/v2...v3)

---
updated-dependencies:
- dependency-name: dawidd6/action-download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

wdc: Fix vs-smart-add-log Command for SN650 and SN655

The incorrect log page was being displayed because
the wrong uuid index was being used.  This patch
determines the correct uuid index needed for
SN650 and SN655.

Signed-off-by: jeff-lien-wdc <jeff.lien@wdc.com>

nvme: restric hmac options for gen-tls-key

During nvme gen-tls-key generation, the permitted hmac options is 1
for SHA-256 & 2 for SHA-384 respectively for the retained key. But
nvme-cli mistakenly permits an additional option 3 too which defaults
to SHA-256 itself. Rectify this.

Signed-off-by: Martin George <marting@netapp.com>

wdc: Fix UUID index fallback mechanism

For certain devices that don't support UUID lists, there may be multiple
definitions of the C2 logpage. This code will check for UUID list
support and search the UUID list for the correct UUID, if supported. If
UUID lists are not supported, the code will try uuid index 0 and 1 and
use an identification algorithm to determine which is returning the
correct log page data.

Signed-off-by: jeff-lien-wdc <jeff.lien@wdc.com>
[dwagner: swashed fixup patchs
  fixed code style issues]
Signed-off-by: Daniel Wagner <dwagner@suse.de>

build: add codecov configuration

Unfortunatly, the codecov configuration wants to have it's own
configurtion file on top level of the project.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

build: add checkpatch to catch style issues

Signed-off-by: Daniel Wagner <dwagner@suse.de>

build: ignore external code for code coverage check

Signed-off-by: Daniel Wagner <dwagner@suse.de>

plugins/ocp: Add OCP Telemetry String log page, Telemetry log page

Signed-off-by: Arunpandian J <arun.j@samsung.com>

Documentations: Add document for telemetry string log page

Signed-off-by: Arunpandian J <arun.j@samsung.com>

completions: Add bash completions for telemetry string log page

Signed-off-by: Arunpandian J <arun.j@samsung.com>

plugins/solidigm: Added OCP 2.0 compatibility version command

Signed-off-by: Leonardo da Cunha <leonardo.da.cunha@solidigm.com>

build: Disable muon bestline for CentOS 7 build error

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

plugins/solidigm: Added OCP 2.0 vs-drive-info command.

Signed-off-by: Leonardo da Cunha <leonardo.da.cunha@solidigm.com>

plugins/ocp: Fix printing order of various Latency Monitor Log buckets

Several buckets were being printed out in an incorrect order (so bucket
3 was being labelled as bucket 0, bucket 2 was labelled as bucket 1, 1
was labelled as 2, etc.).

The tables with these affected buckets were the : Active Latency
Timestamp table, Active Measured Latency table, Static Latency Timestamp
table, and Static Measure Latency table.

Also changed active latency configuration to just print out the hex
value, rather than creating another table.

nvme: validate output format split status from flag return value

Just return the status via the return value and return the flag value
via the arguments.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

nvme: simplify cleanup_nvme_dev()

Use DEFINE_CLEANUP_FUNC() to simplify cleanup_nvme_dev().

Signed-off-by: Caleb Sander <csander@purestorage.com>

cleanup: remove unused cleanup_charp()

cleanup_charp() appears to have been copied from libnvme,
but it has no users. _cleanup_free_ is more general, anyways.
So remove cleanup_charp() along with cleanup.c.

Signed-off-by: Caleb Sander <csander@purestorage.com>

wdc: Add support for SN861 2nd pci device id

Signed-off-by: jeff-lien-wdc <jeff.lien@wdc.com>

build: remove libhugetlbfs references

nvme-cli doesn't depend on libhugetlbfs anymore. Update the documentation
and the CI build.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

nvme: replace libhugetlbfs with mmap and madvise

Instead depending on libhugetlbfs for large memory allocation mapping
just use mmap and madvise for trying to allocate contiguous memory.

While at it also introduce an auto cleanup helper.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

util/mem: move alloc helper to util section

Move the alloc helpers to its own header file so that we avoid an
include header recursion when defining auto cleanup helpers.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

nvme: auto cleanup filedescriptors

Let's make the cleanup logic simpler by using the cleanup hooks for file
descriptors.

Also to simplify the logic don't close STDIN, STDOUT or STDERR. With
this we don't have to dup these file descriptor when we still want to
write to stdout with printf.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

nvme: auto cleanup buffers

Let's make the cleanup logic simpler by using the cleanup hooks for
heap allocated buffers.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

nvme: return error code in get_persistent_event_log

When the generation counter is not matching we report the problem but
don't return an error code.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

nvme: sanitize nvme-gen-tls-key

Simplify the hostnqn / subsysnqn check and do not insert the key
if 'insert' is not specified.

Signed-off-by: Hannes Reinecke <hare@suse.de>

nvme: print out the resulting TLS identity for 'nvme check-tls-key'

Add an option '--version' to specify which key identity version to use,
and add an option '--insert' to clarify whether the retained key should
be inserted in the keyring or not.

Signed-off-by: Hannes Reinecke <hare@suse.de>

nvme: Add version '1' identifier for nvme-gen-tls-key

With NVMe TP8018 the NVMe TLS PSK identity changed, and a PSK
digest got attached to the identity.
Update the 'nvme-gen-tls-key' program to accept an 'identity' option
to allow to switch between the two methods.

Default continues to be '0' for now.

Signed-off-by: Hannes Reinecke <hare@suse.de>

subprojects/libnvme: update wrapper for TP8018

Signed-off-by: Hannes Reinecke <hare@suse.de>

plugins/solidigm: Added re_sku_count smart atrribute

Signed-off-by: shankaralingegowda <shankaralingegowda.singonahalli@solidigmtechnology.com>

doc: Fix nvme-connect manpage --application option string

(--application -> --context)

Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>

plugins/ocp: changed command clear-pcie-correctable-error-counters to match OCP 2.0 spec.
Fixed some function name typos.

Signed-off-by: leonardo.da.cunha <leonardo.da.cunha@solidigm.com>

plugins/solidigm: Added command to clear PCIe Correctable Error Counters according to OCP 2.0

Signed-off-by: leonardo.da.cunha <leonardo.da.cunha@solidigm.com>

plugins/ocp: Reorganized clear feature code for better reuse

Signed-off-by: leonardo.da.cunha <leonardo.da.cunha@solidigm.com>

nvme: fixup length calculation for 'nvme gen-tls-key --secret'

The raw secret is passed in hex, so the length of the input is
twice the size of the key.

Signed-off-by: Hannes Reinecke <hare@suse.de>

doc: add additional build instructions

Add more information how to build the project in different
scenarios (older distros, static builds etc.).

Also mention where to download the test AppImage.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

build: remove the wrap feature dependency for muon

The libnvme.wrap is using a git URL for libnvme thus it doesn't depend
on libcurl, libarchive or libpkgconf. The wrap implementation is calling
git directly to download the library. Thus we can drop these dependency
which makes it possible to build it on older distributions such as
CentOS 7 and 8.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
[dwagner: updated commit message]
Signed-off-by: Daniel Wagner <dwagner@suse.de>

build: pass the linker argument via muon argument

Use the canonical way to set the static build using the command line
argument.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

build: do not rebuild muon/samu every time

There is not need to build the build tools everytime. Thus stage the
samurai and muon build into a new top level directory .build-tools and
only build them on demand.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

doc: remove invalid hostkey info for --dhchap-secret

There is no code which reads in the secret from the mentioned file. This
was done in the early stages of the implementation. But it is not
considered good practice to store secrets as plain text in /etc, thus
this feature was removed later. Instead the connect command is able to
use the kernel keystore for this.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

nvme-print-json: use human helper everywhere

If we have this helper let's use it.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

nvme-print-json: remove obj_print helper

This tiny helper has no real functionality. The json_object is always
valid. Thus drop it and call the other helper directly.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

plugins/ocp: update nvme_show_select_result call

The recent nvme-print-json refactoring/exstension changed the
nvme_show_select_result function signature but missed to update the ocp
plugin. Pass in the fid to the show function.

Fixes: 28a3a0975a33 ("nvme-print-json: Change to report feature select in array")
Signed-off-by: Daniel Wagner <dwagner@suse.de>

mailmap: only show contributer's name

When looking at git history don't clutter the overview. Just list the
name.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

nvme-print-json: Change to report status and message in array

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Change to report feature select in array

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Change to report error and data in array

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add show_init/finish calls to report features in array

Note: Still error and data reported separately so will be fixed later.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print: Add nvme_show_error_status() to merge error message and status

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Use r instead of root and use obj_add_***(r, ..., ...)

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Delete static const char string global variables

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add remaining controller registers readable format

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add readable format cap, vs, cc, csts, nssr and crto registers

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Combine duplicated json key and val string variables

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Replase json_array_add_value_string() to array_add_str()

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Replase json_object_add_value_uint128() to obj/root_add_uint128()

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Replase json_object_add_value_object() to obj/root_add_obj()

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Replase json_array_add_value_object() to array_add_obj()

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Replase json_object_add_value_array() to obj/root_add_array()

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Replase json_object_add_value_uint() to obj/root_add_uint()

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Replase json_object_add_value_int() to obj/root_add_int()

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Replase json_object_add_value_uint64() to obj/root_add_uint64()

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Replase json_object_add_value_string() to obj/root_add_str()

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Update feature_show_fields_*** to use root/obj_add_***()

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Update lba_status_log to use root_add_***() and obj_add_***()

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Replace lba_status_log printf() to root_add_result()

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add list_item print function

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add lba_status_info print function

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add lba_range print function

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add id_ctrl_rpmbs print function

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Unify json_list and jroot object names to root

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add json_zns_changed print function

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add root_add_result() to output result message

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Split persistent_event_log print function

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Remove unnecessary string newline code

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Replace effects_log_list print to use json_print()

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Print persistent_event_log no log data result correctly

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add static "result" and "erorr" strings variables

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add single_property printf function

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme: Replace get feature command stderr output to nvme_show_error()

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Change d() output to use d_json()

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme: Fix get-feature command mixed stdout and json outputs

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add remaining feature fields print functions

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Update formatting and codying style

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>