]> www.infradead.org Git - users/hch/xfs.git/log
users/hch/xfs.git
10 months agoxfs: enable realtime rmap btree xfs-realtime-rmap-rebase
Darrick J. Wong [Wed, 29 May 2024 04:13:00 +0000 (21:13 -0700)]
xfs: enable realtime rmap btree

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: hook live realtime rmap operations during a repair operation
Darrick J. Wong [Fri, 9 Aug 2024 11:23:32 +0000 (13:23 +0200)]
xfs: hook live realtime rmap operations during a repair operation

Hook the regular realtime rmap code when an rtrmapbt repair operation is
running so that we can unlock the AGF buffer to scan the filesystem and
keep the in-memory btree up to date during the scan.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: create a shadow rmap btree during realtime rmap repair
Darrick J. Wong [Wed, 29 May 2024 04:12:58 +0000 (21:12 -0700)]
xfs: create a shadow rmap btree during realtime rmap repair

Create an in-memory btree of rmap records instead of an array.  This
enables us to do live record collection instead of freezing the fs.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: online repair of the realtime rmap btree
Darrick J. Wong [Sat, 10 Aug 2024 08:30:28 +0000 (10:30 +0200)]
xfs: online repair of the realtime rmap btree

Repair the realtime rmap btree while mounted.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: support repairing metadata btrees rooted in metadir inodes
Darrick J. Wong [Wed, 29 May 2024 04:12:57 +0000 (21:12 -0700)]
xfs: support repairing metadata btrees rooted in metadir inodes

Adapt the repair code so that we can stage a new btree in the data fork
area of a metadir inode and reap the old blocks.  We already have nearly
all of the infrastructure; the only parts that were missing were the
metadata inode reservation handling.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: online repair of realtime bitmaps for a realtime group
Darrick J. Wong [Sat, 10 Aug 2024 08:03:56 +0000 (10:03 +0200)]
xfs: online repair of realtime bitmaps for a realtime group

For a given rt group, regenerate the bitmap contents from the group's
realtime rmap btree.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: repair rmap btree inodes
Darrick J. Wong [Wed, 29 May 2024 04:12:56 +0000 (21:12 -0700)]
xfs: repair rmap btree inodes

Teach the inode repair code how to deal with realtime rmap btree inodes
that won't load properly.  This is most likely moot since the filesystem
generally won't mount without the rtrmapbt inodes being usable, but
we'll add this for completeness.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: repair inodes that have realtime extents
Darrick J. Wong [Wed, 29 May 2024 04:12:56 +0000 (21:12 -0700)]
xfs: repair inodes that have realtime extents

Plumb into the inode core repair code the ability to search for extents
on realtime devices.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: online repair of realtime file bmaps
Darrick J. Wong [Fri, 9 Aug 2024 09:37:40 +0000 (11:37 +0200)]
xfs: online repair of realtime file bmaps

Repair the block mappings of realtime files.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: walk the rt reverse mapping tree when rebuilding rmap
Darrick J. Wong [Wed, 29 May 2024 04:12:55 +0000 (21:12 -0700)]
xfs: walk the rt reverse mapping tree when rebuilding rmap

When we're rebuilding the data device rmap, if we encounter an "rmap"
format fork, we have to walk the (realtime) rmap btree inode to build
the appropriate mappings.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: scrub the metadir path of rt rmap btree files
Darrick J. Wong [Wed, 29 May 2024 04:12:54 +0000 (21:12 -0700)]
xfs: scrub the metadir path of rt rmap btree files

Add a new XFS_SCRUB_METAPATH subtype so that we can scrub the metadata
directory tree path to the rmap btree file for each rt group.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: scan rt rmap when we're doing an intense rmap check of bmbt mappings
Darrick J. Wong [Fri, 9 Aug 2024 09:15:32 +0000 (11:15 +0200)]
xfs: scan rt rmap when we're doing an intense rmap check of bmbt mappings

Teach the bmbt scrubber how to perform a comprehensive check that the
rmapbt does not contain /any/ mappings that are not described by bmbt
records when it's dealing with a realtime file.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: cross-reference the realtime rmapbt
Darrick J. Wong [Sat, 10 Aug 2024 08:50:51 +0000 (10:50 +0200)]
xfs: cross-reference the realtime rmapbt

Teach the data fork and realtime bitmap scrubbers to cross-reference
information with the realtime rmap btree.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: cross-reference realtime bitmap to realtime rmapbt scrubber
Darrick J. Wong [Wed, 29 May 2024 04:12:52 +0000 (21:12 -0700)]
xfs: cross-reference realtime bitmap to realtime rmapbt scrubber

When we're checking the realtime rmap btree entries, cross-reference
those entries with the realtime bitmap too.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: scrub the realtime rmapbt
Darrick J. Wong [Sun, 11 Aug 2024 06:26:17 +0000 (08:26 +0200)]
xfs: scrub the realtime rmapbt

Check the realtime reverse mapping btree against the rtbitmap, and
modify the rtbitmap scrub to check against the rtrmapbt.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: allow queued realtime intents to drain before scrubbing
Darrick J. Wong [Sun, 11 Aug 2024 06:26:01 +0000 (08:26 +0200)]
xfs: allow queued realtime intents to drain before scrubbing

When a writer thread executes a chain of log intent items for the
realtime volume, the ILOCKs taken during each step are for each rt
metadata file, not the entire rt volume itself.  Although scrub takes
all rt metadata ILOCKs, this isn't sufficient to guard against scrub
checking the rt volume while that writer thread is in the middle of
finishing a chain because there's no higher level locking primitive
guarding the realtime volume.

When there's a collision, cross-referencing between data structures
(e.g. rtrmapbt and rtrefcountbt) yields false corruption events; if
repair is running, this results in incorrect repairs, which is
catastrophic.

Fix this by adding to the mount structure the same drain that we use to
protect scrub against concurrent AG updates, but this time for the
realtime volume.

[Contains a few cleanups from hch]

Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: allow queued realtime intents to drain before scrubbing
Darrick J. Wong [Fri, 9 Aug 2024 07:30:21 +0000 (00:30 -0700)]
xfs: allow queued realtime intents to drain before scrubbing

When a writer thread executes a chain of log intent items for the
realtime volume, the ILOCKs taken during each step are for each rt
metadata file, not the entire rt volume itself.  Although scrub takes
all rt metadata ILOCKs, this isn't sufficient to guard against scrub
checking the rt volume while that writer thread is in the middle of
finishing a chain because there's no higher level locking primitive
guarding the realtime volume.

When there's a collision, cross-referencing between data structures
(e.g. rtrmapbt and rtrefcountbt) yields false corruption events; if
repair is running, this results in incorrect repairs, which is
catastrophic.

Fix this by adding to the mount structure the same drain that we use to
protect scrub against concurrent AG updates, but this time for the
realtime volume.

[Contains a few cleanups from hch]

Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: fix scrub tracepoints when inode-rooted btrees are involved
Darrick J. Wong [Wed, 29 May 2024 04:12:40 +0000 (21:12 -0700)]
xfs: fix scrub tracepoints when inode-rooted btrees are involved

Fix a minor mistakes in the scrub tracepoints that can manifest when
inode-rooted btrees are enabled.  The existing code worked fine for bmap
btrees, but we should tighten the code up to be less sloppy.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: report realtime rmap btree corruption errors to the health system
Darrick J. Wong [Fri, 9 Aug 2024 07:25:20 +0000 (00:25 -0700)]
xfs: report realtime rmap btree corruption errors to the health system

Whenever we encounter corrupt realtime rmap btree blocks, we should
report that to the health monitoring system for later reporting.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: check that the rtrmapbt maxlevels doesn't increase when growing fs
Darrick J. Wong [Fri, 9 Aug 2024 07:12:17 +0000 (00:12 -0700)]
xfs: check that the rtrmapbt maxlevels doesn't increase when growing fs

The size of filesystem transaction reservations depends on the maximum
height (maxlevels) of the realtime btrees.  Since we don't want a grow
operation to increase the reservation size enough that we'll fail the
minimum log size checks on the next mount, constrain growfs operations
if they would cause an increase in those maxlevels.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: wire up getfsmap to the realtime reverse mapping btree
Darrick J. Wong [Wed, 29 May 2024 04:11:56 +0000 (21:11 -0700)]
xfs: wire up getfsmap to the realtime reverse mapping btree

Connect the getfsmap ioctl to the realtime rmapbt.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: create routine to allocate and initialize a realtime rmap btree inode
Darrick J. Wong [Fri, 9 Aug 2024 07:03:58 +0000 (00:03 -0700)]
xfs: create routine to allocate and initialize a realtime rmap btree inode

Create a library routine to allocate and initialize an empty realtime
rmapbt inode.  We'll use this for mkfs and repair.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: wire up rmap map and unmap to the realtime rmapbt
Darrick J. Wong [Fri, 9 Aug 2024 07:00:31 +0000 (00:00 -0700)]
xfs: wire up rmap map and unmap to the realtime rmapbt

Connect the map and unmap reverse-mapping operations to the realtime
rmapbt via the deferred operation callbacks.  This enables us to
perform rmap operations against the correct btree.

[Contains a minor bugfix from hch]

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: allow inodes with zero extents but nonzero nblocks
Darrick J. Wong [Wed, 29 May 2024 04:11:54 +0000 (21:11 -0700)]
xfs: allow inodes with zero extents but nonzero nblocks

Metadata inodes that store btrees will have zero extents and a nonzero
nblocks.  Adjust the inode verifier so that this combination is not
flagged.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: wire up a new inode fork type for the realtime rmap
Darrick J. Wong [Wed, 29 May 2024 04:11:53 +0000 (21:11 -0700)]
xfs: wire up a new inode fork type for the realtime rmap

Plumb in the pieces we need to embed the root of the realtime rmap
btree in an inode's data fork, complete with new fork type and
on-disk interpretation functions.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: add metadata reservations for realtime rmap btrees
Darrick J. Wong [Wed, 29 May 2024 04:11:52 +0000 (21:11 -0700)]
xfs: add metadata reservations for realtime rmap btrees

Reserve some free blocks so that we will always have enough free blocks
in the data volume to handle expansion of the realtime rmap btree.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: add realtime reverse map inode to metadata directory
Darrick J. Wong [Fri, 9 Aug 2024 06:56:16 +0000 (23:56 -0700)]
xfs: add realtime reverse map inode to metadata directory

Add a metadir path to select the realtime rmap btree inode and load
it at mount time.  The rtrmapbt inode will have a unique extent format
code, which means that we also have to update the inode validation and
flush routines to look for it.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: add realtime rmap btree block detection to log recovery
Darrick J. Wong [Wed, 29 May 2024 04:11:51 +0000 (21:11 -0700)]
xfs: add realtime rmap btree block detection to log recovery

Identify rtrmapbt blocks in the log correctly so that we can
validate them during log recovery.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: support recovering rmap intent items targetting realtime extents
Darrick J. Wong [Wed, 29 May 2024 04:11:50 +0000 (21:11 -0700)]
xfs: support recovering rmap intent items targetting realtime extents

Now that we have rmap on the realtime device, log recovery has to
support remapping extents on the realtime volume.  Make this work.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: add a realtime flag to the rmap update log redo items
Darrick J. Wong [Wed, 29 May 2024 04:11:50 +0000 (21:11 -0700)]
xfs: add a realtime flag to the rmap update log redo items

Extend the rmap update (RUI) log items with a new realtime flag that
indicates that the updates apply against the realtime rmapbt.  We'll
wire up the actual rmap code later.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: prepare rmap functions to deal with rtrmapbt
Darrick J. Wong [Wed, 29 May 2024 04:11:49 +0000 (21:11 -0700)]
xfs: prepare rmap functions to deal with rtrmapbt

Prepare the high-level rmap functions to deal with the new realtime
rmapbt and its slightly different conventions.  Provide the ability
to talk to either rmapbt or rtrmapbt formats from the same high
level code.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: add realtime rmap btree operations
Darrick J. Wong [Wed, 29 May 2024 04:11:49 +0000 (21:11 -0700)]
xfs: add realtime rmap btree operations

Implement the generic btree operations needed to manipulate rtrmap
btree blocks. This is different from the regular rmapbt in that we
allocate space from the filesystem at large, and are neither
constrained to the free space nor any particular AG.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: realtime rmap btree transaction reservations
Darrick J. Wong [Fri, 9 Aug 2024 06:49:13 +0000 (23:49 -0700)]
xfs: realtime rmap btree transaction reservations

Make sure that there's enough log reservation to handle mapping
and unmapping realtime extents.  We have to reserve enough space
to handle a split in the rtrmapbt to add the record and a second
split in the regular rmapbt to record the rtrmapbt split.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: define the on-disk realtime rmap btree format
Darrick J. Wong [Wed, 29 May 2024 04:11:47 +0000 (21:11 -0700)]
xfs: define the on-disk realtime rmap btree format

Start filling out the rtrmap btree implementation. Start with the
on-disk btree format; add everything needed to read, write and
manipulate rmap btree blocks. This prepares the way for connecting the
btree operations implementation.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: introduce realtime rmap btree definitions
Darrick J. Wong [Wed, 29 May 2024 04:11:47 +0000 (21:11 -0700)]
xfs: introduce realtime rmap btree definitions

Add new realtime rmap btree definitions. The realtime rmap btree will
be rooted from a hidden inode, but has its own shape and therefore
needs to have most of its own separate types.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: simplify the xfs_rmap_{alloc,free}_extent calling conventions
Darrick J. Wong [Wed, 29 May 2024 04:11:46 +0000 (21:11 -0700)]
xfs: simplify the xfs_rmap_{alloc,free}_extent calling conventions

Simplify the calling conventions by allowing callers to pass a fsbno
(xfs_fsblock_t) directly into these functions, since we're just going to
set it in a struct anyway.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: prepare rmap btree cursor tracepoints for realtime
Darrick J. Wong [Wed, 29 May 2024 04:11:46 +0000 (21:11 -0700)]
xfs: prepare rmap btree cursor tracepoints for realtime

Rework the rmap btree cursor tracepoints in preparation to handle the
realtime rmap btree cursor.  Mostly this involves renaming the field to
"rmapbno" and extracting the group number from the cursor when possible.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: allow inode-based btrees to reserve space in the data device
Darrick J. Wong [Fri, 9 Aug 2024 06:47:35 +0000 (23:47 -0700)]
xfs: allow inode-based btrees to reserve space in the data device

Create a new space reservation scheme so that btree metadata for the
realtime volume can reserve space in the data device to avoid space
underruns.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: attach rtgroup objects to btree cursors
Darrick J. Wong [Wed, 29 May 2024 04:11:40 +0000 (21:11 -0700)]
xfs: attach rtgroup objects to btree cursors

Make it so that we can attach realtime group objects to btree cursors.
This will be crucial for enabling rmap btrees in realtime groups.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: update btree keys correctly when _insrec splits an inode root block
Darrick J. Wong [Wed, 29 May 2024 04:11:33 +0000 (21:11 -0700)]
xfs: update btree keys correctly when _insrec splits an inode root block

In commit 2c813ad66a72, I partially fixed a bug wherein xfs_btree_insrec
would erroneously try to update the parent's key for a block that had
been split if we decided to insert the new record into the new block.
The solution was to detect this situation and update the in-core key
value that we pass up to the caller so that the caller will (eventually)
add the new block to the parent level of the tree with the correct key.

However, I missed a subtlety about the way inode-rooted btrees work.  If
the full block was a maximally sized inode root block, we'll solve that
fullness by moving the root block's records to a new block, resizing the
root block, and updating the root to point to the new block.  We don't
pass a pointer to the new block to the caller because that work has
already been done.  The new record will /always/ land in the new block,
so in this case we need to use xfs_btree_update_keys to update the keys.

This bug can theoretically manifest itself in the very rare case that we
split a bmbt root block and the new record lands in the very first slot
of the new block, though I've never managed to trigger it in practice.
However, it is very easy to reproduce by running generic/522 with the
realtime rmapbt patchset if rtinherit=1.

Fixes: 2c813ad66a72 ("xfs: support btrees with overlapping intervals for keys")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: support storing records in the inode core root
Darrick J. Wong [Wed, 29 May 2024 04:11:32 +0000 (21:11 -0700)]
xfs: support storing records in the inode core root

Add the necessary flags and code so that we can support storing leaf
records in the inode root block of a btree.  This hasn't been necessary
before, but the realtime rmapbt will need to be able to do this.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: hoist the node iroot update code out of xfs_btree_kill_iroot
Darrick J. Wong [Wed, 29 May 2024 04:11:32 +0000 (21:11 -0700)]
xfs: hoist the node iroot update code out of xfs_btree_kill_iroot

In preparation for allowing records in an inode btree root, hoist the
code that copies keyptrs from an existing node child into the root block
to a separate function.  Remove some unnecessary conditionals and clean
up a few function calls in the new function.  Note that this change
reorders the ->free_block call with respect to the change in bc_nlevels
to make it easier to support inode root leaf blocks in the next patch.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: hoist the node iroot update code out of xfs_btree_new_iroot
Darrick J. Wong [Wed, 29 May 2024 04:11:31 +0000 (21:11 -0700)]
xfs: hoist the node iroot update code out of xfs_btree_new_iroot

In preparation for allowing records in an inode btree root, hoist the
code that copies keyptrs from an existing node root into a child block
to a separate function.  Note that the new function explicitly computes
the keys of the new child block and stores that in the root block; while
the bmap btree could rely on leaving the key alone, realtime rmap needs
to set the new high key.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: support leaves in the incore btree root block in xfs_iroot_realloc
Darrick J. Wong [Wed, 29 May 2024 04:11:31 +0000 (21:11 -0700)]
xfs: support leaves in the incore btree root block in xfs_iroot_realloc

Add some logic to xfs_iroot_realloc so that we can handle leaf records
in the btree root block correctly.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: generalize the btree root reallocation function
Darrick J. Wong [Wed, 29 May 2024 04:11:30 +0000 (21:11 -0700)]
xfs: generalize the btree root reallocation function

In preparation for storing realtime rmap btree roots in an inode fork,
make xfs_iroot_realloc take an ops structure that takes care of all the
btree-specific geometry pieces.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: standardize the btree maxrecs function parameters
Darrick J. Wong [Wed, 29 May 2024 04:11:30 +0000 (21:11 -0700)]
xfs: standardize the btree maxrecs function parameters

Standardize the parameters in xfs_{alloc,bm,ino,rmap,refcount}bt_maxrecs
so that we have consistent calling conventions.  This doesn't affect the
kernel that much, but enables us to clean up userspace a bit.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: rearrange xfs_iroot_realloc a bit
Darrick J. Wong [Wed, 29 May 2024 04:11:29 +0000 (21:11 -0700)]
xfs: rearrange xfs_iroot_realloc a bit

Rearrange the innards of xfs_iroot_realloc so that we can reduce
duplicated code prior to genericizing the function.  No functional
changes.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: move the zero records logic into xfs_bmap_broot_space_calc
Darrick J. Wong [Wed, 29 May 2024 04:11:28 +0000 (21:11 -0700)]
xfs: move the zero records logic into xfs_bmap_broot_space_calc

The bmap btree cannot ever have zero records in an incore btree block.
If the number of records drops to zero, that means we're converting the
fork to extents format and are trying to remove the tree.  This logic
won't hold for the future realtime rmap btree, so move the logic into
the bmbt code.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: hoist the code that moves the incore inode fork broot memory
Darrick J. Wong [Wed, 29 May 2024 04:11:28 +0000 (21:11 -0700)]
xfs: hoist the code that moves the incore inode fork broot memory

Whenever we change the size of the memory buffer holding an inode fork
btree root block, we have to copy the contents over.  Refactor all this
into a single function that handles both, in preparation for making
xfs_iroot_realloc more generic.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: fix a sloppy memory handling bug in xfs_iroot_realloc
Darrick J. Wong [Wed, 29 May 2024 04:11:27 +0000 (21:11 -0700)]
xfs: fix a sloppy memory handling bug in xfs_iroot_realloc

While refactoring code, I noticed that when xfs_iroot_realloc tries to
shrink a bmbt root block, it allocates a smaller new block and then
copies "records" and pointers to the new block.  However, bmbt root
blocks cannot ever be leaves, which means that it's not technically
correct to copy records.  We /should/ be copying keys.

Note that this has never resulted in actual memory corruption because
sizeof(bmbt_rec) == (sizeof(bmbt_key) + sizeof(bmbt_ptr)).  However,
this will no longer be true when we start adding realtime rmap stuff,
so fix this now.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: refactor creation of bmap btree roots
Darrick J. Wong [Wed, 29 May 2024 04:11:27 +0000 (21:11 -0700)]
xfs: refactor creation of bmap btree roots

Now that we've created inode fork helpers to allocate and free btree
roots, create a new bmap btree helper to create a new bmbt root, and
refactor the extents <-> btree conversion functions to use our new
helpers.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: refactor the allocation and freeing of incore inode fork btree roots
Darrick J. Wong [Wed, 29 May 2024 04:11:26 +0000 (21:11 -0700)]
xfs: refactor the allocation and freeing of incore inode fork btree roots

Refactor the code that allocates and freese the incore inode fork btree
roots.  This will help us disentangle some of the weird logic when we're
creating and tearing down inode-based btrees.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: replace shouty XFS_BM{BT,DR} macros
Darrick J. Wong [Wed, 29 May 2024 04:11:26 +0000 (21:11 -0700)]
xfs: replace shouty XFS_BM{BT,DR} macros

Replace all the shouty bmap btree and bmap disk root macros with actual
functions, and fix a type handling error in the xattr code that the
macros previously didn't care about.

sed \
 -e 's/XFS_BMBT_BLOCK_LEN/xfs_bmbt_block_len/g' \
 -e 's/XFS_BMBT_REC_ADDR/xfs_bmbt_rec_addr/g' \
 -e 's/XFS_BMBT_KEY_ADDR/xfs_bmbt_key_addr/g' \
 -e 's/XFS_BMBT_PTR_ADDR/xfs_bmbt_ptr_addr/g' \
 -e 's/XFS_BMDR_REC_ADDR/xfs_bmdr_rec_addr/g' \
 -e 's/XFS_BMDR_KEY_ADDR/xfs_bmdr_key_addr/g' \
 -e 's/XFS_BMDR_PTR_ADDR/xfs_bmdr_ptr_addr/g' \
 -e 's/XFS_BMAP_BROOT_PTR_ADDR/xfs_bmap_broot_ptr_addr/g' \
 -e 's/XFS_BMAP_BROOT_SPACE_CALC/xfs_bmap_broot_space_calc/g' \
 -e 's/XFS_BMAP_BROOT_SPACE/xfs_bmap_broot_space/g' \
 -e 's/XFS_BMDR_SPACE_CALC/xfs_bmdr_space_calc/g' \
 -e 's/XFS_BMAP_BMDR_SPACE/xfs_bmap_bmdr_space/g' \
 -i $(git ls-files fs/xfs/*.[ch] fs/xfs/libxfs/*.[ch] fs/xfs/scrub/*.[ch])

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agofold
Christoph Hellwig [Sat, 10 Aug 2024 08:44:18 +0000 (10:44 +0200)]
fold

10 months agoxfs: return -ENOENT when trying to scrub non-existing rtgroup xfs-per-rtg-bitmap-rebase
Christoph Hellwig [Sun, 4 Aug 2024 09:51:16 +0000 (11:51 +0200)]
xfs: return -ENOENT when trying to scrub non-existing rtgroup

Provide a fallback for scrub code trying to scrub RTG 0 when it doesn't
actually exist for a file system with the RTGROUPS feature bit, but without
any RT extents.

Signed-off-by: Christoph Hellwig <hch@lst.de>
10 months agoxfs: enable realtime group feature
Darrick J. Wong [Wed, 29 May 2024 04:11:24 +0000 (21:11 -0700)]
xfs: enable realtime group feature

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: repair realtime group superblock
Darrick J. Wong [Wed, 29 May 2024 04:11:23 +0000 (21:11 -0700)]
xfs: repair realtime group superblock

Repair the realtime superblock if it has become out of date with the
primary superblock.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: scrub the realtime group superblock
Darrick J. Wong [Thu, 1 Aug 2024 15:17:00 +0000 (17:17 +0200)]
xfs: scrub the realtime group superblock

Enable scrubbing of realtime group superblocks.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: don't coalesce file mappings that cross allocation group boundaries
Darrick J. Wong [Wed, 26 Jun 2024 18:19:00 +0000 (11:19 -0700)]
xfs: don't coalesce file mappings that cross allocation group boundaries

The bmbt scrubber will combine file mappings if they are mergeable to
reduce the number of cross-referencing checks.  However, we shouldn't
combine mappings that cross rt group boundaries because that will cause
verifiers to trip incorrectly.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: make the RT allocator rtgroup aware
Christoph Hellwig [Mon, 5 Aug 2024 20:32:55 +0000 (13:32 -0700)]
xfs: make the RT allocator rtgroup aware

Make the allocator rtgroup aware by either picking a specific group if
there is a hint, or loop over all groups otherwise.  A simple rotor is
provided to pick the placement for initial allocations.

Signed-off-by: Christoph Hellwig <hch@lst.de>
10 months agoxfs: don't merge ioends across RTGs
Christoph Hellwig [Mon, 8 Jul 2024 21:38:06 +0000 (14:38 -0700)]
xfs: don't merge ioends across RTGs

Unlike AGs, RTGs don't always have metadata in their first blocks, and
thus we don't get automatic protection from merging I/O completions
across RTG boundaries.  Add code to set the IOMAP_F_BOUNDARY flag for
ioends that start at the first block of a RTG so that they never get
merged into the previous ioend.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: use realtime EFI to free extents when rtgroups are enabled
Darrick J. Wong [Thu, 1 Aug 2024 14:35:00 +0000 (16:35 +0200)]
xfs: use realtime EFI to free extents when rtgroups are enabled

When rmap is enabled, XFS expects a certain order of operations, which
is: 1) remove the file mapping, 2) remove the reverse mapping, and then
3) free the blocks.  When reflink is enabled, XFS replaces (3) with a
deferred refcount decrement operation that can schedule freeing the
blocks if that was the last refcount.

For realtime files, xfs_bmap_del_extent_real tries to do 1 and 3 in the
same transaction, which will break both rmap and reflink unless we
switch it to use realtime EFIs.  Both rmap and reflink depend on the
rtgroups feature, so let's turn on EFIs for all rtgroups filesystems.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: support error injection when freeing rt extents
Darrick J. Wong [Fri, 2 Aug 2024 04:20:09 +0000 (06:20 +0200)]
xfs: support error injection when freeing rt extents

A handful of fstests expect to be able to test what happens when extent
free intents fail to actually free the extent.  Now that we're
supporting EFIs for realtime extents, add to xfs_rtfree_extent the same
injection point that exists in the regular extent freeing code.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: support logging EFIs for realtime extents
Darrick J. Wong [Wed, 29 May 2024 04:11:39 +0000 (21:11 -0700)]
xfs: support logging EFIs for realtime extents

Teach the EFI mechanism how to free realtime extents.  We're going to
need this to enforce proper ordering of operations when we enable
realtime rmap.

Declare a new log intent item type (XFS_LI_EFI_RT) and a separate defer
ops for rt extents.  This keeps the ondisk artifacts and processing code
completely separate between the rt and non-rt cases.  Hopefully this
will make it easier to debug filesystem problems.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: force swapext to a realtime file to use the file content exchange ioctl
Darrick J. Wong [Wed, 29 May 2024 04:11:22 +0000 (21:11 -0700)]
xfs: force swapext to a realtime file to use the file content exchange ioctl

xfs_swap_extent_rmap does not use log items to track the overall
progress of an attempt to swap the extent mappings between two files.
If the system crashes in the middle of swapping a partially written
realtime extent, the mapping will be left in an inconsistent state
wherein a file can point to multiple extents on the rt volume.

The new file range exchange functionality handles this correctly, so all
callers must upgrade to that.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: store rtgroup information with a bmap intent
Darrick J. Wong [Wed, 29 May 2024 04:11:21 +0000 (21:11 -0700)]
xfs: store rtgroup information with a bmap intent

Make the bmap intent items take an active reference to the rtgroup
containing the space that is being mapped or unmapped.  We will need
this functionality once we start enabling rmap and reflink on the rt
volume.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: grow the realtime section when realtime groups are enabled
Darrick J. Wong [Sun, 4 Aug 2024 20:18:06 +0000 (22:18 +0200)]
xfs: grow the realtime section when realtime groups are enabled

Enable growing the rt section when realtime groups are enabled.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: encode the rtsummary in big endian format
Darrick J. Wong [Wed, 29 May 2024 04:11:21 +0000 (21:11 -0700)]
xfs: encode the rtsummary in big endian format

Currently, the ondisk realtime summary file counters are accessed in
units of 32-bit words.  There's no endian translation of the contents of
this file, which means that the Bad Things Happen(tm) if you go from
(say) x86 to powerpc.  Since we have a new feature flag, let's take the
opportunity to enforce an endianness on the file.  Encode the summary
information in big endian format, like most of the rest of the
filesystem.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: encode the rtbitmap in big endian format
Darrick J. Wong [Wed, 29 May 2024 04:11:19 +0000 (21:11 -0700)]
xfs: encode the rtbitmap in big endian format

Currently, the ondisk realtime bitmap file is accessed in units of
32-bit words.  There's no endian translation of the contents of this
file, which means that the Bad Things Happen(tm) if you go from (say)
x86 to powerpc.  Since we have a new feature flag, let's take the
opportunity to enforce an endianness on the file.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: add block headers to realtime bitmap and summary blocks
Darrick J. Wong [Mon, 5 Aug 2024 04:45:18 +0000 (06:45 +0200)]
xfs: add block headers to realtime bitmap and summary blocks

Upgrade rtbitmap and rtsummary blocks to have self describing metadata
like most every other thing in XFS.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: export the geometry of realtime groups to userspace
Darrick J. Wong [Thu, 1 Aug 2024 04:41:15 +0000 (21:41 -0700)]
xfs: export the geometry of realtime groups to userspace

Create an ioctl so that the kernel can report the status of realtime
groups to userspace.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: record rt group metadata errors in the health system
Darrick J. Wong [Mon, 5 Aug 2024 05:03:54 +0000 (07:03 +0200)]
xfs: record rt group metadata errors in the health system

Record the state of per-rtgroup metadata sickness in the rtgroup
structure for later reporting.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: add frextents to the lazysbcounters when rtgroups enabled
Darrick J. Wong [Wed, 29 May 2024 04:11:17 +0000 (21:11 -0700)]
xfs: add frextents to the lazysbcounters when rtgroups enabled

Make the free rt extent count a part of the lazy sb counters when the
realtime groups feature is enabled.  This is possible because the patch
to recompute frextents from the rtbitmap during log recovery predates
the code adding rtgroup support, hence we know that the value will
always be correct during runtime.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: add a helper to prevent bmap merges across rtgroup boundaries
Christoph Hellwig [Tue, 3 Oct 2023 08:26:14 +0000 (10:26 +0200)]
xfs: add a helper to prevent bmap merges across rtgroup boundaries

Except for the rt superblock, realtime groups do not store any metadata
at the start (or end) of the group.  There is nothing to prevent the
bmap code from merging allocations from multiple groups into a single
bmap record.  Add a helper to check for this case.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
[djwong: massage the commit message after pulling this into rtgroups]
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: check that rtblock extents do not break rtsupers or rtgroups
Darrick J. Wong [Wed, 29 May 2024 04:11:16 +0000 (21:11 -0700)]
xfs: check that rtblock extents do not break rtsupers or rtgroups

Check that rt block pointers do not point to the realtime superblock and
that allocated rt space extents do not cross rtgroup boundaries.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: export realtime group geometry via XFS_FSOP_GEOM
Darrick J. Wong [Wed, 29 May 2024 04:11:16 +0000 (21:11 -0700)]
xfs: export realtime group geometry via XFS_FSOP_GEOM

Export the realtime geometry information so that userspace can query it.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: update realtime super every time we update the primary fs super
Darrick J. Wong [Thu, 1 Aug 2024 11:32:34 +0000 (13:32 +0200)]
xfs: update realtime super every time we update the primary fs super

Every time we update parts of the primary filesystem superblock that are
echoed in the rt superblock, we must update the rt super.  Avoid
changing the log to support logging to the rt device by using ordered
buffers.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: check the realtime superblock at mount time
Darrick J. Wong [Wed, 29 May 2024 04:11:13 +0000 (21:11 -0700)]
xfs: check the realtime superblock at mount time

Check the realtime superblock at mount time, to ensure that the label
and uuids actually match the primary superblock on the data device.  If
the rt superblock is good, attach it to the xfs_mount so that the log
can use ordered buffers to keep this primary in sync with the primary
super on the data device.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: define the format of rt groups
Darrick J. Wong [Sun, 4 Aug 2024 09:01:47 +0000 (11:01 +0200)]
xfs: define the format of rt groups

Define the ondisk format of realtime group metadata, and a superblock
for realtime volumes.  rt supers are protected by a separate rocompat
bit so that we can leave them off if the rt device is zoned.

Add a xfs_sb_version_hasrtgroups so that xfs_repair knows how to zero
the tail of superblocks.

For rt group enabled file systems there is a separate bitmap and summary
file for each group and thus the number of bitmap and summary blocks
needs to be calculated differently.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: make RT extent numbers relative to the rtgroup
Christoph Hellwig [Mon, 5 Aug 2024 05:01:11 +0000 (07:01 +0200)]
xfs: make RT extent numbers relative to the rtgroup

To prepare for adding per-rtgroup bitmap files, make the xfs_rtxnum_t
type encode the RT extent number relative to the rtgroup.  The biggest
part of this to clearly distinguish between the relative extent number
that gets masked when converting from a global block number and length
values that just have a factor applied to them when converting from
file system blocks.

Signed-off-by: Christoph Hellwig <hch@lst.de>
10 months agoxfs: refactor xfs_rtsummary_blockcount
Christoph Hellwig [Sun, 4 Aug 2024 20:00:10 +0000 (22:00 +0200)]
xfs: refactor xfs_rtsummary_blockcount

Make xfs_rtsummary_blockcount take all the required information from
the mount structure and return the number of summary levels from it
as well.  This cleans up many of the callers and prepares for making the
rtsummary files per-rtgroup where they need to look at different value.

This means we recalculate some values in some callers, but as all these
calculations are outside the fast path and cheap that seems like a price
worth paying.

Signed-off-by: Christoph Hellwig <hch@lst.de>
10 months agoxfs: refactor xfs_rtbitmap_blockcount
Christoph Hellwig [Fri, 2 Aug 2024 03:51:57 +0000 (05:51 +0200)]
xfs: refactor xfs_rtbitmap_blockcount

Rename the existing xfs_rtbitmap_blockcount to
xfs_rtbitmap_blockcount_len and add a new xfs_rtbitmap_blockcount wrapper
around it that takes the number of extents from the mount structure.

This will simplify the move to per-rtgroup bitmaps as those will need to
pass in the number of extents per rtgroup instead.

Signed-off-by: Christoph Hellwig <hch@lst.de>
10 months agoxfs: factor out a xfs_growfs_check_rtgeom helper
Christoph Hellwig [Sun, 4 Aug 2024 20:16:46 +0000 (22:16 +0200)]
xfs: factor out a xfs_growfs_check_rtgeom helper

Split the check that the rtsummary fits into the log into a separate
helper, and use xfs_growfs_rt_alloc_fake_mount to calculate the new RT
geometry.

Signed-off-by: Christoph Hellwig <hch@lst.de>
10 months agoxfs: use xfs_growfs_rt_alloc_fake_mount in xfs_growfs_rt_alloc_blocks
Christoph Hellwig [Fri, 2 Aug 2024 03:50:41 +0000 (05:50 +0200)]
xfs: use xfs_growfs_rt_alloc_fake_mount in xfs_growfs_rt_alloc_blocks

Use xfs_growfs_rt_alloc_fake_mount instead of manually recalculating
the RT bitmap geometry.

Signed-off-by: Christoph Hellwig <hch@lst.de>
10 months agoxfs: factor out a xfs_growfs_rt_alloc_fake_mount helper
Christoph Hellwig [Sun, 4 Aug 2024 09:01:18 +0000 (11:01 +0200)]
xfs: factor out a xfs_growfs_rt_alloc_fake_mount helper

Split the code to set up a fake mount point to calculate new RT
geometry out of xfs_growfs_rt_bmblock so that it can be reused.

Note that this changes the rmblocks calculation method to be based
on the passed in rblocks and extsize and not the explicitly passed
one, but both methods will always lead to the same result.  The new
version just does a little bit more math while being more general.

Signed-off-by: Christoph Hellwig <hch@lst.de>
10 months agoxfs: calculate RT bitmap and summary blocks based on sb_rextents
Christoph Hellwig [Fri, 2 Aug 2024 03:28:04 +0000 (05:28 +0200)]
xfs: calculate RT bitmap and summary blocks based on sb_rextents

Use the on-disk rextents to calculate the bitmap and summary blocks
instead of the calculated one so that we can refactor the helpers for
calculating them.

As the RT bitmap and summary scrubbers already check that sb_rextents
match the block count this does not change coverage of the scrubber.

Signed-off-by: Christoph Hellwig <hch@lst.de>
10 months agoxfs: remove XFS_ILOCK_RT*
Darrick J. Wong [Fri, 2 Aug 2024 06:28:09 +0000 (08:28 +0200)]
xfs: remove XFS_ILOCK_RT*

Now that we've centralized the realtime metadata locking routines, get
rid of the ILOCK subclasses since we now use explicit lockdep classes.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: move RT bitmap and summary information to the rtgroup
Christoph Hellwig [Sun, 4 Aug 2024 20:11:28 +0000 (22:11 +0200)]
xfs: move RT bitmap and summary information to the rtgroup

Move the pointers to the RT bitmap and summary inodes as well as the
summary cache to the rtgroups structure to prepare for having a
separate bitmap and summary inodes for each rtgroup.

Code using the inodes now needs to operate on a rtgroup.  Where easily
possible such code is converted to iterate over all rtgroups, else
rtgroup 0 (the only one that can currently exist) is hardcoded.

Signed-off-by: Christoph Hellwig <hch@lst.de>
10 months agoxfs: add rtgroup-based realtime scrubbing context management
Darrick J. Wong [Wed, 29 May 2024 04:11:09 +0000 (21:11 -0700)]
xfs: add rtgroup-based realtime scrubbing context management

Create a pair of helpers to deal with setting up the necessary incore
context to check metadata records against the realtime metadata.  Right
now this is limited to locking the realtime bitmap and summary inodes,
but as we add rmap and reflink to the realtime device this will grow to
include btree cursors.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: support caching rtgroup metadata inodes
Darrick J. Wong [Sun, 4 Aug 2024 09:14:04 +0000 (11:14 +0200)]
xfs: support caching rtgroup metadata inodes

Create the necessary per-rtgroup infrastructure that we need to load
metadata inodes into memory.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: add a lockdep class key for rtgroup inodes
Darrick J. Wong [Thu, 1 Aug 2024 04:38:53 +0000 (21:38 -0700)]
xfs: add a lockdep class key for rtgroup inodes

Add a dynamic lockdep class key for rtgroup inodes.  This will enable
lockdep to deduce inconsistencies in the rtgroup metadata ILOCK locking
order.  Each class can have 8 subclasses, and for now we will only have
2 inodes per group.  This enables rtgroup order and inode order checks
when nesting ILOCKs.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: define locking primitives for realtime groups
Darrick J. Wong [Thu, 1 Aug 2024 11:28:32 +0000 (13:28 +0200)]
xfs: define locking primitives for realtime groups

Define helper functions to lock all metadata inodes related to a
realtime group.  There's not much to look at now, but this will become
important when we add per-rtgroup metadata files and online fsck code
for them.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: create incore realtime group structures
Darrick J. Wong [Sun, 4 Aug 2024 09:00:47 +0000 (11:00 +0200)]
xfs: create incore realtime group structures

Create an incore object that will contain information about a realtime
allocation group.  This will eventually enable us to shard the realtime
section in a similar manner to how we shard the data section, but for
now just a single object for the entire RT subvolume is created.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoiomap: add a merge boundary flag
Christoph Hellwig [Mon, 8 Jul 2024 21:36:01 +0000 (14:36 -0700)]
iomap: add a merge boundary flag

File systems might have boundaries over which merges aren't possible.
In fact these are very common, although most of the time some kind of
header at the beginning of this region (e.g. XFS alloation groups, ext4
block groups) automatically create a merge barrier.  But if that is
not present, say for a device purely used for data we need to manually
communicate that to iomap.

Add a IOMAP_F_BOUNDARY flag to never merge I/O into a previous mapping.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: rearrange xfs_fsmap.c a little bit
Darrick J. Wong [Wed, 29 May 2024 04:11:56 +0000 (21:11 -0700)]
xfs: rearrange xfs_fsmap.c a little bit

The order of the functions in this file has gotten a little confusing
over the years.  Specifically, the two data device implementations
(bnobt and rmapbt) could be adjacent in the source code instead of split
in two by the logdev and rtdev fsmap implementations.  We're about to
add more functionality to this file, so rearrange things now.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
10 months agoxfs: replace m_rsumsize with m_rsumblocks
Christoph Hellwig [Sun, 4 Aug 2024 09:00:12 +0000 (11:00 +0200)]
xfs: replace m_rsumsize with m_rsumblocks

Track the RT summary file size in blocks, just like the RT bitmap
file.  While we have users of both units, blocks are used slightly
more often and this matches the bitmap file for consistency.

Signed-off-by: Christoph Hellwig <hch@lst.de>
10 months agoxfs: remove xfs_{rtbitmap,rtsummary}_wordcount
Christoph Hellwig [Fri, 2 Aug 2024 02:51:04 +0000 (04:51 +0200)]
xfs: remove xfs_{rtbitmap,rtsummary}_wordcount

xfs_rtbitmap_wordcount and xfs_rtsummary_wordcount are currently unused,
so remove them to simplify refactoring other rtbitmap helpers.  They
can be added back or simply open coded when actually needed.

Signed-off-by: Christoph Hellwig <hch@lst.de>
10 months agoxfs: add xchk_setup_nothing and xchk_nothing helpers
Darrick J. Wong [Fri, 2 Aug 2024 06:39:24 +0000 (08:39 +0200)]
xfs: add xchk_setup_nothing and xchk_nothing helpers

Add common helpers for no-op scrubbing methods.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
[hch: split from a larger patch]
Signed-off-by: Christoph Hellwig <hch@lst.de>
10 months agoxfs: make the rtalloc start hint a xfs_rtblock_t
Christoph Hellwig [Thu, 1 Aug 2024 18:40:48 +0000 (20:40 +0200)]
xfs: make the rtalloc start hint a xfs_rtblock_t

0 is a valid start RT extent, and with pending changes it will become
both more common and non-unique.  Switch to pass a xfs_rtblock_t instead
so that we can use NULLRTBLOCK to determine if a hint was set or not.

Signed-off-by: Christoph Hellwig <hch@lst.de>
10 months agoxfs: factor out a xfs_rtallocate_align helper
Christoph Hellwig [Thu, 1 Aug 2024 03:53:52 +0000 (20:53 -0700)]
xfs: factor out a xfs_rtallocate_align helper

Split the code to calculate the aligned allocation request from
xfs_bmap_rtalloc into a separate self-contained helper.

Signed-off-by: Christoph Hellwig <hch@lst.de>