]> www.infradead.org Git - users/hch/xfsprogs.git/log
users/hch/xfsprogs.git
14 months agoFOLD: xfs: merge xfs_imeta_utils.[ch] into xfs_imeta.[ch] xfs-metafile-simplification
Christoph Hellwig [Sun, 14 Apr 2024 04:09:33 +0000 (06:09 +0200)]
FOLD: xfs: merge xfs_imeta_utils.[ch] into xfs_imeta.[ch]

14 months agoxfs: merge xfs_imeta_utils.[ch] into xfs_imeta.[ch]
Christoph Hellwig [Sun, 14 Apr 2024 04:08:46 +0000 (06:08 +0200)]
xfs: merge xfs_imeta_utils.[ch] into xfs_imeta.[ch]

Source kernel commit: 59528f21f4ff1fdb6eff1262bd5add77d733be8c

The xfs_imeta_utils code is also used in xfsprogs and copied into
libxfs.  Make sure it gets picked up automatically.

Signed-off-by: Christoph Hellwig <hch@lst.de>
14 months agoFOLD: xfs: stop recording metadir inode numbers in the in-core superblock
Christoph Hellwig [Sat, 13 Apr 2024 06:30:19 +0000 (08:30 +0200)]
FOLD: xfs: stop recording metadir inode numbers in the in-core superblock

14 months agoxfs: stop recording metadir inode numbers in the in-core superblock
Christoph Hellwig [Sat, 13 Apr 2024 06:28:48 +0000 (08:28 +0200)]
xfs: stop recording metadir inode numbers in the in-core superblock

Source kernel commit: fe8cf66f7fadcd5f64de623d9e4dd30194c5108e

Both the RT and quota code now natively support metadir.

Signed-off-by: Christoph Hellwig <hch@lst.de>
14 months agodb: explicitly lookup metadata inodes
Christoph Hellwig [Sat, 13 Apr 2024 06:19:18 +0000 (08:19 +0200)]
db: explicitly lookup metadata inodes

Prepare for the automatic recording of the metadir inodes in the in-core
super block by manually doing the lookup.

Signed-off-by: Christoph Hellwig <hch@lst.de>
14 months agorepair: explicitly lookup metadata inodes
Christoph Hellwig [Fri, 12 Apr 2024 13:52:12 +0000 (15:52 +0200)]
repair: explicitly lookup metadata inodes

Prepare for the automatic recording of the metadir inodes in the in-core
super block by manually doing the lookup.

Signed-off-by: Christoph Hellwig <hch@lst.de>
14 months agoxfs: xfs_imeta_create is now only used on metadir file systems
Christoph Hellwig [Sat, 13 Apr 2024 06:27:43 +0000 (08:27 +0200)]
xfs: xfs_imeta_create is now only used on metadir file systems

Source kernel commit: 1dd8e4bb248b2a39dcb97d1971579d19325e83b5

Remove the sb case and add a WARN_ON instead.

Signed-off-by: Christoph Hellwig <hch@lst.de>
14 months agomkfs: create static RT inodes without the imeta code
Christoph Hellwig [Fri, 12 Apr 2024 13:41:23 +0000 (15:41 +0200)]
mkfs: create static RT inodes without the imeta code

To prepare for removing the static inode handline from the imeta code.

Signed-off-by: Christoph Hellwig <hch@lst.de>
14 months agoxfs: remove the ENOENT check in xfs_imeta_lookup
Christoph Hellwig [Sat, 13 Apr 2024 06:26:08 +0000 (08:26 +0200)]
xfs: remove the ENOENT check in xfs_imeta_lookup

Source kernel commit: 426c663b888ef19983e5b6cf23dd168a910e7553

xfs_imeta_lookup_int already turns ENOENT into a NULLSFSINO *inop.

Signed-off-by: Christoph Hellwig <hch@lst.de>
14 months agolibxfs: remove XFS_QMOPT_SBVERSION
Christoph Hellwig [Fri, 12 Apr 2024 05:50:46 +0000 (07:50 +0200)]
libxfs: remove XFS_QMOPT_SBVERSION

XFS_QMOPT_SBVERSION was never used in user space, and is gone from the
kernel as well now.

Signed-off-by: Christoph Hellwig <hch@lst.de>
14 months agoxfs: add a xfs_noquota_inode predicate
Christoph Hellwig [Fri, 12 Apr 2024 05:48:54 +0000 (07:48 +0200)]
xfs: add a xfs_noquota_inode predicate

Source kernel commit: 415b06be5965b9dd36b6a9287962dbc38b7f4c3a

All remaining uses of xfs_is_noquota_inode are used to check if quota
accounting should not be applied to an inode, and unless used in asserts
is always combined with a metadir check as we never apply quotas to
metadir inodes.

Combine these checks into a single xfs_noquota_inode that explains the
logic.  Note that for dqadjust this now means we have to read the
inode first before skipping them, but that's a small price to pay for
more obvious code.

Signed-off-by: Christoph Hellwig <hch@lst.de>
14 months agoFOLD: xfs: remove the metadir root creation case in xfs_imeta_dir_create
Christoph Hellwig [Fri, 12 Apr 2024 05:47:52 +0000 (07:47 +0200)]
FOLD: xfs: remove the metadir root creation case in xfs_imeta_dir_create

14 months agoxfs: remove the metadir root creation case in xfs_imeta_dir_create
Christoph Hellwig [Fri, 12 Apr 2024 05:33:33 +0000 (07:33 +0200)]
xfs: remove the metadir root creation case in xfs_imeta_dir_create

Source kernel commit: e2661d07c7e38c1739a5758a53eaf2bee42b2ca8

This code is only used by mkfs, where it will be reimplemented in the
xfsprogs patches.

Signed-off-by: Christoph Hellwig <hch@lst.de>
14 months agoxfs: xfs_imeta_link is only used on metadir file systems
Christoph Hellwig [Fri, 12 Apr 2024 05:29:35 +0000 (07:29 +0200)]
xfs: xfs_imeta_link is only used on metadir file systems

Source kernel commit: 746518f244cef8c3fe93090cca2ba6677780e9ca

So remove the sb link case and add a WARN_ON instead.

Signed-off-by: Christoph Hellwig <hch@lst.de>
14 months agoxfs: remove xfs_imeta_unlink
Christoph Hellwig [Fri, 12 Apr 2024 05:14:21 +0000 (07:14 +0200)]
xfs: remove xfs_imeta_unlink

Source kernel commit: 48694dd1775389fbad71c7826c123900eedfc76b

xfs_imeta_unlink isn't used either in the kernel or xfsprogs.

Signed-off-by: Christoph Hellwig <hch@lst.de>
14 months agoxfs: remove xfs_imeta_sb_lookup
Christoph Hellwig [Fri, 12 Apr 2024 05:14:03 +0000 (07:14 +0200)]
xfs: remove xfs_imeta_sb_lookup

Source kernel commit: 5617a631fd85927dd845da0e39659b1bc33897ed

It is only used for the metadir root, which can be open coded.

Signed-off-by: Christoph Hellwig <hch@lst.de>
14 months agoxfs: xfs_imeta_lookup is only used on metadir file systems
Christoph Hellwig [Fri, 12 Apr 2024 05:13:36 +0000 (07:13 +0200)]
xfs: xfs_imeta_lookup is only used on metadir file systems

Source kernel commit: 19d25c34be4bc0205b4f2b9ff168a0b14fc13a62

So remove the sb lookup case and add a WARN_ON instead.

Signed-off-by: Christoph Hellwig <hch@lst.de>
14 months agoFOLD: xfs: move inode number validation to xfs_meta_iget
Christoph Hellwig [Fri, 12 Apr 2024 05:12:15 +0000 (07:12 +0200)]
FOLD: xfs: move inode number validation to xfs_meta_iget

14 months agoxfs: move inode number validation to xfs_meta_iget
Christoph Hellwig [Fri, 12 Apr 2024 05:10:34 +0000 (07:10 +0200)]
xfs: move inode number validation to xfs_meta_iget

Source kernel commit: 14eb1a7de9f4531fa27923e36e4f4da64dc38b69

Verifying the inode number in iget makes more sense than in lookup.
(shouldn't we be doing this for all inodes in xfs_iget?)

Signed-off-by: Christoph Hellwig <hch@lst.de>
14 months agoFOLD: xfs: pass a file mode instead of file type to xfs_imeta_iget
Christoph Hellwig [Fri, 12 Apr 2024 05:07:35 +0000 (07:07 +0200)]
FOLD: xfs: pass a file mode instead of file type to xfs_imeta_iget

14 months agoxfs: pass a file mode instead of file type to xfs_imeta_iget
Christoph Hellwig [Fri, 12 Apr 2024 05:04:52 +0000 (07:04 +0200)]
xfs: pass a file mode instead of file type to xfs_imeta_iget

Source kernel commit: 3e3f172d55ff6b43bfa821d4dd4ee9822839dee3

The file type is a directory entry concept, the inode stores the
file mode.  Pass that to xfs_imeta_iget to avoid conversions and
make the code easier to read.

Signed-off-by: Christoph Hellwig <hch@lst.de>
14 months agoFOLD: xfs: refactor is static metadata inode checks
Christoph Hellwig [Fri, 12 Apr 2024 05:58:26 +0000 (07:58 +0200)]
FOLD: xfs: refactor is static metadata inode checks

14 months agoxfs: refactor is static metadata inode checks
Christoph Hellwig [Fri, 12 Apr 2024 04:53:25 +0000 (06:53 +0200)]
xfs: refactor is static metadata inode checks

Source kernel commit: c1a55c7bacaa75f4b87dbf3678080448879b170e

Use a single helper to check for the up to give static metatada
inodes.  Include the !metadir check in it as metadir file systems
never have them set.

Remove the duplicate check in xrep_orphanage_can_adopt as it already
checks for all metadata inodes directly below.

Remove the xfs_internal_inum wrapper as xfs_is_static_metadata_ino is
much more descriptive for what it does.

Check that an ino is valid before checking it is metadata in all places
that do both.

Signed-off-by: Christoph Hellwig <hch@lst.de>
14 months agoFOLD: xfs: make sb_metadirino, sb_rgcount and sb_rgblocks separate fields
Christoph Hellwig [Thu, 11 Apr 2024 05:12:56 +0000 (07:12 +0200)]
FOLD: xfs: make sb_metadirino, sb_rgcount and sb_rgblocks separate fields

14 months agoxfs: make sb_metadirino, sb_rgcount and sb_rgblocks separate fields
Christoph Hellwig [Fri, 12 Apr 2024 04:52:19 +0000 (06:52 +0200)]
xfs: make sb_metadirino, sb_rgcount and sb_rgblocks separate fields

Source kernel commit: 8a3050a92feb2f0e14ae3e841319888a8c1c90e5

No need to do fancy overloading, the sb isn't size limited (unlike the
inode).

Signed-off-by: Christoph Hellwig <hch@lst.de>
14 months agomkfs: enable reflink on the realtime device
Darrick J. Wong [Tue, 9 Jan 2024 17:40:33 +0000 (09:40 -0800)]
mkfs: enable reflink on the realtime device

Allow the creation of filesystems with both reflink and realtime volumes
enabled.  For now we don't support a realtime extent size > 1.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agomkfs: validate CoW extent size hint when rtinherit is set
Darrick J. Wong [Tue, 9 Jan 2024 17:40:33 +0000 (09:40 -0800)]
mkfs: validate CoW extent size hint when rtinherit is set

Extent size hints exist to nudge the behavior of the file data block
allocator towards trying to make aligned allocations.  Therefore, it
doesn't make sense to allow a hint that isn't a multiple of the
fundamental allocation unit for a given file.

This means that if the sysadmin is formatting with rtinherit set on the
root dir, validate_cowextsize_hint needs to check the hint value on a
simulated realtime file to make sure that it's correct.  This hasn't
been necessary in the past since one cannot have a CoW hint without a
reflink filesystem, and we previously didn't allow rt reflink
filesystems.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_logprint: report realtime CUIs
Darrick J. Wong [Tue, 9 Jan 2024 17:40:33 +0000 (09:40 -0800)]
xfs_logprint: report realtime CUIs

Decode the CUI format just enough to report if an CUI targets the
realtime device or not.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_repair: allow sysadmins to add realtime reflink
Darrick J. Wong [Tue, 9 Jan 2024 17:40:33 +0000 (09:40 -0800)]
xfs_repair: allow sysadmins to add realtime reflink

Allow the sysadmin to use xfs_repair to upgrade an existing filesystem
to support the realtime reference count btree, and therefore reflink on
realtime volumes.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_repair: validate CoW extent size hint on rtinherit directories
Darrick J. Wong [Tue, 9 Jan 2024 17:40:32 +0000 (09:40 -0800)]
xfs_repair: validate CoW extent size hint on rtinherit directories

XFS allows a sysadmin to change the rt extent size when adding a rt
section to a filesystem after formatting.  If there are any directories
with both a cowextsize hint and rtinherit set, the hint could become
misaligned with the new rextsize.  Offer to fix the problem if we're in
modify mode and the verifier didn't trip.  If we're in dry run mode,
we let the kernel fix it.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_repair: allow realtime files to have the reflink flag set
Darrick J. Wong [Tue, 9 Jan 2024 17:40:32 +0000 (09:40 -0800)]
xfs_repair: allow realtime files to have the reflink flag set

Now that we allow reflink on the realtime volume, allow that combination
of inode flags if the feature's enabled.  Note that we now allow inodes
to have rtinherit even if there's no realtime volume, since the kernel
has never restricted that.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_repair: rebuild the realtime refcount btree
Darrick J. Wong [Tue, 9 Jan 2024 17:40:32 +0000 (09:40 -0800)]
xfs_repair: rebuild the realtime refcount btree

Use the collected reference count information to rebuild the btree.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_repair: reject unwritten shared extents
Darrick J. Wong [Tue, 9 Jan 2024 17:40:32 +0000 (09:40 -0800)]
xfs_repair: reject unwritten shared extents

We don't allow sharing of unwritten extents, which means that repair
should reject an unwritten extent if someone else has already claimed
the space.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_repair: check existing realtime refcountbt entries against observed refcounts
Darrick J. Wong [Tue, 9 Jan 2024 17:40:32 +0000 (09:40 -0800)]
xfs_repair: check existing realtime refcountbt entries against observed refcounts

Once we've finished collecting reverse mapping observations from the
metadata scan, check those observations against the realtime refcount
btree (particularly if we're in -n mode) to detect rtrefcountbt
problems.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_repair: compute refcount data for the realtime groups
Darrick J. Wong [Tue, 9 Jan 2024 17:40:31 +0000 (09:40 -0800)]
xfs_repair: compute refcount data for the realtime groups

At the end of phase 4, compute reference count information for realtime
groups from the realtime rmap information collected, just like we do for
AGs in the data section.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_repair: find and mark the rtrefcountbt inode
Darrick J. Wong [Tue, 9 Jan 2024 17:40:31 +0000 (09:40 -0800)]
xfs_repair: find and mark the rtrefcountbt inode

Make sure that we find the realtime refcountbt inode and mark it
appropriately, just in case we find a rogue inode claiming to
be an rtrefcount, or just plain garbage in the superblock field.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_repair: use realtime refcount btree data to check block types
Darrick J. Wong [Tue, 9 Jan 2024 17:40:31 +0000 (09:40 -0800)]
xfs_repair: use realtime refcount btree data to check block types

Use the realtime refcount btree to pre-populate the block type information
so that when repair iterates the primary metadata, we can confirm the
block type.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_repair: allow CoW staging extents in the realtime rmap records
Darrick J. Wong [Tue, 9 Jan 2024 17:40:31 +0000 (09:40 -0800)]
xfs_repair: allow CoW staging extents in the realtime rmap records

Don't flag the rt rmap btree as having errors if there are CoW staging
extent records in it and the filesystem supports.  As far as reporting
leftover staging extents, we'll report them when we scan the rt refcount
btree, in a future patch.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_spaceman: report health of the realtime refcount btree
Darrick J. Wong [Tue, 9 Jan 2024 17:40:31 +0000 (09:40 -0800)]
xfs_spaceman: report health of the realtime refcount btree

Report the health of the realtime reference count btree.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_db: copy the realtime refcount btree
Darrick J. Wong [Tue, 9 Jan 2024 17:40:30 +0000 (09:40 -0800)]
xfs_db: copy the realtime refcount btree

Copy the realtime refcountbt when we're metadumping the filesystem.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_db: support rudimentary checks of the rtrefcount btree
Darrick J. Wong [Tue, 9 Jan 2024 17:40:30 +0000 (09:40 -0800)]
xfs_db: support rudimentary checks of the rtrefcount btree

Perform some fairly superficial checks of the rtrefcount btree.  We'll
do more sophisticated checks in xfs_repair, but provide enough of
a spot-check here that we can do simple things.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_db: widen block type mask to 64 bits
Darrick J. Wong [Tue, 9 Jan 2024 17:40:30 +0000 (09:40 -0800)]
xfs_db: widen block type mask to 64 bits

We're about to enlarge enum dbm beyond 32 items, so we need to widen the
block type mask to 64 bits to avoid problems.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_db: support the realtime refcountbt
Darrick J. Wong [Tue, 9 Jan 2024 17:40:30 +0000 (09:40 -0800)]
xfs_db: support the realtime refcountbt

Wire up various parts of xfs_db for realtime refcount support.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_db: display the realtime refcount btree contents
Darrick J. Wong [Tue, 9 Jan 2024 17:40:29 +0000 (09:40 -0800)]
xfs_db: display the realtime refcount btree contents

Implement all the code we need to dump rtrefcountbt contents, starting
from the root inode.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agolibfrog: enable scrubbing of the realtime refcount data
Darrick J. Wong [Tue, 9 Jan 2024 17:40:29 +0000 (09:40 -0800)]
libfrog: enable scrubbing of the realtime refcount data

Add a new entry so that we can scrub the rtrefcountbt.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs: scrub the metadir path of rt refcount btree files
Darrick J. Wong [Tue, 9 Jan 2024 17:40:29 +0000 (09:40 -0800)]
xfs: scrub the metadir path of rt refcount btree files

Add a new XFS_SCRUB_METAPATH subtype so that we can scrub the metadata
directory tree path to the refcount btree file for each rt group.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs: scrub the realtime refcount btree
Darrick J. Wong [Tue, 9 Jan 2024 17:40:29 +0000 (09:40 -0800)]
xfs: scrub the realtime refcount btree

Add code to scrub realtime refcount btrees.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs: report realtime refcount btree corruption errors to the health system
Darrick J. Wong [Tue, 9 Jan 2024 17:44:38 +0000 (09:44 -0800)]
xfs: report realtime refcount btree corruption errors to the health system

Whenever we encounter corrupt realtime refcount btree blocks, we should
report that to the health monitoring system for later reporting.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs: enable extent size hints for CoW operations
Darrick J. Wong [Tue, 9 Jan 2024 17:40:28 +0000 (09:40 -0800)]
xfs: enable extent size hints for CoW operations

Wire up the copy-on-write extent size hint for realtime files, and
connect it to the rt allocator so that we avoid fragmentation on rt
filesystems.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs: apply rt extent alignment constraints to CoW extsize hint
Darrick J. Wong [Tue, 9 Jan 2024 17:40:28 +0000 (09:40 -0800)]
xfs: apply rt extent alignment constraints to CoW extsize hint

The copy-on-write extent size hint is subject to the same alignment
constraints as the regular extent size hint.  Since we're in the process
of adding reflink (and therefore CoW) to the realtime device, we must
apply the same scattered rextsize alignment validation strategies to
both hints to deal with the possibility of rextsize changing.

Therefore, fix the inode validator to perform rextsize alignment checks
on regular realtime files, and to remove misaligned directory hints.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs: fix xfs_get_extsz_hint behavior with realtime alwayscow files
Darrick J. Wong [Tue, 9 Jan 2024 17:40:28 +0000 (09:40 -0800)]
xfs: fix xfs_get_extsz_hint behavior with realtime alwayscow files

Currently, we (ab)use xfs_get_extsz_hint so that it always returns a
nonzero value for realtime files.  This apparently was done to disable
delayed allocation for realtime files.

However, once we enable realtime reflink, we can also turn on the
alwayscow flag to force CoW writes to realtime files.  In this case, the
logic will incorrectly send the write through the delalloc write path.

Fix this by adjusting the logic slightly.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs: refcover CoW leftovers in the realtime volume
Darrick J. Wong [Tue, 9 Jan 2024 17:40:28 +0000 (09:40 -0800)]
xfs: refcover CoW leftovers in the realtime volume

Scan the realtime refcount tree at mount time to get rid of leftover
CoW staging extents.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs: allow inodes to have the realtime and reflink flags
Darrick J. Wong [Tue, 9 Jan 2024 17:40:28 +0000 (09:40 -0800)]
xfs: allow inodes to have the realtime and reflink flags

Now that we can share blocks between realtime files, allow this
combination.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs: compute rtrmap btree max levels when reflink enabled
Darrick J. Wong [Tue, 9 Jan 2024 17:40:27 +0000 (09:40 -0800)]
xfs: compute rtrmap btree max levels when reflink enabled

Compute the maximum possible height of the realtime rmap btree when
reflink is enabled.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs: update rmap to allow cow staging extents in the rt rmap
Darrick J. Wong [Tue, 9 Jan 2024 17:40:27 +0000 (09:40 -0800)]
xfs: update rmap to allow cow staging extents in the rt rmap

Don't error out on CoW staging extent records when realtime reflink is
enabled.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs: create routine to allocate and initialize a realtime refcount btree inode
Darrick J. Wong [Tue, 9 Jan 2024 17:40:27 +0000 (09:40 -0800)]
xfs: create routine to allocate and initialize a realtime refcount btree inode

Create a library routine to allocate and initialize an empty realtime
refcountbt inode.  We'll use this for growfs, mkfs, and repair.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs: wire up realtime refcount btree cursors
Darrick J. Wong [Tue, 9 Jan 2024 17:44:28 +0000 (09:44 -0800)]
xfs: wire up realtime refcount btree cursors

Wire up realtime refcount btree cursors wherever they're needed
throughout the code base.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs: wire up a new inode fork type for the realtime refcount
Darrick J. Wong [Tue, 9 Jan 2024 17:40:27 +0000 (09:40 -0800)]
xfs: wire up a new inode fork type for the realtime refcount

Plumb in the pieces we need to embed the root of the realtime refcount
btree in an inode's data fork, complete with new fork type and
on-disk interpretation functions.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs: add metadata reservations for realtime refcount btree
Darrick J. Wong [Tue, 9 Jan 2024 17:40:26 +0000 (09:40 -0800)]
xfs: add metadata reservations for realtime refcount btree

Reserve some free blocks so that we will always have enough free blocks
in the data volume to handle expansion of the realtime refcount btree.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs: add realtime refcount btree inode to metadata directory
Darrick J. Wong [Tue, 9 Jan 2024 17:44:25 +0000 (09:44 -0800)]
xfs: add realtime refcount btree inode to metadata directory

Add a metadir path to select the realtime refcount btree inode and load
it at mount time.  The rtrefcountbt inode will have a unique extent format
code, which means that we also have to update the inode validation and
flush routines to look for it.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs: add a realtime flag to the refcount update log redo items
Darrick J. Wong [Tue, 9 Jan 2024 17:44:23 +0000 (09:44 -0800)]
xfs: add a realtime flag to the refcount update log redo items

Extend the refcount update (CUI) log items with a new realtime flag that
indicates that the updates apply against the realtime refcountbt.  We'll
wire up the actual refcount code later.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs: prepare refcount functions to deal with rtrefcountbt
Darrick J. Wong [Tue, 9 Jan 2024 17:44:22 +0000 (09:44 -0800)]
xfs: prepare refcount functions to deal with rtrefcountbt

Prepare the high-level refcount functions to deal with the new realtime
refcountbt and its slightly different conventions.  Provide the ability
to talk to either refcountbt or rtrefcountbt formats from the same high
level code.

Note that we leave the _recover_cow_leftovers functions for a separate
patch so that we can convert it all at once.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs: add realtime refcount btree operations
Darrick J. Wong [Tue, 9 Jan 2024 17:40:25 +0000 (09:40 -0800)]
xfs: add realtime refcount btree operations

Implement the generic btree operations needed to manipulate rtrefcount
btree blocks. This is different from the regular refcountbt in that we
allocate space from the filesystem at large, and are neither constrained
to the free space nor any particular AG.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs: realtime refcount btree transaction reservations
Darrick J. Wong [Tue, 9 Jan 2024 17:40:25 +0000 (09:40 -0800)]
xfs: realtime refcount btree transaction reservations

Make sure that there's enough log reservation to handle mapping
and unmapping realtime extents.  We have to reserve enough space
to handle a split in the rtrefcountbt to add the record and a second
split in the regular refcountbt to record the rtrefcountbt split.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs: define the on-disk realtime refcount btree format
Darrick J. Wong [Tue, 9 Jan 2024 17:44:20 +0000 (09:44 -0800)]
xfs: define the on-disk realtime refcount btree format

Start filling out the rtrefcount btree implementation. Start with the
on-disk btree format; add everything needed to read, write and
manipulate refcount btree blocks. This prepares the way for connecting
the btree operations implementation.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs: namespace the maximum length/refcount symbols
Darrick J. Wong [Tue, 9 Jan 2024 17:40:25 +0000 (09:40 -0800)]
xfs: namespace the maximum length/refcount symbols

Actually namespace these variables properly, so that readers can tell
that this is an XFS symbol, and that it's for the refcount
functionality.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs: introduce realtime refcount btree definitions
Darrick J. Wong [Tue, 9 Jan 2024 17:44:18 +0000 (09:44 -0800)]
xfs: introduce realtime refcount btree definitions

Add new realtime refcount btree definitions. The realtime refcount btree
will be rooted from a hidden inode, but has its own shape and therefore
needs to have most of its own separate types.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs: move xfs_refcount_update_defer_add to xfs_refcount_item.c
Darrick J. Wong [Tue, 9 Jan 2024 17:40:24 +0000 (09:40 -0800)]
xfs: move xfs_refcount_update_defer_add to xfs_refcount_item.c

Move the code that adds the incore xfs_refcount_update_item deferred
work data to a transaction live with the CUI log item code.  This means
that the refcount code no longer has to know about the inner workings of
the CUI log items.

As a consequence, we can get rid of the _{get,put}_group helpers.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs: simplify usage of the rcur local variable in xfs_refcount_finish_one
Darrick J. Wong [Tue, 9 Jan 2024 17:44:16 +0000 (09:44 -0800)]
xfs: simplify usage of the rcur local variable in xfs_refcount_finish_one

Only update rcur when we know the final *pcur value.

Inspired-by: Christoph Hellwig <hch@lst.de>
[djwong: don't leave the caller with a dangling ref]
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs: don't bother calling xfs_refcount_finish_one_cleanup in xfs_refcount_finish_one
Darrick J. Wong [Tue, 9 Jan 2024 17:44:15 +0000 (09:44 -0800)]
xfs: don't bother calling xfs_refcount_finish_one_cleanup in xfs_refcount_finish_one

In xfs_refcount_finish_one we know the cursor is non-zero when calling
xfs_refcount_finish_one_cleanup and we pass a 0 error variable.  This
means xfs_refcount_finish_one_cleanup is just doing a
xfs_btree_del_cursor.

Open code that and move xfs_refcount_finish_one_cleanup to
fs/xfs/xfs_refcount_item.c.

Inspired-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs: reuse xfs_refcount_update_cancel_item
Darrick J. Wong [Tue, 9 Jan 2024 17:40:24 +0000 (09:40 -0800)]
xfs: reuse xfs_refcount_update_cancel_item

Reuse xfs_refcount_update_cancel_item to put the AG/RTG and free the
item in a few places that currently open code the logic.

Inspired-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs: add a ci_entry helper
Darrick J. Wong [Tue, 9 Jan 2024 17:40:24 +0000 (09:40 -0800)]
xfs: add a ci_entry helper

Add a helper to translate from the item list head to the
refcount_intent_item structure and use it so shorten assignments and
avoid the need for extra local variables.

Inspired-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs: clean up refcount log intent item tracepoint callsites
Darrick J. Wong [Tue, 9 Jan 2024 17:40:23 +0000 (09:40 -0800)]
xfs: clean up refcount log intent item tracepoint callsites

Pass the incore refcount intent structure to the tracepoints instead of
open-coding the argument passing.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs: prepare refcount btree tracepoints for widening
Darrick J. Wong [Tue, 9 Jan 2024 17:44:11 +0000 (09:44 -0800)]
xfs: prepare refcount btree tracepoints for widening

Prepare the rest of refcount btree tracepoints for use with realtime
reflink by making them take the btree cursor object as a parameter.
This will save us a lot of trouble later on.

Remove the xfs_refcount_recover_extent tracepoint since it's already
covered by other refcount tracepoints.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs: create specialized classes for refcount tracepoints
Darrick J. Wong [Tue, 9 Jan 2024 17:40:23 +0000 (09:40 -0800)]
xfs: create specialized classes for refcount tracepoints

The only user of the "ag" tracepoint event classes is the refcount
btree, so rename them to make that obvious and make them take the btree
cursor to simplify the arguments.  This will save us a lot of trouble
later on.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs: give refcount btree cursor error tracepoints their own class
Darrick J. Wong [Tue, 9 Jan 2024 17:40:23 +0000 (09:40 -0800)]
xfs: give refcount btree cursor error tracepoints their own class

Convert all the refcount tracepoints to use the btree error tracepoint
class.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agomkfs: use file write helper to populate files
Darrick J. Wong [Tue, 9 Jan 2024 17:40:23 +0000 (09:40 -0800)]
mkfs: use file write helper to populate files

Use the file write helper to write files into the filesystem.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_repair: use libxfs_alloc_file_space to reallocate rt metadata
Darrick J. Wong [Tue, 9 Jan 2024 17:40:22 +0000 (09:40 -0800)]
xfs_repair: use libxfs_alloc_file_space to reallocate rt metadata

Now that libxfs_alloc_file_space can allocate and zero blocks, use it to
repair the realtime metadata instead of open-coding all this.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agomkfs: use libxfs_alloc_file_space for rtinit
Darrick J. Wong [Tue, 9 Jan 2024 17:40:22 +0000 (09:40 -0800)]
mkfs: use libxfs_alloc_file_space for rtinit

Since xfs_bmapi_write can now zero newly allocated blocks, use it to
initialize the realtime inodes instead of open coding this.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agolibxfs: resync libxfs_alloc_file_space interface with the kernel
Darrick J. Wong [Tue, 9 Jan 2024 17:40:22 +0000 (09:40 -0800)]
libxfs: resync libxfs_alloc_file_space interface with the kernel

Make the userspace xfs_alloc_file_space behave (more or less) like the
kernel version, at least as far as the interface goes.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agomkfs: create the realtime rmap inode
Darrick J. Wong [Tue, 9 Jan 2024 17:40:22 +0000 (09:40 -0800)]
mkfs: create the realtime rmap inode

Create a realtime rmapbt inode if we format the fs with realtime
and rmap.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_logprint: report realtime RUIs
Darrick J. Wong [Tue, 9 Jan 2024 17:40:22 +0000 (09:40 -0800)]
xfs_logprint: report realtime RUIs

Decode the RUI format just enough to report if an RUI targets the
realtime device or not.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_repair: allow sysadmins to add realtime reverse mapping indexes
Darrick J. Wong [Tue, 9 Jan 2024 17:40:21 +0000 (09:40 -0800)]
xfs_repair: allow sysadmins to add realtime reverse mapping indexes

Allow the sysadmin to use xfs_repair to upgrade an existing filesystem
to support the reverse mapping btree index for realtime volumes.  This
is needed for online fsck.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_repair: reserve per-AG space while rebuilding rt metadata
Darrick J. Wong [Tue, 9 Jan 2024 17:40:21 +0000 (09:40 -0800)]
xfs_repair: reserve per-AG space while rebuilding rt metadata

Realtime metadata btrees can consume quite a bit of space on a full
filesystem.  Since the metadata are just regular files, we need to
make the per-AG reservations to avoid overfilling any of the AGs while
rebuilding metadata.  This avoids the situation where a filesystem comes
straight from repair and immediately trips over not having enough space
in an AG.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_repair: rebuild the bmap btree for realtime files
Darrick J. Wong [Tue, 9 Jan 2024 17:40:21 +0000 (09:40 -0800)]
xfs_repair: rebuild the bmap btree for realtime files

Use the realtime rmap btree information to rebuild an inode's data fork
when appropriate.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_repair: check for global free space concerns with default btree slack levels
Darrick J. Wong [Tue, 9 Jan 2024 17:40:21 +0000 (09:40 -0800)]
xfs_repair: check for global free space concerns with default btree slack levels

It's possible that before repair was started, the filesystem might have
been nearly full, and its metadata btree blocks could all have been
nearly full.  If we then rebuild the btrees with blocks that are only
75% full, that expansion might be enough to run out of free space.  The
solution to this is to pack the new blocks completely full if we fear
running out of space.

Previously, we only had to check and decide that on a per-AG basis.
However, now that XFS can have filesystems with metadata btrees rooted
in inodes, we have a global free space concern because there might be
enough space in each AG to regenerate the AG btrees at 75%, but that
might not leave enough space to regenerate the inode btrees, even if we
fill those blocks to 100%.

Hence we need to precompute the worst case space usage for all btrees in
the filesystem and compare /that/ against the global free space to
decide if we're going to pack the btrees maximally to conserve space.
That decision can override the per-AG determination.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_repair: rebuild the realtime rmap btree
Darrick J. Wong [Tue, 9 Jan 2024 17:40:20 +0000 (09:40 -0800)]
xfs_repair: rebuild the realtime rmap btree

Rebuild the realtime rmap btree file from the reverse mapping records we
gathered from walking the inodes.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_repair: always check realtime file mappings against incore info
Darrick J. Wong [Tue, 9 Jan 2024 17:40:20 +0000 (09:40 -0800)]
xfs_repair: always check realtime file mappings against incore info

Curiously, the xfs_repair code that processes data fork mappings of
realtime files doesn't actually compare the mappings against the incore
state map during the !check_dups phase (aka phase 3).  As a result, we
lose the opportunity to clear damaged realtime data forks before we get
to crosslinked file checking in phase 4, which results in ondisk
metadata errors calling do_error, which aborts repair.

Split the process_rt_rec_state code into two functions: one to check the
mapping, and another to update the incore state.  The first one can be
called to help us decide if we're going to zap the fork, and the second
one updates the incore state if we decide to keep the fork.  We already
do this for regular data files.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_repair: check existing realtime rmapbt entries against observed rmaps
Darrick J. Wong [Tue, 9 Jan 2024 17:40:20 +0000 (09:40 -0800)]
xfs_repair: check existing realtime rmapbt entries against observed rmaps

Once we've finished collecting reverse mapping observations from the
metadata scan, check those observations against the realtime rmap btree
(particularly if we're in -n mode) to detect rtrmapbt problems.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_repair: find and mark the rtrmapbt inodes
Darrick J. Wong [Tue, 9 Jan 2024 17:40:20 +0000 (09:40 -0800)]
xfs_repair: find and mark the rtrmapbt inodes

Make sure that we find the realtime rmapbt inodes and mark them
appropriately, just in case we find a rogue inode claiming to be an
rtrmap, or garbage in the metadata directory tree.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_repair: refactor realtime inode check
Darrick J. Wong [Tue, 9 Jan 2024 17:40:20 +0000 (09:40 -0800)]
xfs_repair: refactor realtime inode check

Refactor the realtime bitmap and summary checks into a helper function.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_repair: collect relatime reverse-mapping data for refcount/rmap tree rebuilding
Darrick J. Wong [Tue, 9 Jan 2024 17:40:19 +0000 (09:40 -0800)]
xfs_repair: collect relatime reverse-mapping data for refcount/rmap tree rebuilding

Collect reverse-mapping data for realtime files so that we can later
check and rebuild the reference count tree and the reverse mapping
tree.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_repair: create a new set of incore rmap information for rt groups
Darrick J. Wong [Tue, 9 Jan 2024 17:40:19 +0000 (09:40 -0800)]
xfs_repair: create a new set of incore rmap information for rt groups

Create a parallel set of "xfs_ag_rmap" structures to cache information
about reverse mappings for the realtime groups.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_repair: use realtime rmap btree data to check block types
Darrick J. Wong [Tue, 9 Jan 2024 17:40:19 +0000 (09:40 -0800)]
xfs_repair: use realtime rmap btree data to check block types

Use the realtime rmap btree to pre-populate the block type information
so that when repair iterates the primary metadata, we can confirm the
block type.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_repair: flag suspect long-format btree blocks
Darrick J. Wong [Tue, 9 Jan 2024 17:40:19 +0000 (09:40 -0800)]
xfs_repair: flag suspect long-format btree blocks

Pass a "suspect" counter through scan_lbtree just like we do for
short-format btree blocks, and increment its value when we encounter
blocks with bad CRCs or outright corruption.  This makes it so that
repair actually catches bmbt blocks with bad crcs or other verifier
errors.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agolibxfs: dirty buffers should be marked uptodate too
Darrick J. Wong [Tue, 9 Jan 2024 17:40:19 +0000 (09:40 -0800)]
libxfs: dirty buffers should be marked uptodate too

I started fuzz-testing the realtime rmap feature with a very large
number of realtime allocation groups.  There were so many rt groups that
repair had to rebuild /realtime in the metadata directory tree, and that
directory was big enough to spur the creation of a block format
directory.

Unfortunately, repair then walks both directory trees to look for
unconnceted files.  This part of phase 6 emits CRC errors on the newly
created buffers for the /realtime directory, declares the directory to
be garbage, and moves all the rt rmap inodes to /lost+found, resulting
in a corrupt fs.

Poking around in gdb, I noticed that the buffer contents were indeed
zero, and that UPTODATE was not set.  This was very strange, until I
added a watch on bp->b_flags to watch for accesses.  It turns out that
xfs_repair's prefetch code will _get a buffer and zero the contents if
UPTODATE is not set.

The directory tree code in libxfs will also _get a buffer, initialize
it, and log it to the coordinating transaction, which in this case is
the transactions used to reconnect the rmap btree inodes to /realtime.
At no point does any of that code ever set UPTODATE on the buffer, which
is why prefetch zaps the contents.

Hence change both buffer dirtying functions to set UPTODATE, since a
dirty buffer is by definition at least as recent as whatever's on disk.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_spaceman: report health status of the realtime rmap btree
Darrick J. Wong [Tue, 9 Jan 2024 17:40:18 +0000 (09:40 -0800)]
xfs_spaceman: report health status of the realtime rmap btree

Add reporting of the rt rmap btree health to spaceman.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_scrub: retest metadata across scrub groups after a repair
Darrick J. Wong [Tue, 9 Jan 2024 17:40:18 +0000 (09:40 -0800)]
xfs_scrub: retest metadata across scrub groups after a repair

Certain types of metadata have dependencies that cross scrub groups.
For example, after a repair the part of realtime bitmap corresponding to
a realtime group, we potentially need to rebuild the realtime summary to
reflect the new bitmap contents.  The rtsummary is a separate scrub group
(metafiles) from the rgbitmap (rtgroup), which means that the rtsummary
repairs must be tracked by a separate scrub_item.

Create the necessary dependency table and code to make these kinds of
cross-group validations possible.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agoxfs_scrub: check rtrmapbt metadata directory connections
Darrick J. Wong [Tue, 9 Jan 2024 17:40:18 +0000 (09:40 -0800)]
xfs_scrub: check rtrmapbt metadata directory connections

Run the rt rmap btree metapath scrubber during phase 5 to ensure that
it's still connected to the metadir tree after we've pruned any bad
links.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
14 months agolibfrog: enable scrubbng of the realtime rmap
Darrick J. Wong [Tue, 9 Jan 2024 17:40:18 +0000 (09:40 -0800)]
libfrog: enable scrubbng of the realtime rmap

Add a new entry so that we can scrub the rtrmapbt.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>