]> www.infradead.org Git - users/sagi/nvme-cli.git/log
users/sagi/nvme-cli.git
6 years agonvme-cli: don't use unsigned for fd in lnvm-nvme.c
Chaitanya Kulkarni [Mon, 20 Aug 2018 00:36:06 +0000 (20:36 -0400)]
nvme-cli: don't use unsigned for fd in lnvm-nvme.c

Change the data type of the fd from unsigned int -> int.

Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
6 years agonvme-cli: fix sparse warnings for declaration
Chaitanya Kulkarni [Sun, 19 Aug 2018 16:57:31 +0000 (12:57 -0400)]
nvme-cli: fix sparse warnings for declaration

Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
6 years agonvme-cli: wdc-plugin mark array static declaration
Chaitanya Kulkarni [Sun, 19 Aug 2018 17:06:57 +0000 (13:06 -0400)]
nvme-cli: wdc-plugin mark array static declaration

The array deFeatureIdList is only used in wdc-nvme.c,
use static declaration.

6 years agonvme-cli: make show_registers_cap() static
Chaitanya Kulkarni [Sun, 19 Aug 2018 17:14:16 +0000 (13:14 -0400)]
nvme-cli: make show_registers_cap() static

The function show_registers_cap() us only used in the nvme-print.c,
mark this function static.

Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
6 years agoFix nvme id namespace struct
Keith Busch [Mon, 20 Aug 2018 16:23:16 +0000 (10:23 -0600)]
Fix nvme id namespace struct

Off by one in the reserved field.

Link: https://github.com/linux-nvme/nvme-cli/issues/405
Signed-off-by: Keith Busch <keith.busch@intel.com>
6 years agonvme-discover: sanitize options
Hannes Reinecke [Fri, 17 Aug 2018 07:29:05 +0000 (09:29 +0200)]
nvme-discover: sanitize options

The discovery controller doesn't accept any KATO or number of I/O
queue changes, but we do want to change the reconnect delay and
the controller loss timeout.

Signed-off-by: Hannes Reinecke <hare@suse.com>
6 years agonvme-vendor: fixup c99 declaration in huawei plugin
Hannes Reinecke [Fri, 17 Aug 2018 07:29:04 +0000 (09:29 +0200)]
nvme-vendor: fixup c99 declaration in huawei plugin

We can't use c99 declaration with older compilers.

Signed-off-by: Hannes Reinecke <hare@suse.com>
6 years agonvme-ana-log: fixup compiler warning in show_ana_log()
Hannes Reinecke [Fri, 17 Aug 2018 07:29:03 +0000 (09:29 +0200)]
nvme-ana-log: fixup compiler warning in show_ana_log()

Add the correct type cast to keep the compiler happy.

Signed-off-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
6 years agoMerge pull request #398 from bdeyal/master
Keith Busch [Thu, 16 Aug 2018 18:53:58 +0000 (12:53 -0600)]
Merge pull request #398 from bdeyal/master

nvme-get-property : Add documentation

6 years agoMerge pull request #403 from bdeyal/pci_ids
Keith Busch [Mon, 13 Aug 2018 14:56:13 +0000 (08:56 -0600)]
Merge pull request #403 from bdeyal/pci_ids

nvme-models.c - search for pci.ids

6 years agoFix print format specifier for 64-bit
Keith Busch [Mon, 13 Aug 2018 14:40:51 +0000 (08:40 -0600)]
Fix print format specifier for 64-bit

For cross platform compatibility, we use PRI macros instead of hard
coding 64-bit specifiers.

Signed-off-by: Keith Busch <keith.busch@intel.com>
6 years agonvme-cli: add ana-log documentation
Chaitanya Kulkarni [Mon, 13 Aug 2018 05:59:20 +0000 (22:59 -0700)]
nvme-cli: add ana-log documentation

Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
6 years agonvme-cli: add minimal ana-log page support
Chaitanya Kulkarni [Mon, 13 Aug 2018 05:59:19 +0000 (22:59 -0700)]
nvme-cli: add minimal ana-log page support

This patch adds a new command to retrieve the ANA Log page.
We update identify ctrl/ns data structure to support this command.
We also add ana based error codes and different identifiers to the
linux/nvme.h header file in order to support this command.

Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: Hannes Reinecke <hare@suse.com>
6 years agonvme-cli add ns write protect feature support
Chaitanya Kulkarni [Sun, 12 Aug 2018 23:30:51 +0000 (16:30 -0700)]
nvme-cli add ns write protect feature support

Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
6 years agonvme-models.c - search for pci.ids
Eyal Ben David [Sat, 4 Aug 2018 21:15:51 +0000 (00:15 +0300)]
nvme-models.c - search for pci.ids

Take from PCI_IDS_PATH or look at some default locations
Updated docs for the envrironment in nvme-list.txt
Regenerated man and html pages.

6 years agofabrics: write keep-alive-timeout to fabrics device on connect
Johannes Thumshirn [Thu, 9 Aug 2018 09:25:23 +0000 (11:25 +0200)]
fabrics: write keep-alive-timeout to fabrics device on connect

Commit 7099227b07a8 ("fabrics: add option to supply keep-alive-timeout
for connect-all") introduced a keep-alive-timeout option for
connect-all but forgot to write it down to the kernel's fabrics
device in connect_ctrl().

Pass down the keep-alove-timeouts if we're connecting to a non
discovery controller.

Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Fixes: 7099227b07a8 ("fabrics: add option to supply keep-alive-timeout for connect-all")
Signed-off-by: Keith Busch <keith.busch@intel.com>
6 years agofabrics: write ctrl_loss_tmo to fabrics device on connect
Johannes Thumshirn [Thu, 9 Aug 2018 09:25:22 +0000 (11:25 +0200)]
fabrics: write ctrl_loss_tmo to fabrics device on connect

Commit 388c9dbe86be ("fabrics: add ctrl-loss-tmo to connect-all")
introduced the '--ctrl-loss-tmo' option for the connect-all command,
but we forgor to pass down the option to the kernel in connect_ctrl().

Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Fixes: 388c9dbe86be ("fabrics: add ctrl-loss-tmo to connect-all")
fixup! fabrics: write ctrl_loss_tmo to fabrics device on connect
Signed-off-by: Keith Busch <keith.busch@intel.com>
6 years agonvme-get-property : Add documentation
Eyal Ben David [Sat, 4 Aug 2018 20:12:05 +0000 (23:12 +0300)]
nvme-get-property : Add documentation

7 years agoMerge pull request #397 from minwooim/v1.7/fix_typo_in_list
Keith Busch [Fri, 3 Aug 2018 14:20:04 +0000 (08:20 -0600)]
Merge pull request #397 from minwooim/v1.7/fix_typo_in_list

nvme-cli: fix typo in json_print_list_items

7 years agonvme-cli: fix typo in json_print_list_items
Minwoo Im [Fri, 3 Aug 2018 09:52:02 +0000 (18:52 +0900)]
nvme-cli: fix typo in json_print_list_items

Fix the typo like below:
MaximiumLBA -> MaximumLBA

Issue: #396: Typo in nvme list command
Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
7 years agoMerge pull request #387 from narasimhan-v/create_max_ns_test
Keith Busch [Thu, 2 Aug 2018 18:50:52 +0000 (12:50 -0600)]
Merge pull request #387 from narasimhan-v/create_max_ns_test

Use tnvmcap register for creating namespace

7 years agoMerge pull request #389 from talshorer/master
Keith Busch [Thu, 2 Aug 2018 18:50:23 +0000 (12:50 -0600)]
Merge pull request #389 from talshorer/master

don't execute a command if --dry-run is supplied

7 years agoMerge pull request #390 from bdeyal/master
Keith Busch [Thu, 2 Aug 2018 18:50:08 +0000 (12:50 -0600)]
Merge pull request #390 from bdeyal/master

nvme-print.c : fix ns-descs JSON output

7 years agonvme-print.c : fix ns-descs JSON output
Eyal Ben David [Sun, 15 Jul 2018 14:11:21 +0000 (17:11 +0300)]
nvme-print.c : fix ns-descs JSON output

7 years agonvme-cli: remove unnecessary assignments
Chaitanya Kulkarni [Thu, 26 Jul 2018 21:59:13 +0000 (14:59 -0700)]
nvme-cli: remove unnecessary assignments

This removes the unnecessary assignment of the variable.

Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
7 years agoMerge pull request #393 from puneetk/smart-log-add-patch
Keith Busch [Wed, 25 Jul 2018 19:48:22 +0000 (13:48 -0600)]
Merge pull request #393 from puneetk/smart-log-add-patch

Remove trailing "\n" so that the output is valid json

7 years agoRemove trailing "\n" so that the output is valid json
puneet kandhari [Wed, 25 Jul 2018 19:46:26 +0000 (14:46 -0500)]
Remove trailing "\n" so that the output is valid json

7 years agoRelease 1.6 v1.6
Keith Busch [Wed, 18 Jul 2018 18:47:00 +0000 (12:47 -0600)]
Release 1.6

It's been far too long, and we've lots of fixes and updates, so tagging
a new release. Shortlog of all the commits since the 1.5 release are
below. Special thanks to everyone who contributed, including the people
not listed here who filed and verified issues.

521852 (2):
      Adding ppc big endian support
      Updating version to 1.1

Alexey Timofeyev (3):
      nvme-cli: Fix build breaks for GCC 8.1 Signed-off-by: Alexey Timofeyev <alexey.timofeyev@sk.com>
      nvme-cli: Fix build breaks for GCC 8.1 Signed-off-by: Alexey Timofeyev <alexey.timofeyev@sk.com>
      nvme-cli: add support of RAE

Andrew Meir (3):
      Add toshiba plugin code and command documentation.
      Add toshiba plugin to makefile rules.
      Fixes for log page access.

Chaitanya Kulkarni (5):
      nvme-cli: allow block device for delete-ns
      nvme-cli: fix get_nsid() return value check
      nvme-cli: fix compilation error
      nvme-cli: add changed log ns support
      nvme-cli: add changed-ns-list-log documentation

Daniel Verkamp (1):
      nvme-cli: fix typo in 'disconnect' docs

Eyal Ben David (3):
      nvme-ioctl.c : nvme_get_properties(): fix 64bit offset advance
      Add a single get-property command for NVMeOF.
      nvme.c, list_ns: use le32_to_cpu in display

James Smart (4):
      nvme-cli: correct spelling of discovery
      nvme-cli: show partial results if controller fails during list and list-subsys
      nvme-cli: Wait for device file if not present after successful add_ctrl
      nvme-cli: Add ioctl retry support for "connect-all"

JasonChiuCC (2):
      nvme-cli: fix show command typo
      nvme-cli: Modify Get Features-Asynchronous Event Configuration

Javier González (1):
      lightnvm: enable to set OP on target creation

Jeff Lien (10):
      NVMe-CLI WDC-Plugin Add drive-essentials command
      NVMe-CLI WDC-Plugin Add drive-essentials documentation
      NVMe-CLI WDC-Plugin Add clear-pcie-corr command
      NVMe-CLI WDC-Plugin Add clear-pcie-corr documentation.
      NVMe-CLI WDC-Plugin Update drive essentials code with review comments.
      NVMe-CLI Fix fw_log Command json output
      Add nvme fw-log commmand test
      Add nvme id-ctrl command test
      Add nvme id-ns command test
      NVMe-CLI Fix id-ns fpi field when Human Readable option selected.

Johannes Thumshirn (3):
      Documentation: add manpage entry for connect's --ctrl-loss-tmo setting
      fabrics: add option to supply keep-alive-timeout for connect-all
      fabrics: add ctrl-loss-tmo to connect-all

Keith Busch (34):
      Allow hierarchy of similiarly named plugins
      Fix verbose decoding for coalescing aggregation time
      Use NSID all for error log
      Use '-' for compounded word telemetry-log subcommand
      flush: Use device NSID if issuing through block device
      Fix freeing wrong address
      Update makefile dependencies
      Add decoding for new controller attributes
      Add support for decoding IO Determinism features
      Add support for NVMe Sets log page
      Add read-recover level feature decoding
      Ignore cscope files
      Fix fabrics property commands
      Add manpage for endurance log
      Regenerate documentation
      Don't print non-existent command line options
      Add remaining fields from NVM Sets
      Fix parameter descriptions
      get-log: Make log identifier a required parameter
      Use fixed-width integer types for long suffixed parameters
      Fix intel media wear json output
      Remove error print for telemetry log arg parse
      Regenrate documentation
      Regenerate man pages
      Revert "nvme-cli: Add ioctl retry support for "connect-all""
      Revert "nvme-cli: Wait for device file if not present after successful add_ctrl"
      Add man pages for new device self test commands
      Replace host-gen telemetry short-option 'h' with 'g'
      Fix json output of 128-bit numbers
      Fix format specifier for 32-bit
      Update doc
      intel: fix latency stats printing
      fix reservation report 0's based dword count
      lightnvm: fix type coercion

Klaus Birkelund Abildgaard Jensen (1):
      nvme-cli: add support for DLFEAT

Matias Bjørling (1):
      Add open-channel 2.0 identify support

Max Gurtovoy (1):
      nvme-cli: fabrics: Fix passing "host_traddr" for all transports

Maxim (2):
      Add user parameter to specify data area region from telemetry log
      Wrote man page for telemetry

Minwoo Im (55):
      nvme-cli: make sanitize description const
      nvme-cli: update print for sanitize-log command with output-format
      nvme-cli: add print for command specific info field of error log page
      nvme-cli: Remove unnecessary nsid field in error-log
      nvme-cli: add support for json output format of sanitize-log command
      Update subcommand alias description in README.md
      nvme-cli: add BPS bit field to CAP controller register
      nvme-cli: lnvm: add whitespace between words in a description
      nvme-cli: lnvm: remove unnecessary force parameter of ns-id in lnvm
      nvme-cli: lnvm: add check for fd after open operation
      nvme-cli: lnvm: add human-readable print format to ns-id subcommand
      nvme-cli: update error-log documentation
      nvme-cli: intel: update smart-log-add command documentation
      nvme-cli: intel: fix smart-log-add documentation
      nvme-cli: intel: add check for fd after open to intel commands
      nvme-cli: intel: add const to descriptions of subcommand option
      nvme-cli: add support for options to effects-log subcommand
      nvme-cli: update documentation of effects-log
      nvme-cli: tests: remove nsid parameter in a testcase of error-log
      nvme-cli: tests: fix typo in get_feature_test
      nvme-cli: add error handling for a failure of malloc
      nvme-cli: fix memory leak in list_ctrl()
      nvme-cli: fix memory leak in ns_descs()
      nvme-cli: fix memory leak in fw_download()
      nvme-cli: fix memory leak in set_feature()
      nvme-cli: fix memory leak in sec_send()
      nvme-cli: fix memory leak in dir_send()
      nvme-cli: fix memory leak in sec_recv()
      nvme-cli: fix memory leak in dir_receive()
      nvme-cli: wdc: add const to descriptions
      nvme-cli: wdc: fix mismatch in document for smart-add-log
      nvme-cli: fix memory leak in passthru()
      nvme-cli: lnvm: Make it return error status when argconfig_parse fails
      nvme-cli: memblaze: fix memory leak in memblaze-nvme.c
      nvme-cli: memblaze: add error return after parse_and_open()
      nvme-cli: add command specific field to json output of error-log
      nvme-cli: make it have bpid in cdw10 for fw-commit
      nvme-cli: add print for command name to effects-log
      nvme-cli: fix leaks in subcommands
      nvme-cli: move print-function to nvme-print
      nvme-cli: make return negative value in nvme_get_nsid() when not blkdev
      nvme-cli: convert iekey into a no_argument parameter
      nvme-cli: update documentations to sync up with subcommands
      nvme-cli: add helper for sanitize command
      nvme-cli: adjust json print according to uint format
      nvme-cli: make it use NVME_IDENTIFY_DATA_SIZE
      nvme-cli: fix seg_fault by cmd options in endurance_log
      nvme-cli: fix leak in endurance_log command
      nvme-cli: make it return 0 in case of non-fabric for show-regs
      nvme-cli: fix perror when blkdev not given when get-ns-id
      nvme-cli: add support for id-nvmset subcommand
      nvme-cli: update new fields in id-ns subcommand
      nvme-cli: update the document for id-nvmset subcommand
      nvme-cli: print firmware activation notices support bit to id_ctrl
      nvme-cli: adjust memset size for data buffer in submit_io

Muhammad Ahmad (2):
      Fixed a bug where cdw11 was being overwritten by cdw12
      Updatign the plugin version

Oleksii Timofieiev (5):
      nvme-cli: Add support of unsigned long long to json routines Signed-off-by: Oleksii Timofieiev <tim.oleksii@gmail.com>
      nvme-cli: wdc: Removed superfluous output in WDC plugin
      nvme-cli: handle long commands in help message by adjusting minimal padding Signed-off-by: Oleksii Timofieiev <tim.oleksii@gmail.com>
      nvme-cli: Fixed incosistency of error handling in intel plugin Signed-off-by: Oleksii Timofieiev <tim.oleksii@gmail.com>
      Fix endianess in WDC plugin.

Pavel Borzenkov (1):
      nvme-cli: fix typo in Intel SMART json output

Revanth Rajashekar (5):
      nvme-cli: Implemented Device self test and log.
      nvme-cli: Implement printing the get timestamp feature.
      nvme-cli: Implement printing the get host controlled thermal management feature.
      nvme-cli: Implement printing the get Keep Alive Timer feature
      nvme-cli: Implement printing get NOPSC feature

Rodrigo R. Galvao (1):
      nvme-cli: Add friendly status messages

Sagi Grimberg (2):
      fabrics: fail early if argconfig_parse failed
      fabrics: omit newline character when reading nvme host nqn

Schremmer, Steven (2):
      nvme-cli: add NetApp plugin
      nvme-cli: add netapp smdevices man page

Scott Bauer (4):
      nvme-cli: Implement get_telemetry_log from 1.3 spec
      nvme/vendor: Add get log LSP/LSO fields from 1.3 spec
      nvme-cli: Implement nvme_get_log13
      nvme-cli: telemetry-log add controller initiated log gathering

Stephen Tubbs (1):
      Add support for Micron plugin

Takashi Iwai (2):
      Documentation: fix title markers
      Documentation: allow to format with asciidoctor

Vijay Kumar (2):
      Fix double free in list_subsys
      Log error incase of failure in get_nvme_subsystem_info()

muhammad.ahmad@seagate.com (7):
      Initial checkin for Seagate Plugin
      Removed Duplicate commands.
      refactored some strings
      Initial checkin for Seagate Plugin
      Removed Duplicate commands.
      refactored some strings
      Making gcc compiler (5.4.0 among others) happy

Signed-off-by: Keith Busch <keith.busch@intel.com>
7 years agolightnvm: fix type coercion
Keith Busch [Tue, 17 Jul 2018 21:56:25 +0000 (15:56 -0600)]
lightnvm: fix type coercion

The lightnvm passthrough command wasn't actually aligned to the ioctl's
structure because it had an extra dword, and some compilers were having a
hard time dealing with some of the other structure casting. This fixes
the passthrough structure by removing the erroneous dword, and uses
temporary void pointers for type casting.

Link: https://github.com/linux-nvme/nvme-cli/issues/386
Signed-off-by: Keith Busch <keith.busch@intel.com>
7 years agodon't execute a command if --dry-run is supplied
Tal Shorer [Fri, 13 Jul 2018 14:41:42 +0000 (17:41 +0300)]
don't execute a command if --dry-run is supplied

Previously, issuing a command with --dry-run but without
--show-command would actually execute the command

Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
7 years agoUse tnvmcap register for creating namespace
Narasimhan V [Thu, 12 Jul 2018 10:32:01 +0000 (16:02 +0530)]
Use tnvmcap register for creating namespace

Creating max ns by getting the total nvm capacity, and format.
Thus, the whole capacity is used in nvme_create_max_ns_test

Signed-off-by: Narasimhan V <sim@linux.vnet.ibm.com>
7 years agofix reservation report 0's based dword count
Keith Busch [Thu, 5 Jul 2018 14:59:09 +0000 (08:59 -0600)]
fix reservation report 0's based dword count

Some parts of treating this as a 0's based value as the spec requires,
and others were not. This patch fixes that.

Link: https://github.com/linux-nvme/nvme-cli/issues/385
Signed-off-by: Keith Busch <keith.busch@intel.com>
7 years agoMerge pull request #384 from bdeyal/master
Keith Busch [Thu, 5 Jul 2018 14:42:18 +0000 (08:42 -0600)]
Merge pull request #384 from bdeyal/master

nvme.c, list_ns: use le32_to_cpu in display

7 years agonvme.c, list_ns: use le32_to_cpu in display
Eyal Ben David [Wed, 4 Jul 2018 17:50:10 +0000 (20:50 +0300)]
nvme.c, list_ns: use le32_to_cpu in display

7 years agonvme-cli: adjust memset size for data buffer in submit_io
Minwoo Im [Tue, 3 Jul 2018 13:18:59 +0000 (22:18 +0900)]
nvme-cli: adjust memset size for data buffer in submit_io

Adjust size of memset() for the data buffer to its own size.

Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
7 years agofabrics: omit newline character when reading nvme host nqn
Sagi Grimberg [Tue, 3 Jul 2018 12:09:25 +0000 (15:09 +0300)]
fabrics: omit newline character when reading nvme host nqn

This breaks the command string.

Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
7 years agofabrics: fail early if argconfig_parse failed
Sagi Grimberg [Tue, 3 Jul 2018 12:09:24 +0000 (15:09 +0300)]
fabrics: fail early if argconfig_parse failed

If user got params wrong or asked for --help,
we shouldn't try to execute the command.

Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
7 years agonvme-cli: print firmware activation notices support bit to id_ctrl
Minwoo Im [Sun, 1 Jul 2018 13:58:05 +0000 (22:58 +0900)]
nvme-cli: print firmware activation notices support bit to id_ctrl

It's now currently printing the OAES(Optional Asynchronous Events Supported)
field in identify controller data structure without [9] firmware activation
notices field in case of human-readable format.
Print it out by updating the reserved bit field.

Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
Signed-off-by: Keith Busch <keith.busch@intel.com>
7 years agoMerge pull request #381 from bdeyal/master
Keith Busch [Fri, 29 Jun 2018 20:05:57 +0000 (14:05 -0600)]
Merge pull request #381 from bdeyal/master

Add a single get-property command for NVMeOF.

7 years agoMerge pull request #383 from tim-oleksii/master
Keith Busch [Thu, 28 Jun 2018 18:57:01 +0000 (12:57 -0600)]
Merge pull request #383 from tim-oleksii/master

nvme-cli: add support of RAE

7 years agonvme-cli: add support of RAE
Alexey Timofeyev [Thu, 28 Jun 2018 17:33:05 +0000 (17:33 +0000)]
nvme-cli: add support of RAE

Currently telemetry-log cannot retain content of corresponding log page as RAE is not set.
This patch adds RAE bit support into routines to retrieve log pages.

Signed-off-by: Alexey Timofeyev <alexey.timofeyev@sk.com>
7 years agoAdd a single get-property command for NVMeOF.
Eyal Ben David [Wed, 27 Jun 2018 20:03:55 +0000 (23:03 +0300)]
Add a single get-property command for NVMeOF.

7 years agoMerge pull request #380 from bdeyal/master
Keith Busch [Wed, 27 Jun 2018 18:48:01 +0000 (12:48 -0600)]
Merge pull request #380 from bdeyal/master

nvme-ioctl.c : nvme_get_properties(): fix 64bit offset advance

7 years agonvme-ioctl.c : nvme_get_properties(): fix 64bit offset advance
Eyal Ben David [Wed, 27 Jun 2018 18:31:05 +0000 (21:31 +0300)]
nvme-ioctl.c : nvme_get_properties(): fix 64bit offset advance

7 years agoMerge pull request #379 from birkelund/dlfeat
Keith Busch [Wed, 27 Jun 2018 14:04:45 +0000 (08:04 -0600)]
Merge pull request #379 from birkelund/dlfeat

nvme-cli: add support for DLFEAT

7 years agonvme-cli: add support for DLFEAT
Klaus Birkelund Abildgaard Jensen [Wed, 27 Jun 2018 11:47:40 +0000 (13:47 +0200)]
nvme-cli: add support for DLFEAT

This adds support for the NVMe revision 1.3 Deallocate Logical Block
Features (DLFEAT) field in the Identify Namespace data structure.

Signed-off-by: Klaus Birkelund Abildgaard Jensen <klaus.jensen@cnexlabs.com>
7 years agointel: fix latency stats printing
Keith Busch [Tue, 26 Jun 2018 17:29:17 +0000 (11:29 -0600)]
intel: fix latency stats printing

Incorrectly using the same bucket for all three print routines.

Link: https://github.com/linux-nvme/nvme-cli/issues/378
Signed-off-by: Keith Busch <keith.busch@intel.com>
7 years agoUpdate doc
Keith Busch [Mon, 25 Jun 2018 15:52:45 +0000 (09:52 -0600)]
Update doc

Signed-off-by: Keith Busch <keith.busch@intel.com>
7 years agonvme-cli: add changed-ns-list-log documentation
Chaitanya Kulkarni [Mon, 11 Jun 2018 02:05:08 +0000 (22:05 -0400)]
nvme-cli: add changed-ns-list-log documentation

Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: Keith Busch <keith.busch@intel.com>
7 years agonvme-cli: add changed log ns support
Chaitanya Kulkarni [Mon, 11 Jun 2018 02:05:07 +0000 (22:05 -0400)]
nvme-cli: add changed log ns support

Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: Keith Busch <keith.busch@intel.com>
7 years agoNVMe-CLI Fix id-ns fpi field when Human Readable option selected.
Jeff Lien [Thu, 21 Jun 2018 18:58:17 +0000 (13:58 -0500)]
NVMe-CLI Fix id-ns fpi field when Human Readable option selected.

Currently when fpi = 0, the Format Progress Indicator Remaining is
100% and should be 0%.  This patch fixes that condition.

Signed-off-by: Jeff Lien <jeff.lien@wdc.com>
Signed-off-by: Keith Busch <keith.busch@intel.com>
7 years agoFix format specifier for 32-bit
Keith Busch [Thu, 21 Jun 2018 14:46:27 +0000 (08:46 -0600)]
Fix format specifier for 32-bit

Link: https://github.com/linux-nvme/nvme-cli/issues/377
Signed-off-by: Keith Busch <keith.busch@intel.com>
7 years agoFix json output of 128-bit numbers
Keith Busch [Fri, 15 Jun 2018 19:28:11 +0000 (13:28 -0600)]
Fix json output of 128-bit numbers

We use the long float for only very large integers. We don't want to
see the decimal, and the locale settings could cause different output,
so let's remove it.

Link: https://github.com/linux-nvme/nvme-cli/issues/354
Signed-off-by: Keith Busch <keith.busch@intel.com>
7 years agoMerge branch 'master' of https://github.com/linux-nvme/nvme-cli
Keith Busch [Fri, 15 Jun 2018 19:15:49 +0000 (13:15 -0600)]
Merge branch 'master' of https://github.com/linux-nvme/nvme-cli

7 years agoReplace host-gen telemetry short-option 'h' with 'g'
Keith Busch [Fri, 15 Jun 2018 19:15:05 +0000 (13:15 -0600)]
Replace host-gen telemetry short-option 'h' with 'g'

The 'h' is reserved as the short option for "help".

Signed-off-by: Keith Busch <keith.busch@intel.com>
7 years agoAdd man pages for new device self test commands
Keith Busch [Fri, 15 Jun 2018 19:12:58 +0000 (13:12 -0600)]
Add man pages for new device self test commands

For initiating the test and retrieving the self test logs.

Signed-off-by: Keith Busch <keith.busch@intel.com>
7 years agoMerge pull request #375 from Seagate/master
Keith Busch [Fri, 15 Jun 2018 13:52:57 +0000 (07:52 -0600)]
Merge pull request #375 from Seagate/master

Updating Seagate plug-in to 1.1

7 years agoFinish Seagate_v1.1
521852 [Fri, 15 Jun 2018 04:08:16 +0000 (09:38 +0530)]
Finish Seagate_v1.1

7 years agoUpdating version to 1.1
521852 [Fri, 15 Jun 2018 04:07:52 +0000 (09:37 +0530)]
Updating version to 1.1

7 years agoMerge remote-tracking branch 'github-upstream_nvme-cli/master'
521852 [Fri, 15 Jun 2018 04:01:49 +0000 (09:31 +0530)]
Merge remote-tracking branch 'github-upstream_nvme-cli/master'

7 years agonvme-cli: Implement printing get NOPSC feature
Revanth Rajashekar [Wed, 13 Jun 2018 21:21:43 +0000 (15:21 -0600)]
nvme-cli: Implement printing get NOPSC feature

Signed-off-by: Revanth Rajashekar <revanth.rajashekar@intel.com>
Signed-off-by: Keith Busch <keith.busch@intel.com>
7 years agonvme-cli: Implement printing the get Keep Alive Timer feature
Revanth Rajashekar [Wed, 13 Jun 2018 20:39:29 +0000 (14:39 -0600)]
nvme-cli: Implement printing the get Keep Alive Timer feature

Signed-off-by: Revanth Rajashekar <revanth.rajashekar@intel.com>
Signed-off-by: Keith Busch <keith.busch@intel.com>
7 years agonvme-cli: Implement printing the get host controlled thermal management feature.
Revanth Rajashekar [Wed, 13 Jun 2018 20:15:31 +0000 (14:15 -0600)]
nvme-cli: Implement printing the get host controlled thermal management feature.

Signed-off-by: Revanth Rajashekar <revanth.rajashekar@intel.com>
Signed-off-by: Keith Busch <keith.busch@intel.com>
7 years agonvme-cli: Implement printing the get timestamp feature.
Revanth Rajashekar [Wed, 13 Jun 2018 19:53:52 +0000 (13:53 -0600)]
nvme-cli: Implement printing the get timestamp feature.

Signed-off-by: Revanth Rajashekar <revanth.rajashekar@intel.com>
Signed-off-by: Keith Busch <keith.busch@intel.com>
7 years agoAdding ppc big endian support
521852 [Thu, 14 Jun 2018 15:25:06 +0000 (20:55 +0530)]
Adding ppc big endian support

7 years agoMerge remote-tracking branch 'upstream/master'
muhammad.ahmad@seagate.com [Wed, 13 Jun 2018 14:49:30 +0000 (09:49 -0500)]
Merge remote-tracking branch 'upstream/master'

7 years agoRevert "nvme-cli: Wait for device file if not present after successful add_ctrl"
Keith Busch [Wed, 13 Jun 2018 13:33:03 +0000 (07:33 -0600)]
Revert "nvme-cli: Wait for device file if not present after successful add_ctrl"

This reverts commit bb2d87d7f386882005bb87fe9412af23c646c876.

Not ready for this one yet either.

7 years agoRevert "nvme-cli: Add ioctl retry support for "connect-all""
Keith Busch [Wed, 13 Jun 2018 13:31:38 +0000 (07:31 -0600)]
Revert "nvme-cli: Add ioctl retry support for "connect-all""

This reverts commit d8f949c21e9d832149518f26c71dfd8de16cd628.

The kernel side was not ready, so this needs more sorting.

Signed-off-by: Keith Busch <keith.busch@intel.com>
7 years agonvme-cli: fix compilation error
Chaitanya Kulkarni [Mon, 11 Jun 2018 17:04:29 +0000 (13:04 -0400)]
nvme-cli: fix compilation error

Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: Keith Busch <keith.busch@intel.com>
7 years agoMaking gcc compiler (5.4.0 among others) happy
muhammad.ahmad@seagate.com [Mon, 11 Jun 2018 18:06:47 +0000 (13:06 -0500)]
Making gcc compiler (5.4.0 among others) happy

7 years agoMerge pull request #342 from minwooim/v1.6/for_tp4018
Keith Busch [Mon, 11 Jun 2018 15:19:08 +0000 (09:19 -0600)]
Merge pull request #342 from minwooim/v1.6/for_tp4018

nvme-cli: add support for id-nvmset subcmmand

7 years agoMerge pull request #366 from Seagate/master
Keith Busch [Mon, 11 Jun 2018 15:00:28 +0000 (09:00 -0600)]
Merge pull request #366 from Seagate/master

Request to add Seagate Plugin

7 years agoFinish seagate-plugin-v1.0
Muhammad Ahmad [Sun, 10 Jun 2018 21:17:17 +0000 (16:17 -0500)]
Finish seagate-plugin-v1.0

7 years agoUpdatign the plugin version
Muhammad Ahmad [Sun, 10 Jun 2018 21:16:51 +0000 (16:16 -0500)]
Updatign the plugin version

7 years agoMerge remote-tracking branch 'origin/master'
Muhammad Ahmad [Sun, 10 Jun 2018 21:03:39 +0000 (16:03 -0500)]
Merge remote-tracking branch 'origin/master'

# Conflicts:
# Makefile

7 years agorefactored some strings
muhammad.ahmad@seagate.com [Sat, 9 Jun 2018 16:03:44 +0000 (11:03 -0500)]
refactored some strings

7 years agoRemoved Duplicate commands.
muhammad.ahmad@seagate.com [Thu, 7 Jun 2018 22:06:27 +0000 (17:06 -0500)]
Removed Duplicate commands.

7 years agoInitial checkin for Seagate Plugin
muhammad.ahmad@seagate.com [Wed, 23 May 2018 04:51:06 +0000 (23:51 -0500)]
Initial checkin for Seagate Plugin

7 years agonvme-cli: update the document for id-nvmset subcommand
Minwoo Im [Sun, 10 Jun 2018 12:07:10 +0000 (21:07 +0900)]
nvme-cli: update the document for id-nvmset subcommand

Update the document for the usage of id-nvmset subcommand.

Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
7 years agonvme-cli: update new fields in id-ns subcommand
Minwoo Im [Sun, 10 Jun 2018 12:03:54 +0000 (21:03 +0900)]
nvme-cli: update new fields in id-ns subcommand

Update new fields in Identify Namespace data structure: nvmsetid,
endgid.  These fields are added in TP 4018.

Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
7 years agonvme-cli: add support for id-nvmset subcommand
Minwoo Im [Sun, 15 Apr 2018 17:34:41 +0000 (02:34 +0900)]
nvme-cli: add support for id-nvmset subcommand

Identify for NVM Set List has been added and it can be found in TP 4018.
This identify CNS 0x4 uses CDW11 as a NVM Set Identify(NVMSETID).
Currently nvme-cli is not using cdw11 for the identify command.

Therefore make it available for cdw11 to be passed to ioctl command by
adding nvme_identify13() to support the new CNS.

Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
7 years agorefactored some strings
muhammad.ahmad@seagate.com [Sat, 9 Jun 2018 16:03:44 +0000 (11:03 -0500)]
refactored some strings

7 years agoMerge pull request #365 from maximveligan/master
Keith Busch [Fri, 8 Jun 2018 22:19:27 +0000 (16:19 -0600)]
Merge pull request #365 from maximveligan/master

Wrote man page for telemetry

7 years agoWrote man page for telemetry
Maxim [Fri, 8 Jun 2018 22:14:49 +0000 (15:14 -0700)]
Wrote man page for telemetry

7 years agonvme-cli: Implemented Device self test and log.
Revanth Rajashekar [Tue, 5 Jun 2018 20:32:51 +0000 (14:32 -0600)]
nvme-cli: Implemented Device self test and log.

Implmented device self test and log gathering described in the NVMe
1.3 specificiation.

Link: https://github.com/linux-nvme/nvme-cli/pull/364
Signed-off-by: Revanth Rajashekar <revanth.rajashekar@intel.com>
[changelog, code and print formatting]
Signed-off-by: Keith Busch <keith.busch@intel.com>
7 years agoAdd user parameter to specify data area region from telemetry log
Maxim [Thu, 7 Jun 2018 18:06:04 +0000 (11:06 -0700)]
Add user parameter to specify data area region from telemetry log

And read in block size chunks instead of 4k.

Link: https://github.com/linux-nvme/nvme-cli/pull/361
Signed-off-by: Maxim Veligan <maximveligan@gmail.com>
[changelog, formatting, set error on exit, removed unnecessary error check]
Signed-off-by: Keith Busch <keith.busch@intel.com>
7 years agoRemoved Duplicate commands.
muhammad.ahmad@seagate.com [Thu, 7 Jun 2018 22:06:27 +0000 (17:06 -0500)]
Removed Duplicate commands.

7 years agoMerge pull request #359 from JasonChiuCC/master
Keith Busch [Tue, 5 Jun 2018 15:07:30 +0000 (09:07 -0600)]
Merge pull request #359 from JasonChiuCC/master

 nvme-cli: Add Get Feature Command

7 years agoRegenerate man pages
Keith Busch [Tue, 5 Jun 2018 15:02:15 +0000 (09:02 -0600)]
Regenerate man pages

Signed-off-by: Keith Busch <keith.busch@intel.com>
7 years agoDocumentation: allow to format with asciidoctor
Takashi Iwai [Thu, 12 Apr 2018 11:02:38 +0000 (04:02 -0700)]
Documentation: allow to format with asciidoctor

Add asciidoctor support.  You need to pass USE_ASCIIDOCTOR=yes to make
for enabling the feature.

Most of the rb extension code was shamelessly borrowed from git.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Keith Busch <keith.busch@intel.com>
7 years agoDocumentation: fix title markers
Takashi Iwai [Thu, 12 Apr 2018 11:02:37 +0000 (04:02 -0700)]
Documentation: fix title markers

The length of the title marker has to be aligned with the previous
line.  This was caught when running asciidoctor, which is more strict
than asciidoc.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Keith Busch <keith.busch@intel.com>
7 years agofabrics: add ctrl-loss-tmo to connect-all
Johannes Thumshirn [Tue, 29 May 2018 09:32:33 +0000 (11:32 +0200)]
fabrics: add ctrl-loss-tmo to connect-all

Similarly to "keep-alive-tmo" a user might want to specify the
"ctrl-loss-tmo" on connect-all as well.

Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Keith Busch <keith.busch@intel.com>
7 years agonvme-cli: Modify Get Features-Asynchronous Event Configuration
JasonChiuCC [Tue, 29 May 2018 07:27:15 +0000 (15:27 +0800)]
nvme-cli: Modify Get Features-Asynchronous Event Configuration

Modify Get Features-Asynchronous Event Configuration that can get Telemetry Log Notices info

7 years agoMerge pull request #341 from minwooim/v1.6/fix_perror_in_get_ns_id
Keith Busch [Fri, 25 May 2018 15:56:04 +0000 (09:56 -0600)]
Merge pull request #341 from minwooim/v1.6/fix_perror_in_get_ns_id

nvme-cli: fix perror when blkdev not given when get-ns-id

7 years agoMerge pull request #353 from StephenATubbs/master
Keith Busch [Fri, 25 May 2018 15:55:30 +0000 (09:55 -0600)]
Merge pull request #353 from StephenATubbs/master

Add support for Micron plugin

7 years agoMerge pull request #357 from MatiasBjorling/for-keith
Keith Busch [Fri, 25 May 2018 15:55:13 +0000 (09:55 -0600)]
Merge pull request #357 from MatiasBjorling/for-keith

Add open-channel 2.0 identify geometry support

7 years agoMerge pull request #356 from JasonChiuCC/master
Keith Busch [Fri, 25 May 2018 15:54:51 +0000 (09:54 -0600)]
Merge pull request #356 from JasonChiuCC/master

nvme-cli: fix show command typo

7 years agoAdd open-channel 2.0 identify support
Matias Bjørling [Fri, 25 May 2018 07:04:34 +0000 (09:04 +0200)]
Add open-channel 2.0 identify support

The 2.0 specification has been released. Update the lightnvm
submodule to understand the 2.0 geometry structure.

Signed-off-by: Matias Bjørling <mb@lightnvm.io>
7 years agonvme-cli: fix show command typo
JasonChiuCC [Fri, 25 May 2018 02:04:33 +0000 (10:04 +0800)]
nvme-cli: fix show command typo

7 years agoMerge pull request #355 from tim-oleksii/master
Keith Busch [Wed, 23 May 2018 14:13:22 +0000 (08:13 -0600)]
Merge pull request #355 from tim-oleksii/master

nvme-cli: Fix build breaks for GCC 8.1