Artem Bityutskiy [Fri, 29 Nov 2013 16:49:19 +0000 (18:49 +0200)]
email-lda: start parsing the configuration file
This is a preparation for the further changes where we teach the email-lda
script sending notifications when it rejects a patch. We'll need to know some
basic information like own e-mail address, and this is stored in the config
file. So parse it.
Artem Bityutskiy [Fri, 29 Nov 2013 16:43:28 +0000 (18:43 +0200)]
email-sh-functions: rework e-mail sending some more
Leave only the email composition stuff in the common code, and move the e-mail
sending stuff to email-test-patchset. This way the common code does not depend
on the "verbose" and "test_mode" variables anymore, which is a bit cleaner.
Artem Bityutskiy [Fri, 29 Nov 2013 14:46:17 +0000 (16:46 +0200)]
email-sh-functions: misc improvements
This is a huge patch and it should really be split. But I am being lazy and
committing all at once. Yes, this is bad, sorry, but I am trying to save time.
Anyway, this patch does 2 big changes:
1. Improves the strip_address function so that it does not anymore depend on
any global 'cfg_*' variables and gets the e-mail address to strip as a
parameter.
2. Simplifies the 'compose_email' function interface and teach it to get a
single list of addresses to CC. This required some an additional function
for merging 2 lists of e-mails. But the end result is that
email-test-patchset becomes simpler.
Artem Bityutskiy [Thu, 28 Nov 2013 12:44:53 +0000 (14:44 +0200)]
email-sh-function: new file for shared e-mail code
Let's have a separate file for the shared code which is only relevant to
e-mail handling. For now we only have the subject parsing there, but we'll add
more stuff to this file later.
Commit '07837a6 email-test-patchset: add cppcheck support' introduced a
breakage by adding an unexisting variable named "commit", which causes the
following error:
aiaiai-email-test-patchset: line 334: commit: unbound variable
The variable should be named 'branch'. This patch fixes the problem.
Artem Bityutskiy [Wed, 27 Nov 2013 13:00:24 +0000 (15:00 +0200)]
sh-functions: rename __prfx to __blah
I am going to add support for [Prefix PATCH Suffix n/n] subject, so
the prefix word would be needed, and thus in this patch I use word
"blah" for the [blah] prefixes.
Artem Bityutskiy [Wed, 27 Nov 2013 12:46:22 +0000 (14:46 +0200)]
sh-function: rename __ws to __blanks
The internal __ws variable is a short-cut for "zero or reasonable amount of
white-space or tab characters". This patch renames it to "__blanks", which
is a bit more readable. Additionally I make the reasonable amount to be 8
blanks instead of 4.
Artem Bityutskiy [Wed, 27 Nov 2013 11:42:21 +0000 (13:42 +0200)]
sh-functions: refine the 'prefix_format' variable
First of all, the whole subject parsing thing belongs to the e-mail stuff, so
it really should be moved to the email sub-directory.
The 'prefix_format' is a variable which is supposed to explain in a short form
what is the format of the subject we expect. Currently we have a confusing
<project> part there, and this patch removes it. I do not think the result is
ideal, since it does not tell that the format is rather flexible, but still
it is a bit better. Later we can change this to something better.
Jacob Keller [Tue, 26 Nov 2013 22:35:06 +0000 (14:35 -0800)]
sh-functions: fix print_separator
print_separator needs to be run as a subshell, because we need its output, not
the string itself. This fixes a print display bug where we show
"print_separator" instead of the actual separator.
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Jacob Keller [Tue, 26 Nov 2013 20:02:17 +0000 (12:02 -0800)]
aiaiai: don't assume kernel tree will be checked out
This change addresses a possible issue if someone uses a bare repsitory
as their remote. We handle this by using a new sh-function git_dir()
which will return $path/.git if that is a directly, then path if that is
a directory, or will complain if it's not a valid directory. This
enables us to automatically use the correct directory without issue even
if the repository is bare.
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Artem Bityutskiy [Tue, 26 Nov 2013 17:03:33 +0000 (19:03 +0200)]
email: fix ini_config_get_or_die
Similarly to what we did in the previous patch, change ini_config_get_or_die
interface so that the caller would not have to call it in a subshell, which
makes dying impossible.
Artem Bityutskiy [Tue, 26 Nov 2013 16:52:44 +0000 (18:52 +0200)]
Fix fetch_header_or_die
The fetch_header_or_die function is suppoed to make the caller exit if the
header is not found. However, this did not happen, because the interface of
this function assumed that it is called in a subshell in order to intercept the
results. And the exiting happened in the subshell, which did not affect the
caller at all.
Fix this issue by changing the interface of fetch_header_or_die() so that the
result is written to the first parameter.
Jacob Keller [Mon, 25 Nov 2013 18:56:25 +0000 (10:56 -0800)]
sh-functions: show merge results when patch fails to apply
This patch enables the email notification an attempt at showing you the
result of a merge based on the patch utility. This might enable more
easily debugging why a patch failed to apply.
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Jacob Keller [Mon, 25 Nov 2013 18:56:15 +0000 (10:56 -0800)]
aiaiai: make formail allow non-strict mbox format
Sometimes patches are not properly emailed in strict mbox format. This
can result in some bogus issues, which are simply automatically resolved
by just working in non-strict mbox format. This patch makes sure all
executions of formail accept non-strict formats.
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Jacob Keller [Mon, 25 Nov 2013 18:56:02 +0000 (10:56 -0800)]
email-test-patchset: add cppcheck support
The aiaiai-email-test-patchset script did not have a cppcheck option,
even though the lower level aiaiai-test-patchset supports this. Add the
option along with the other check options.
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Jacob Keller [Mon, 25 Nov 2013 18:55:57 +0000 (10:55 -0800)]
email-test-patchset: allow a configuration directory
The aiaiai-test-patchset has a configuration directory option, but the
aiaiai-email-test-patchset does not have this option. Update the
email-test-patchset script to support passing this option onto the lower
level aiaiai-test-patchset script.
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Jacob Keller [Mon, 25 Nov 2013 18:55:52 +0000 (10:55 -0800)]
make-kernel: add parameter to enable endian checking
Endian checking is not turned on by default, and requires a separate
parameter in order to enable it. As it can be quite useful to have, this
patch adds the proper syntax to enable it when the kernel checker is
enabled.
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Jacob Keller [Mon, 25 Nov 2013 18:55:40 +0000 (10:55 -0800)]
sh-functions: rename fetch_all_headers
The fetch_all_headers name is not descriptive, as it actually splits the
mailbox up and processes the first header of each message. It does not
obtain every copy of a given header from the mbox. This patch renames
the function, and updates the comment so that it is clear what the
function does.
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Jacob Keller [Mon, 25 Nov 2013 18:55:35 +0000 (10:55 -0800)]
aiaiai: use --shared since we know we will be safe
We want to use a shared clone here, because it will prevent duplicate copies
of all the object data, and we know it will be ok, since we won't be mucking
with the tree, and the commits will be tagged.
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Jacob Keller [Mon, 25 Nov 2013 18:55:30 +0000 (10:55 -0800)]
make-kernel: fix --keep-going option
The make-kernel utility has an option "--keep-going" which can be useful
if you want to continue testing past kernel build failures, in order to try
and find as many issues as you can. However, it previously did not work,
as getopt-long format required a parameter, and the case statement did
not check for the correct long syntax.
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Phil Carmody [Tue, 11 Jun 2013 14:24:00 +0000 (17:24 +0300)]
test-patchset: use net diff, not sum of all diffs
We generated the end-start diff presumably for this reason.
Using the concatenation of all patches effectively gives us
the concatenation of all diagnostics, which we already have.
Signed-off-by: Phil Carmody <phil.carmody@partner.samsung.com> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
It does not work for anymore because we cannot find the correct architecture
(ARCH=) from the defconfigs.
For example, if a patch changes arch/x86/configs/i386_deconfig, the script
finds out that the architecture is 'x86', and then starts verifying the
patch using 'ARCH=x86', which actually translates to 'ARCH=x86_64', which
is incorrect and gives bogus results.
I do not know how to easily fix this and do not have time for a non-trivial
solution, so just removing this script. If later I need it, it is in the git
history.
Artem Bityutskiy [Fri, 5 Oct 2012 08:20:04 +0000 (11:20 +0300)]
Improve user-friendliness
Rafał Miłecki <zajec5@gmail.com> complained that aiaiai does not immediately
fail if there are missing tools. Add some more checks to aiaiai and add some
user-friendly messages.
Ed Bartosh [Thu, 26 Jul 2012 14:21:29 +0000 (17:21 +0300)]
rpm: improve packaging
- Added Requires: to spec
- Added install target to project's Makefile
- Added rpm/Makefile to integrate it with Jenkins testing job
- Removed unneeded files from rpm/
Artem Bityutskiy [Fri, 11 May 2012 10:12:15 +0000 (13:12 +0300)]
Add support for quick fixes
Unfortunately I have to carry various build fixes, hopefully temporarily,
and it is very handy to ask aiaiai apply certain quick fixes before running
the test.
Artem Bityutskiy [Thu, 10 May 2012 10:20:43 +0000 (13:20 +0300)]
make-kernel: introduce -D option
Add -D option to aiaiai-make-kernel which allows to specify the defconfig
which should be used for each target. This is a preparation for further
changes where we'll allow to use external defconfig files.
projects / users / dedekind / aiaiai.git / log