]> www.infradead.org Git - users/hch/xfsprogs.git/log
users/hch/xfsprogs.git
8 months agoman: document the rt group geometry ioctl
Darrick J. Wong [Tue, 15 Oct 2024 19:44:17 +0000 (12:44 -0700)]
man: document the rt group geometry ioctl

Document the new ioctl that retrieves realtime allocation group geometry
information.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs: implement busy extent tracking for rtgroups
Darrick J. Wong [Tue, 15 Oct 2024 19:44:16 +0000 (12:44 -0700)]
xfs: implement busy extent tracking for rtgroups

For rtgroups filesystems, track newly freed (rt) space through the log
until the rt EFIs have been committed to disk.  This way we ensure that
space cannot be reused until all traces of the old owner are gone.

As a fringe benefit, we now support -o discard on the realtime device.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: move the min and max group block numbers to xfs_group
Darrick J. Wong [Tue, 15 Oct 2024 19:39:24 +0000 (12:39 -0700)]
xfs: move the min and max group block numbers to xfs_group

Move the min and max agblock numbers to the generic xfs_group structure
so that we can start building validators for extents within an rtgroup.
While we're at it, use check_add_overflow for the extent length
computation because that has much better overflow checking.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: adjust min_block usage in xfs_verify_agbno
Darrick J. Wong [Tue, 15 Oct 2024 19:39:24 +0000 (12:39 -0700)]
xfs: adjust min_block usage in xfs_verify_agbno

There's some weird logic in xfs_verify_agbno -- min_block ought to be
the first agblock number in the AG that can be used by non-static
metadata.  However, we initialize it to the last agblock of the static
metadata, which works due to the <= check, even though this isn't
technically correct.

Change the check to < and set min_block to the next agblock past the
static metadata.  This hasn't been an issue up to now, but we're going
to move these things into the generic group struct, and this will cause
problems with rtgroups, where min_block can be zero for an rtgroup that
doesn't have a rt superblock.

Note that there's no user-visible impact with the old logic, so this
isn't a bug fix.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: make xfs_rtblock_t a segmented address like xfs_fsblock_t
Darrick J. Wong [Tue, 15 Oct 2024 23:44:17 +0000 (16:44 -0700)]
xfs: make xfs_rtblock_t a segmented address like xfs_fsblock_t

Now that we've finished adding allocation groups to the realtime volume,
let's make the file block mapping address (xfs_rtblock_t) a segmented
value just like we do on the data device.  This means that group number
and block number conversions can be done with shifting and masking
instead of integer division.

While in theory we could continue caching the rgno shift value in
m_rgblklog, the fact that we now always use the shift value means that
we have an opportunity to increase the redundancy of the rt geometry by
storing it in the ondisk superblock and adding more sb verifier code.
Extend the sueprblock to store the rgblklog value.

Now that we have segmented addresses, set the correct values in
m_groups[XG_TYPE_RTG] so that the xfs_group helpers work correctly.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: create helpers to deal with rounding xfs_filblks_t to rtx boundaries
Darrick J. Wong [Tue, 15 Oct 2024 19:44:14 +0000 (12:44 -0700)]
xfs: create helpers to deal with rounding xfs_filblks_t to rtx boundaries

We're about to segment xfs_rtblock_t addresses, so we must create
type-specific helpers to do rt extent rounding of file mapping block
lengths because the rtb helpers soon will not do the right thing there.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: create helpers to deal with rounding xfs_fileoff_t to rtx boundaries
Darrick J. Wong [Tue, 15 Oct 2024 19:44:14 +0000 (12:44 -0700)]
xfs: create helpers to deal with rounding xfs_fileoff_t to rtx boundaries

We're about to segment xfs_rtblock_t addresses, so we must create
type-specific helpers to do rt extent rounding of file block offsets
because the rtb helpers soon will not do the right thing there.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: mask off the rtbitmap and summary inodes when metadir in use
Darrick J. Wong [Tue, 15 Oct 2024 19:39:19 +0000 (12:39 -0700)]
xfs: mask off the rtbitmap and summary inodes when metadir in use

Set the rtbitmap and summary file inumbers to NULLFSINO in the
superblock and make sure they're zeroed whenever we write the superblock
to disk, to mimic mkfs behavior.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: scrub metadir paths for rtgroup metadata
Darrick J. Wong [Tue, 15 Oct 2024 19:44:13 +0000 (12:44 -0700)]
xfs: scrub metadir paths for rtgroup metadata

Add the code we need to scan the metadata directory paths of rt group
metadata files.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: scrub the realtime group superblock
Darrick J. Wong [Tue, 15 Oct 2024 19:44:13 +0000 (12:44 -0700)]
xfs: scrub the realtime group superblock

Enable scrubbing of realtime group superblocks.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: make the RT allocator rtgroup aware
Christoph Hellwig [Tue, 15 Oct 2024 19:44:13 +0000 (12:44 -0700)]
xfs: make the RT allocator rtgroup aware

Make the allocator rtgroup aware by either picking a specific group if
there is a hint, or loop over all groups otherwise.  A simple rotor is
provided to pick the placement for initial allocations.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs: use realtime EFI to free extents when rtgroups are enabled
Darrick J. Wong [Tue, 15 Oct 2024 19:44:13 +0000 (12:44 -0700)]
xfs: use realtime EFI to free extents when rtgroups are enabled

When rmap is enabled, XFS expects a certain order of operations, which
is: 1) remove the file mapping, 2) remove the reverse mapping, and then
3) free the blocks.  When reflink is enabled, XFS replaces (3) with a
deferred refcount decrement operation that can schedule freeing the
blocks if that was the last refcount.

For realtime files, xfs_bmap_del_extent_real tries to do 1 and 3 in the
same transaction, which will break both rmap and reflink unless we
switch it to use realtime EFIs.  Both rmap and reflink depend on the
rtgroups feature, so let's turn on EFIs for all rtgroups filesystems.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: support error injection when freeing rt extents
Darrick J. Wong [Tue, 15 Oct 2024 19:44:12 +0000 (12:44 -0700)]
xfs: support error injection when freeing rt extents

A handful of fstests expect to be able to test what happens when extent
free intents fail to actually free the extent.  Now that we're
supporting EFIs for realtime extents, add to xfs_rtfree_extent the same
injection point that exists in the regular extent freeing code.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: support logging EFIs for realtime extents
Darrick J. Wong [Tue, 15 Oct 2024 19:44:12 +0000 (12:44 -0700)]
xfs: support logging EFIs for realtime extents

Teach the EFI mechanism how to free realtime extents.  We're going to
need this to enforce proper ordering of operations when we enable
realtime rmap.

Declare a new log intent item type (XFS_LI_EFI_RT) and a separate defer
ops for rt extents.  This keeps the ondisk artifacts and processing code
completely separate between the rt and non-rt cases.  Hopefully this
will make it easier to debug filesystem problems.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: store rtgroup information with a bmap intent
Darrick J. Wong [Tue, 15 Oct 2024 19:39:11 +0000 (12:39 -0700)]
xfs: store rtgroup information with a bmap intent

Make the bmap intent items take an active reference to the rtgroup
containing the space that is being mapped or unmapped.  We will need
this functionality once we start enabling rmap and reflink on the rt
volume.  Technically speaking we need it even for !rtgroups filesystems
to prevent the (dummy) rtgroup 0 from going away, even though this will
never happen.

As a bonus, we can rework the xfs_bmap_deferred_class tracepoint to use
the xfs_group object to figure out the type and group number, widen the
group block number field to fit 64-bit quantities, and get rid of the
now redundant opdev and rtblock fields.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: grow the realtime section when realtime groups are enabled
Darrick J. Wong [Tue, 15 Oct 2024 19:44:12 +0000 (12:44 -0700)]
xfs: grow the realtime section when realtime groups are enabled

Enable growing the rt section when realtime groups are enabled.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: encode the rtsummary in big endian format
Darrick J. Wong [Tue, 15 Oct 2024 19:44:12 +0000 (12:44 -0700)]
xfs: encode the rtsummary in big endian format

Currently, the ondisk realtime summary file counters are accessed in
units of 32-bit words.  There's no endian translation of the contents of
this file, which means that the Bad Things Happen(tm) if you go from
(say) x86 to powerpc.  Since we have a new feature flag, let's take the
opportunity to enforce an endianness on the file.  Encode the summary
information in big endian format, like most of the rest of the
filesystem.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: encode the rtbitmap in big endian format
Darrick J. Wong [Tue, 15 Oct 2024 19:44:11 +0000 (12:44 -0700)]
xfs: encode the rtbitmap in big endian format

Currently, the ondisk realtime bitmap file is accessed in units of
32-bit words.  There's no endian translation of the contents of this
file, which means that the Bad Things Happen(tm) if you go from (say)
x86 to powerpc.  Since we have a new feature flag, let's take the
opportunity to enforce an endianness on the file.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: add block headers to realtime bitmap and summary blocks
Darrick J. Wong [Tue, 15 Oct 2024 19:39:07 +0000 (12:39 -0700)]
xfs: add block headers to realtime bitmap and summary blocks

Upgrade rtbitmap and rtsummary blocks to have self describing metadata
like most every other thing in XFS.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: export the geometry of realtime groups to userspace
Darrick J. Wong [Tue, 15 Oct 2024 19:39:07 +0000 (12:39 -0700)]
xfs: export the geometry of realtime groups to userspace

Create an ioctl so that the kernel can report the status of realtime
groups to userspace.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: record rt group metadata errors in the health system
Darrick J. Wong [Tue, 15 Oct 2024 19:39:06 +0000 (12:39 -0700)]
xfs: record rt group metadata errors in the health system

Record the state of per-rtgroup metadata sickness in the rtgroup
structure for later reporting.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: add frextents to the lazysbcounters when rtgroups enabled
Darrick J. Wong [Tue, 15 Oct 2024 19:44:11 +0000 (12:44 -0700)]
xfs: add frextents to the lazysbcounters when rtgroups enabled

Make the free rt extent count a part of the lazy sb counters when the
realtime groups feature is enabled.  This is possible because the patch
to recompute frextents from the rtbitmap during log recovery predates
the code adding rtgroup support, hence we know that the value will
always be correct during runtime.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: add a helper to prevent bmap merges across rtgroup boundaries
Christoph Hellwig [Tue, 15 Oct 2024 19:44:10 +0000 (12:44 -0700)]
xfs: add a helper to prevent bmap merges across rtgroup boundaries

Source kernel commit: a3ae21f825b8790c5cf231e366309dbec3677ddf

Except for the rt superblock, realtime groups do not store any metadata
at the start (or end) of the group.  There is nothing to prevent the
bmap code from merging allocations from multiple groups into a single
bmap record.  Add a helper to check for this case.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
[djwong: massage the commit message after pulling this into rtgroups]
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs: check that rtblock extents do not break rtsupers or rtgroups
Darrick J. Wong [Tue, 15 Oct 2024 19:44:10 +0000 (12:44 -0700)]
xfs: check that rtblock extents do not break rtsupers or rtgroups

Check that rt block pointers do not point to the realtime superblock and
that allocated rt space extents do not cross rtgroup boundaries.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: export realtime group geometry via XFS_FSOP_GEOM
Darrick J. Wong [Tue, 15 Oct 2024 19:44:10 +0000 (12:44 -0700)]
xfs: export realtime group geometry via XFS_FSOP_GEOM

Export the realtime geometry information so that userspace can query it.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: update realtime super every time we update the primary fs super
Darrick J. Wong [Tue, 15 Oct 2024 19:44:10 +0000 (12:44 -0700)]
xfs: update realtime super every time we update the primary fs super

Every time we update parts of the primary filesystem superblock that are
echoed in the rt superblock, we must update the rt super.  Avoid
changing the log to support logging to the rt device by using ordered
buffers.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: define the format of rt groups
Darrick J. Wong [Tue, 15 Oct 2024 19:39:00 +0000 (12:39 -0700)]
xfs: define the format of rt groups

Define the ondisk format of realtime group metadata, and a superblock
for realtime volumes.  rt supers are conditionally enabled by a
predicate function so that they can be disabled if we ever implement
zoned storage support for the realtime volume.

For rt group enabled file systems there is a separate bitmap and summary
file for each group and thus the number of bitmap and summary blocks
needs to be calculated differently.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs_repair: remove calls to xfs_rtb_round{up,down}_rtx
Darrick J. Wong [Tue, 15 Oct 2024 19:44:09 +0000 (12:44 -0700)]
xfs_repair: remove calls to xfs_rtb_round{up,down}_rtx

The kernel will remove xfs_rtb_roundup_rtx soon, so open code the single
caller using the mod value that we already computed.

The kernel will remove xfs_rtb_rounddown_rtx soon, so remove the call
because the xfs_rtb_to_rtx call below it already does the rounding for
us.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agolibfrog: add memchr_inv
Darrick J. Wong [Tue, 15 Oct 2024 19:44:09 +0000 (12:44 -0700)]
libfrog: add memchr_inv

Add this kernel function so we can use it in userspace.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
[hch: split from a larger patch]
Signed-off-by: Christoph Hellwig <hch@lst.de>
8 months agolibxfs: use correct rtx count to block count conversion
Darrick J. Wong [Tue, 15 Oct 2024 19:44:09 +0000 (12:44 -0700)]
libxfs: use correct rtx count to block count conversion

Fix a place where we use the wrong conversion functions to convert
between a number of rt extents and a number of rt blocks.  This isn't
really necessary since userspace cannot allocate rt extents, but let's
not leave a logic bomb.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_repair,mkfs: port to libxfs_rt{bitmap,summary}_create
Darrick J. Wong [Tue, 15 Oct 2024 19:44:09 +0000 (12:44 -0700)]
xfs_repair,mkfs: port to libxfs_rt{bitmap,summary}_create

Replace the open-coded rtbitmap and summary creation routines with the
ones in libxfs so that we share code.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs: make RT extent numbers relative to the rtgroup
Christoph Hellwig [Tue, 15 Oct 2024 19:44:08 +0000 (12:44 -0700)]
xfs: make RT extent numbers relative to the rtgroup

To prepare for adding per-rtgroup bitmap files, make the xfs_rtxnum_t
type encode the RT extent number relative to the rtgroup.  The biggest
part of this to clearly distinguish between the relative extent number
that gets masked when converting from a global block number and length
values that just have a factor applied to them when converting from
file system blocks.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs: refactor xfs_rtsummary_blockcount
Christoph Hellwig [Tue, 15 Oct 2024 19:44:08 +0000 (12:44 -0700)]
xfs: refactor xfs_rtsummary_blockcount

Make xfs_rtsummary_blockcount take all the required information from
the mount structure and return the number of summary levels from it
as well.  This cleans up many of the callers and prepares for making the
rtsummary files per-rtgroup where they need to look at different value.

This means we recalculate some values in some callers, but as all these
calculations are outside the fast path and cheap, which seems like a
price worth paying.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs: refactor xfs_rtbitmap_blockcount
Christoph Hellwig [Tue, 15 Oct 2024 19:44:08 +0000 (12:44 -0700)]
xfs: refactor xfs_rtbitmap_blockcount

Rename the existing xfs_rtbitmap_blockcount to
xfs_rtbitmap_blockcount_len and add a new xfs_rtbitmap_blockcount wrapper
around it that takes the number of extents from the mount structure.

This will simplify the move to per-rtgroup bitmaps as those will need to
pass in the number of extents per rtgroup instead.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs: remove XFS_ILOCK_RT*
Darrick J. Wong [Tue, 15 Oct 2024 19:44:08 +0000 (12:44 -0700)]
xfs: remove XFS_ILOCK_RT*

Now that we've centralized the realtime metadata locking routines, get
rid of the ILOCK subclasses since we now use explicit lockdep classes.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: support creating per-RTG files in growfs
Christoph Hellwig [Tue, 15 Oct 2024 19:38:51 +0000 (12:38 -0700)]
xfs: support creating per-RTG files in growfs

To support adding new RT groups in growfs, we need to be able to create
the per-RT group files.  Add a new xfs_rtginode_create helper to create
a given per-RTG file.  Most of the code for that is shared, but the
details of the actual file are abstracted out using a new create method
in struct xfs_rtginode_ops.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs: move RT bitmap and summary information to the rtgroup
Christoph Hellwig [Tue, 15 Oct 2024 19:44:07 +0000 (12:44 -0700)]
xfs: move RT bitmap and summary information to the rtgroup

Move the pointers to the RT bitmap and summary inodes as well as the
summary cache to the rtgroups structure to prepare for having a
separate bitmap and summary inodes for each rtgroup.

Code using the inodes now needs to operate on a rtgroup.  Where easily
possible such code is converted to iterate over all rtgroups, else
rtgroup 0 (the only one that can currently exist) is hardcoded.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs: add a xfs_bmap_free_rtblocks helper
Christoph Hellwig [Tue, 15 Oct 2024 19:44:07 +0000 (12:44 -0700)]
xfs: add a xfs_bmap_free_rtblocks helper

Split the RT extent freeing logic from xfs_bmap_del_extent_real because
it will become more complicated when adding RT group.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs: support caching rtgroup metadata inodes
Darrick J. Wong [Tue, 15 Oct 2024 19:44:07 +0000 (12:44 -0700)]
xfs: support caching rtgroup metadata inodes

Create the necessary per-rtgroup infrastructure that we need to load
metadata inodes into memory.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: add a lockdep class key for rtgroup inodes
Darrick J. Wong [Tue, 15 Oct 2024 19:44:07 +0000 (12:44 -0700)]
xfs: add a lockdep class key for rtgroup inodes

Add a dynamic lockdep class key for rtgroup inodes.  This will enable
lockdep to deduce inconsistencies in the rtgroup metadata ILOCK locking
order.  Each class can have 8 subclasses, and for now we will only have
2 inodes per group.  This enables rtgroup order and inode order checks
when nesting ILOCKs.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: define locking primitives for realtime groups
Darrick J. Wong [Tue, 15 Oct 2024 19:38:43 +0000 (12:38 -0700)]
xfs: define locking primitives for realtime groups

Define helper functions to lock all metadata inodes related to a
realtime group.  There's not much to look at now, but this will become
important when we add per-rtgroup metadata files and online fsck code
for them.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: create incore realtime group structures
Darrick J. Wong [Tue, 15 Oct 2024 19:38:43 +0000 (12:38 -0700)]
xfs: create incore realtime group structures

Create an incore object that will contain information about a realtime
allocation group.  This will eventually enable us to shard the realtime
section in a similar manner to how we shard the data section, but for
now just a single object for the entire RT subvolume is created.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agomkfs: add a utility to generate protofiles
Darrick J. Wong [Tue, 15 Oct 2024 19:44:06 +0000 (12:44 -0700)]
mkfs: add a utility to generate protofiles

Add a new utility to generate mkfs protofiles from a directory tree.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agomkfs: support copying in xattrs
Darrick J. Wong [Tue, 15 Oct 2024 20:49:41 +0000 (13:49 -0700)]
mkfs: support copying in xattrs

Update the protofile code to import extended attributes from the source
files.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agomkfs: support copying in large or sparse files
Darrick J. Wong [Tue, 15 Oct 2024 20:49:41 +0000 (13:49 -0700)]
mkfs: support copying in large or sparse files

Restructure the protofile code to handle sparse files and files that are
larger than the program's address space.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agolibxfs: resync libxfs_alloc_file_space interface with the kernel
Darrick J. Wong [Tue, 15 Oct 2024 19:44:41 +0000 (12:44 -0700)]
libxfs: resync libxfs_alloc_file_space interface with the kernel

Make the userspace xfs_alloc_file_space behave (more or less) like the
kernel version, at least as far as the interface goes.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agomkfs.xfs: enable metadata directories
Darrick J. Wong [Tue, 15 Oct 2024 19:44:06 +0000 (12:44 -0700)]
mkfs.xfs: enable metadata directories

Enable formatting filesystems with metadata directories.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_repair: refactor generate_rtinfo
Christoph Hellwig [Tue, 15 Oct 2024 19:44:06 +0000 (12:44 -0700)]
xfs_repair: refactor generate_rtinfo

Move the allocation of the computed values into generate_rtinfo, and thus
make the variables holding them private in rt.c, and clean up a few
formatting nits.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
[djwong: move functions to fix build errors]
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_repair: fix maximum file offset comparison
Darrick J. Wong [Tue, 15 Oct 2024 19:44:05 +0000 (12:44 -0700)]
xfs_repair: fix maximum file offset comparison

When running generic/525 with rtinherit=1 and rextsize=28k, generic/525
trips over the following block mapping:

data offset 2251799813685247 startblock 7 (0/7) count 1 flag 0
data offset 2251799813685248 startblock 8 (0/8) count 6 flag 1

with this error:

inode 155 - extent exceeds max offset - start 2251799813685248, count 6,
physical block 8

This is due to an incorrect check in xfs_repair, which tries to validate
that a block mapping cannot exceed what it thinks is the maximum file
offset.  Unfortunately, the check is wrong, because only br_startoff is
subject to the 2^52-1 limit -- not br_startoff + br_blockcount.

Nowadays libxfs provides a symbol XFS_MAX_FILEOFF for the maximum
allowable file block offset that can be mapped into a file.  Use this
instead of the open-coded logic in versions.c and correct all the other
checks.  Note that this problem only surfaced when rtgroups were enabled
because hch changed xfs_repair to use the same tree-based block state
data structure that we use for AGs when rtgroups are enabled.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_repair: do not count metadata directory files when doing quotacheck
Darrick J. Wong [Tue, 15 Oct 2024 19:44:05 +0000 (12:44 -0700)]
xfs_repair: do not count metadata directory files when doing quotacheck

Previously, we stated that files in the metadata directory tree are not
counted in the dquot information.  Fix the offline quotacheck code in
xfs_repair and xfs_check to reflect this.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_repair: truncate and unmark orphaned metadata inodes
Darrick J. Wong [Tue, 15 Oct 2024 19:44:05 +0000 (12:44 -0700)]
xfs_repair: truncate and unmark orphaned metadata inodes

If an inode claims to be a metadata inode but wasn't linked in either
directory tree, remove the attr fork and reset the data fork if the
contents weren't regular extent mappings before moving the inode to the
lost+found.

We don't ifree the inode, because it's possible that the inode was not
actually a metadata inode but simply got corrupted due to bitflips or
something, and we'd rather let the sysadmin examine what's left of the
file instead of photorec'ing it.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_repair: drop all the metadata directory files during pass 4
Darrick J. Wong [Tue, 15 Oct 2024 19:44:05 +0000 (12:44 -0700)]
xfs_repair: drop all the metadata directory files during pass 4

Drop the entire metadata directory tree during pass 4 so that we can
reinitialize the entire tree in phase 6.  The existing metadata files
(rtbitmap, rtsummary, quotas) will be reattached to the newly rebuilt
directory tree.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_repair: metadata dirs are never plausible root dirs
Darrick J. Wong [Tue, 15 Oct 2024 19:44:05 +0000 (12:44 -0700)]
xfs_repair: metadata dirs are never plausible root dirs

Metadata directories are never candidates to be the root of the
user-accessible directory tree.  Update has_plausible_rootdir to ignore
them all, as well as detecting the case where the superblock incorrectly
thinks both trees have the same root.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_repair: adjust keep_fsinos to handle metadata directories
Darrick J. Wong [Tue, 15 Oct 2024 19:44:04 +0000 (12:44 -0700)]
xfs_repair: adjust keep_fsinos to handle metadata directories

In keep_fsinos, mark the root of the metadata directory tree as inuse.
The realtime bitmap and summary files still come after the root
directories, so this is a fairly simple change to the loop test.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_repair: mark space used by metadata files
Darrick J. Wong [Tue, 15 Oct 2024 19:44:04 +0000 (12:44 -0700)]
xfs_repair: mark space used by metadata files

Track space used by metadata files as a separate incore extent type.
This ensures that we can warn about cross-linked metadata files, even
though we are going to rebuild the entire metadata directory tree in the
end.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_repair: pass private data pointer to scan_lbtree
Darrick J. Wong [Tue, 15 Oct 2024 19:44:04 +0000 (12:44 -0700)]
xfs_repair: pass private data pointer to scan_lbtree

Pass a private data pointer through scan_lbtree.  We'll use this
later when scanning the rtrmapbt to keep track of scan state.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_repair: update incore metadata state whenever we create new files
Darrick J. Wong [Tue, 15 Oct 2024 19:44:04 +0000 (12:44 -0700)]
xfs_repair: update incore metadata state whenever we create new files

Make sure that we update our incore metadata inode bookkeepping whenever
we create new metadata files.  There will be many more of these later.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_repair: don't let metadata and regular files mix
Darrick J. Wong [Tue, 15 Oct 2024 19:44:03 +0000 (12:44 -0700)]
xfs_repair: don't let metadata and regular files mix

Track whether or not inodes thought they were metadata inodes.  We
cannot allow metadata inodes to appear in the regular directory tree,
and we cannot allow regular inodes to appear in the metadata directory
tree.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_repair: rebuild the metadata directory
Darrick J. Wong [Tue, 15 Oct 2024 19:44:03 +0000 (12:44 -0700)]
xfs_repair: rebuild the metadata directory

Check the dirents in metadata directories for problems and repair them
if necessary.  Also make sure that the sb-rooted inodes (root, metadir
root, rt bitmap, rt summary) are always allocated in that order.

Note that xfs_repair will always rebuild the metadata directory tree
itself, so we only need to report problems, not fix them.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_repair: use libxfs_metafile_iget for quota/rt inodes
Darrick J. Wong [Tue, 15 Oct 2024 19:44:03 +0000 (12:44 -0700)]
xfs_repair: use libxfs_metafile_iget for quota/rt inodes

Use the new iget function for these metadata files so that we can check
types, etc.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_repair: check metadata inode flag
Darrick J. Wong [Tue, 15 Oct 2024 19:44:03 +0000 (12:44 -0700)]
xfs_repair: check metadata inode flag

Check whether or not the metadata inode flag is set appropriately.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_repair: refactor grabbing realtime metadata inodes
Darrick J. Wong [Tue, 15 Oct 2024 19:44:03 +0000 (12:44 -0700)]
xfs_repair: refactor grabbing realtime metadata inodes

Create a helper function to grab a realtime metadata inode.  When
metadir arrives, the bitmap and summary inodes can float, so we'll
turn this function into a "load or allocate" function.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_repair: refactor root directory initialization
Darrick J. Wong [Tue, 15 Oct 2024 19:44:02 +0000 (12:44 -0700)]
xfs_repair: refactor root directory initialization

Refactor root directory initialization into a separate function we can
call for both the root dir and the metadir.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_repair: refactor marking of metadata inodes
Darrick J. Wong [Tue, 15 Oct 2024 19:44:02 +0000 (12:44 -0700)]
xfs_repair: refactor marking of metadata inodes

Refactor the mechanics of marking a metadata inode into a helper
function so that we don't have to open-code that for every single
metadata inode.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_repair: refactor fixing dotdot
Darrick J. Wong [Tue, 15 Oct 2024 19:44:02 +0000 (12:44 -0700)]
xfs_repair: refactor fixing dotdot

Pull the code that fixes a directory's dot-dot entry into a separate
helper function so that we can call it on the rootdir and (later) the
metadir.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_repair: dont check metadata directory dirent inumbers
Darrick J. Wong [Tue, 15 Oct 2024 19:44:02 +0000 (12:44 -0700)]
xfs_repair: dont check metadata directory dirent inumbers

Phase 6 always rebuilds the entire metadata directory tree, and repair
quietly ignores all the DIFLAG2_METADATA directory inodes that it finds.
As a result, none of the metadata directories are marked inuse in the
incore data.  Therefore, the is_inode_free checks are not valid for
anything we find in a metadata directory.

Therefore, avoid checking is_inode_free when scanning metadata directory
dirents.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_repair: preserve the metadirino field when zeroing supers
Darrick J. Wong [Tue, 15 Oct 2024 19:44:01 +0000 (12:44 -0700)]
xfs_repair: preserve the metadirino field when zeroing supers

The metadata directory root inumber is now the last field in the
superblock, so extend the zeroing code to know about that.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_scrub: re-run metafile scrubbers during phase 5
Darrick J. Wong [Tue, 15 Oct 2024 19:44:01 +0000 (12:44 -0700)]
xfs_scrub: re-run metafile scrubbers during phase 5

For metadata files on a metadir filesystem, re-run the scrubbers during
phase 5 to ensure that the metadata files are still connected.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_scrub: scan metadata directories during phase 3
Darrick J. Wong [Tue, 15 Oct 2024 19:44:01 +0000 (12:44 -0700)]
xfs_scrub: scan metadata directories during phase 3

Scan metadata directories for correctness during phase 3.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_scrub: tread zero-length read verify as an IO error
Darrick J. Wong [Tue, 15 Oct 2024 19:44:01 +0000 (12:44 -0700)]
xfs_scrub: tread zero-length read verify as an IO error

While doing some chaos testing on the xfs_scrub read verify code, I
noticed that if the device under a live filesystem gets resized while
scrub is running a media scan, reads will start returning 0.  This
causes read_verify() to run around in an infinite loop instead of
erroring out like it should.

Cc: <linux-xfs@vger.kernel.org> # v5.3.0
Fixes: 27464242956fac ("xfs_scrub: fix read verify disk error handling strategy")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_spaceman: report health of metadir inodes too
Darrick J. Wong [Tue, 15 Oct 2024 19:44:00 +0000 (12:44 -0700)]
xfs_spaceman: report health of metadir inodes too

If the filesystem has a metadata directory tree, we should include those
inodes in the health report.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_io: support scrubbing metadata directory paths
Darrick J. Wong [Tue, 15 Oct 2024 19:44:00 +0000 (12:44 -0700)]
xfs_io: support scrubbing metadata directory paths

Support invoking the metadata directory path scrubber from xfs_io for
testing.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_io: support the bulkstat metadata directory flag
Darrick J. Wong [Tue, 15 Oct 2024 19:44:00 +0000 (12:44 -0700)]
xfs_io: support the bulkstat metadata directory flag

Support the new XFS_BULK_IREQ_METADIR flag for bulkstat commands.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_db: display di_metatype
Darrick J. Wong [Tue, 15 Oct 2024 19:44:00 +0000 (12:44 -0700)]
xfs_db: display di_metatype

Print the metadata file type if available.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_db: show the metadata root directory when dumping superblocks
Darrick J. Wong [Tue, 15 Oct 2024 22:37:40 +0000 (15:37 -0700)]
xfs_db: show the metadata root directory when dumping superblocks

Show the metadirino field when appropriate.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_db: support metadata directories in the path command
Darrick J. Wong [Tue, 15 Oct 2024 19:44:00 +0000 (12:44 -0700)]
xfs_db: support metadata directories in the path command

Teach various directory tree debugger commands to traverse the metadata
directory tree by adding a -m switch to select that tree.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_db: don't obfuscate metadata directories and attributes
Darrick J. Wong [Tue, 15 Oct 2024 19:43:59 +0000 (12:43 -0700)]
xfs_db: don't obfuscate metadata directories and attributes

Don't obfuscate the directory and attribute names of metadata inodes.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_db: report metadir support for version command
Darrick J. Wong [Tue, 15 Oct 2024 19:43:59 +0000 (12:43 -0700)]
xfs_db: report metadir support for version command

Report metadir support if we have it enabled.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_db: disable xfs_check when metadir is enabled
Darrick J. Wong [Tue, 15 Oct 2024 19:43:59 +0000 (12:43 -0700)]
xfs_db: disable xfs_check when metadir is enabled

As of July 2024, xfs_repair can detect more types of corruptions than
xfs_check does.  I don't think it makes sense to maintain the xfs_check
code anymore, so let's just turn it off for any filesystem that has
metadata directory trees.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs_io: support scrubbing metadata directory paths
Darrick J. Wong [Tue, 15 Oct 2024 19:43:59 +0000 (12:43 -0700)]
xfs_io: support scrubbing metadata directory paths

Support invoking the metadata directory path scrubber from xfs_io for
testing.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agolibfrog: allow METADIR in xfrog_bulkstat_single5
Darrick J. Wong [Tue, 15 Oct 2024 19:43:58 +0000 (12:43 -0700)]
libfrog: allow METADIR in xfrog_bulkstat_single5

This is a valid flag for a single-file bulkstat, so add that to the
filter.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agolibfrog: report metadata directories in the geometry report
Darrick J. Wong [Tue, 15 Oct 2024 19:43:58 +0000 (12:43 -0700)]
libfrog: report metadata directories in the geometry report

Report the presence of a metadata directory tree in the geometry report.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs: check metadata directory file path connectivity
Darrick J. Wong [Tue, 15 Oct 2024 19:43:58 +0000 (12:43 -0700)]
xfs: check metadata directory file path connectivity

Create a new scrubber type that checks that well known metadata
directory paths are connected to the metadata inode that the incore
structures think is in use.  IOWs, check that "/quota/user" in the
metadata directory tree actually points to
mp->m_quotainfo->qi_uquotaip->i_ino.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: record health problems with the metadata directory
Darrick J. Wong [Tue, 15 Oct 2024 19:43:58 +0000 (12:43 -0700)]
xfs: record health problems with the metadata directory

Make a report to the health monitoring subsystem any time we encounter
something in the metadata directory tree that looks like corruption.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: adjust xfs_bmap_add_attrfork for metadir
Darrick J. Wong [Tue, 15 Oct 2024 19:43:58 +0000 (12:43 -0700)]
xfs: adjust xfs_bmap_add_attrfork for metadir

Online repair might use the xfs_bmap_add_attrfork to repair a file in
the metadata directory tree if (say) the metadata file lacks the correct
parent pointers.  In that case, it is not correct to check that the file
is dqattached -- metadata files must be not have /any/ dquot attached at
all.  Adjust the assertions appropriately.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: allow bulkstat to return metadata directories
Darrick J. Wong [Tue, 15 Oct 2024 19:43:57 +0000 (12:43 -0700)]
xfs: allow bulkstat to return metadata directories

Allow the V5 bulkstat ioctl to return information about metadata
directory files so that xfs_scrub can find and scrub them, since they
are otherwise ordinary directories.

(Metadata files of course require per-file scrub code and hence do not
need exposure.)

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: advertise metadata directory feature
Darrick J. Wong [Tue, 15 Oct 2024 19:43:57 +0000 (12:43 -0700)]
xfs: advertise metadata directory feature

Advertise the existence of the metadata directory feature; this will be
used by scrub to decide if it needs to scan the metadir too.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: disable the agi rotor for metadata inodes
Darrick J. Wong [Tue, 15 Oct 2024 19:43:57 +0000 (12:43 -0700)]
xfs: disable the agi rotor for metadata inodes

Ideally, we'd put all the metadata inodes in one place if we could, so
that the metadata all stay reasonably close together instead of
spreading out over the disk.  Furthermore, if the log is internal we'd
probably prefer to keep the metadata near the log.  Therefore, disable
AGI rotoring for metadata inode allocations.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: read and write metadata inode directory tree
Darrick J. Wong [Tue, 15 Oct 2024 19:43:57 +0000 (12:43 -0700)]
xfs: read and write metadata inode directory tree

Plumb in the bits we need to load metadata inodes from a named entry in
a metadir directory, create (or hardlink) inodes into a metadir
directory, create metadir directories, and flag inodes as being metadata
files.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: enforce metadata inode flag
Darrick J. Wong [Tue, 15 Oct 2024 19:43:57 +0000 (12:43 -0700)]
xfs: enforce metadata inode flag

Add checks for the metadata inode flag so that we don't ever leak
metadata inodes out to userspace, and we don't ever try to read a
regular inode as metadata.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: load metadata directory root at mount time
Darrick J. Wong [Tue, 15 Oct 2024 19:43:56 +0000 (12:43 -0700)]
xfs: load metadata directory root at mount time

Load the metadata directory root inode into memory at mount time and
release it at unmount time.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: iget for metadata inodes
Darrick J. Wong [Tue, 15 Oct 2024 19:43:56 +0000 (12:43 -0700)]
xfs: iget for metadata inodes

Create a xfs_trans_metafile_iget function for metadata inodes to ensure
that when we try to iget a metadata file, the inode is allocated and its
file mode matches the metadata file type the caller expects.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: define the on-disk format for the metadir feature
Darrick J. Wong [Tue, 15 Oct 2024 19:38:22 +0000 (12:38 -0700)]
xfs: define the on-disk format for the metadir feature

Define the on-disk layout and feature flags for the metadata inode
directory feature.  Add a xfs_sb_version_hasmetadir for benefit of
xfs_repair, which needs to know where the new end of the superblock
lies.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: rename metadata inode predicates
Darrick J. Wong [Tue, 15 Oct 2024 21:50:14 +0000 (14:50 -0700)]
xfs: rename metadata inode predicates

The predicate xfs_internal_inum tells us if an inumber refers to one of
the inodes rooted in the superblock.  Soon we're going to have internal
inodes in a metadata directory tree, so this helper should be renamed
to capture its limited scope.

Ondisk inodes will soon have a flag to indicate that they're metadata
inodes.  Head off some confusion by renaming the xfs_is_metadata_inode
predicate to xfs_is_internal_inode.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: constify the xfs_inode predicates
Darrick J. Wong [Tue, 15 Oct 2024 19:43:55 +0000 (12:43 -0700)]
xfs: constify the xfs_inode predicates

Change the xfs_inode predicates to take a const struct xfs_inode pointer
because they do not change the inode.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: constify the xfs_sb predicates
Darrick J. Wong [Tue, 15 Oct 2024 19:43:55 +0000 (12:43 -0700)]
xfs: constify the xfs_sb predicates

Change the xfs_sb predicates to take a const struct xfs_sb pointer
because they do not change the superblock.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
8 months agoxfs: store a generic group structure in the intents
Christoph Hellwig [Tue, 15 Oct 2024 19:38:20 +0000 (12:38 -0700)]
xfs: store a generic group structure in the intents

Replace the pag pointers in the extent free, bmap, rmap and refcount
intent structures with a pointer to the generic group to prepare
for adding intents for realtime groups.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs: add group based bno conversion helpers
Christoph Hellwig [Tue, 15 Oct 2024 19:38:18 +0000 (12:38 -0700)]
xfs: add group based bno conversion helpers

Add/move the blocks, blklog and blkmask fields to the generic groups
structure so that code can work with AGs and RTGs by just using the
right index into the array.

Then, add convenience helpers to convert block numbers based on the
generic group.  This will allow writing code that doesn't care if it is
used on AGs or the upcoming realtime groups.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs: add a generic group pointer to the btree cursor
Christoph Hellwig [Tue, 15 Oct 2024 19:38:17 +0000 (12:38 -0700)]
xfs: add a generic group pointer to the btree cursor

Replace the pag pointers in the type specific union with a generic
xfs_group pointer.  This prepares for adding realtime group support.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
8 months agoxfs: convert busy extent tracking to the generic group structure
Christoph Hellwig [Tue, 15 Oct 2024 19:38:16 +0000 (12:38 -0700)]
xfs: convert busy extent tracking to the generic group structure

Split busy extent tracking from struct xfs_perag into its own private
structure, which can be pointed to by the generic group structure.

Note that this structure is now dynamically allocated instead of embedded
as the upcoming zone XFS code doesn't need it and will also have an
unusually high number of groups due to hardware constraints.  Dynamically
allocating the structure this is a big memory saver for this case.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>