Jeremy Kerr [Thu, 20 Oct 2022 07:02:10 +0000 (15:02 +0800)]
mi: Distinguish MI status from NVMe (CDW3) status
We curerently have some overloading in the status values returned from
the nvme_* API, as the NVMe CDW3 values overlap with the
recently-introduced NVMe-MI response header status.
This change introduces a new encoding for the return values of MI
functions, where we use a set of bits in the return value to encode
whether the value is either a MI status value or a NVMe status value. We
leave room for future expansion too, by defining three bits of possible
type values.
This has minimal change to the current API, as we're using 0 for the
current NVMe status codes, so they are all unchanged. Since the MI
values alised those, they will have high bits set now, but we couldn't
previously distinguish them from the NVMe values anyway.
Fixes: https://github.com/linux-nvme/libnvme/issues/456 Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Jinliang Wang [Tue, 11 Oct 2022 17:20:58 +0000 (10:20 -0700)]
mi: Add Identify helper for ns-descs and primary-ctrl-caps
This change adds two helpers for the Identify command, retrieving the
namespace identification descriptior list and primary controller capabilities
data structure.
Signed-off-by: Jinliang Wang <jinliangw@google.com>
Simon A. F. Lund [Thu, 20 Oct 2022 10:09:49 +0000 (12:09 +0200)]
Makefile: add 'make uninstall'
An uninstall option, in addition to RPM install/uninstall, is arguably
quite convenient. Yet, Makefiles usually do not provide an 'uninstall'
target since that would require recording an installation manifest and
custom logic for removal.
However, meson has an internal feature doing precisely that.
This change invokes the meson uninstall feature via "make uninstall".
Signed-off-by: Simon A. F. Lund <simon.lund@samsung.com>
Jeremy Kerr [Wed, 28 Sep 2022 09:44:24 +0000 (17:44 +0800)]
mi: fix get_log_page chunked offset check
In our get_log_page helper, we're incorrectly checking the requested
chunk offset against the chunk len, rather than the overall length -
this means we can't query anything but the first chunk.
This change fixes this to check against the overall length instead, and
adds an additional check to ensure we're not requesting more than the
full data size.
We also add a testcase for the chunking code.
Reported-by: Hao Jiang <jianghao@google.com> Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
json-c's json_object_from_fd() doesn't set the JSON_TOKENER_STRICT
flag. This means the parser is more failure tolerant. Let's be strict
and enforce fully correctly formatted configuration.
Martin Belanger [Wed, 28 Sep 2022 12:57:33 +0000 (08:57 -0400)]
examples: LID supported must be shifted right by 16
To access the LID Specific Field (see Base specs) the values
from the Get Supported Log pages must be shifted right by 16.
The example code was missing the shift.
Also added better exception handling example.
Signed-off-by: Martin Belanger <martin.belanger@dell.com>
Jeremy Kerr [Mon, 26 Sep 2022 13:10:22 +0000 (21:10 +0800)]
mi: Move post-1.1 symbols to 1_2 section of libnvme-mi.map
There have been a few functions added after the v1.1 release that ended
up in the 1_1 section of the symbol map. This change moves them to a new
1_2 section instead.
Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Martin Belanger [Mon, 26 Sep 2022 11:13:55 +0000 (07:13 -0400)]
fabrics: Add nvmf_get_discovery_wargs()
This function is similar to nvmf_get_discovery_log(), but takes
an extensible "args" parameter. The args parameter contains more
options than are available with nvmf_get_discovery_log(). For
example, it provides a way to set the LSP (Log page Specific field)
which is needed for advanced TP8010 features.
Signed-off-by: Martin Belanger <martin.belanger@dell.com>
Jeremy Kerr [Sat, 24 Sep 2022 09:01:08 +0000 (17:01 +0800)]
mi: Introduce a helper for response status, unify values with ioctls
Currently, every admin command function has a similar pattern for
catching an error from one of:
- the MI transport; or
- the admin cdw0 field, sometimes populated to a result pointer
This change adds a helper for that pattern.
Then, instead of using cdw0 for the return value, we should be using
cdw3 instead, as cdw0 is command-specific, and may not always indicate
an error. We can then return the proper status type & status, in the
same way that the ioctl commands do.
This goes part way to fixing
https://github.com/linux-nvme/libnvme/issues/456, but we still have an
issue where the MI return values may alias the cdw3 return values.
Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Jeremy Kerr [Sat, 24 Sep 2022 02:49:16 +0000 (10:49 +0800)]
github workflows: Add an armhf cross build
This RFC change adds a github workflow for a cross-compile of libnvme on
armhf. We use a similar setup to the build-distro job, but install a
suitable cross compiler and provide a cross config to meson.
We currently setup with -Dpython=false, as the setup-python@v4 seems to
assume a native python build. We may be able to remove this later.
The suitability of this will depend on the resources available for
actions; doing some test runs on a private repo shows an execution time
of about 1 min 15 sec - a little less than the build-static job.
Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
error: invalid conversion from 'int' to 'nvme_mi_config_smbus_freq'
error: designator order for field 'nvme_ns_mgmt_args::nsid' does not match declaration order in 'nvme_ns_mgmt_args'
Jeremy Kerr [Fri, 9 Sep 2022 10:10:10 +0000 (18:10 +0800)]
examples/mi-mctp: fix warning for possibly uninitialised variable
gcc-12 with -Wuninitialized-var reports a warning for mi-mctp:
examples/mi-mctp.c: In function ‘do_action_endpoint’:
examples/mi-mctp.c:665:16: warning: ‘rc’ may be used uninitialized [-Wmaybe-uninitialized]
665 | return rc;
| ^~
examples/mi-mctp.c:637:13: note: ‘rc’ was declared here
637 | int rc;
| ^~
We shouldn't be able to hit this path, but explicitly set rc to an error
if we miss an enum case.
Fixes: https://github.com/linux-nvme/libnvme/issues/467 Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Daniel Wagner [Tue, 30 Aug 2022 14:03:56 +0000 (16:03 +0200)]
doc: Install pre-compiled man pages to the correct path
The install_subdir('man', ...) command installs the man pages under
$mandir/man/ instead of $mandir. Use and external script to get the
list of man pages to avoid having to list all the man pages
explicitly.
Martin George [Fri, 26 Aug 2022 13:17:57 +0000 (18:47 +0530)]
nvme-tree: avoid segfault if auth keys are unavailable
Seeing multiple segfaults in nvme_configure_ctrl() when the
respective controller attributes (including auth keys) are
unavailable. For e.g. attempting a nvme connect with bidirectional
auth hits the following segfault:
Hannes Reinecke [Thu, 25 Aug 2022 08:27:02 +0000 (10:27 +0200)]
Parse dhchap_host_key on controller level
The json config schema declares an 'dhchap_key' element representing
the dhchap host key on the controller level, but the implementation
was missing. Add the missing parsing elements and ensure to pick the
correct one (either host or controller setting) when creating the
nvme connect string.
Jeremy Kerr [Fri, 12 Aug 2022 04:44:50 +0000 (12:44 +0800)]
mi: Allow Admin-message sized More Processing Required responses
Devices may implement their MPR response as an actual Admin response
message, rather than the simple MI-only message described in 4.1.2.3 of
NVMe-MI v1.2b.
Allow this, but with some fairly stringent header checks. Add a test for
this behaviour too.
Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Jeremy Kerr [Thu, 21 Jul 2022 08:21:30 +0000 (16:21 +0800)]
example/mi-conf: Add an example for MI transport configuration
With the Read MI Data Structure and MI Configuration Set functions
available, we can query a device for its maximum MTU, and update the
current MTU to suit.
This also requires telling the local MCTP stack about the new MTU too,
by sending a d-bus message to `mctpd`.
This change adds a little example for this functionality, where we
perform the MI query and configuration, and implements the d-bus
communication for the local stack control.
Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Daniel Wagner [Wed, 3 Aug 2022 11:56:48 +0000 (13:56 +0200)]
util: Add LINE_MAX define
The bionic libc implementation doesn't implement the complete
POSIX API. Apperantly we just need this define to be able
to compile for Android OS. Thus, keep it as simple as possible
and just define it here.
Hannes Reinecke [Fri, 29 Jul 2022 06:14:14 +0000 (08:14 +0200)]
json: fixup dhchap_ctrl_key definitions
The config schema declared a 'dhchap_key' and a 'dhchap_ctrl_key'
value for the port structure, but the json parser implemented a
'dhchap_key' entry for the port (holding the controller key), and
a 'dhchap_key' entry for the host (holding the host key).
Fixup the config schema to declared the correct entries and the
json parser to check for 'dhchap_ctrl_key' instead of 'dhchap_key'.
projects / users / sagi / libnvme.git / log