]> www.infradead.org Git - users/sagi/nvme-cli.git/log
users/sagi/nvme-cli.git
8 months agonvme: set file permission for keyfile to owner only
Daniel Wagner [Thu, 24 Oct 2024 13:23:33 +0000 (15:23 +0200)]
nvme: set file permission for keyfile to owner only

Since this file contains secret enforce the read/write permission
limited to the owner only.

Signed-off-by: Daniel Wagner <dwagner@suse.de>
8 months agonvme: export tls keys honoring version and hmac
Daniel Wagner [Thu, 24 Oct 2024 13:21:42 +0000 (15:21 +0200)]
nvme: export tls keys honoring version and hmac

Export the keys with the correct encoding scheme.

Signed-off-by: Daniel Wagner <dwagner@suse.de>
8 months agonvmf-keys: add udev rule to import tls keys
Daniel Wagner [Thu, 24 Oct 2024 13:07:54 +0000 (15:07 +0200)]
nvmf-keys: add udev rule to import tls keys

Load keys to the keyring when the nvme-tcp module is loaded.

Signed-off-by: Daniel Wagner <dwagner@suse.de>
8 months agodocs: update TLS options
Daniel Wagner [Wed, 23 Oct 2024 09:39:32 +0000 (11:39 +0200)]
docs: update TLS options

With the added support to also accept the key via the command line
update the documentation accordingly.

Signed-off-by: Daniel Wagner <dwagner@suse.de>
8 months agofabrics: add support to connect to accept a PSK command line
Daniel Wagner [Thu, 10 Oct 2024 07:04:51 +0000 (09:04 +0200)]
fabrics: add support to connect to accept a PSK command line

Extend the connect command also to accept the pre-shared key via command
line. Obviously, this is not recommended to use for a production system
but for testing this is a simple way to get a setup working.

Signed-off-by: Daniel Wagner <dwagner@suse.de>
8 months agofabrics: add support to connect to accept a configuration
Daniel Wagner [Wed, 23 Oct 2024 08:45:54 +0000 (10:45 +0200)]
fabrics: add support to connect to accept a configuration

The connect-all command accepts JSON configuration but not
the connect command. connect-all will try to connect to all
possible resources, which includes creating discovery controllers.
This might not always needed or wanted.

The connect command will only connect to the controllers
listed in the configuration file and doesn't to any
additional discovery at all.

Signed-off-by: Daniel Wagner <dwagner@suse.de>
8 months agonvme: use unsigned char for hmac and identity
Daniel Wagner [Thu, 10 Oct 2024 07:02:16 +0000 (09:02 +0200)]
nvme: use unsigned char for hmac and identity

The spec is limiting the size of both variables to one byte, thus there
is no need to use wider types.

Signed-off-by: Daniel Wagner <dwagner@suse.de>
8 months agobuild: bump libnvme wrap
Daniel Wagner [Thu, 24 Oct 2024 09:36:11 +0000 (11:36 +0200)]
build: bump libnvme wrap

Fetch TLS API changes.

Signed-off-by: Daniel Wagner <dwagner@suse.de>
8 months agonvme-print: Add Sanitize Media Verification Event in PEL log
Francis Pravin [Mon, 28 Oct 2024 06:27:13 +0000 (11:57 +0530)]
nvme-print: Add Sanitize Media Verification Event in PEL log

Add Sanitize Media Verification Event in Persistent Event Log.

Signed-off-by: Francis Pravin <francis.p@samsung.com>
8 months agonetapp-ontapdev: add err msg for no ontapdevices
Martin George [Sun, 27 Oct 2024 17:40:19 +0000 (23:10 +0530)]
netapp-ontapdev: add err msg for no ontapdevices

Print an error message if no ontapdevices on the host.

Signed-off-by: Martin George <marting@netapp.com>
8 months agonetapp-smdev: add err msg for no smdevices
Martin George [Sun, 27 Oct 2024 17:36:10 +0000 (23:06 +0530)]
netapp-smdev: add err msg for no smdevices

Print an error message if no smdevices on the host.

Signed-off-by: Martin George <marting@netapp.com>
9 months agodoc: Add sanitize command emvs option
Francis Pravin [Fri, 25 Oct 2024 10:02:20 +0000 (15:32 +0530)]
doc: Add sanitize command emvs option

Add Enter Media Verification State (EVMS) option of Sanitize command.

Signed-off-by: Francis Pravin <francis.p@samsung.com>
9 months agoocp: combine to use GUID length definitions
Tokunori Ikegami [Fri, 25 Oct 2024 01:57:45 +0000 (10:57 +0900)]
ocp: combine to use GUID length definitions

This reduces the duplicated GUID length 16 bytes definitions.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
9 months agonvme: update tls_key() handling
Martin George [Wed, 16 Oct 2024 07:56:55 +0000 (13:26 +0530)]
nvme: update tls_key() handling

Few misc issues in current tls_key() implementation:

1) Additional blank line printed in err message if the keyfile
cannot be opened.

2) For export, nvme_scan_tls_keys() can return positive values too
for successful scenarios. So this currently leads to erroneous return
value handling.

3) For import, no return value checking for import_key() failure
scenarios.

4) For revoke, return appropriate error immediately when
nvme_revoke_tls_key() fails.

5) No helpful success message printed for all the options.

Fix the same.

Signed-off-by: Martin George <marting@netapp.com>
9 months agonvme-print-stdout: print VERS bit of SANICAP field
Francis Pravin [Wed, 9 Oct 2024 13:37:57 +0000 (19:07 +0530)]
nvme-print-stdout: print VERS bit of SANICAP field

Print the newly added VERS bit of SANICAP field in Identify Controller
Data Structure. Also, changed the variable names as per spec.

Signed-off-by: Francis Pravin <francis.p@samsung.com>
9 months agonvme: add EMVS support to sanitize command
Francis Pravin [Thu, 24 Oct 2024 05:07:19 +0000 (10:37 +0530)]
nvme: add EMVS support to sanitize command

Add Enter Media Verification State (EMVS) support to sanitize
command.
TP4152 - Post-Sanitize Media Verification 2024.04.01 Ratified.

Signed-off-by: Francis Pravin <francis.p@samsung.com>
Reviewed-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
9 months agobuild: update libnvme wrap
Francis Pravin [Thu, 24 Oct 2024 04:18:47 +0000 (09:48 +0530)]
build: update libnvme wrap

Get EMVS support of sanitize command and SMVES enum.

Signed-off-by: Francis Pravin <francis.p@samsung.com>
9 months agoocp: remove callback function cast
Tokunori Ikegami [Thu, 24 Oct 2024 01:39:49 +0000 (10:39 +0900)]
ocp: remove callback function cast

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
9 months agodoc: added commit conventions to contribution guidelines
paumr [Mon, 21 Oct 2024 16:27:22 +0000 (18:27 +0200)]
doc: added commit conventions to contribution guidelines

Show new contributors the project's commit guidelines

Signed-off-by: paumr <paum@bdisk.eu>
9 months agoocp: fix ocp-print-stdout.c indentation error
Tokunori Ikegami [Mon, 7 Oct 2024 15:43:47 +0000 (00:43 +0900)]
ocp: fix ocp-print-stdout.c indentation error

Fix also some build warnings.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
9 months agoocp: fix ocp-nvme.c indentation errors
Tokunori Ikegami [Mon, 7 Oct 2024 14:36:21 +0000 (23:36 +0900)]
ocp: fix ocp-nvme.c indentation errors

Also fix to use cpu_to_le64 to output __le64 values.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
9 months agoocp: build ocp-nvme.c and ocp-telemetry-decode.c without json
Tokunori Ikegami [Sun, 6 Oct 2024 06:59:35 +0000 (15:59 +0900)]
ocp: build ocp-nvme.c and ocp-telemetry-decode.c without json

Still ocp-telemetry-decode.c includes json code so check CONFIG_JSON.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
9 months agoocp: split TCG configuration log print codes
Tokunori Ikegami [Sun, 6 Oct 2024 12:13:15 +0000 (21:13 +0900)]
ocp: split TCG configuration log print codes

Move into ocp-print-stdout.c and ocp-print-json.c.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
9 months agoocp: split telemetry string log print codes
Tokunori Ikegami [Sun, 6 Oct 2024 12:11:54 +0000 (21:11 +0900)]
ocp: split telemetry string log print codes

Move into ocp-print-stdout.c and ocp-print-json.c.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
9 months agoocp: split device capabilities log print codes
Tokunori Ikegami [Sun, 20 Oct 2024 16:36:03 +0000 (01:36 +0900)]
ocp: split device capabilities log print codes

Move into ocp-print-stdout.c and ocp-print-json.c.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
9 months agoocp: split error recovery log print codes
Tokunori Ikegami [Sun, 20 Oct 2024 16:35:02 +0000 (01:35 +0900)]
ocp: split error recovery log print codes

Move into ocp-print-stdout.c and ocp-print-json.c.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
9 months agoocp: split unsupported requirement log print codes
Tokunori Ikegami [Sun, 20 Oct 2024 16:33:41 +0000 (01:33 +0900)]
ocp: split unsupported requirement log print codes

Move into ocp-print-stdout.c and ocp-print-json.c.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
9 months agoocp: split latency monitor log print codes
Tokunori Ikegami [Sun, 20 Oct 2024 16:32:07 +0000 (01:32 +0900)]
ocp: split latency monitor log print codes

Move into ocp-print-stdout.c and ocp-print-json.c.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
9 months agoocp: move ocp telemetry log print function into ocp-print
Tokunori Ikegami [Sun, 6 Oct 2024 01:22:10 +0000 (10:22 +0900)]
ocp: move ocp telemetry log print function into ocp-print

Still the ocp-telemetry-decode used by print functions combined json code.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
9 months agoocp: split smart extended log print codes
Tokunori Ikegami [Sun, 29 Sep 2024 14:19:10 +0000 (23:19 +0900)]
ocp: split smart extended log print codes

Move into ocp-print-stdout.c and ocp-print-json.c.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
9 months agoocp: split ocp-fw-activation-history print codes
Tokunori Ikegami [Fri, 27 Sep 2024 16:22:57 +0000 (01:22 +0900)]
ocp: split ocp-fw-activation-history print codes

Moved into print stdout and json files.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
9 months agoplugins: update meson.build file to always build ocp plugin
Tokunori Ikegami [Fri, 20 Sep 2024 13:15:49 +0000 (22:15 +0900)]
plugins: update meson.build file to always build ocp plugin

Still ocp-nvme.c and some other ocp commands files depended on json.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
9 months agoocp-print: move json code into separate files
Tokunori Ikegami [Thu, 19 Sep 2024 16:10:10 +0000 (01:10 +0900)]
ocp-print: move json code into separate files

At first only hwcomp print code moved.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
9 months agonvme-print-json: display only verbose output
Martin George [Thu, 17 Oct 2024 11:57:18 +0000 (17:27 +0530)]
nvme-print-json: display only verbose output

Having separate regular & verbose outputs makes more sense for the
stdout outputs, and not necessarily for the JSON outputs. So let's
make things simpler by having the JSON output everything, and
nothing short.

Suggested-by: Daniel Wagner <dwagner@suse.de>
Signed-off-by: Martin George <marting@netapp.com>
9 months agoocp-nvme: ocp plugin version update
Steven Seungcheol Lee [Tue, 15 Oct 2024 05:57:14 +0000 (14:57 +0900)]
ocp-nvme: ocp plugin version update

Add missing version update after adding changes for ocp spec 2.5

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
9 months agonvme-print: print KV command set page header
rick [Fri, 23 Aug 2024 12:45:55 +0000 (14:45 +0200)]
nvme-print: print KV command set page header

Let stdout_effects_log_page handle NVME_CSI_KV as well.

Signed-off-by: laiaferrer <laiaferrermoser@gmail.com>
9 months agodoc: show where self-test results can be found
paumr [Fri, 4 Oct 2024 09:29:13 +0000 (11:29 +0200)]
doc: show where self-test results can be found

Point the reader of the device-self-test documentation to
the command used for querying the test results.

Signed-off-by: paumr <paum@bdisk.eu>
9 months agoplugins/memblaze: fix a wrong id on smart-log-add
jinhua.huang [Tue, 15 Oct 2024 10:22:29 +0000 (18:22 +0800)]
plugins/memblaze: fix a wrong id on smart-log-add

Modify 0xB8 to 0xDF

Signed-off-by: jinhua.huang <jinhua.huang@memblaze.com>
9 months agoplugins/dapustor: smart-log-add fix
Xiaoyuan Zhang [Wed, 9 Oct 2024 09:47:23 +0000 (17:47 +0800)]
plugins/dapustor: smart-log-add fix

Output Extended Additional SMART raw binary data if it exists.
Add the missing 'temp_since_bootup' field for json output.

Signed-off-by: Xiaoyuan Zhang <zhxiaoy2024@gmail.com>
9 months agoplugins/sed: add sid password change
Greg Joyce [Fri, 16 Aug 2024 17:29:16 +0000 (12:29 -0500)]
plugins/sed: add sid password change

The existing ioctl to change password only updated the admin1 password.
Add using a new ioctl IOC_OPAL_SET_SID_PW to also update the sid password
so that sid and admin1 passwords are kept in sync.

Signed-off-by: Greg Joyce <gjoyce@linux.ibm.com>
9 months agoplugins/solidigm: Automatic retry smaller log chunk size.
Leonardo da Cunha [Tue, 1 Oct 2024 22:28:20 +0000 (15:28 -0700)]
plugins/solidigm: Automatic retry smaller log chunk size.

Retry to retrieve telemetry and PEL with smaller chunk size, because
some systems are failing to retrieve telemetry in 256KB chunks.

Signed-off-by: Leonardo da Cunha <leonardo.da.cunha@solidigm.com>
9 months agoocp-nvme: Add LMDATA-37 for Latency Monitor Log
Steven Seungcheol Lee [Mon, 7 Oct 2024 11:17:48 +0000 (20:17 +0900)]
ocp-nvme: Add LMDATA-37 for Latency Monitor Log

Datacenter NVMe SSD Specification v2.5
Log Identifier C3h
[447:436] Latency Monitor Debug Telemetry Log Size
This is the number of Dwords in the Latency Monitor Debug Log.
This value is in Dwords.
little endian order print

Signed-off-by: Hyuntae Kim <h1219.kim@samsung.com>
Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
9 months agoocp-nvme: remove ocp log page version checking
Steven Seungcheol Lee [Mon, 7 Oct 2024 10:23:13 +0000 (19:23 +0900)]
ocp-nvme: remove ocp log page version checking

For supporting ocp 2.5 and legacy version
if we want to check the log version,
we need to get DSSD(OCP) Spec version from ocp smart.

example) Latency Monitor (Log Identifier C3h)
OCP 2.0 Log Page version : 0x1
OCP 2.5 Log Page version : 0x4

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
9 months agowdc: Fix for Reading WDC C2 Vendor Unique Log Page
jeff-lien-wdc [Mon, 7 Oct 2024 17:27:53 +0000 (12:27 -0500)]
wdc: Fix for Reading WDC C2 Vendor Unique Log Page

In cases where nvme drives are connected via a PCIe
switch, the pci vendor and device id are unable to
be read.  This causes a failure when reading values
in the WDC C2 log page needed for the get-drive-status
wdc plugin command.

Signed-off-by: jeff-lien-wdc <jeff.lien@wdc.com>
9 months agoocp: Fixes for OCP 2.5 Telemetry DA1 FIFO Event Parsing
jeff-lien-wdc [Mon, 12 Aug 2024 17:24:48 +0000 (12:24 -0500)]
ocp: Fixes for OCP 2.5 Telemetry DA1 FIFO Event Parsing

This commit fixes several issues related to parsing
the Telemetry DA 1 and 2 Event FIFO's.

Fixes parsing of VU Event Data.
    Added checking for VU data.
    Removed the vu_event_identifier field from the debug
    event class structs since it's not guaranteed to be there.
    Added nvme_ocp_common_dbg_evt_class_vu_data to be used
    to access the VU data.

    Added checking for NULL pointers

    Added a check for the end of the Event FIFO entries that will
    break from the while loop when detected.

    Fixed lines longer then 100 columns.
    Fixed other miscellaneous errors flagged
    by checkpatch.pl.
    Fixed "Suspicious sizeof offset in a pointer
    arithmetic expression." errors flagged by Code
    scanning.

    Fixed loop index size error
    Fixed LE variable declarations and conversion issues
    Fixed vu data size errors
    Make variable names more descriptive

Signed-off-by: jeff-lien-wdc <jeff.lien@wdc.com>
9 months agonvme-print-json: update JSON verbose output for nvm-id-ctrl
Martin George [Thu, 3 Oct 2024 17:20:24 +0000 (22:50 +0530)]
nvme-print-json: update JSON verbose output for nvm-id-ctrl

Update the nvme-id-ctrl JSON verbose output for parity with this
command's normal verbose output.

Signed-off-by: Martin George <marting@netapp.com>
9 months agowdc: Add Support for SN5100S
jeff-lien-wdc [Wed, 2 Oct 2024 18:48:50 +0000 (13:48 -0500)]
wdc: Add Support for SN5100S

This commit will add support for the SN51000S drive
which includes the following pci device ids:
0x5061, 0x5062, 0x5063.

Signed-off-by: jeff-lien-wdc <jeff.lien@wdc.com>
9 months agonvme: Support show-regs for nvmeof
Minsik Jeon [Wed, 2 Oct 2024 08:18:59 +0000 (17:18 +0900)]
nvme: Support show-regs for nvmeof

Get properties only at offsets that support nvme fabric registers.
Since crto was not found in the nvmeof spec, it is removed.
Also, NSSR is only optional register. If the device is not supported by
the optional register, the error is ignored.

Reviewed-by: Steven Seungcheol <sc108.lee@samsung.com>
Signed-off-by: Minsik Jeon <hmi.jeon@samsung.com>
9 months agoocp: fix option handling in internal-log
Tetsuya TAKAHASHI [Fri, 27 Sep 2024 01:50:54 +0000 (10:50 +0900)]
ocp: fix option handling in internal-log

When the noraml format is specified without -t option to
ocp internal-log command, the command ends abnormally with
segmentation fault.
This commit fixes the option handling.

Signed-off-by: Tetsuya TAKAHASHI <tetsuya20.takahashi@kioxia.com>
9 months agoDocumentation: Added solidigm plugin commands
Leonardo da Cunha [Wed, 18 Sep 2024 03:36:46 +0000 (20:36 -0700)]
Documentation: Added solidigm plugin commands

Added documentation to all current solidigm plugin commands

Signed-off-by: Leonardo da Cunha <leonardo.da.cunha@solidigm.com>
9 months agowdc: add support for SNTMP drive
Brandon Paupore [Mon, 30 Sep 2024 20:12:00 +0000 (15:12 -0500)]
wdc: add support for SNTMP drive

Adding an additional PCI Device ID (0x2761) to be recognized.

Signed-off-by: Brandon Paupore <brandon.paupore@wdc.com>
9 months agobuild: use linux-nvme/ci-containers
Daniel Wagner [Tue, 1 Oct 2024 14:42:44 +0000 (16:42 +0200)]
build: use linux-nvme/ci-containers

Use the pre build containers from linux-nvme/ci-containers.

Signed-off-by: Daniel Wagner <dwagner@suse.de>
9 months agonvme-print: print NSSES field of CAP register
Francis Pravin [Mon, 30 Sep 2024 12:52:31 +0000 (18:22 +0530)]
nvme-print: print NSSES field of CAP register

Print the newly added NSSES field of CAP register.

Signed-off-by: Francis Pravin <francis.p@samsung.com>
9 months agoocp: fix GUID output
Tetsuya TAKAHASHI [Fri, 27 Sep 2024 05:25:02 +0000 (14:25 +0900)]
ocp: fix GUID output

Some OCP commands are missing a high-order zero in each byte
of the output GUID.

This commit fixes the format specifier for the printf function.

Signed-off-by: Tetsuya TAKAHASHI <tetsuya20.takahashi@kioxia.com>
Signed-off-by: Koki Ueha <koki1.ueha@kioxia.com>
9 months agonvme-print-json: print controller register values in offset order
Francis Pravin [Wed, 25 Sep 2024 04:22:11 +0000 (09:52 +0530)]
nvme-print-json: print controller register values in offset order

Print the Controller Register valuse in order based on the offset.

Signed-off-by: Francis Pravin <francis.p@samsung.com>
9 months agonvme-print-json: print CMBEBS and CMBSWTP in json format
Francis Pravin [Wed, 25 Sep 2024 04:17:31 +0000 (09:47 +0530)]
nvme-print-json: print CMBEBS and CMBSWTP in json format

Print the CMBEBS and CMBSWTP register in json forma

Signed-off-by: Francis Pravin <francis.p@samsung.com>
10 months agonvme-print-stdout: update changed-ns-list-log output
Martin George [Tue, 24 Sep 2024 10:51:48 +0000 (16:21 +0530)]
nvme-print-stdout: update changed-ns-list-log output

The changed-ns-list-log command currently prints nothing for
scenarios where there are no changed ns in the log data. Print a
meaningful message for the same.

Signed-off-by: Martin George <marting@netapp.com>
10 months agonvme: fix uninitialized value in error-log
Martin George [Sun, 22 Sep 2024 18:21:20 +0000 (23:51 +0530)]
nvme: fix uninitialized value in error-log

Valgrind complained about an "uninitialized value created by a
stack allocation" error while running the error-log command.
Fix the same.

Signed-off-by: Martin George <marting@netapp.com>
10 months agonvme: fix to convert metadata size to native byte order
Tokunori Ikegami [Sun, 22 Sep 2024 01:47:40 +0000 (10:47 +0900)]
nvme: fix to convert metadata size to native byte order

The changes for create-ns, compare, read and write commands.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agonvme-print: fix error information log page endianness error
Tokunori Ikegami [Sat, 21 Sep 2024 00:58:42 +0000 (09:58 +0900)]
nvme-print: fix error information log page endianness error

Convert the status and phase tag fields to native byte order at first.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agocompletions: add get-feature command changed option
Tokunori Ikegami [Fri, 20 Sep 2024 16:24:26 +0000 (01:24 +0900)]
completions: add get-feature command changed option

Separeted from the sel option changed value.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agodoc: add get-feature command changed option
Tokunori Ikegami [Fri, 20 Sep 2024 16:22:08 +0000 (01:22 +0900)]
doc: add get-feature command changed option

Separeted from the sel option changed value.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agonvme: separate get NVME_GET_FEATURES_SEL_CHANGED definition
Tokunori Ikegami [Fri, 20 Sep 2024 16:12:12 +0000 (01:12 +0900)]
nvme: separate get NVME_GET_FEATURES_SEL_CHANGED definition

Since it is not defined in the NVMe specification.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agonvme: use NVME_GET_FEATURES_SEL definitions
Tokunori Ikegami [Sun, 15 Sep 2024 06:07:58 +0000 (15:07 +0900)]
nvme: use NVME_GET_FEATURES_SEL definitions

These changes are to replace the hardcoded SEL values.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agonvme-print-stdout: use NVME_CTRL_OAES definitions
Tokunori Ikegami [Fri, 20 Sep 2024 14:54:02 +0000 (23:54 +0900)]
nvme-print-stdout: use NVME_CTRL_OAES definitions

This is to reduce the hard coded value usage.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agocompletion: add ocp set-telemetry-profile to zsh
Leonardo da Cunha [Fri, 20 Sep 2024 07:50:25 +0000 (09:50 +0200)]
completion: add ocp set-telemetry-profile to zsh

The zsh completion is missing the ocp set-telemetry-profile binding.

Signed-off-by: Leonardo da Cunha <leonardo.da.cunha@solidigm.com>
10 months agocompletion: add solidgm work-tracker binding
Leonardo da Cunha [Fri, 20 Sep 2024 07:51:09 +0000 (09:51 +0200)]
completion: add solidgm work-tracker binding

Signed-off-by: Leonardo da Cunha <leonardo.da.cunha@solidigm.com>
10 months agoplugins/solidigm: Added Workload Tracker Triggers and Wall Time
Leonardo da Cunha [Tue, 3 Sep 2024 23:11:47 +0000 (16:11 -0700)]
plugins/solidigm: Added Workload Tracker Triggers and Wall Time

Added Trigger configurations, Stopped converting timestamps to millisec,
added optional property to display wall clock column.

Signed-off-by: Leonardo da Cunha <leonardo.da.cunha@solidigm.com>
10 months agoocp: include util/types.h to use nvme_uint128_t
Tokunori Ikegami [Wed, 18 Sep 2024 15:28:49 +0000 (00:28 +0900)]
ocp: include util/types.h to use nvme_uint128_t

This is to fix nvme_uint128_t functions to work correctly.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agoocp: fix to set log data pointer allocated
Tokunori Ikegami [Wed, 18 Sep 2024 14:36:08 +0000 (23:36 +0900)]
ocp: fix to set log data pointer allocated

Previously the NULL pointer is set incorrectly.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agonvme: use NVME_CHECK() to check get features select field value
Tokunori Ikegami [Sun, 15 Sep 2024 01:45:24 +0000 (10:45 +0900)]
nvme: use NVME_CHECK() to check get features select field value

Use the macro instead of comparing the long filed value definition.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agobuild: bump libnvme wrap
Tokunori Ikegami [Mon, 16 Sep 2024 12:10:29 +0000 (21:10 +0900)]
build: bump libnvme wrap

Include libnvme NVME_CHECK() definition addition.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agoocp: split ocp-hwcomp log
Tokunori Ikegami [Mon, 16 Sep 2024 11:59:30 +0000 (20:59 +0900)]
ocp: split ocp-hwcomp log

This is to reduce the ocp-nvme.c code size.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agocompletions: add ocp hardware-component-log command
Tokunori Ikegami [Sat, 7 Sep 2024 11:22:50 +0000 (20:22 +0900)]
completions: add ocp hardware-component-log command

The command lists component descriptions.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agodoc: add ocp hardware-component-log command
Tokunori Ikegami [Sat, 7 Sep 2024 08:00:35 +0000 (17:00 +0900)]
doc: add ocp hardware-component-log command

The command lists component descriptions.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agoocp: add hwcomp log json output
Tokunori Ikegami [Sun, 1 Sep 2024 08:29:03 +0000 (17:29 +0900)]
ocp: add hwcomp log json output

Add struct hwcomp_desc_entry and fix id option value type error.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agoocp: add hwcomp log command list option
Tokunori Ikegami [Sat, 31 Aug 2024 10:49:59 +0000 (19:49 +0900)]
ocp: add hwcomp log command list option

This is to list component descriptions.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agoocp: add hwcomp log command comp-id option
Tokunori Ikegami [Sat, 31 Aug 2024 07:46:37 +0000 (16:46 +0900)]
ocp: add hwcomp log command comp-id option

This is to filter the component descriptions.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agoocp: add hwcomp dummy definition
Tokunori Ikegami [Sat, 31 Aug 2024 06:50:52 +0000 (15:50 +0900)]
ocp: add hwcomp dummy definition

This is for a debugging.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agoocp: add support for hwcomp log page
Tokunori Ikegami [Mon, 16 Sep 2024 11:57:18 +0000 (20:57 +0900)]
ocp: add support for hwcomp log page

Note: Still json output not supported.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agonvme: use NVME_CTRL_FNA definitions
Tokunori Ikegami [Mon, 16 Sep 2024 06:11:51 +0000 (15:11 +0900)]
nvme: use NVME_CTRL_FNA definitions

Replace the hardcoded values.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agonetapp-smdevices: print single device output too
Martin George [Fri, 13 Sep 2024 17:14:18 +0000 (22:44 +0530)]
netapp-smdevices: print single device output too

In addition to printing info of all smdevices on the host, provide
an option to print the output of the specified device alone.

Signed-off-by: Martin George <marting@netapp.com>
Tested-by: Clayton Skaggs <claytons@netapp.com>
10 months agonetapp-smdevices: segregate print routines
Martin George [Fri, 13 Sep 2024 16:06:37 +0000 (21:36 +0530)]
netapp-smdevices: segregate print routines

Segregate printing the respective normal/column and json outputs
into separate routines for better readability.

Signed-off-by: Martin George <marting@netapp.com>
Tested-by: Clayton Skaggs <claytons@netapp.com>
10 months agoAdd Support for new SN655 PCI Device ID
jeff-lien-wdc [Thu, 12 Sep 2024 20:15:19 +0000 (15:15 -0500)]
Add Support for new SN655 PCI Device ID

Support was added for an additional PCI Device ID (0x2723)
for SN655 drives.

Signed-off-by: jeff-lien-wdc <jeff.lien@wdc.com>
10 months agonvme-print-json: extern json object add functions
Tokunori Ikegami [Mon, 9 Sep 2024 16:08:25 +0000 (01:08 +0900)]
nvme-print-json: extern json object add functions

Some additinal functions introduced and fix obj_add_uint_0nx error.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agoocp: add SMART / health information extended log page version 4
Tokunori Ikegami [Tue, 3 Sep 2024 14:46:01 +0000 (23:46 +0900)]
ocp: add SMART / health information extended log page version 4

Add NVMe command set errata version and lowest permitted firmware revision.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agoocp: add error recovery log page version 3
Tokunori Ikegami [Tue, 3 Sep 2024 17:55:17 +0000 (02:55 +0900)]
ocp: add error recovery log page version 3

Add panic count and previous panic IDs.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agoocp: add get-enable-ieee1667-silo command
Tokunori Ikegami [Sun, 8 Sep 2024 10:00:52 +0000 (19:00 +0900)]
ocp: add get-enable-ieee1667-silo command

The commands returns set of enable IEEE1667 silo.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agofabrics: fix incorrect access filename check
Martin George [Wed, 28 Aug 2024 08:33:55 +0000 (14:03 +0530)]
fabrics: fix incorrect access filename check

Config JSON file handling is currently broken due to an incorrect
access filename check. Fix it.

Signed-off-by: Martin George <marting@netapp.com>
10 months agonvme: use NVME_GET_FEATURES_SEL_SUPPORTED definition
Tokunori Ikegami [Sun, 8 Sep 2024 10:05:56 +0000 (19:05 +0900)]
nvme: use NVME_GET_FEATURES_SEL_SUPPORTED definition

This is to delete the hardcoded values.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agonvme-print-json: use _cleanup_free_
Tokunori Ikegami [Sat, 7 Sep 2024 13:25:59 +0000 (22:25 +0900)]
nvme-print-json: use _cleanup_free_

This is to delete the free function call.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agoplugins/solidigm: fix use after free.
Maurizio Lombardi [Mon, 2 Sep 2024 15:43:03 +0000 (17:43 +0200)]
plugins/solidigm: fix use after free.

the "output" file descriptor is automatically closed when the function
returns; therefore we shouldn't explicitly call close() against it.

Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
10 months agoocp: fix ocp-nvme.c coding style errors
Tokunori Ikegami [Sun, 1 Sep 2024 14:16:13 +0000 (23:16 +0900)]
ocp: fix ocp-nvme.c coding style errors

Only fixed some errors found by the file changes.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agoocp: Change C9 function names to use c9 instead
Tokunori Ikegami [Sun, 1 Sep 2024 14:12:18 +0000 (23:12 +0900)]
ocp: Change C9 function names to use c9 instead

This is to unify c9 and C9 function names.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agoocp: fix to return c9 log page data error to open file
Tokunori Ikegami [Sun, 1 Sep 2024 14:02:58 +0000 (23:02 +0900)]
ocp: fix to return c9 log page data error to open file

Use _cleanup_fd_ function so delete close() call and goto statement.
Also fix some minor coding style errors around the code.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agoocp: fix to set return value to get c9 log page data
Tokunori Ikegami [Sun, 1 Sep 2024 13:50:43 +0000 (22:50 +0900)]
ocp: fix to set return value to get c9 log page data

The value not set but checked the ret variable after the call.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agonvme: update nvme_insert_tls_key_versioned() return handling
Martin George [Sun, 1 Sep 2024 11:51:47 +0000 (17:21 +0530)]
nvme: update nvme_insert_tls_key_versioned() return handling

Treat nvme_insert_tls_key_versioned() return value of zero as
errors too.

Signed-off-by: Martin George <marting@netapp.com>
10 months agonvme-print-stdout: add print_array function
Tokunori Ikegami [Sat, 31 Aug 2024 05:54:16 +0000 (14:54 +0900)]
nvme-print-stdout: add print_array function

To reduce the repeated print code for arrays.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agologging: add print_info function
Tokunori Ikegami [Sat, 31 Aug 2024 06:24:30 +0000 (15:24 +0900)]
logging: add print_info function

This is for debugging print.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
10 months agoutil: extern uint128_t_to_double() function
Tokunori Ikegami [Fri, 30 Aug 2024 18:49:45 +0000 (03:49 +0900)]
util: extern uint128_t_to_double() function

Use the function to calculate with the uint128_t value.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>