nvme-print-stdout: use NVME_MAJOR and NVME_MINOR definitions

Replace hard coded shift and mask values.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-stdout: use FDP configuration attributes definitions

Replace the hard coded shift and mask values in the print function.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

build(deps): bump sand4rt/ftp-deployer from 1.7 to 1.8

Bumps [sand4rt/ftp-deployer](https://github.com/sand4rt/ftp-deployer) from 1.7 to 1.8.
- [Release notes](https://github.com/sand4rt/ftp-deployer/releases)
- [Commits](https://github.com/sand4rt/ftp-deployer/compare/v1.7...v1.8)

---
updated-dependencies:
- dependency-name: sand4rt/ftp-deployer
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

nvme: add new function 'tls_key'

Add a new function 'tls_key' to import and export keys from the
keyring.

Signed-off-by: Hannes Reinecke <hare@suse.de>

build: bump libnvme wrap

To include missing symbol nvme_scan_tls_keys.

Signed-off-by: Hannes Reinecke <hare@suse.de>

nvme: use library functions for importing and exporting TLS keys

As we now have library functions for importing and exporting TLS
keys we should be using them.

Signed-off-by: Hannes Reinecke <hare@suse.de>

nvme: extend error message for ns scan failures

When the scan operation fails, let's also report the error code in order
to help understand why the operation failed.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

nvme-print-json: Bugfix status json key of sanitize-log

There is a history of combining duplicated json keys before.
Fixes: 1d7c092f9dac ("nvme-print-json: Combine duplicated json key and val string variables")
Fixes: 59a0f125cb08 ("nvme-print-json: Delete static const char string global variables")
But there is a local variable with the same name, so the key and value
are the same.

Reviewed-by: Sangkuk Lee <sangkuk0.lee@samsung.com>
Reported-by: Kiryong Kim <kiryong1.kim@samsung.com>
Signed-off-by: Minsik Jeon <hmi.jeon@samsung.com>
Co-authored-by: Steven Seungcheol Lee <sc108.lee@samsung.com>

sed: update SED password when initalizing

The SED key and kernel keyring were not being updated by the
initialization operation. Add password update after the other
initialization tasks are completed.

Signed-off-by: Greg Joyce <gjoyce@linux.ibm.com>

plugins/memblaze: add performance stats

Add performance stats feature

Signed-off-by: jinhua.huang <jinhua.huang@memblaze.com>

plugins/memblaze: fix code mis-type error

Change "flash_error_media_count" to "inflight_write_io_cmd".

Signed-off-by: jinhua.huang <jinhua.huang@memblaze.com>

plugins/memblaze: code refactor on applying __packed on more structs

applying __packed on more structs

Signed-off-by: jinhua.huang <jinhua.huang@memblaze.com>

plugins/memblaze: code refactor on using cleanup_nvme_dev

using cleanup_nvme_dev to open/close device

Signed-off-by: jinhua.huang <jinhua.huang@memblaze.com>

nvme: Fix to cleanup free raw_secret memory allocated

The memory is allocated by the gen-tls-key and check-tls-key commands.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

plugins/memblaze: code-format on leading indent and align

1. Set leading indent to tab
2. Set proper alignment as code len limitation

Signed-off-by: jinhua.huang <jinhua.huang@memblaze.com>

plugins/wdc: Fix narrow index variable type in for loop to __u32

Fix the comparison of narrow type with wide type in loop condition.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

plugins/wdc: Whitespace changes

Delete the loop variable since not changed the value.
Also delete the some variables initial values not necessary.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme: Delete unused nvme root scanned

The mmap registers has been changed to not use the nvme root.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

ocp: support OCP 2.5 Set Telemetry Profile feature

Adds a new OCP plugin function to set the device telemetry profile,
configuring what debug data shall be collected by the device.

Signed-off-by: Brandon Paupore <brandon.paupore@wdc.com>

nvme: Don't seg fault if given device is not char/block device

If the given device name is not char/block device then in
open_dev_direct() set errno to ENODEV and err to -1 before
returning to the dev_fd(). This would then ensure that in
case of error, dev_fd() returns the corerct negative error
code back to its callers. So now the callers of dev_fd()
would handle the error appropriately instead of try
accessing the nvme_dev which would be NULL.

Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
Signed-off-by: Daniel Wagner <dwagner@suse.de>

nbft: Include SSNS index in error messages

In case of complex NBFT tables, multiple messages printed out
start to get confusing. Better to print SSNS indexes for easier
identification in further debugging.

Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>

nbft: Pause logging for expected connection failures

For unavailable SSNSs, pause logging to make connection
attempts truly silent.

Kernel errors are still being logged, e.g.
  nvme nvme8: failed to connect socket: -110

Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>

nbft: Silence connection failures for unavailable SSNS

In case a SSNS is marked as 'unavailable' by the firmware,
let's give it another try but silence any errors.

Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>

nbft: Fix 'verbose' argument type

nvme-cli logging offers multiple levels now.

Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>

plugins/nbft: Implement verbose logging

Useful for debugging the libnvme NBFT parser.
Specify '-vv' for debugging messages.

Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>

plugins/nbft: Print the new SSNS flags

New 'unavailable' and 'discovered' flags.
JSON only for the moment.

Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>

nbft: Fix uninitialized variable

../nbft.c:106:28: warning: variable 'entry' is uninitialized when used here [-Wuninitialized]
  106 |         list_for_each(&nbft_list, entry, node)
      |                                   ^~~~~
../ccan/ccan/list/list.h:524:40: note: expanded from macro 'list_for_each'
  524 |         list_for_each_off(h, i, list_off_var_(i, member))
      |                                               ^
../ccan/ccan/list/list.h:824:21: note: expanded from macro 'list_off_var_'
  824 |         (container_off_var(var, member) +               \
      |                            ^~~
../ccan/ccan/container_of/container_of.h:142:19: note: expanded from macro 'container_off_var'
  142 |         ((const char *)&(var)->member - (const char *)(var))
      |                          ^~~
../ccan/ccan/list/list.h:738:34: note: expanded from macro 'list_for_each_off'
  738 |         list_for_each_off_dir_((h),(i),(off),next)
      |                                         ^~~
../ccan/ccan/list/list.h:693:9: note: expanded from macro 'list_for_each_off_dir_'
  693 |                                    (off));                              \
      |                                     ^~~
../nbft.c:90:31: note: initialize the variable 'entry' to silence this warning
   90 |         struct nbft_file_entry *entry;
      |                                      ^
      |                                       = NULL

Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>

plugins/nbft: Fix uninitialized variables

../plugins/nbft/nbft-plugin.c:328:27: warning: variable 'entry' is uninitialized when used here [-Wuninitialized]
  328 |         list_for_each(nbft_list, entry, node) {
      |                                  ^~~~~
../ccan/ccan/list/list.h:524:40: note: expanded from macro 'list_for_each'
  524 |         list_for_each_off(h, i, list_off_var_(i, member))
      |                                               ^
../ccan/ccan/list/list.h:824:21: note: expanded from macro 'list_off_var_'
  824 |         (container_off_var(var, member) +               \
      |                            ^~~
../ccan/ccan/container_of/container_of.h:142:19: note: expanded from macro 'container_off_var'
  142 |         ((const char *)&(var)->member - (const char *)(var))
      |                          ^~~
../ccan/ccan/list/list.h:738:34: note: expanded from macro 'list_for_each_off'
  738 |         list_for_each_off_dir_((h),(i),(off),next)
      |                                         ^~~
../ccan/ccan/list/list.h:693:9: note: expanded from macro 'list_for_each_off_dir_'
  693 |                                    (off));                              \
      |                                     ^~~
../plugins/nbft/nbft-plugin.c:322:31: note: initialize the variable 'entry' to silence this warning
  322 |         struct nbft_file_entry *entry;
      |                                      ^
      |                                       = NULL

../plugins/nbft/nbft-plugin.c:515:27: warning: variable 'entry' is uninitialized when used here [-Wuninitialized]
  515 |         list_for_each(nbft_list, entry, node) {
      |                                  ^~~~~
../ccan/ccan/list/list.h:524:40: note: expanded from macro 'list_for_each'
  524 |         list_for_each_off(h, i, list_off_var_(i, member))
      |                                               ^
../ccan/ccan/list/list.h:824:21: note: expanded from macro 'list_off_var_'
  824 |         (container_off_var(var, member) +               \
      |                            ^~~
../ccan/ccan/container_of/container_of.h:142:19: note: expanded from macro 'container_off_var'
  142 |         ((const char *)&(var)->member - (const char *)(var))
      |                          ^~~
../ccan/ccan/list/list.h:738:34: note: expanded from macro 'list_for_each_off'
  738 |         list_for_each_off_dir_((h),(i),(off),next)
      |                                         ^~~
../ccan/ccan/list/list.h:693:9: note: expanded from macro 'list_for_each_off_dir_'
  693 |                                    (off));                              \
      |                                     ^~~
../plugins/nbft/nbft-plugin.c:513:31: note: initialize the variable 'entry' to silence this warning
  513 |         struct nbft_file_entry *entry;
      |                                      ^
      |                                       = NULL

Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>

plugins/sed: Fix uninitialized variable

../plugins/sed/sedopal_cmd.c: In function ‘sedopal_cmd_discover’:
../plugins/sed/sedopal_cmd.c:506:17: warning: ‘locking_flags’ may be used uninitialized [-Wmaybe-uninitialized]
  506 |                 sedopal_print_locking_features(locking_flags);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../plugins/sed/sedopal_cmd.c:459:17: note: ‘locking_flags’ was declared here
  459 |         uint8_t locking_flags;
      |                 ^~~~~~~~~~~~~

Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>

nvme-print-stdout: Fix uninitialized variable

../nvme-print-stdout.c:3796:22: warning: variable 'node' is uninitialized when used here [-Wuninitialized]
 3796 |         list_for_each(list, node, node) {
      |                             ^~~~
../ccan/ccan/list/list.h:524:40: note: expanded from macro 'list_for_each'
  524 |         list_for_each_off(h, i, list_off_var_(i, member))
      |                                               ^
../ccan/ccan/list/list.h:824:21: note: expanded from macro 'list_off_var_'
  824 |         (container_off_var(var, member) +               \
      |                            ^~~
../ccan/ccan/container_of/container_of.h:142:19: note: expanded from macro 'container_off_var'
  142 |         ((const char *)&(var)->member - (const char *)(var))
      |                          ^~~
../ccan/ccan/list/list.h:738:34: note: expanded from macro 'list_for_each_off'
  738 |         list_for_each_off_dir_((h),(i),(off),next)
      |                                         ^~~
../ccan/ccan/list/list.h:693:9: note: expanded from macro 'list_for_each_off_dir_'
  693 |                                    (off));                              \
      |                                     ^~~
../nvme-print-stdout.c:3794:31: note: initialize the variable 'node' to silence this warning
 3794 |         nvme_effects_log_node_t *node;
      |                                      ^
      |                                       = NULL

Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>

nvme-print-json: Fix uninitialized variable

../nvme-print-json.c:1340:22: warning: variable 'node' is uninitialized when used here [-Wuninitialized]
 1340 |         list_for_each(list, node, node) {
      |                             ^~~~
../ccan/ccan/list/list.h:524:40: note: expanded from macro 'list_for_each'
  524 |         list_for_each_off(h, i, list_off_var_(i, member))
      |                                               ^
../ccan/ccan/list/list.h:824:21: note: expanded from macro 'list_off_var_'
  824 |         (container_off_var(var, member) +               \
      |                            ^~~
../ccan/ccan/container_of/container_of.h:142:19: note: expanded from macro 'container_off_var'
  142 |         ((const char *)&(var)->member - (const char *)(var))
      |                          ^~~
../ccan/ccan/list/list.h:738:34: note: expanded from macro 'list_for_each_off'
  738 |         list_for_each_off_dir_((h),(i),(off),next)
      |                                         ^~~
../ccan/ccan/list/list.h:693:9: note: expanded from macro 'list_for_each_off_dir_'
  693 |                                    (off));                              \
      |                                     ^~~
../nvme-print-json.c:1338:31: note: initialize the variable 'node' to silence this warning
 1338 |         nvme_effects_log_node_t *node;
      |                                      ^
      |                                       = NULL

Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>

build: Switch default meson buildtype to 'debugoptimized'

The meson 'debug' buildtype defaults to '-O0 -g' which misses
some important compiler warnings (as of gcc-13). While there's
no universal solution, the 'debugoptimized' buildtype supplies
'-O2 -g' that appears to be a reasonable compromise for having
important compiler warnings by default.

Either way, the specified warning_level=1 always supplies
'-Wall' that is unfortunately not enough with '-O0'.

Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>

nvme: do not scan topology when mmaping registers

For accessing the registers we don't need to scan the topology. With the
device name we already know where to lookup the resource0 file in sysfs.

We also don't need to do the fallback lookup via the namespaces because
Linux kernel v4.0 has introduced the link in /sys/class/nvme/nvme%d. And
nvme-cli 2.x depends on Linux kernel >= 4.15, so it's safe to drop the
fallback.

This avoids all the topology scanning which is excessive and also might
issue an 'id command' via the nuse sysfs entry. So let's not do it.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

nvme-print-stdout: Use NVME_BOOT_PARTITION_INFO field definitions

Change it instead of hardcoded field mask and shift values.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-stdout: Use NVME_GET for MI commands supported and effects CSP

Use it with NVME_MI_CMD_SUPPORTED_EFFECTS register definitions existed.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-stdout: Use NVME_GET for FID supported and effects FSP

Use it with NVME_FID_SUPPORTED_EFFECTS register definitions existed.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-stdout: Use NVME_SET_FEAT_EVENT register definitions

Change it instead of hardcoded register mask and shift values.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print: Add PEL EHAI port identifier type printf function

Change to use NVME_PEL_EHAI_PIT definitions.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

build: bump libnvme wrap

Include latest libnvme changes.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ocp: fix for power-state argument checking

Noticed this as part of supporting set-telemetry-profile, it seems that
the power-state option is not being detected properly. With this fix the
function is able to enter set_dssd_power_state when given the option or
its alias.

Signed-off-by: Brandon Paupore <brandon.paupore@wdc.com>

nvme: do not issue warning when nvme_core module is not loaded

nvme 1.x did not issue an warning when the nvme_core module was not
loaded. Make 2.x behave in the same way.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

wdc: Review changes and build fixes

Changes based on review comments.
Fixed build errors building timestamp string.
Fixed lines over the 100 char limit.

Signed-off-by: jeff-lien-wdc <jeff.lien@wdc.com>

wdc:  Fix timestamp displayed by vs-firmware-activate-history command

The actual timestamp value is in bytes 0:5 of the 8 byte field.
The code was using all 8 bytes so a change was made to mask off
the top 2 bytes.  The timestamp calculations were also simplified
to be more maintainable.

Signed-off-by: jeff-lien-wdc <jeff.lien@wdc.com>

logging: Split to output ioctl latency by log info level

This is for only output latency but not output other debugging info.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-stdout: Change hexadecimal value 0x prefix to use %#x

Also channge 64bit value to use  %#"PRIx64" instead of 0x%"PRIx64".

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-stdout: Fix LBA status DSLBA output as hexadecimal

The output printed with the 0x prefix but as not hexadecimal.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-stdout: Split line length exceeded 100 columns

This resolves checkpatch line length exceeding warning.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-stdout: Use NVME_PMRMSC register definitions to print

Change it instead of hardcoded register mask and shift values.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-stdout: Use NVME_PMRSWTP register definitions to print

Change it instead of hardcoded register mask and shift values.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-stdout: Use NVME_PMREBS register definitions to print

Change it instead of hardcoded register mask and shift values.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-stdout: Use NVME_PMRSTS register definitions to print

Change it instead of hardcoded register mask and shift values.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-stdout: Use NVME_PMRCTL_EN register definition to print

Change it instead of hardcoded register mask value.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-stdout: Use NVME_PMRCAP register definition to print

Change it instead of hardcoded register mask and shift values.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

doc: Fix admin and io passthru cdw parameters description

Fixes: 2f31c7905558 ("doc: Documentations maintenance changes")
Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

doc: Add get-feature cdw11 and set-feature cdw12 parameters

Those implemented but missed to described by the documentations.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

micron-nvme: Unuse stat() to check if strMainDirName exists

It is checked by mkdir errno EEXIST instead.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

doc: Fix get-property and set-property offset and value descriptions

Those parameters need the <offset> and <val> parameters values.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

doc: Fix documentation file mode 100755 to 100644

Only the get-property and set-property commands fixed errors.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-stdout: Fix channel configuration descriptors pointer

Set the address after NVM set EGSETS - 1 identifier parameter.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-stdout: Check sscanf return value

To fix linux kernel check patch error.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-stdout: Fix linux kernel check patch errors

Note: The long line string and strncpy() warnings are not fixed.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme: Delete unusual fallthrough for cases have no body

All the cases listed adjacently and use only for cases have any body.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme: Delete duplicated semicolon

Fix for the checkpatch.pl error.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print, common: Fix for whitespace change

Fix to change space characters for indentation to tab characters.
Delete a space between cast parentheses and variable.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

logging: output ioctl debugging info

Instead pushing insane logging infra code into the library, let's keep
this stuff in the frontend. This is done by providing our own version
of the low level ioctl function as the library is exposing this as weak
symbol. This allows us to print the passthru structures and also the
timing information.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

nvme: track verbose level

The command line option parser is able to count how many times 'verbose'
is provided by the user. This increases the verbosity level. Use this
for mapping it to the correct log_level.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

logging: track log level globally

Preparation patch to enable verbose/debug logging in parts where we
don't have the nvme_root_t object introduce a global logging level
variable.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

logging: move logging code to a new file

In preparation to extend the logging use case move the existing code to
a new location.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

nvme: update include for libnvme

This header file is not a local header file, it's the main header from
libnvme. Thus use the correct include statement.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

nvme: remove unused declaration

There is no user for current_index, thus remove it

Signed-off-by: Daniel Wagner <dwagner@suse.de>

build: bump libnvme wrap

Fetch the new low level passthru functions.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

nvme-netapp: add nspath tlv handling

Add nspath tlv handling logic to the NetApp plugin.

Signed-off-by: Martin George <marting@netapp.com>

rpm: Add missing rule and service files

Rule and service were added previously.
But rule and service files were not added the spec file.
So add missing rule and service files.

make rpm result:
Installed (but unpackaged) file(s) found:
/usr/local/lib/systemd/system/nvmf-connect-nbft.service
/usr/local/lib/udev/rules.d/65-persistent-net-nbft.rules

Signed-off-by: Minsik Jeon <hmi.jeon@samsung.com>
Co-authored-by: Ra See <tkwpvk789@gmail.com>

nvme-print-json, nvme-print-stdout: Use CHAR_BIT definition

Instead of the hardcoded value use the macro definition.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-stdout: Delete duplicated if condition checking line

nvme_pel_event_to_string() checked twice in stdout_add_bitmap().

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

ocp: Fix timestamp displayed by fw-activate-history command

The current code is displaying all 8 bytes of the timestamp
field for the timestamp.  The timestamp value is only in
the first 6 bytes. The 7th byte contains the origin and
synch fields and the 8th byte is reserved.

Signed-off-by: jeff-lien-wdc <jeff.lien@wdc.com>

wdc: Add support for the get-drive-status command to SN861

This change will use UUID lists to access the WD C2 log
page and retrieve the correct info needed to display the
drive status.

Signed-off-by: jeff-lien-wdc <jeff.lien@wdc.com>

nvme-print: Fix nvme_host_metadata_type_to_string() indentation errors

Change white space indentations to use tab spaces.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print: Add PEL RCI port identifier type printf function

Change to use NVME_PEL_RCI_RCPIT definitions.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-stdout: Use persistent event log RCI definitions

Change the hardcoded the register bit shift to use the definitions.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

build: bump libnvme wrap

Include PEL changes.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

nvme: Add show-regs and get-property commands NSSD print outputs

Output the NVM Subsystem Shutdown property.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print: print more details in ns-descs verbose output

Print additional details such as loc, nidt, nidl & type in the
ns-descs verbose output for parity with the corresponding
json output.

Signed-off-by: Martin George <marting@netapp.com>

Revert "nvme-print-json: remove obj_print helper"

This reverts commit b854cbda04a19b7dcfcbeb569146cf9ab79fd5f3.

The helper function is used the json_r is set by json_show_init()
then the function does not print but it is done by json_show_finish()
instead. The get-feature command using nvme_show_init() and
nvme_show_finish() those call json_show_init() and json_show_init()
json print functions so the command json output does not work correctly
currently.

Also the init and finish functions will be used by the PR #2188 get-reg
command also. (The issue found by the implementation working.)

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

sed: Confirm entered password before initialization.

Ask for password twice in case there is a typo in entering it.

Signed-off-by: Greg Joyce <gjoyce@linux.ibm.com>

doc: Regenerate all docs for v2.8

Signed-off-by: Daniel Wagner <dwagner@suse.de>

build: Update version to v2.8

Signed-off-by: Daniel Wagner <dwagner@suse.de>

build: bump libnvme version

Update to latest version, v1.8.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

nvme-print-json: append array object in json_support_log

The valid object is of type array not obj, thus use obj_add_array to add
it to the root.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

sed: Add plugin for basic SED Opal operations

A new plugin 'sed' is developed to provide basic SED Opal CLI
operations. These include:
        discover        Discover drive locking features
        intialize       Initialize a drive for SED Opal
        password        Change the authorization key
        revert          Revert drive to SED Opal disabled
        lock            Lock a SED Opal drive
        unlock          Unlock a SED Opal drive

Signed-off-by: Greg Joyce <gjoyce@linux.ibm.com>

don't include newlines in already wrapped text

The descriptions are already line wrapped as appropriate. Don't insert
random newline characters in inappropriate places. It just makes the
output look rediculous.

Signed-off-by: Keith Busch <kbusch@kernel.org>

nvme: do not include meta data for PRACT=1 and MD=8 (version 2)

No meta data is transferred for PRACT=1 and MD=8:
  5.2.2.1 Protection Information and Write Commands
  5.2.2.2 Protection Informatio and Read Commands

commit 8dcac74470ec (nvme: do not include meta data for PRACT=1 and MD=8)
the condition in if sentence is wrong, mixed up pract with prinfo.

Signed-off-by: Bean Li <libin@dapustor.com>

build(deps): bump codecov/codecov-action from 3 to 4

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/codecov/codecov-action/compare/v3...v4)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

create-ns: align the namespaces to 1Mib boundaries when using SI suffixes

Some controllers refuse to create namespaces with a size not aligned to
a 1 MiB boundary, this happens when using the -S and -C options.

$ nvme create-ns /dev/nvme0 -S 80M -C 80M -f 0
NVMe status: Invalid Field in Command: A reserved coded value or
an unsupported value in a defined field(0x2)

Fix this problem by modifying create_ns() parse_lba_num_si() to align
the values to 1 MiB boundaries. If granularity is supported, we will
use the specified values, if they are smaller than 1 MiB.

Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>

doc: Fix config-schema.json's URL

The old URL returns 404.

Signed-off-by: Felix Yan <felixonmars@archlinux.org>

plugins/solidigm: Compressing vs-internal-log log files into zip file.

Creates zip file containing files useful to debug.

Signed-off-by: Leonardo da Cunha <leonardo.da.cunha@solidigm.com>

nbft: do not issue an error if ACPI tables are missing

Not all architectures have ACPI tables, e.g. riscv64. Thus the nbft code
should fail gracefully if it's not present.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

nbft: fixup include for libnvme

libnvme.h is from an external source, so use the correct include
grammar.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

doc: Fix short option name for cfg-file

It was renamed to "-J" but some docs were left out.

Fixes: 0571307d3af0 ("nvme-connect: Add 'dhchap-secret' and 'dhchap-ctrl-secret' arguments")
Signed-off-by: Felix Yan <felixonmars@archlinux.org>
[dwagner: updated some more outdated references
Signed-off-by: Daniel Wagner <dwagner@suse.de>

completions: added Solidigm plugin to autocomplete scripts

Updated both bash and zsh autocomplete scripts
Fixed copy-paste error under ocp section of zsh script

Signed-off-by: Anant Mashiana <anant.mashiana@solidigm.com>