]> www.infradead.org Git - users/dedekind/aiaiai.git/log
users/dedekind/aiaiai.git
11 years agotest-bisectability: restructure the code a little bit
Artem Bityutskiy [Wed, 4 Dec 2013 12:23:10 +0000 (14:23 +0200)]
test-bisectability: restructure the code a little bit

This commit does not do any functional changing, just some re-structuring and
renaming as a preparation to the next change.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agoImprove help output
Artem Bityutskiy [Wed, 4 Dec 2013 09:43:18 +0000 (11:43 +0200)]
Improve help output

This is a cosmetic patch. It changes globally:

s/working directory/work directory/

And it fixes the bogus 'aiaiai-diff-log' help output.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agodiff-log-helper: group lines starting with "make:"
Artem Bityutskiy [Wed, 4 Dec 2013 09:38:26 +0000 (11:38 +0200)]
diff-log-helper: group lines starting with "make:"

Thie makes the diff look a tiny bit nice when there is a build failure.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agobisectability: don't fail if base commit can't compile
Jacob Keller [Mon, 25 Nov 2013 18:57:03 +0000 (10:57 -0800)]
bisectability: don't fail if base commit can't compile

This makes the bisectability test only fail when it can't compile
inbetween a patch series. It is perfectly reasonable that the first
patch in the series could fix the compile issue, so we should still
check the patch for bisection issues.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agotest-patchset: improve build failure output
Artem Bityutskiy [Wed, 4 Dec 2013 07:33:10 +0000 (09:33 +0200)]
test-patchset: improve build failure output

The previous patch made it acceptable for the base commit to fail. However, the
e-mail message we generate in this case contained something like:

"Failed to build the following commit for configuration ..."

which is not too readable, because it does not make it clear that this is the
base commit which fails to compile.

This patch improves the output and makes it look like this:

"Failed to build base commit ..."

This is just a bit nicer.

Additionally, when the base commit fails, and the first patch fixes it, the
resulting build diff is rather messy. This patch makes aiaiai-test-patchset
print a short explanation for the messy build diff.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agotest-patchset: don't skip email when pre-patch build fails
Jacob Keller [Mon, 25 Nov 2013 18:56:37 +0000 (10:56 -0800)]
test-patchset: don't skip email when pre-patch build fails

Currently, whenever the pre-patched kernel fails to build, we
don't show the results for the post-patched kernel. This is faulty,
because we could easily be providing a patch which fixes the issue.
Instead, we should show the results for the failed build, but still
continue. If the post-patched kernel fails to build there is little need
to show a complex diff, but we can at least show the results for both
the pre-patched and post-patched kernel.

This patch also additionally adds --keep-going to the pre-patched kernel
in order to obtain more data for comparison.

Artem: add a commentary

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agotest-patchset: add a perl check
Artem Bityutskiy [Tue, 3 Dec 2013 13:30:06 +0000 (15:30 +0200)]
test-patchset: add a perl check

Check that the perl interpreter is available.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agoUse a helper for the 'fatal()' function
Artem Bityutskiy [Mon, 2 Dec 2013 12:14:04 +0000 (14:14 +0200)]
Use a helper for the 'fatal()' function

Unfortunately libshell's "fatal()" does not prefix messages with an "Error"
prefix. Introduce a new helper called "die()" which prepends messages with
"Fatal error".

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agosh-functions: protect from double inclusion
Artem Bityutskiy [Mon, 2 Dec 2013 12:10:34 +0000 (14:10 +0200)]
sh-functions: protect from double inclusion

Add simple protection against double inclusion of the shared sh files.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agoemail-lda: honor 'always_cc' and 'reply_to_all'
Artem Bityutskiy [Mon, 2 Dec 2013 08:56:31 +0000 (10:56 +0200)]
email-lda: honor 'always_cc' and 'reply_to_all'

When rejecting a patch we should try to honor the 'always_cc' and
'reply_to_all' per-project configuration variables. This patch does exactly
that - parses the 'To' and 'Cc' list, finds out which project the e-mail
belongs to, parses the config file and CCes the 'always_cc' list, as well as
preserves the 'To' and 'Cc' addresses if 'reply_to_all' is true.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agoemail-lda: send a reply when chaining was incorrect
Artem Bityutskiy [Mon, 2 Dec 2013 08:28:01 +0000 (10:28 +0200)]
email-lda: send a reply when chaining was incorrect

This patch is based on Jacob Keller's work. It teaches the aiaiai-email-lda
script sending rejection notifications to the patch submitter. Right now it
only sends a reply when the submitter missed the 'In-Reply-To:' e-mail header.
Later more conditions may be added.

At the moment we do not CC the 'always_cc' list, neither honor the
'reply_to_all' flag. This may be changed later, if needed.

I've added several 'program_required's too, I was too lazy to separate them,
again, sorry.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agoemail-lda: introduce --test-mode option
Artem Bityutskiy [Mon, 2 Dec 2013 08:00:31 +0000 (10:00 +0200)]
email-lda: introduce --test-mode option

We are going to teach this script sending replies, and this option will disable
the functionality, just like in the aiaia-email-test-patchset script. This
patch is just a preparation.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agoemail-lda: start parsing the configuration file
Artem Bityutskiy [Fri, 29 Nov 2013 16:49:19 +0000 (18:49 +0200)]
email-lda: start parsing the configuration file

This is a preparation for the further changes where we teach the email-lda
script sending notifications when it rejects a patch. We'll need to know some
basic information like own e-mail address, and this is stored in the config
file. So parse it.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agoemail-sh-functions: rework e-mail sending some more
Artem Bityutskiy [Fri, 29 Nov 2013 16:43:28 +0000 (18:43 +0200)]
email-sh-functions: rework e-mail sending some more

Leave only the email composition stuff in the common code, and move the e-mail
sending stuff to email-test-patchset. This way the common code does not depend
on the "verbose" and "test_mode" variables anymore, which is a bit cleaner.

Plus add an explicit check that mutt is present.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agoemail-sh-functions: misc improvements
Artem Bityutskiy [Fri, 29 Nov 2013 14:46:17 +0000 (16:46 +0200)]
email-sh-functions: misc improvements

This is a huge patch and it should really be split. But I am being lazy and
committing all at once. Yes, this is bad, sorry, but I am trying to save time.

Anyway, this patch does 2 big changes:

1. Improves the strip_address function so that it does not anymore depend on
   any global 'cfg_*' variables and gets the e-mail address to strip as a
   parameter.

2. Simplifies the 'compose_email' function interface and teach it to get a
   single list of addresses to CC. This required some an additional function
   for merging 2 lists of e-mails. But the end result is that
   email-test-patchset becomes simpler.

I have tested this patch.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agoaiaiai-checker: used printf for printing uncontrolled data
Artem Bityutskiy [Fri, 29 Nov 2013 15:34:35 +0000 (17:34 +0200)]
aiaiai-checker: used printf for printing uncontrolled data

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agoemail-test-patchset: move compose_email to email-sh-functions
Artem Bityutskiy [Fri, 29 Nov 2013 13:05:49 +0000 (15:05 +0200)]
email-test-patchset: move compose_email to email-sh-functions

Move the 'compose_email' function to the shared file so that it could be used
by other scripts.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agoemail-test-patchset: move config handling to email-sh-functions
Artem Bityutskiy [Fri, 29 Nov 2013 11:04:03 +0000 (13:04 +0200)]
email-test-patchset: move config handling to email-sh-functions

We are going to need configuration file parsing functions in the email-lda
script, so move them to the shared file.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agoemail.cfg: refine the configuration file example
Artem Bityutskiy [Fri, 29 Nov 2013 11:04:03 +0000 (13:04 +0200)]
email.cfg: refine the configuration file example

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agoemail-test-patchset: move ini_config_get_or_die
Artem Bityutskiy [Thu, 28 Nov 2013 15:38:51 +0000 (17:38 +0200)]
email-test-patchset: move ini_config_get_or_die

Move the ini_config_get_or_die helper function to the aiaiai-email-sh-functions
file, since it will be used by other components as well soon.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agoemail-sh-function: new file for shared e-mail code
Artem Bityutskiy [Thu, 28 Nov 2013 12:44:53 +0000 (14:44 +0200)]
email-sh-function: new file for shared e-mail code

Let's have a separate file for the shared code which is only relevant to
e-mail handling. For now we only have the subject parsing there, but we'll add
more stuff to this file later.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agoemail-test-patchset: fix breakage introduced recently
Artem Bityutskiy [Thu, 28 Nov 2013 15:12:15 +0000 (17:12 +0200)]
email-test-patchset: fix breakage introduced recently

Commit '07837a6 email-test-patchset: add cppcheck support' introduced a
breakage by adding an unexisting variable named "commit", which causes the
following error:

aiaiai-email-test-patchset: line 334: commit: unbound variable

The variable should be named 'branch'. This patch fixes the problem.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agoemail-dispatcher: verify that inotifywait is present in the system
Artem Bityutskiy [Thu, 28 Nov 2013 15:01:42 +0000 (17:01 +0200)]
email-dispatcher: verify that inotifywait is present in the system

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agodoc: document e-mail setup some more
Artem Bityutskiy [Thu, 28 Nov 2013 14:21:13 +0000 (16:21 +0200)]
doc: document e-mail setup some more

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agolda: amend forgotten fetch_header_or_die call
Artem Bityutskiy [Thu, 28 Nov 2013 12:50:28 +0000 (14:50 +0200)]
lda: amend forgotten fetch_header_or_die call

We changed the interface for the 'fetch_header_or_die()' function, but forgot
to amend one place in aiaia-email-lda. Fix this.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agosh-functions: use ? instead of {0,1}
Artem Bityutskiy [Thu, 28 Nov 2013 08:32:35 +0000 (10:32 +0200)]
sh-functions: use ? instead of {0,1}

... since the former is shorter.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agosh-functions: change subject parsing
Artem Bityutskiy [Wed, 27 Nov 2013 13:30:19 +0000 (15:30 +0200)]
sh-functions: change subject parsing

This patch change subject parsing so that it would allow a prefix before the
PATCH keyword: [Prefix PATCH Suffix m/n], as Jacob Keller requested.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agosh-functions: rename __prfx to __blah
Artem Bityutskiy [Wed, 27 Nov 2013 13:00:24 +0000 (15:00 +0200)]
sh-functions: rename __prfx to __blah

I am going to add support for [Prefix PATCH Suffix n/n] subject, so
the prefix word would be needed, and thus in this patch I use word
"blah" for the [blah] prefixes.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agosh-funcions: introduce another helper variable - __blank
Artem Bityutskiy [Wed, 27 Nov 2013 12:58:43 +0000 (14:58 +0200)]
sh-funcions: introduce another helper variable - __blank

Introduce a helper variable for a single blank, which is supposed to make
the code a bit more readable.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agosh-function: rename __ws to __blanks
Artem Bityutskiy [Wed, 27 Nov 2013 12:46:22 +0000 (14:46 +0200)]
sh-function: rename __ws to __blanks

The internal __ws variable is a short-cut for "zero or reasonable amount of
white-space or tab characters". This patch renames it to "__blanks", which
is a bit more readable. Additionally I make the reasonable amount to be 8
blanks instead of 4.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agoemail-lda: use case insensitive match when searching for reply headers
Jacob Keller [Mon, 25 Nov 2013 18:56:47 +0000 (10:56 -0800)]
email-lda: use case insensitive match when searching for reply headers

This patch helps make aiaiai a bit more robust by using case insensitive
search for the in-reply-to header searches.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agotest-subj-parsing: add a test for subject parsing
Artem Bityutskiy [Wed, 27 Nov 2013 11:41:28 +0000 (13:41 +0200)]
test-subj-parsing: add a test for subject parsing

Add a test which verifies that e-mails subject parsing works as expected.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agosh-functions: refine the 'prefix_format' variable
Artem Bityutskiy [Wed, 27 Nov 2013 11:42:21 +0000 (13:42 +0200)]
sh-functions: refine the 'prefix_format' variable

First of all, the whole subject parsing thing belongs to the e-mail stuff, so
it really should be moved to the email sub-directory.

The 'prefix_format' is a variable which is supposed to explain in a short form
what is the format of the subject we expect. Currently we have a confusing
<project> part there, and this patch removes it. I do not think the result is
ideal, since it does not tell that the format is rather flexible, but still
it is a bit better. Later we can change this to something better.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agosh-functions: fix print_separator
Jacob Keller [Tue, 26 Nov 2013 22:35:06 +0000 (14:35 -0800)]
sh-functions: fix print_separator

print_separator needs to be run as a subshell, because we need its output, not
the string itself. This fixes a print display bug where we show
"print_separator" instead of the actual separator.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agoaiaiai: don't assume kernel tree will be checked out
Jacob Keller [Tue, 26 Nov 2013 20:02:17 +0000 (12:02 -0800)]
aiaiai: don't assume kernel tree will be checked out

This change addresses a possible issue if someone uses a bare repsitory
as their remote. We handle this by using a new sh-function git_dir()
which will return $path/.git if that is a directly, then path if that is
a directory, or will complain if it's not a valid directory. This
enables us to automatically use the correct directory without issue even
if the repository is bare.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agoemail: fix ini_config_get_or_die
Artem Bityutskiy [Tue, 26 Nov 2013 17:03:33 +0000 (19:03 +0200)]
email: fix ini_config_get_or_die

Similarly to what we did in the previous patch, change ini_config_get_or_die
interface so that the caller would not have to call it in a subshell, which
makes dying impossible.

I did not dest this patch.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agoFix fetch_header_or_die
Artem Bityutskiy [Tue, 26 Nov 2013 16:52:44 +0000 (18:52 +0200)]
Fix fetch_header_or_die

The fetch_header_or_die function is suppoed to make the caller exit if the
header is not found. However, this did not happen, because the interface of
this function assumed that it is called in a subshell in order to intercept the
results. And the exiting happened in the subshell, which did not affect the
caller at all.

Fix this issue by changing the interface of fetch_header_or_die() so that the
result is written to the first parameter.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agoRevert "aiaiai: make formail allow non-strict mbox format"
Artem Bityutskiy [Tue, 26 Nov 2013 15:53:17 +0000 (17:53 +0200)]
Revert "aiaiai: make formail allow non-strict mbox format"

Unfortunately, -d makes formail split patches at unexpected places.

This reverts commit bdbd0321b40c10a51f4f084809eb26c91dcd4729.

11 years agotest-patchset: check that defconfig exists
Artem Bityutskiy [Tue, 26 Nov 2013 15:23:33 +0000 (17:23 +0200)]
test-patchset: check that defconfig exists

Make sure the defconfig exists before we start building with it.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agodoc: smatch does not install own sparse anymore
Artem Bityutskiy [Tue, 26 Nov 2013 14:24:10 +0000 (16:24 +0200)]
doc: smatch does not install own sparse anymore

... well, actually it does, but it calls it "sparsec".

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agodoc: tell that aiaiai needs the 'patch' tool
Artem Bityutskiy [Tue, 26 Nov 2013 13:03:54 +0000 (15:03 +0200)]
doc: tell that aiaiai needs the 'patch' tool

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agobisectability: fixup comment in compile_test
Jacob Keller [Mon, 25 Nov 2013 18:56:57 +0000 (10:56 -0800)]
bisectability: fixup comment in compile_test

We aren't testing the base commit here, we are patching the kernel and
testing the particular commit.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agotest-patchset: ignore sign-off for the combined patch
Jacob Keller [Mon, 25 Nov 2013 18:56:30 +0000 (10:56 -0800)]
test-patchset: ignore sign-off for the combined patch

We only need to check the sign-off on the individual patches, rather
than on the combined patch, as this patch is created only for our
internal use.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agosh-functions: show merge results when patch fails to apply
Jacob Keller [Mon, 25 Nov 2013 18:56:25 +0000 (10:56 -0800)]
sh-functions: show merge results when patch fails to apply

This patch enables the email notification an attempt at showing you the
result of a merge based on the patch utility. This might enable more
easily debugging why a patch failed to apply.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agoaiaiai: make formail allow non-strict mbox format
Jacob Keller [Mon, 25 Nov 2013 18:56:15 +0000 (10:56 -0800)]
aiaiai: make formail allow non-strict mbox format

Sometimes patches are not properly emailed in strict mbox format. This
can result in some bogus issues, which are simply automatically resolved
by just working in non-strict mbox format. This patch makes sure all
executions of formail accept non-strict formats.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agoemail-test-patchset: add cppcheck support
Jacob Keller [Mon, 25 Nov 2013 18:56:02 +0000 (10:56 -0800)]
email-test-patchset: add cppcheck support

The aiaiai-email-test-patchset script did not have a cppcheck option,
even though the lower level aiaiai-test-patchset supports this. Add the
option along with the other check options.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agoemail-test-patchset: allow a configuration directory
Jacob Keller [Mon, 25 Nov 2013 18:55:57 +0000 (10:55 -0800)]
email-test-patchset: allow a configuration directory

The aiaiai-test-patchset has a configuration directory option, but the
aiaiai-email-test-patchset does not have this option. Update the
email-test-patchset script to support passing this option onto the lower
level aiaiai-test-patchset script.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agomake-kernel: add parameter to enable endian checking
Jacob Keller [Mon, 25 Nov 2013 18:55:52 +0000 (10:55 -0800)]
make-kernel: add parameter to enable endian checking

Endian checking is not turned on by default, and requires a separate
parameter in order to enable it. As it can be quite useful to have, this
patch adds the proper syntax to enable it when the kernel checker is
enabled.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agochecker: use -Wsparse-all to enable more checks
Jacob Keller [Mon, 25 Nov 2013 18:55:47 +0000 (10:55 -0800)]
checker: use -Wsparse-all to enable more checks

sparse does not have all of its warnings on by default. This patch
enables some extra checks which were not being done before.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agosh-functions: rename fetch_all_headers
Jacob Keller [Mon, 25 Nov 2013 18:55:40 +0000 (10:55 -0800)]
sh-functions: rename fetch_all_headers

The fetch_all_headers name is not descriptive, as it actually splits the
mailbox up and processes the first header of each message. It does not
obtain every copy of a given header from the mbox. This patch renames
the function, and updates the comment so that it is clear what the
function does.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agoaiaiai: use --shared since we know we will be safe
Jacob Keller [Mon, 25 Nov 2013 18:55:35 +0000 (10:55 -0800)]
aiaiai: use --shared since we know we will be safe

We want to use a shared clone here, because it will prevent duplicate copies
of all the object data, and we know it will be ok, since we won't be mucking
with the tree, and the commits will be tagged.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agomake-kernel: fix --keep-going option
Jacob Keller [Mon, 25 Nov 2013 18:55:30 +0000 (10:55 -0800)]
make-kernel: fix --keep-going option

The make-kernel utility has an option "--keep-going" which can be useful
if you want to continue testing past kernel build failures, in order to try
and find as many issues as you can. However, it previously did not work,
as getopt-long format required a parameter, and the case statement did
not check for the correct long syntax.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agoemail-test-patchset: always_cc is not required
Jacob Keller [Mon, 25 Nov 2013 18:55:25 +0000 (10:55 -0800)]
email-test-patchset: always_cc is not required

We do not require always_cc, so we should not die when it is not
available.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agococcinelle: sync scripts with 3.13-rc1
Artem Bityutskiy [Tue, 26 Nov 2013 08:51:20 +0000 (10:51 +0200)]
coccinelle: sync scripts with 3.13-rc1

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agocheckpatch.pl: update from 3.13-rc1
Artem Bityutskiy [Tue, 26 Nov 2013 08:49:43 +0000 (10:49 +0200)]
checkpatch.pl: update from 3.13-rc1

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agocheckpatch.pl: update from 3.12-rc7
Artem Bityutskiy [Tue, 29 Oct 2013 09:25:58 +0000 (11:25 +0200)]
checkpatch.pl: update from 3.12-rc7

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agoUpdate checkpatch.pl
Phil Carmody [Thu, 1 Aug 2013 14:29:09 +0000 (17:29 +0300)]
Update checkpatch.pl

Sync with Linux 3.11-rc3

checkpatch commit:
c707a81 checkpatch: make the CamelCase cache work for non-git trees too

Signed-off-by: Phil Carmody <phil.carmody@partner.samsung.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
11 years agotest-patchset: use net diff, not sum of all diffs
Phil Carmody [Tue, 11 Jun 2013 14:24:00 +0000 (17:24 +0300)]
test-patchset: use net diff, not sum of all diffs

We generated the end-start diff presumably for this reason.
Using the concatenation of all patches effectively gives us
the concatenation of all diagnostics, which we already have.

Signed-off-by: Phil Carmody <phil.carmody@partner.samsung.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agoremove the aiaiai-test-defconfigs
Artem Bityutskiy [Fri, 26 Apr 2013 11:13:39 +0000 (07:13 -0400)]
remove the aiaiai-test-defconfigs

It does not work for anymore because we cannot find the correct architecture
(ARCH=) from the defconfigs.

For example, if a patch changes arch/x86/configs/i386_deconfig, the script
finds out that the architecture is 'x86', and then starts verifying the
patch using 'ARCH=x86', which actually translates to 'ARCH=x86_64', which
is incorrect and gives bogus results.

I do not know how to easily fix this and do not have time for a non-trivial
solution, so just removing this script. If later I need it, it is in the git
history.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agojenkins: add aiaiai-jenkins-test-patchset script
Artem Bityutskiy [Mon, 25 Mar 2013 15:53:23 +0000 (17:53 +0200)]
jenkins: add aiaiai-jenkins-test-patchset script

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agotest-patch-set: run checkpatch only once in case of single patch
Artem Bityutskiy [Wed, 27 Mar 2013 09:59:49 +0000 (05:59 -0400)]
test-patch-set: run checkpatch only once in case of single patch

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agotest-patchset: always reset to the base commit before testing
Artem Bityutskiy [Wed, 27 Mar 2013 09:42:50 +0000 (05:42 -0400)]
test-patchset: always reset to the base commit before testing

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agoaiaiai-test-patchset: introduce --logdir option
Artem Bityutskiy [Wed, 27 Mar 2013 09:41:12 +0000 (05:41 -0400)]
aiaiai-test-patchset: introduce --logdir option

It is useful when one wants to preserve build logs.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agotest-patchset: move print_spearator to sh-funcions
Jenkins Continuous Build server [Tue, 26 Mar 2013 13:03:02 +0000 (09:03 -0400)]
test-patchset: move print_spearator to sh-funcions

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agorpm: fixup packaging to make it work on Fedora 18
Artem Bityutskiy [Fri, 22 Mar 2013 12:42:39 +0000 (14:42 +0200)]
rpm: fixup packaging to make it work on Fedora 18

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agorpm: reset the changes file
Artem Bityutskiy [Fri, 22 Mar 2013 12:32:24 +0000 (14:32 +0200)]
rpm: reset the changes file

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agoUpdate checkpatch.pl
Artem Bityutskiy [Tue, 12 Mar 2013 12:31:46 +0000 (14:31 +0200)]
Update checkpatch.pl

Sync with v3.9-rc2.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agoUpdate coccinelle scripts
Artem Bityutskiy [Tue, 12 Mar 2013 12:29:13 +0000 (14:29 +0200)]
Update coccinelle scripts

Sync with 3.9-rc2

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agoUpdate coccinelle scripts
Artem Bityutskiy [Wed, 17 Oct 2012 10:52:16 +0000 (13:52 +0300)]
Update coccinelle scripts

Sync with 3.7-rc1.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agoaiaiai-make-kernel: silence junk ouptut
Artem Bityutskiy [Wed, 10 Oct 2012 10:50:22 +0000 (13:50 +0300)]
aiaiai-make-kernel: silence junk ouptut

We forgot -q in a grep invocation.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agoaiaia-make-kernel: fix a typo in help message
Artem Bityutskiy [Wed, 10 Oct 2012 10:49:52 +0000 (13:49 +0300)]
aiaia-make-kernel: fix a typo in help message

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agoImprove user-friendliness
Artem Bityutskiy [Fri, 5 Oct 2012 08:20:04 +0000 (11:20 +0300)]
Improve user-friendliness

Rafał Miłecki <zajec5@gmail.com> complained that aiaiai does not immediately
fail if there are missing tools. Add some more checks to aiaiai and add some
user-friendly messages.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agocheckpatch.pl: sync with 3.6-rc3
Artem Bityutskiy [Thu, 30 Aug 2012 06:32:15 +0000 (09:32 +0300)]
checkpatch.pl: sync with 3.6-rc3

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agoaiaiai-test-defconfigs: fix nested config directories
Artem Bityutskiy [Fri, 24 Aug 2012 14:13:24 +0000 (17:13 +0300)]
aiaiai-test-defconfigs: fix nested config directories

In powerpc the defconfigs may be like "83xx/mpc8315_rdb_defconfig" which
the script did not handle well and errored out. Fix this.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agorpm: improve packaging
Ed Bartosh [Thu, 26 Jul 2012 14:21:29 +0000 (17:21 +0300)]
rpm: improve packaging

- Added Requires: to spec
- Added install target to project's Makefile
- Added rpm/Makefile to integrate it with Jenkins testing job
- Removed unneeded files from rpm/

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agococcinelle: add all the new scripts
Artem Bityutskiy [Thu, 26 Jul 2012 07:23:47 +0000 (10:23 +0300)]
coccinelle: add all the new scripts

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agorpm: add rpm packaging stuff from Olev and Markus
Artem Bityutskiy [Mon, 23 Jul 2012 13:26:12 +0000 (16:26 +0300)]
rpm: add rpm packaging stuff from Olev and Markus

Does not look ideal, but the guys can make an rpm using that stuff.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agoaiaiai-make-kernel: add -M option to pass Kbuild arguments
Artem Bityutskiy [Wed, 18 Jul 2012 12:50:26 +0000 (15:50 +0300)]
aiaiai-make-kernel: add -M option to pass Kbuild arguments

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@linux.intel.com>
12 years agoemail: a couple of fixes caused by re-naming
Artem Bityutskiy [Wed, 16 May 2012 07:55:52 +0000 (10:55 +0300)]
email: a couple of fixes caused by re-naming

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agoUpdate coccinelle scripts
Artem Bityutskiy [Fri, 11 May 2012 16:31:42 +0000 (19:31 +0300)]
Update coccinelle scripts

Copy from v3.4-rc6.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agoUpdate checkpatch.pl
Artem Bityutskiy [Fri, 11 May 2012 16:28:34 +0000 (19:28 +0300)]
Update checkpatch.pl

Take the one from v3.4-rc6.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agomake-kernel: do not forget to change the directory
Artem Bityutskiy [Fri, 11 May 2012 15:29:06 +0000 (18:29 +0300)]
make-kernel: do not forget to change the directory

This patch fixes a horrible bug - I forgot -C <srcdir> make option and
as a result the build was incorrect.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agotest-patchset: fix help output
Artem Bityutskiy [Fri, 11 May 2012 11:34:47 +0000 (14:34 +0300)]
test-patchset: fix help output

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agofix small typos
Alexander Shishkin [Fri, 11 May 2012 11:21:59 +0000 (14:21 +0300)]
fix small typos

Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agotest-patchset: make sure we only print to stderr
Artem Bityutskiy [Fri, 11 May 2012 10:24:46 +0000 (13:24 +0300)]
test-patchset: make sure we only print to stderr

Redirect the output of the newly added git commands to stderr - I forgot
to do this in the first place.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agotest-patchset: add -q option to git commit
Artem Bityutskiy [Fri, 11 May 2012 10:23:26 +0000 (13:23 +0300)]
test-patchset: add -q option to git commit

Silence 'git commit' unless -v option was used, otherwise it prints
unwanted message.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agoAdd support for quick fixes
Artem Bityutskiy [Fri, 11 May 2012 10:12:15 +0000 (13:12 +0300)]
Add support for quick fixes

Unfortunately I have to carry various build fixes, hopefully temporarily,
and it is very handy to ask aiaiai apply certain quick fixes before running
the test.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agoFix stand-alone defconfigs handling
Artem Bityutskiy [Fri, 11 May 2012 06:52:20 +0000 (09:52 +0300)]
Fix stand-alone defconfigs handling

Now it seems to really work.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agotest-patchset: some more minor output changes
Artem Bityutskiy [Thu, 10 May 2012 12:14:40 +0000 (15:14 +0300)]
test-patchset: some more minor output changes

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agoAdd out-of-tree defconfigs support
Artem Bityutskiy [Thu, 10 May 2012 11:40:18 +0000 (14:40 +0300)]
Add out-of-tree defconfigs support

Now the defconfigs do not have to be part of the tree and you may use
stand-along defconfigs using -C option.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agomake-kernel: fix help message spacing
Artem Bityutskiy [Thu, 10 May 2012 10:22:48 +0000 (13:22 +0300)]
make-kernel: fix help message spacing

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agomake-kernel: introduce -D option
Artem Bityutskiy [Thu, 10 May 2012 10:20:43 +0000 (13:20 +0300)]
make-kernel: introduce -D option

Add -D option to aiaiai-make-kernel which allows to specify the defconfig
which should be used for each target. This is a preparation for further
changes where we'll allow to use external defconfig files.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agoMove rename and move serialize-log
Artem Bityutskiy [Thu, 10 May 2012 09:48:41 +0000 (12:48 +0300)]
Move rename and move serialize-log

Move the serialize-log program to the top-level because it is not external.
Rename it to aiaiai-locker. Add Makefile at the top level as well.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agoMove libshell to the "external" subdirectory
Artem Bityutskiy [Thu, 10 May 2012 09:29:39 +0000 (12:29 +0300)]
Move libshell to the "external" subdirectory

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agoRename "tools" subdirectory to "external"
Artem Bityutskiy [Thu, 10 May 2012 09:25:27 +0000 (12:25 +0300)]
Rename "tools" subdirectory to "external"

Because it makes more sense - we keep files which we borrowed from
other projects there.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agoRename email-test-patchset aiaiai-email-test-patchset
Artem Bityutskiy [Thu, 10 May 2012 08:41:34 +0000 (11:41 +0300)]
Rename email-test-patchset aiaiai-email-test-patchset

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agoRename email-lda to aiaiai-email-lda
Artem Bityutskiy [Thu, 10 May 2012 08:39:13 +0000 (11:39 +0300)]
Rename email-lda to aiaiai-email-lda

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agoRename email-dispatcher* to aiaiai-email-dispatcher*
Artem Bityutskiy [Thu, 10 May 2012 08:37:32 +0000 (11:37 +0300)]
Rename email-dispatcher* to aiaiai-email-dispatcher*

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agoRename email/email.cfg to email/aiaiai-email.cfg
Artem Bityutskiy [Thu, 10 May 2012 08:33:43 +0000 (11:33 +0300)]
Rename email/email.cfg to email/aiaiai-email.cfg

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
12 years agoMove the README files to the doc directory
Artem Bityutskiy [Thu, 10 May 2012 08:30:59 +0000 (11:30 +0300)]
Move the README files to the doc directory

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>