]> www.infradead.org Git - users/jedix/linux-maple.git/log
users/jedix/linux-maple.git
10 months agoStaging: rtl8192e: Rename variable RxDrvInfoSize
Tree Davies [Sun, 8 Sep 2024 19:26:33 +0000 (12:26 -0700)]
Staging: rtl8192e: Rename variable RxDrvInfoSize

Rename variable RxDrvInfoSize to rx_drv_info_size
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240908192633.94144-17-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agoStaging: rtl8192e: Rename variable RxBufShift
Tree Davies [Sun, 8 Sep 2024 19:26:32 +0000 (12:26 -0700)]
Staging: rtl8192e: Rename variable RxBufShift

Rename variable RxBufShift to rx_buf_shift
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240908192633.94144-16-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agoStaging: rtl8192e: Rename variable bAddNewTs
Tree Davies [Sun, 8 Sep 2024 19:26:31 +0000 (12:26 -0700)]
Staging: rtl8192e: Rename variable bAddNewTs

Rename variable bAddNewTs to add_new_ts
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240908192633.94144-15-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agoStaging: rtl8192e: Rename variable nStuckCount
Tree Davies [Sun, 8 Sep 2024 19:26:30 +0000 (12:26 -0700)]
Staging: rtl8192e: Rename variable nStuckCount

Rename variable nStuckCount to stuck_count
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240908192633.94144-14-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agoStaging: rtl8192e: Rename variable isEncrypt
Tree Davies [Sun, 8 Sep 2024 19:26:29 +0000 (12:26 -0700)]
Staging: rtl8192e: Rename variable isEncrypt

Rename variable isEncrypt to is_encrypt
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240908192633.94144-13-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agoStaging: rtl8192e: Rename variable SignalQuality
Tree Davies [Sun, 8 Sep 2024 19:26:28 +0000 (12:26 -0700)]
Staging: rtl8192e: Rename variable SignalQuality

Rename variable SignalQuality to signal_quality
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240908192633.94144-12-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agoStaging: rtl8192e: Rename variable bAssoc
Tree Davies [Sun, 8 Sep 2024 19:26:27 +0000 (12:26 -0700)]
Staging: rtl8192e: Rename variable bAssoc

Rename variable bAssoc to assoc
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240908192633.94144-11-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agoStaging: rtl8192e: Rename variable Operation
Tree Davies [Sun, 8 Sep 2024 19:26:26 +0000 (12:26 -0700)]
Staging: rtl8192e: Rename variable Operation

Rename variable Operation to operation
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240908192633.94144-10-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agoStaging: rtl8192e: Rename variable ScanOperationBackupHandler
Tree Davies [Sun, 8 Sep 2024 19:26:25 +0000 (12:26 -0700)]
Staging: rtl8192e: Rename variable ScanOperationBackupHandler

Rename variable ScanOperationBackupHandler to
scan_operation_backup_handler to fix checkpatch warning
Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240908192633.94144-9-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agoStaging: rtl8192e: Rename variable Para2
Tree Davies [Sun, 8 Sep 2024 19:26:24 +0000 (12:26 -0700)]
Staging: rtl8192e: Rename variable Para2

Rename variable Para2 to para2
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240908192633.94144-8-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agoStaging: rtl8192e: Rename variable Para1
Tree Davies [Sun, 8 Sep 2024 19:26:23 +0000 (12:26 -0700)]
Staging: rtl8192e: Rename variable Para1

Rename variable Para1 to para1
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240908192633.94144-7-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agoStaging: rtl8192e: Rename variable bPacketToSelf
Tree Davies [Sun, 8 Sep 2024 19:26:22 +0000 (12:26 -0700)]
Staging: rtl8192e: Rename variable bPacketToSelf

Rename variable bPacketToSelf to packet_to_self
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240908192633.94144-6-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agoStaging: rtl8192e: Rename variable pFrame
Tree Davies [Sun, 8 Sep 2024 19:26:21 +0000 (12:26 -0700)]
Staging: rtl8192e: Rename variable pFrame

Rename variable pFrame to frame
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240908192633.94144-5-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agoStaging: rtl8192e: Rename variable SignalStrength
Tree Davies [Sun, 8 Sep 2024 19:26:20 +0000 (12:26 -0700)]
Staging: rtl8192e: Rename variable SignalStrength

Rename variable SignalStrength to signal_strength
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240908192633.94144-4-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agoStaging: rtl8192e: Rename variable SeqNum
Tree Davies [Sun, 8 Sep 2024 19:26:19 +0000 (12:26 -0700)]
Staging: rtl8192e: Rename variable SeqNum

Rename variable SeqNum to seq_num
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240908192633.94144-3-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agoStaging: rtl8192e: Rename variable pReorderEntry
Tree Davies [Sun, 8 Sep 2024 19:26:18 +0000 (12:26 -0700)]
Staging: rtl8192e: Rename variable pReorderEntry

Rename variable pReorderEntry to reorder_entry
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240908192633.94144-2-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agostaging: vchiq_core: Pass enumerated flag instead of int
Umang Jain [Tue, 10 Sep 2024 05:10:07 +0000 (10:40 +0530)]
staging: vchiq_core: Pass enumerated flag instead of int

Pass proper enumerated flag which exists, instead of an integer while
calling queue_message(). It helps with readability of the code.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Stefan Wahren <wahrenst@gmx.net>
Tested-by: Stefan Wahren <wahrenst@gmx.net>
Link: https://lore.kernel.org/r/20240910051007.297227-8-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agostaging: vchiq_core: Remove unused function argument
Umang Jain [Tue, 10 Sep 2024 05:10:06 +0000 (10:40 +0530)]
staging: vchiq_core: Remove unused function argument

The argument 'is_blocking' in queue_message_sync() is not
used in the function. Drop it.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Stefan Wahren <wahrenst@gmx.net>
Tested-by: Stefan Wahren <wahrenst@gmx.net>
Link: https://lore.kernel.org/r/20240910051007.297227-7-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agostaging: vchiq_core: Drop vchiq_bulk_transfer()
Umang Jain [Tue, 10 Sep 2024 05:10:05 +0000 (10:40 +0530)]
staging: vchiq_core: Drop vchiq_bulk_transfer()

Drop vchiq_bulk_transfer() as every VCHIQ_BULK_MODE_* mode
now have their own dedicated functions to execute bulk transfers.

Also, drop the temporary label we introduced earlier in vchiq-dev.c
to jump over the vchiq_bulk_transfer() call when each separate mode
helper was being developed.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Tested-by: Stefan Wahren <wahrenst@gmx.net>
Link: https://lore.kernel.org/r/20240910051007.297227-6-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agostaging: vchiq_core: Factor out bulk transfer for (no/)callback mode
Umang Jain [Tue, 10 Sep 2024 05:10:04 +0000 (10:40 +0530)]
staging: vchiq_core: Factor out bulk transfer for (no/)callback mode

Factor out bulk transfer for VCHIQ_BULK_MODE_NOCALLBACK and
VCHIQ_BULK_MODE_CALLBACK mode into a separate dedicated function
bulk_xfer_callback_interruptible(). It is suffixed by "_interruptible"
to denote that it can be interrupted and -EAGAIN can be returned. It
would be up to the users of the function to retry the call in those cases.

bulk_xfer_callback_interruptible() also takes in 'mode' parameter to
differentiate between VCHIQ_BULK_MODE_NOCALLBACK and
VCHIQ_BULK_MODE_CALLBACK, which then is directly passed to
vchiq_bulk_xfer_queue_msg_interruptible() inside the function.

Adjust the calls to vchiq-dev.c ioctl interface and vchiq_arm.c
for the respective bulk transfers.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Tested-by: Stefan Wahren <wahrenst@gmx.net>
Link: https://lore.kernel.org/r/20240910051007.297227-5-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agostaging: vchiq_core: Factor out bulk transfer for blocking mode
Umang Jain [Tue, 10 Sep 2024 05:10:03 +0000 (10:40 +0530)]
staging: vchiq_core: Factor out bulk transfer for blocking mode

Factor out bulk transfer for blocking mode into a separate dedicated
function bulk_xfer_blocking_interruptible(). It is suffixed by
"_interruptible" to denote that it can be interrupted and -EAGAIN
can be returned. It would be up to the users of the function to retry
the call in those cases.

Adjust the calls to vchiq-dev.c ioctl interface and vchiq_arm.c
for blocking bulk transfers.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Tested-by: Stefan Wahren <wahrenst@gmx.net>
Link: https://lore.kernel.org/r/20240910051007.297227-4-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agostaging: vchiq_core: Simplify vchiq_bulk_transfer()
Umang Jain [Tue, 10 Sep 2024 05:10:02 +0000 (10:40 +0530)]
staging: vchiq_core: Simplify vchiq_bulk_transfer()

Factor out core logic for preparing bulk data transfer(mutex locking,
waits on vchiq_bulk_queue wait-queue, initialising the bulk transfer)
out of the vchiq_bulk_transfer(). This simplifies the existing
vchiq_bulk_transfer() and makes it more readable since all the core
logic is handled in vchiq_bulk_xfer_queue_msg_interruptible(). It
will also help us to refactor vchiq_bulk_transfer() easily for different
vchiq bulk transfer modes.

No functional changes intended in this patch.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Tested-by: Stefan Wahren <wahrenst@gmx.net>
Link: https://lore.kernel.org/r/20240910051007.297227-3-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agostaging: vchiq: Factor out bulk transfer for VCHIQ_BULK_MODE_WAITING
Umang Jain [Tue, 10 Sep 2024 05:10:01 +0000 (10:40 +0530)]
staging: vchiq: Factor out bulk transfer for VCHIQ_BULK_MODE_WAITING

The bulk transfer is VCHIQ_BULK_MODE_WAITING is used by VCHIQ ioctl
interface. It is factored out to a separate function from
vchiq_bulk_transfer() to bulk_xfer_waiting_interruptible().

This is a part of vchiq_bulk_transfer refactoring. Each bulk mode
will have their dedicated functions to execute bulk transfers.
Each mode will be handled separately in subsequent patches.

bulk_xfer_waiting_interruptible() is suffixed with "_interruptible"
to denote that it can be interrupted when a signal is received.
-EAGAIN maybe returned in those cases, similar to what
vchiq_bulk_transfer() does.

Adjust the vchiq_irq_queue_bulk_tx_rx() in the vchiq-dev.c to call
bulk_xfer_waiting_interruptible() for waiting mode. A temporary
goto label has been introduced to jump the call execution over
vchiq_bulk_transfer() for waiting mode only. When all dedicated bulk
transfer calls are introduced, this label shall be dropped.

No function changes intended in this patch.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Tested-by: Stefan Wahren <wahrenst@gmx.net>
Link: https://lore.kernel.org/r/20240910051007.297227-2-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agostaging: vme_user: changed geoid data type from int to u32
Riyan Dhiman [Tue, 3 Sep 2024 11:48:51 +0000 (17:18 +0530)]
staging: vme_user: changed geoid data type from int to u32

Geoid is a module parameter which is set by root user.
Its valid values are between 0 and VME_MAX_SLOTS. So, changing data type
of geoid from int to u32 since it will always be positive.

Signed-off-by: Riyan Dhiman <riyandhiman14@gmail.com>
Link: https://lore.kernel.org/r/20240903114849.4953-3-riyandhiman14@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agoStaging: rtl8723bs: Rename function SelectChannel()
vivek t s [Thu, 5 Sep 2024 10:12:02 +0000 (15:42 +0530)]
Staging: rtl8723bs: Rename function SelectChannel()

Rename function SelectChannel() to r8723bs_select_channel(), to avoid
CamelCase and to improve cleanliness of the global namespace.

Signed-off-by: vivek t s <vivek6429.ts@gmail.com>
Link: https://lore.kernel.org/r/ZtmD8i7YZLRIcaI9@victor-IdeaPad-Gaming-3-16IAH7
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agostaging: rtl8723bs: include: Fix spelling mistake in rtw_event.h
Roshan Khatri [Thu, 5 Sep 2024 13:45:36 +0000 (19:30 +0545)]
staging: rtl8723bs: include: Fix spelling mistake in rtw_event.h

This patch fixes spelling mistake to increase code readability
and searching.

Signed-off-by: Roshan Khatri <topofeverest8848@gmail.com>
Link: https://lore.kernel.org/r/20240905134536.4364-1-topofeverest8848@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agostaging: rtl8723bs: include: Fix spelling mistake in rtl8723b_hal.h
Roshan Khatri [Thu, 5 Sep 2024 11:27:20 +0000 (17:12 +0545)]
staging: rtl8723bs: include: Fix spelling mistake in rtl8723b_hal.h

This patch fixes spelling mistake to increase code readability
and searching.

Signed-off-by: Roshan Khatri <topofeverest8848@gmail.com>
Link: https://lore.kernel.org/r/20240905112720.3141-1-topofeverest8848@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agostaging: rtl8723bs: Remove an unused struct in rtw_cmd.h
Qianqiang Liu [Tue, 3 Sep 2024 01:44:02 +0000 (09:44 +0800)]
staging: rtl8723bs: Remove an unused struct in rtw_cmd.h

struct getcountjudge_rsp is not used, just remove it.

Signed-off-by: Qianqiang Liu <qianqiang.liu@163.com>
Link: https://lore.kernel.org/r/20240903014402.170750-1-qianqiang.liu@163.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agostaging: greybus: Fix capitalization and punctuation inconsistencies
Steven Davis [Sun, 1 Sep 2024 21:18:59 +0000 (17:18 -0400)]
staging: greybus: Fix capitalization and punctuation inconsistencies

There were a lot of inconsistencies in outputs and
comments, some were properly formatted and
capitalized, and some weren't. This patch resolves
this by properly formatting the inconsistent comments
and outputs.

Signed-off-by: Steven Davis <goldside000@outlook.com>
Link: https://lore.kernel.org/r/SJ2P223MB102660087EA9382BE5287FDBF7912@SJ2P223MB1026.NAMP223.PROD.OUTLOOK.COM
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agostaging: rtl8723bs: Remove trailing space after \n newline
Colin Ian King [Sun, 1 Sep 2024 16:15:34 +0000 (17:15 +0100)]
staging: rtl8723bs: Remove trailing space after \n newline

There is a extraneous space after a newline in a netdev_dbg message.
Remove it.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Link: https://lore.kernel.org/r/20240901161534.143887-1-colin.i.king@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agostaging: rtl8192e: Constify struct pci_device_id
Riyan Dhiman [Sat, 31 Aug 2024 16:08:31 +0000 (21:38 +0530)]
staging: rtl8192e: Constify struct pci_device_id

static variable struct pci_device_id rtl8192_pci_id_tbl is not modified
in file rtl_core.c.

Constifying this structure moves some data to a read-only section, so
increase overall security.

Before
======
   text    data     bss     dec     hex filename
  17838     893       1   18732    492c drivers/staging/rtl8192e/rtl8192e/rtl_core.o

After
=====
  text    data     bss     dec     hex filename
  18006     725       1   18732    492c drivers/staging/rtl8192e/rtl8192e/rtl_core.o

Signed-off-by: Riyan Dhiman <riyandhiman14@gmail.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240831160831.121720-1-riyandhiman14@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agoStaging: rtl8192e: Add spaces around operators.
Tree Davies [Fri, 30 Aug 2024 02:05:08 +0000 (19:05 -0700)]
Staging: rtl8192e: Add spaces around operators.

Add spaces around arithmetic and bitwise operators to improve
readability of the code.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Link: https://lore.kernel.org/r/20240830020508.532945-4-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agoStaging: rtl8192e: Rename variable bHwError
Tree Davies [Fri, 30 Aug 2024 02:05:07 +0000 (19:05 -0700)]
Staging: rtl8192e: Rename variable bHwError

Rename variable bHwError to hw_error
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240830020508.532945-3-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agoStaging: rtl8192e: Rename variable pNetwork
Tree Davies [Fri, 30 Aug 2024 02:05:06 +0000 (19:05 -0700)]
Staging: rtl8192e: Rename variable pNetwork

Rename variable pNetwork to network
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240830020508.532945-2-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agostaging: rtl8192e: Fix parenthesis alignment in rtl_core.c
Gabriel Tassinari [Thu, 29 Aug 2024 21:40:31 +0000 (18:40 -0300)]
staging: rtl8192e: Fix parenthesis alignment in rtl_core.c

fix parenthesis alignment in _rtl92e_qos_handle_probe_response to
silence checkpatch warning:

CHECK: Alignment should match open parenthesis

Signed-off-by: Gabriel Tassinari <gabrieldtassinari@gmail.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240829214031.4893-1-gabrieldtassinari@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agostaging: rtl8192e: Fix Assignment operator '=' in rtl_wx.c
Alien Wesley [Thu, 29 Aug 2024 12:32:51 +0000 (09:32 -0300)]
staging: rtl8192e: Fix Assignment operator '=' in rtl_wx.c

Separated assignments for pairwise_key_type and group_key_type
in order to silence the following checkpatch warning.

CHECK: Assignment operator '=' should be on the previous line.

Signed-off-by: Alien Wesley <alienwesley51@gmail.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240829123251.83574-1-alienwesley51@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agostaging: rtl8192e: Fix multiple assignments in rtl_wx.c
Alien Wesley [Thu, 29 Aug 2024 11:36:06 +0000 (08:36 -0300)]
staging: rtl8192e: Fix multiple assignments in rtl_wx.c

Separated assignments for pairwise_key_type and group_key_type
in order to silence the following checkpatch warning.

CHECK: multiple assignments should be avoided.

Signed-off-by: Alien Wesley <alienwesley51@gmail.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240829113606.76645-1-alienwesley51@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agostaging: greybus: spi: switch to use spi_alloc_host()
Yang Yingliang [Mon, 2 Sep 2024 12:59:46 +0000 (20:59 +0800)]
staging: greybus: spi: switch to use spi_alloc_host()

Switch to use modern name function spi_alloc_host().

No functional changed.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20240902125947.1368-7-yangyingliang@huaweicloud.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agostaging: rtl8192e: adjust size of RxMIMOSignalStrength
Michael Straube [Sat, 31 Aug 2024 10:08:09 +0000 (12:08 +0200)]
staging: rtl8192e: adjust size of RxMIMOSignalStrength

The array RxMIMOSignalStrength in struct rtllib_rx_stats is always accessed
with indices in the range i = 0; i < 2. We can reduce the size from 4 to 2.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240831100809.29173-6-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agostaging: rtl8192e: adjust size of brfpath_rxenable for new RF90_PATH_MAX
Michael Straube [Sat, 31 Aug 2024 10:08:08 +0000 (12:08 +0200)]
staging: rtl8192e: adjust size of brfpath_rxenable for new RF90_PATH_MAX

The array brfpath_rxenable in struct r8192_priv is always accessed by
indices in the range i = 0; i < RF90_PATH_MAX. A previous patch changed the
value of RF90_PATH_MAX from 4 to 2, so we can reduce the size of
brfpath_rxenable to 2. Use RF90_PATH_MAX instead of a hard-coded size.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240831100809.29173-5-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agostaging: rtl8192e: adjust size of trsw_gain_X for new RF90_PATH_MAX
Michael Straube [Sat, 31 Aug 2024 10:08:07 +0000 (12:08 +0200)]
staging: rtl8192e: adjust size of trsw_gain_X for new RF90_PATH_MAX

The array trsw_gain_X in struct phy_sts_ofdm_819xpci is always accessed by
indices in the range i = 0; i < RF90_PATH_MAX. A previous patch changed the
value of RF90_PATH_MAX from 4 to 2, so we can reduce the size of
trsw_gain_X to 2. Use RF90_PATH_MAX instead of a hard-coded size.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240831100809.29173-4-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agostaging: rtl8192e: adjust size of rx_pwr for new RF90_PATH_MAX
Michael Straube [Sat, 31 Aug 2024 10:08:06 +0000 (12:08 +0200)]
staging: rtl8192e: adjust size of rx_pwr for new RF90_PATH_MAX

The local array rx_pwr in the function _rtl92e_query_rxphystatus() is
always accessed by indices in the range i = 0; i < RF90_PATH_MAX.
A previous patch changed the value of RF90_PATH_MAX from 4 to 2, so we can
reduce the size of rx_pwr to 2. Use RF90_PATH_MAX instead of a hard-coded
size.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240831100809.29173-3-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agostaging: rtl8192e: remove RF90_PATH_{C,D} from enum rf90_radio_path
Michael Straube [Sat, 31 Aug 2024 10:08:05 +0000 (12:08 +0200)]
staging: rtl8192e: remove RF90_PATH_{C,D} from enum rf90_radio_path

RF90_PATH_C and RF90_PATH_D are unused in this driver. Remove them
from enum rf90_radio_path.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240831100809.29173-2-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agostaging: rtl8712: Calculate size from pointer
Manisha Singh [Wed, 28 Aug 2024 22:21:55 +0000 (03:51 +0530)]
staging: rtl8712: Calculate size from pointer

Calculate the size from the pointer instead of struct to adhere to kernel
coding style.

Signed-off-by: Manisha Singh <masingh.linux@gmail.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240828222153.68062-4-masingh.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agostaging: rtl8712: Fix style issues in rtl871x_io.c
Manisha Singh [Wed, 28 Aug 2024 22:21:53 +0000 (03:51 +0530)]
staging: rtl8712: Fix style issues in rtl871x_io.c

Refactor the _init_intf_hdl() function to avoid multiple
assignments in a single statement. This change improves code readability
and adheres to kernel coding style guidelines.

Signed-off-by: Manisha Singh <masingh.linux@gmail.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240828222153.68062-2-masingh.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agostaging: rtl8712: Align parenthesis in usb_ops_linux.c
Dorine Tipo [Wed, 28 Aug 2024 08:29:35 +0000 (08:29 +0000)]
staging: rtl8712: Align parenthesis in usb_ops_linux.c

Fix the parenthesis alignment in r8712_read_port() function to match
the opening parenthesis.
This improves code readability and adheres to the kernel coding style.

Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240828082935.GA3815@ubuntu-focal
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agostaging: vt6655: Fix block comment alignment
Dominik Karol Piątkowski [Wed, 28 Aug 2024 15:00:09 +0000 (15:00 +0000)]
staging: vt6655: Fix block comment alignment

This patch fixes the "Block comments should align the * on each line"
warning detected by checkpatch.pl.

Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Link: https://lore.kernel.org/r/20240828145923.78004-1-dominik.karol.piatkowski@protonmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agostaging: vt6655: Update maintainer in TODO
Dominik Karol Piątkowski [Wed, 28 Aug 2024 14:46:56 +0000 (14:46 +0000)]
staging: vt6655: Update maintainer in TODO

Commit ed394dbf5371b03a5335a7ba1973ba124c0ced3d replaced Forest Bond
with Philipp Hortmann as vt665X maintainer in MAINTAINERS, but
drivers/staging/vt6655/TODO was not changed, rendering it stale. This
patch fixes it.

Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Link: https://lore.kernel.org/r/20240828144545.76022-1-dominik.karol.piatkowski@protonmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agostaging: vme_user: added bound check to geoid
Riyan Dhiman [Tue, 27 Aug 2024 12:56:05 +0000 (18:26 +0530)]
staging: vme_user: added bound check to geoid

The geoid is a module parameter that allows users to hardcode the slot number.
A bound check for geoid was added in the probe function because only values
between 0 and less than VME_MAX_SLOT are valid.

Signed-off-by: Riyan Dhiman <riyandhiman14@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20240827125604.42771-2-riyandhiman14@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agoStaging: rtl8192e: Rename variable bCmdOrInit
Tree Davies [Mon, 26 Aug 2024 00:17:24 +0000 (17:17 -0700)]
Staging: rtl8192e: Rename variable bCmdOrInit

Rename variable bCmdOrInit to cmd_or_init
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240826001724.274811-7-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agoStaging: rtl8192e: Rename variable msDelay
Tree Davies [Mon, 26 Aug 2024 00:17:23 +0000 (17:17 -0700)]
Staging: rtl8192e: Rename variable msDelay

Rename variable msDelay to ms_delay
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240826001724.274811-6-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agoStaging: rtl8192e: Rename variable CmdID
Tree Davies [Mon, 26 Aug 2024 00:17:22 +0000 (17:17 -0700)]
Staging: rtl8192e: Rename variable CmdID

Rename variable CmdID to cmd_id
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240826001724.274811-5-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agoStaging: rtl8192e: Rename variable CmdID_RF_WriteReg
Tree Davies [Mon, 26 Aug 2024 00:17:21 +0000 (17:17 -0700)]
Staging: rtl8192e: Rename variable CmdID_RF_WriteReg

Rename variable CmdID_RF_WriteReg to cmd_id_rf_write_reg
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240826001724.274811-4-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agoStaging: rtl8192e: Rename variable bLastIniPkt
Tree Davies [Mon, 26 Aug 2024 00:17:20 +0000 (17:17 -0700)]
Staging: rtl8192e: Rename variable bLastIniPkt

Rename variable bLastIniPkt to last_ini_pkt
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240826001724.274811-3-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 months agoStaging: rtl8192e: Rename variable CurPsLevel
Tree Davies [Mon, 26 Aug 2024 00:17:19 +0000 (17:17 -0700)]
Staging: rtl8192e: Rename variable CurPsLevel

Rename variable CurPsLevel to cur_ps_level
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240826001724.274811-2-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: rtl8192e: remove set but otherwise unused local variable iv16
Simon Horman [Fri, 23 Aug 2024 17:26:27 +0000 (18:26 +0100)]
staging: rtl8192e: remove set but otherwise unused local variable iv16

Since the commit 5f1a6826ea49 ("staging: rtl8192e: remove set but
otherwise unused local variable iv32"), the local variable iv16 is set
but otherwise unused. So remove it.

Compile tested only.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202408232049.UJef268y-lkp@intel.com/
Signed-off-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20240823-rtl8192e-iv16-v1-1-000702673065@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agoStaging: rtl8192e: Remove unnecessary blank line
Gabriel Maciel Raad [Fri, 23 Aug 2024 00:08:38 +0000 (21:08 -0300)]
Staging: rtl8192e: Remove unnecessary blank line

Remove unneeded blank line in rtl92e_leisure_ps_enter to silence the
folowing checkpatch.pl warning:

CHECK: Blank lines aren't necessary after an open brace '{'

Signed-off-by: Gabriel Maciel Raad <ffunctor@gmail.com>
Link: https://lore.kernel.org/r/20240823000838.8207-3-ffunctor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agoStaging: rtl8192e: Fix parenthesis alignment
Gabriel Maciel Raad [Fri, 23 Aug 2024 00:08:37 +0000 (21:08 -0300)]
Staging: rtl8192e: Fix parenthesis alignment

Fix parenthesis alingment in rtl92e_leisure_ps_enter to silence the
following checkpatch.pl warning:

CHECK: Alignment should match open parenthesis

Signed-off-by: Gabriel Maciel Raad <ffunctor@gmail.com>
Link: https://lore.kernel.org/r/20240823000838.8207-2-ffunctor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agoStaging: rtl8192e: Fix arguments alignment
Ana Carolina Hernandes [Thu, 22 Aug 2024 20:27:27 +0000 (17:27 -0300)]
Staging: rtl8192e: Fix arguments alignment

Fix the alignment of arguments in function _rtl92e_query_rxphystatus in
order to silence the following checkpatch warning:

CHECK: Lines should not end with a '('

Signed-off-by: Ana Carolina Hernandes <anachan.01h@gmail.com>
Link: https://lore.kernel.org/r/20240822202727.18882-1-anachan.01h@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: rtl8192e: Fix Assignment operator '=' in rtl_dm.c:1488
Alien Wesley [Thu, 22 Aug 2024 16:30:57 +0000 (13:30 -0300)]
staging: rtl8192e: Fix Assignment operator '=' in rtl_dm.c:1488

Removed enter before operator '=' in rtl_dm.c:1488 in order to silence the
following checkpatch warning.

CHECK: Assignment operator '=' should be on the previous line

Signed-off-by: Alien Wesley <alienwesley51@gmail.com>
Link: https://lore.kernel.org/r/20240822163057.14114-1-alienwesley51@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: rtl8723bs: make read-only array dot11_rate_table static const
Colin Ian King [Thu, 22 Aug 2024 16:30:52 +0000 (17:30 +0100)]
staging: rtl8723bs: make read-only array dot11_rate_table static const

Don't populate the read-only array dot11_rate_table on the stack at
run time, instead make it static const.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Link: https://lore.kernel.org/r/20240822163052.636570-1-colin.i.king@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: rtl8192e: Insert spaces around '|'
Hans Buss [Thu, 22 Aug 2024 14:36:55 +0000 (11:36 -0300)]
staging: rtl8192e: Insert spaces around '|'

Insert spaces around '|' to adhre to Linux kernel coding style.

CHECK: spaces preferred around that '|' (ctx:VxV)

Signed-off-by: Hans Buss <hans.buss@mailfence.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20240822143837.37768-1-hansbh123@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: rtl8192e: Fix blank line
Alien Wesley [Thu, 22 Aug 2024 01:04:56 +0000 (22:04 -0300)]
staging: rtl8192e: Fix blank line

Removed blank line in r8192E_dev.c in order to silence the
following checkpatch warning.

CHECK: Please don't use multiple blank lines

Signed-off-by: Alien Wesley <alienwesley51@gmail.com>
Link: https://lore.kernel.org/r/20240822010456.20186-1-alienwesley51@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: rtl8192e: Fix parenthesis alignment
Túlio Fernandes [Thu, 22 Aug 2024 00:45:58 +0000 (21:45 -0300)]
staging: rtl8192e: Fix parenthesis alignment

Fix parenthesis alignment in rtl92e_set_rf_state in order to rid
the following warning:

CHECK: Alignment should match open parenthesis

Signed-off-by: Túlio Fernandes <tuliomf09@gmail.com>
Link: https://lore.kernel.org/r/20240822004558.14638-1-tuliomf09@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: rtl8192e: Fix parenthesis alignment
Pedro Orlando [Thu, 22 Aug 2024 00:26:58 +0000 (21:26 -0300)]
staging: rtl8192e: Fix parenthesis alignment

Fix parenthesis alignment in _rtl92e_wx_set_encode_ext to fix
checkpatch warning:

CHECK: Alignment should match open parenthesis

Signed-off-by: Pedro Orlando <scramblerdoodle@gmail.com>
Link: https://lore.kernel.org/r/20240822002658.33672-1-scramblerdoodle@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: rtl8192e: fix parenthesis alignment
Christian S Lima [Thu, 22 Aug 2024 00:26:12 +0000 (21:26 -0300)]
staging: rtl8192e: fix parenthesis alignment

fix line 1326 in order to silence warning
CHECK: Alignment should match open parenthesis

Signed-off-by: Christian S Lima <christiansantoslima21@gmail.com>
Link: https://lore.kernel.org/r/20240822002620.63732-1-christiansantoslima21@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: rtl8192e: Fix line ended with '('
João Pedro Leôncio [Thu, 22 Aug 2024 00:24:58 +0000 (21:24 -0300)]
staging: rtl8192e: Fix line ended with '('

Fix line ended with '(' in _rtl92e_update_received_rate_histogram_stats
in order to silence the following checkpat warning:

CHECK: Lines should not end with a '('

Signed-off-by: João Pedro Leôncio <aljpleoncio@gmail.com>
Link: https://lore.kernel.org/r/20240822002502.92583-1-aljpleoncio@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: rtl8192e: change logical continuation to previous line on file r8192E_dev.c
thdecamargoj [Thu, 22 Aug 2024 00:24:03 +0000 (21:24 -0300)]
staging: rtl8192e: change logical continuation to previous line on file r8192E_dev.c

Change logical continuation to previous line to silence checkpatch
warning:

CHECK: Logical continuations should be on the previous line

Signed-off-by: thdecamargoj <thdecamargoj@gmail.com>
Link: https://lore.kernel.org/r/20240822002403.268452-1-thdecamargoj@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: rtl8192e: Fix parenthesis alignment
Vinicius Peixoto [Thu, 22 Aug 2024 00:23:43 +0000 (21:23 -0300)]
staging: rtl8192e: Fix parenthesis alignment

Fix parenthesis alignment in rtl92e_init_gain in order to silence the
following checkpatch warning:

CHECK: Alignment should match open parenthesis

Signed-off-by: Vinicius Peixoto <vpeixoto@lkcamp.dev>
Link: https://lore.kernel.org/r/20240822002346.94433-1-vpeixoto@lkcamp.dev
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: rtl8192e: Fix parenthesis alignment
Leonardo Kenji [Thu, 22 Aug 2024 00:25:43 +0000 (21:25 -0300)]
staging: rtl8192e: Fix parenthesis alignment

Fix parenthesis alignment in _rtl92e_read_eeprom_info in order to
silence the following checkpatch warning:

CHECK: Alignment should match open parenthesis

Signed-off-by: Leonardo Kenji <leokk06@gmail.com>
Link: https://lore.kernel.org/r/20240822002543.44835-1-leokk06@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: vme: vme_user: Remove NULL check of list_entry()
Yuesong Li [Thu, 22 Aug 2024 02:57:36 +0000 (10:57 +0800)]
staging: vme: vme_user: Remove NULL check of list_entry()

list_entry() will never return a NULL pointer, thus remove the
check.

Signed-off-by: Yuesong Li <liyuesong@vivo.com>
Link: https://lore.kernel.org/r/20240822025736.1208339-1-liyuesong@vivo.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: rtl8192e: insert blank line after function declaration
Vinicius Peixoto [Wed, 21 Aug 2024 20:46:45 +0000 (17:46 -0300)]
staging: rtl8192e: insert blank line after function declaration

This adds a blank line after the declaration of rtl92e_config_bb, in
order to fix the following checkpatch warning:

CHECK: Please use a blank line after function/struct/union/enum
declarations

Signed-off-by: Vinicius Peixoto <vpeixoto@lkcamp.dev>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20240821204714.5839-1-vpeixoto@lkcamp.dev
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: rtl8723bs: add spaces arround operators
Guillaume Lefèvre-Crimé [Fri, 16 Aug 2024 18:37:32 +0000 (20:37 +0200)]
staging: rtl8723bs: add spaces arround operators

Adhere to Linux kernel coding style.
Reported by checkpath :
CHECK: spaces preferred around that '&' (ctx:VxV)

Signed-off-by: Guillaume Lefèvre-Crimé <guillaume.lefevre.crime@netc.fr>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240816183756.59250-1-guillaume.lefevre.crime@netc.fr
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: rtl8192e: remove set but otherwise unused local variable iv32
Simon Horman [Wed, 21 Aug 2024 15:42:50 +0000 (16:42 +0100)]
staging: rtl8192e: remove set but otherwise unused local variable iv32

Remove iv32 from rtllib_tkip_get_key() as it is set but otherwise
unused.

Flagged by allmodconfig W=1 builds with gcc-13 and clang-18.
Compile tested only.

Signed-off-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20240821-rtl8192e-unused-var-v1-1-08b9e869260e@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agoStaging: rtl8192e: Rename variable CmdID_WritePortUchar
Tree Davies [Wed, 21 Aug 2024 03:08:56 +0000 (20:08 -0700)]
Staging: rtl8192e: Rename variable CmdID_WritePortUchar

Rename variable CmdID_WritePortUchar to cmd_id_write_port_uchar
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Link: https://lore.kernel.org/r/20240821030856.57423-7-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agoStaging: rtl8192e: Rename variable CmdID_WritePortUshort
Tree Davies [Wed, 21 Aug 2024 03:08:55 +0000 (20:08 -0700)]
Staging: rtl8192e: Rename variable CmdID_WritePortUshort

Rename variable CmdID_WritePortUshort to cmd_id_write_port_ushort
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Link: https://lore.kernel.org/r/20240821030856.57423-6-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agoStaging: rtl8192e: Rename variable CmdID_WritePortUlong
Tree Davies [Wed, 21 Aug 2024 03:08:54 +0000 (20:08 -0700)]
Staging: rtl8192e: Rename variable CmdID_WritePortUlong

Rename variable CmdID_WritePortUlong to cmd_id_write_port_ulong
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Link: https://lore.kernel.org/r/20240821030856.57423-5-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agoStaging: rtl8192e: Rename variable CmdID_BBRegWrite10
Tree Davies [Wed, 21 Aug 2024 03:08:53 +0000 (20:08 -0700)]
Staging: rtl8192e: Rename variable CmdID_BBRegWrite10

Rename variable CmdID_BBRegWrite10 to cmd_id_bbreg_write10
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Link: https://lore.kernel.org/r/20240821030856.57423-4-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agoStaging: rtl8192e: Rename variable CmdID_SetTxPowerLevel
Tree Davies [Wed, 21 Aug 2024 03:08:52 +0000 (20:08 -0700)]
Staging: rtl8192e: Rename variable CmdID_SetTxPowerLevel

Rename variable CmdID_SetTxPowerLevel to
cmd_id_set_tx_power_level to fix checkpatch warning Avoid
CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Link: https://lore.kernel.org/r/20240821030856.57423-3-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agoStaging: rtl8192e: Rename variable CmdID_End
Tree Davies [Wed, 21 Aug 2024 03:08:51 +0000 (20:08 -0700)]
Staging: rtl8192e: Rename variable CmdID_End

Rename variable CmdID_End to cmd_id_end
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Link: https://lore.kernel.org/r/20240821030856.57423-2-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: vt6655: Fix alignment to open parentheses
Dominik Karol Piątkowski [Sat, 17 Aug 2024 10:07:26 +0000 (10:07 +0000)]
staging: vt6655: Fix alignment to open parentheses

This patch fixes the "Alignment should match open parenthesis" checks
detected by checkpatch.pl.

Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Link: https://lore.kernel.org/r/20240817100559.33174-1-dominik.karol.piatkowski@protonmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: rtl8723bs: drop unnessary dep on CFG80211_WEXT
Peter Robinson [Wed, 14 Aug 2024 14:52:46 +0000 (15:52 +0100)]
staging: rtl8723bs: drop unnessary dep on CFG80211_WEXT

In commit 174ac41a7aaf ("staging: rtl8723bs: remove obsolete wext
support") a dep on CFG80211_WEXT was added to allow wext userspace
calls to be managed via the compatibility support. This is an
optional dependency which the driver has no dependency on and
stops users/distros etc from dropping CFG80211_WEXT if they want
to enable this driver. Drop this dependency as if users want this
legacy feature they will be explicitly enabling it themselves.

Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20240814145250.943457-1-pbrobinson@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agoStaging: rtl8192e: Rename variable nSubframe_Length
Tree Davies [Mon, 12 Aug 2024 01:36:50 +0000 (18:36 -0700)]
Staging: rtl8192e: Rename variable nSubframe_Length

Rename variable nSubframe_Length to subframe_len
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Link: https://lore.kernel.org/r/20240812013650.199675-1-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: rtl8723bs: Delete unnecessary braces for single statement blocks in xmit_linux.c
Jiwon Kim [Mon, 5 Aug 2024 13:56:23 +0000 (13:56 +0000)]
staging: rtl8723bs: Delete unnecessary braces for single statement blocks in xmit_linux.c

Delete braces {} for single statement blocks to shorten code.

Signed-off-by: Jiwon Kim <jiwonaid0@gmail.com>
Reviewed-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240805135623.2069-1-jiwonaid0@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agogreybus: camera-gb: Fix a alignment bug on gb_camera_ops()
Thais-ra [Sat, 3 Aug 2024 07:22:36 +0000 (07:22 +0000)]
greybus: camera-gb: Fix a alignment bug on gb_camera_ops()

Fix checkpatch message "CHECK: Alignment should match open parenthesis".

Signed-off-by: Thais-ra <thais_ra@riseup.net>
Link: https://lore.kernel.org/r/20240803072236.368-1-thais_ra@riseup.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: rtl8723bs: Improve clarity of MAR usage
Manjae Cho [Wed, 31 Jul 2024 22:51:34 +0000 (07:51 +0900)]
staging: rtl8723bs: Improve clarity of MAR usage

This patch improves the readability of the code related to the Multicast
Address Register (REG_MAR) in the rtl8723bs driver. It adds comments to
clarify the purpose and offset of the register, making the code more
self-documenting without introducing new macros.

Signed-off-by: Manjae Cho <manjae.cho@samsung.com>
Reviewed-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240731225134.917542-1-manjae.cho@samsung.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: olpc_dcon: Use backlight power constants
Thomas Zimmermann [Wed, 31 Jul 2024 12:58:52 +0000 (14:58 +0200)]
staging: olpc_dcon: Use backlight power constants

Replace FB_BLANK_ constants with their counterparts from the
backlight subsystem. The values are identical, so there's no
change in functionality or semantics.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Jens Frederich <jfrederich@gmail.com>
Cc: Jon Nettleton <jon.nettleton@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20240731130130.1148153-3-tzimmermann@suse.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: fbtft: Use backlight power constants
Thomas Zimmermann [Wed, 31 Jul 2024 12:58:51 +0000 (14:58 +0200)]
staging: fbtft: Use backlight power constants

Replace FB_BLANK_ constants with their counterparts from the
backlight subsystem. The values are identical, so there's no
change in functionality or semantics.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20240731130130.1148153-2-tzimmermann@suse.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: vme_user: vme.h: alignment of closing parenthesis should match open parenthe...
Riyan Dhiman [Wed, 31 Jul 2024 07:05:07 +0000 (12:35 +0530)]
staging: vme_user: vme.h: alignment of closing parenthesis should match open parenthesis in function declaration

Adhere to Linux kernel coding style.

Reported by checkpatch:

CHECK: Alignment should match open parenthesis

Signed-off-by: Riyan Dhiman <riyandhiman14@gmail.com>
Link: https://lore.kernel.org/r/20240731070507.6290-1-riyandhiman14@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: rtl8192e: remove duplicate macros from rtllib.h
Michael Straube [Tue, 30 Jul 2024 08:29:28 +0000 (10:29 +0200)]
staging: rtl8192e: remove duplicate macros from rtllib.h

These macros just duplicate macros from include/linux/ieee80211.h.
We can safely remove them from rtllib.h.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240730082928.62284-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: nvec: Capitalize outputs to match the rest of the driver
Steven Davis [Tue, 30 Jul 2024 21:08:12 +0000 (17:08 -0400)]
staging: nvec: Capitalize outputs to match the rest of the driver

Noticing that some messages were capitalized and some weren't, I
capitalized them to match the rest. This makes the messages relatively
easier to understand for an end user, and reduces confusion about
capitalization. A comment was also capitalized.

Signed-off-by: Steven Davis <goldside000@outlook.com>
Link: https://lore.kernel.org/r/SJ2P223MB102626B10E837EF5A93ED1F1F7B02@SJ2P223MB1026.NAMP223.PROD.OUTLOOK.COM
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: rtl8723bs: rtw_mlme_ext: replace spaces by tabs
Santiago Ruano Rincón [Tue, 30 Jul 2024 08:05:31 +0000 (17:05 +0900)]
staging: rtl8723bs: rtw_mlme_ext: replace spaces by tabs

Fix checkpatch error "ERROR: code indent should use tabs where possible"
in include/rtw_mlme_ext.h:388.

Signed-off-by: Santiago Ruano Rincón <santiagorr@riseup.net>
Link: https://lore.kernel.org/r/20240730080531.991195-1-santiagorr@riseup.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: rtl8723bs: remove space after pointer
Kartik Kulkarni [Tue, 30 Jul 2024 13:41:55 +0000 (13:41 +0000)]
staging: rtl8723bs: remove space after pointer

Fix checkpatch error "foo * bar" should be "foo *bar"
in osdep_service.h:105

Signed-off-by: Kartik Kulkarni <kartik.koolks@gmail.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20240730134155.37784-1-kartik.koolks@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: rtl8712: Fix move '{' to previous line
Tchadel Icard [Tue, 30 Jul 2024 07:09:10 +0000 (07:09 +0000)]
staging: rtl8712: Fix move '{' to previous line

Fix checkpatch error "ERROR: that open brace {
should be on the previous line"

Signed-off-by: Tchadel Icard <hello@tchadelicard.fr>
Link: https://lore.kernel.org/r/20240730070910.34996-1-hello@tchadelicard.fr
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: rtl8723bs: Fix spacing issues
Benjamin Somers [Tue, 30 Jul 2024 07:05:18 +0000 (07:05 +0000)]
staging: rtl8723bs: Fix spacing issues

This patch removes superfluous tabs at the beginning of the file and
commented includes

Signed-off-by: Benjamin Somers <benjamin.somers@resel.fr>
Link: https://lore.kernel.org/r/20240730070518.2850-1-benjamin.somers@resel.fr
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: rtl8723bs: replace indent space for tabs
Emmanuel Arias [Tue, 30 Jul 2024 07:00:59 +0000 (07:00 +0000)]
staging: rtl8723bs: replace indent space for tabs

Fix checkpatch error code indent should use tabs in file
hal_pwr_seq.h:104

Signed-off-by: Emmanuel Arias <eamanu@riseup.net>
Link: https://lore.kernel.org/r/20240730070059.33210-1-eamanu@riseup.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: rtl8723bs: style fix open brace on new line
Sai Sree Kartheek Adivi [Tue, 30 Jul 2024 06:59:01 +0000 (06:59 +0000)]
staging: rtl8723bs: style fix open brace on new line

It fixes the following checkpatch.pl error
"ERROR: that open brace { should be on the previous line" and avoids the
warning "WARNING: braces {} are not necessary for single statement blocks".

Signed-off-by: Sai Sree Kartheek Adivi <sskartheekadivi@gmail.com>
Link: https://lore.kernel.org/r/20240730065901.35254-1-sskartheekadivi@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: rtl8723bs: place opening brace on previous line
Guilherme Puida Moreira [Tue, 30 Jul 2024 06:48:12 +0000 (06:48 +0000)]
staging: rtl8723bs: place opening brace on previous line

Fix checkpatch diagnostic "ERROR: that open brace { should be on the
previous line" in rtw_security.h:173

Signed-off-by: Guilherme Puida Moreira <guilherme@puida.xyz>
Link: https://lore.kernel.org/r/20240730064812.1979-1-guilherme@puida.xyz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: rtl8192e: style fix - alignment to match parenthesis
David Prévot [Tue, 30 Jul 2024 06:47:07 +0000 (06:47 +0000)]
staging: rtl8192e: style fix - alignment to match parenthesis

Fixed checkpath Alignment should match open parenthesis

Signed-off-by: David Prévot <david@tilapin.org>
Link: https://lore.kernel.org/r/20240730064707.914-1-david@tilapin.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 months agostaging: rtl8712: remove trailing whitespace
Felix Yan [Tue, 30 Jul 2024 06:37:38 +0000 (09:37 +0300)]
staging: rtl8712: remove trailing whitespace

Fix the following checkpatch.pl error:

ERROR: trailing whitespace

Signed-off-by: Felix Yan <felixonmars@archlinux.org>
Link: https://lore.kernel.org/r/20240730063746.176245-1-felixonmars@archlinux.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>