Merge pull request #1571 from jeffreyalien/sn560-capabilities

wdc: Increment WDC Plugin Version

wdc: Increment WDC Plugin Version

Signed-off-by: Jeff Lien <jeff.lien@wdc.com>

Merge pull request #1568 from jeffreyalien/sn560-capabilities

wdc: Fix SN560 Device Capabilities

Merge pull request #1570 from igaw/sfx-get_lat_stats_log-csd3000

Sfx get lat stats log csd3000

sfx: remove unsupport ouptut option for query_cap and change_cap cmd

Signed-off-by: Wei Hou <wei.hou@scaleflux.com>

sfx: get_lat_stats_log support for csd3000

Signed-off-by: Wei Hou <wei.hou@scaleflux.com>

Merge pull request #1567 from linux-nvme/dependabot/github_actions/actions/setup-python-4

build(deps): bump actions/setup-python from 3 to 4

build(deps): bump actions/setup-python from 3 to 4

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 3 to 4.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](https://github.com/actions/setup-python/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Merge pull request #1569 from igaw/ci-add-python-version

ci: add python version to setup-python environment

ci: add python version to setup-python environment

v4 of the setup-python helper wants to know the python version number.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

wdc: Fix SN560 Device Capabilities

Signed-off-by: Jeff Lien <jeff.lien@wdc.com>

Merge pull request #1566 from igaw/add-kernel-dep-note

README: add note about min kernel version

README: add note about min kernel version

The min kernel version is v4.15 kernel because libnvme depends on the
/sys/class/nvme-subsystem interface.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

Merge pull request #1564 from jlevon/fix-compare

submit_io(): fix "nvme compare" to pass correct command

submit_io(): fix "nvme compare" to pass correct command

Since "18de3a6d Convert to libnvme", an "nvme compare" was being
converted incorrectly into an "nvme write" in submit_io().

Signed-off-by: John Levon <john.levon@nutanix.com>

Merge pull request #1561 from ankit-sam/master

libnvme wrap update, update power descriptor fields

print: Update power descriptor fields

1. Add missing active power workload field.
2. Use enums for power scale.
3. Fix indentation.
4. Update json entry for active power workload and
   fix idle scale.

Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>

build: update libnvme wrap

Fetch power state descriptor enums from libnvme

Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>

Merge pull request #1554 from hanumanthuh/master

Micron plugin version 1.0.14

Micron plugin version 1.0.14

Merge pull request #1550 from igaw/log-connect-errors

Log connect errors

fabrics: Already connected uses a different error code

The libnvme library reports connection errors with it's own error
codes, e.g. ENVME_CONNECT_ALREADY stands for already connected. Update
the connect-all call so that it prints 'already connected' again.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

build: Update libnvme wrap

Get connect error codes feature from libnvme

Signed-off-by: Daniel Wagner <dwagner@suse.de>

Merge pull request #1549 from igaw/list-subsys-ana

nvme-print: Show ANA state only for one namespace

Merge pull request #1552 from ankit-sam/master

print: Update nvme id-ctrl ctratt fields and small cleanup

print: Update nvme id-ctrl ctratt fields and small cleanup

Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>

nvme-print: Show ANA state only for one namespace

'nvme list-subsys' shows the state of all controllers belonging to a
subsystem. The ANA state is a per namespace attribute hence it only
makes sense to show it if the user lists the subsystem for a
namespace.

Fixes: 7435ed9ae6a6 ("nvme-print: Show paths from the first namespace only")
Signed-off-by: Daniel Wagner <dwagner@suse.de>

Merge pull request #1532 from jeffreyalien/tp-4068-4084-master

Changes to support TP-4068  and TP-4084

doc: Update to verify and write-zeroes for TP-4068

Signed-off-by: Jeff Lien <jeff.lien@wdc.com>

nvme: 64-bit Reference Tags and TP-4068 changes

Signed-off-by: Brandon Paupore <brandon.paupore@wdc.com>
Signed-off-by: Jeff Lien <jeff.lien@wdc.com>

print: Update show-regs for TP-4084

Signed-off-by: Jeff Lien <jeff.lien@wdc.com>

print: Fix json_ctrl_registers 64 bit fields

Signed-off-by: Jeff Lien <jeff.lien@wdc.com>

build: Update libnvme dependency revision

Get the TP-4068 and TP-4084 changes.

Signed-off-by: Jeff Lien <jeff.lien@wdc.com>

Merge pull request #1548 from jeffreyalien/new-dev-support

wdc:  Add support for new WDC Devices

Merge pull request #1547 from igaw/build-docs-on-arch

docs: Don't confuse asciidoc with asciidoctor

wdc:  Add support for new WDC Devices

Signed-off-by: Jeff Lien <jeff.lien@wdc.com>

docs: Don't confuse asciidoc with asciidoctor

Apparently, asciidoc and asciidoctor are two different
projects. nvme-cli depends on the former. Depend on asciidoc only and
make it a hard dependency when the user ask to build the doc.

Fixes: 6b18babf40d4 ("docs: Search for 'asciidoctor' as alternative")
Signed-off-by: Daniel Wagner <dwagner@suse.de>

Merge pull request #1545 from igaw/build-docs-on-arch

docs: Search for 'asciidoctor' as alternative

docs: Search for 'asciidoctor' as alternative

There are alternative binary names for asciidoctor. Search for
'asciidoc' or 'asciidoctor' when building the docs.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

Merge pull request #1540 from igaw/list-subsys-show-path-once

nvme-print: Show paths from the first namespace only

Merge pull request #1537 from lgdacunha/Solidigm_VU_garbage_collect_log

Added Vendor Unique Solidigm Garbage Collect Log.

Added Vendor Unique Solidigm Garbage Collect Log.

nvme-print: Show paths from the first namespace only

When listing the subsystem, show the path from the first namespace
only. Every namespace has the same paths for a subsystem. This avoids
listening the same controllers for each namespace.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

Merge pull request #1531 from igaw/apply-json-config

fabrics: Honor config file for connect-all

fabrics: Honor config file for connect-all

The command line option -J config.json allows to provide a
configuration via a JSON file. We handle this correctly for the
'connect' case but fail to apply the configuration for 'connect-all'
because we missed to add nvme_read_config() in this path.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

Merge pull request #1528 from igaw/fix-mec-field

nvme-print: Show mec field in human output instead of vwci

nvme-print: Show mec field in human output instead of vwci

Looks like a copy&past error for the human output.

Reported-by: mgerdts
Signed-off-by: Daniel Wagner <dwagner@suse.de>
Fix: 43460fcce21b ("nvme: add identify controller structure 2.0 spec. fields")

Merge pull request #1526 from igaw/clarify-lisence

treewide: Add SPDX identifier

build: Clarify current main project license

The original desired license for the project was GPL-2.0-or-later
but during the development a few files (e.g. fabrics.c and nvme.h)
got added which are licensed as GPL-2.0-only, which renders the
whole project to GPL-2.0-only.

Update the meson license field and the nvme.spec license field.
While at it mentions this in the contributions notes as well.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

treewide: Add SPDX identifier

Add the default project wide license SPDX identifier GPL-2.0-or-later
to all files which do not have any copyright statement.

Add the GPL-2.0-or-later or GPL-2.0-only according the copyright
statement listed in the file.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ocp: Update license to GPL-2.0-or-later

When I reviewed the plugin I asked wrongly for GPL-2.0-only. The
project is using the GPL-2.0-or-later license. Relax the license
requirement to GPL-2.0-or-later.

Cc: Wei Zhang <wzhang@fb.com>
Cc: Venkat Ramesh <venkatraghavan@fb.com>
Signed-off-by: Daniel Wagner <dwagner@suse.de>
Signed-off-by: Arthur Shau <arthurshau@fb.com>
Link: https://lore.kernel.org/r/20220517060256.6733-1-dwagner@suse.de

nvme-rpmb: Update license to GPL-2.0-or-later

The project is using the GPL-2.0-or-later license. Relax the license
requirement to GPL-2.0-or-later.

Signed-off-by: Daniel Wagner <dwagner@suse.de>
Signed-off-by: Hanumanthu H <hanumanthuh@micron.com>
Link: https://lore.kernel.org/r/20220517062806.9448-1-dwagner@suse.de

Merge pull request #1525 from glimchb/master

ci: add static library compilation

ci: bump meson version from 0.53.2 to 0.61.2

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

ci: disable werror for uuid subproject

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

subprojects: libnvme.wrap update for static uuid

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

ci: add static library compilation

Now possible since we can use uuid for fallback

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

Merge pull request #1523 from jeffreyalien/sn810-2-master

Changes for WDC SN810-2 Drive

Merge pull request #1510 from lgdacunha/feature/SMART_VU_plugin

Feature/smart vu plugin

solidigm: Add Solidigm pluging for vendor specific SMART fields.

Merge pull request #1527 from igaw/remove-parser

util: Remove unused parser

util: Remove unused parser

There is no user for parser. Remove the implementation.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

Merge pull request #1524 from glimchb/master

build: use uuid wrap for fallback build

build: use uuid wrap for fallback build

see util-linux/util-linux#1657

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

Merge pull request #1518 from bmouring/master

completions: Collapse declaration and attribute assignment

Merge pull request #1513 from Foxboron/morten/systemd-service

meson_options: Include system sub directory

Merge pull request #1522 from igaw/sfx-byte-align

sfx: align fixes + smartlog

sfx: support query-cap change-cap for sfx csd3000

Support query-cap change-cap for myrtle

Co-authored-by: yjin <yuekun.jin@scaleflux.com>
Signed-off-by: Wei Hou <wei.hou@scaleflux.com>

sfx: fixed some of add_smart_log_items not shown issue

sfx: fixed byte aligned issue; add additional smart log items

Merge pull request #1498 from sc108-lee/passthru

nvme: Fix error when passthru does not match opcode based flags

wdc: Add vs-temperature-stats for SN810-2

Signed-off-by: Jeff Lien <jeff.lien@wdc.com>

wdc: Updated field descriptions in vs-cloud-log command

  Fixed printout of 16 byte smart log fields

Signed-off-by: Jeff Lien <jeff.lien@wdc.com>

wdc: Update wdc plugin version to 2.0.0

Signed-off-by: Jeff Lien <jeff.lien@wdc.com>

doc: Add doc files for wdc vs-device-waf command

Signed-off-by: Jeff Lien <jeff.lien@wdc.com>

wdc: add vs-device-waf command

Signed-off-by: Jeff Lien <jeff.lien@wdc.com>

completions: Collapse declaration and attribute assignment

Previously, the associative arrays for the vendor/subcommands and
vendor/functions listings were split into a declaration of type
(using "typeset") and attribute definition (using "readonly"). On
bash 5.1.16 (at least), this lead to the following error (reported
after enabling -xv to expand and print shell inputs)

  ...
  + . /usr/share/bash-completion/completions/nvme
  # bash tab completion for the nvme command line utility
  # (unfortunately, bash won't let me add descriptions to cmds)
  # Kelly Kaoudis kelly.n.kaoudis at intel.com, Aug. 2015

  # Constant to indicate command has no options
  readonly NO_OPTS=""
  ++ readonly NO_OPTS=
  ++ NO_OPTS=

  # Associative array of plugins and associated subcommands
  # Order here is same as PLUGIN_OBJS in Makefile
  typeset -A _plugin_subcmds
  ++ typeset -A _plugin_subcmds
  readonly _plugin_subcmds=(
          [intel]="id-ctrl internal-log lat-stats \
  ...
  ++ _plugin_subcmds=(['intel']='id-ctrl internal-log lat-stats...
  bash: 'intel': syntax error: operand expected (error token is "'intel'")
  ...

Using the available flags for "typeset" to declare the variables as
readonly arrays resolved the issue (and allows for bash completion
to work as-expected)

Signed-off-by: Brad Mouring <bmouring@gmail.com>

Merge pull request #1517 from glimchb/master

README: add more badges

README: add more badges

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

meson_options: Include system sub directory

Signed-off-by: Morten Linderud <morten@linderud.pw>

Merge pull request #1512 from hreinecke/coverity

Coverity fixes

Merge pull request #1511 from vincentkfu/addr-cleanup

fabrics: fix help string for connect traddr option

nvme: add '--groups' option to nvme ana-log

Coverity complained that the 'groups' variable was never changed,
so implement a '--groups' option to 'nvme ana-log'.

Signed-off-by: Hannes Reinecke <hare@suse.de>

nvme: coverity fixes

Coverity found some logic issues and resource leaks.

Signed-off-by: Hannes Reinecke <hare@suse.de>

nvme-rpmb: fixup resource leaks

Found by coverity.

Signed-off-by: Hannes Reinecke <hare@suse.de>

nvme-models: fixup resource leaks

Found by coverity.

Signed-off-by: Hannes Reinecke <hare@suse.de>

fabrics: 'e->traddr' is static

Found by coverity.

Signed-off-by: Hannes Reinecke <hare@suse.de>

util/argconfig: fixup possible overflows

Found by coverity.

Signed-off-by: Hannes Reinecke <hare@suse.de>

plugins/zns: fixup resource leaks

Found by coverity.

Signed-off-by: Hannes Reinecke <hare@suse.de>

plugins/ymtc: fixup resource leaks

Found by coverity.

Signed-off-by: Hannes Reinecke <hare@suse.de>

plugins/virtium: fixup possible string overflows

Found by coverity.

Signed-off-by: Hannes Reinecke <hare@suse.de>

plugins/toshiba: fix resource leak

Found by coverity.

Signed-off-by: Hannes Reinecke <hare@suse.de>

plugins/seagate: fixup byte calculation

When calculating the number of bytes from the number of blocks one
has to ensure that the values can't overflow, so use a large data
type for the number of bytes than for the number of blocks.

Signed-off-by: Hannes Reinecke <hare@suse.de>

plugins/scaleflux: fixup fgetc() usage

fgetc() actually returns an unsigned char.
Found by coverity.

Signed-off-by: Hannes Reinecke <hare@suse.de>

plugins/ocp: remove dead code

Found by coverity.

Signed-off-by: Hannes Reinecke <hare@suse.de>

plugins/wdc: coverity fixes

Coverity found an off-by-one error when printing raw values; looks
like someone forgot convert the 1-based NVMe spec convention into
the 0-based C convention.
And, of course, various resource leaks.

Signed-off-by: Hannes Reinecke <hare@suse.de>

plugins/wdc: fixup error printing and possible size overflow

Fixup handling of error codes and possible overflows when printing
LBA values.

Signed-off-by: Hannes Reinecke <hare@suse.de>

plugins/micron: coverity fixes

Cleanup possible string overflows and fix resource leaks found
by coverity.

Signed-off-by: Hannes Reinecke <hare@suse.de>

plugins/memblaze: coverity fixes

Fixed some resource leaks and possible string overflows.

Signed-off-by: Hannes Reinecke <hare@suse.de>

plugins/intel: fix logic errors

Fixup some logic errors found by coverity.

Signed-off-by: Hannes Reinecke <hare@suse.de>