Daniel Wagner [Tue, 15 Mar 2022 18:25:22 +0000 (19:25 +0100)]
fabrics: Honor sysconfdir for hostnqn and hostid files
When sysconfdir is set during build the hostnqn and hostid file should
be installed under this path. Replace the hard coded path and also
update the documentation.
Daniel Wagner [Tue, 15 Mar 2022 18:08:25 +0000 (19:08 +0100)]
build: Copy include adoc files to build dir
asciidoctor wants all file to live under one common directory root,
thus we can't provide a search path for the include files. Copy
include files to the build dir.
Tomas Bzatek [Mon, 14 Mar 2022 17:15:20 +0000 (18:15 +0100)]
connect: Set errno to zero on nvmf_add_ctrl() success
The libnvme's nvmf_add_ctrl() might return zero (success) while
having errno set to a non-zero value due to lots of calls inside.
And since nvmf_connect() returns errno primarily, make sure
it's zeroed on success.
See related https://github.com/linux-nvme/libnvme/pull/292
Daniel Wagner [Fri, 11 Mar 2022 16:46:46 +0000 (17:46 +0100)]
nvme: constify variable in list_subsys
The compiler complains with
../nvme.c: In function ‘list_subsys’:
../nvme.c:2478:19: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
2478 | n = strrchr(devicename, 'n');
| ^
devicename is of type 'const char *' so the returning pointer is of
the same type. Thus constify the n variable.
Daniel Wagner [Fri, 11 Mar 2022 16:30:08 +0000 (17:30 +0100)]
build: Enable docs build in update docs script
Commit 59263bbcd3e4 ("build: Use boolean type for docs-build default")
introduced a command line option to enable docs build. Let's enable
this in the update docs script.
Hannes Reinecke [Fri, 11 Mar 2022 08:16:09 +0000 (09:16 +0100)]
nvme: print out ANA state for 'list-subsys'
Commit 00aeb92 ("nvme-list-subsys: Add device name argument
and print out ANA state") was not properly ported to libnvme/nvme-cli.
So port the missing bits.
Daniel Wagner [Tue, 8 Mar 2022 14:32:25 +0000 (15:32 +0100)]
nvme: Explicit initialize all command line options
Sort the command line options like the appear on the command line.
Also tabilize and initialize all command options. The consistent
aligment of the options makes the reviewing simpler.
Steven Seungcheol Lee [Fri, 4 Mar 2022 07:05:32 +0000 (16:05 +0900)]
Add build_assert to fix debug build error
../ccan/ccan/str/str.h:169:10: fatal error: ccan/build_assert/build_assert.h: No such file or directory
169 | #include <ccan/build_assert/build_assert.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
Daniel Wagner [Tue, 1 Mar 2022 15:10:25 +0000 (16:10 +0100)]
nvme-cli: Ignore traddr case
There was is no requirement in the NVME-FC specification that traddr
needs to be upper or lower case. Given the case difference, the
connect-all fails the match logic. Switch to strcasecmp for a
case insensitive compare.
Based on 1264c6323937 ("nvme-cli: Make connect-all matching be case
insensitive")
Martin George [Tue, 1 Mar 2022 11:52:36 +0000 (17:22 +0530)]
nvme: fix segfault in nvme telemetry-log error handling
After the upgrade to libnvme, the nvme telemetry-log command
segfaults for error scenarios as shown below:
NVMe status: Invalid Log Page: The log page indicated is invalid(0x4009)
Failed to acquire telemetry log 16393!
Segmentation fault (core dumped)
Freeing the telemetry log page header for error scenarios is already
handled in the libnvme. So avoid freeing this again here, which led to
this segfault.
Daniel Wagner [Fri, 25 Feb 2022 12:57:05 +0000 (13:57 +0100)]
fabrics: ensure zero kato for non-persistent controllers
Add a helper function that sets the default kato value for the
discovery controllers. Along with ensuring a non-zero kato value
(i.e. NVMF_DEF_DISC_TMO) is passed to a persistent discovery
controller, it also ensures a zero kato value is passed to a
non-persistent discovery controller, as mandated by the NVMe spec.
Signed-off-by: Martin George <marting@netapp.com>
[dwagner: ported from monolithic branch] Signed-off-by: Daniel Wagner <dwagner@suse.de>
Daniel Wagner [Tue, 22 Feb 2022 09:21:29 +0000 (10:21 +0100)]
intel: Workaround initializer element is not constant
Older gcc do not like the constant initializer expression in the intel
plugin:
../plugins/intel/intel-nvme.c: In function ‘lat_stats_log_scale’:
../plugins/intel/intel-nvme.c:662:47: error: initializer element is not constant
static const int LATENCY_STATS_V4_BASE_VAL = (
Martin George [Mon, 21 Feb 2022 10:17:24 +0000 (15:47 +0530)]
nvme-print: fix 'nvme list -o json' segfault
After the recent upgrade to libnvme, 'nvme list -o json' segfaults
due to incorrect json object type passed here. So fix this by passing
the appropriate json object type and invoking it outside the
nvme_for_each_host loop.
Martin George [Mon, 21 Feb 2022 05:09:14 +0000 (10:39 +0530)]
nvme: get_ns_id command fails on nvme device
The get-ns-id command currently prints the perror status for a
given nvme device rather than its nsid. Fix this by properly
checking the return status of the nvme_get_nsid() function.
Martin George [Wed, 16 Feb 2022 18:33:20 +0000 (00:03 +0530)]
netapp-nvme: fix nvme ns desc uuid handling for ontapdevices
The nvme ns desc uuid handling in the NetApp plugin for
ontapdevices is broken after the recent upgrade to libnvme. The
uuid hanlding logic here was flawed to begin with, so rework this
code to ensure the respective uuid descriptor itself is stored in
the ontapdevice_info structure and processed appropriately.
Jeff Lien [Mon, 14 Feb 2022 22:32:19 +0000 (16:32 -0600)]
wdc: Fix use-after-free access of cbs_data
Fix incorrect access after memory is already freed up. Also couple
of minor fixes to use correct cpu endianness while accessing data
read from drive.
Create a new function wdc_get_fw_cust_id that will simplfy the code
and handle the free of the allocated data
Signed-off-by: Jeff Lien <jeff.lien@wdc.com> Co-Authored-by: Indraneel-M
[dwagner: updated commit message and merged everything into one patch] Signed-off-by: Daniel Wagner <dwagner@suse.de>
Daniel Wagner [Tue, 15 Feb 2022 15:05:32 +0000 (16:05 +0100)]
nvme: Update help text for --force
The short flag version --force has been removed in 90592d5188fe ("nvme: Consolidate --force option and udpate
documetation") but the help text didn't get updated.
Daniel Wagner [Tue, 15 Feb 2022 15:00:53 +0000 (16:00 +0100)]
nvme: Open device exclusive for write command
Commit 2100609ddefb ("nvme: open namespace exclusive by default")
tried to make the write command a bit safer by asking to open the
device exclusive. Because the commit got reverted let's add the main
change back which is to use O_EXCL for write commands on default.
Daniel Wagner [Tue, 15 Feb 2022 14:26:37 +0000 (15:26 +0100)]
nvme: Only open device once
open_exclusive() takes care with opening the device. Do not open a
second time the device.
open_exclusive() has an overwrite flag. Document it a bit better by
renaming it what it actually means. The idea here is that the device
is openened with O_EXCL and when forced is used, open without this
flag.
Fix this by passing the appropriate json array type for
ontapdevices. Include a couple of minor changes here as well -
add a newline to the end of the json output, and then free the
json root device.
projects / users / sagi / nvme-cli.git / log