Martin George [Mon, 21 Feb 2022 10:17:24 +0000 (15:47 +0530)]
nvme-print: fix 'nvme list -o json' segfault
After the recent upgrade to libnvme, 'nvme list -o json' segfaults
due to incorrect json object type passed here. So fix this by passing
the appropriate json object type and invoking it outside the
nvme_for_each_host loop.
Martin George [Wed, 16 Feb 2022 18:33:20 +0000 (00:03 +0530)]
netapp-nvme: fix nvme ns desc uuid handling for ontapdevices
The nvme ns desc uuid handling in the NetApp plugin for
ontapdevices is broken after the recent upgrade to libnvme. The
uuid hanlding logic here was flawed to begin with, so rework this
code to ensure the respective uuid descriptor itself is stored in
the ontapdevice_info structure and processed appropriately.
Jeff Lien [Mon, 14 Feb 2022 22:32:19 +0000 (16:32 -0600)]
wdc: Fix use-after-free access of cbs_data
Fix incorrect access after memory is already freed up. Also couple
of minor fixes to use correct cpu endianness while accessing data
read from drive.
Create a new function wdc_get_fw_cust_id that will simplfy the code
and handle the free of the allocated data
Signed-off-by: Jeff Lien <jeff.lien@wdc.com> Co-Authored-by: Indraneel-M
[dwagner: updated commit message and merged everything into one patch] Signed-off-by: Daniel Wagner <dwagner@suse.de>
Daniel Wagner [Tue, 15 Feb 2022 15:05:32 +0000 (16:05 +0100)]
nvme: Update help text for --force
The short flag version --force has been removed in 90592d5188fe ("nvme: Consolidate --force option and udpate
documetation") but the help text didn't get updated.
Daniel Wagner [Tue, 15 Feb 2022 15:00:53 +0000 (16:00 +0100)]
nvme: Open device exclusive for write command
Commit 2100609ddefb ("nvme: open namespace exclusive by default")
tried to make the write command a bit safer by asking to open the
device exclusive. Because the commit got reverted let's add the main
change back which is to use O_EXCL for write commands on default.
Daniel Wagner [Tue, 15 Feb 2022 14:26:37 +0000 (15:26 +0100)]
nvme: Only open device once
open_exclusive() takes care with opening the device. Do not open a
second time the device.
open_exclusive() has an overwrite flag. Document it a bit better by
renaming it what it actually means. The idea here is that the device
is openened with O_EXCL and when forced is used, open without this
flag.
Fix this by passing the appropriate json array type for
ontapdevices. Include a couple of minor changes here as well -
add a newline to the end of the json output, and then free the
json root device.
Daniel Wagner [Thu, 10 Feb 2022 16:57:01 +0000 (17:57 +0100)]
argconfig: Increase the flag value
If the flag is provided several time increase the flag value. This is
a pretty ugly fix for how getopt_long_only() handles '--verbose' vs
'-v'. getopt_long_only() returns 0 when --verbose is used and 'v' for
-v hence we will not usually not take the short option path for
--verbose.
Break out in the short option parsing when non flag options are used.
Another uglyliness here is that it sets up long options differently
depending on short or long version is used. For the short version we
have to use value_addr.
Daniel Wagner [Tue, 8 Feb 2022 11:13:34 +0000 (12:13 +0100)]
nvme: Fix --force flag inversion
argparse sets the default_value member when the argument has been
provided by the user. But in parse_and_open we set O_EXCL when --force
is not used.
It also introduced a regression in the 'id-ns' where the --force flag
is used to determine which function is used to identify the
namespace (nvme_identify_allocated_ns() vs nvme_identify_ns()).
Fixes: 2100609 ("nvme: open namespace exclusive by default") Signed-off-by: Daniel Wagner <dwagner@suse.de>
Daniel Wagner [Mon, 7 Feb 2022 14:13:40 +0000 (15:13 +0100)]
build: Make CI build fail on warnings.
Currently, warnings are hidden in the logs and the build is marked as
succeeded. Mark all warnings as error so that we see them show up in
the review process.
Steven Seungcheol Lee [Fri, 7 Jan 2022 09:37:06 +0000 (18:37 +0900)]
nvme: Add nvm-id-ns-lba-format(CNS 0Ah) command from TP4095
I/O Command Set specific Identify Namespace data structure
for the specified LBA Format index for the NVM Command Set
specified in the CSI field.
None capabilities from nvme_id_ns structure are returned as 0 with this command
Set maximum nlbaf when identify ns for all ns is failed to print elbafs
Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
Steven Seungcheol Lee [Fri, 28 Jan 2022 07:53:52 +0000 (16:53 +0900)]
rpmbuild: Add json required version that detected from meson
With higher version of json-c, yum install shows required version of it
Error: Package: nvme-2.0-1.el7.x86_64 (/nvme-2.0-1.el7.x86_64)
Requires: json-c >= 0.14
Installed: json-c-0.11-4.el7_0.x86_64 (@anaconda)
json-c = 0.11-4.el7_0
Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
Steven Seungcheol Lee [Thu, 27 Jan 2022 11:40:36 +0000 (20:40 +0900)]
rpmbuild: enable rpmbuild via make rpm
Makefile:
add make rpm via meson
rename libnvme -> nvme on Makefile
meson.build, meson_options.txt:
using former path that nvme provided
using libdir to be installed right place (32bit -> lib, 64bit -> lib64)
rpmbuild:
remove unnecessary rpm stages
since rpm spec file created from meson build
no need to pacaking it to rpmbuild directory
build in meson directory
using rpmbuild directory for install & packaging rpm
Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
Andrew Maier [Thu, 3 Feb 2022 18:55:56 +0000 (11:55 -0700)]
README: Update the ubuntu install instructions
nvme-cli is now a supported package in the Ubuntu universe (from Xenial
and above). Therefore, we can remove the reference to the sbates ppa.
This patch also updates the wording around the supported packages and
architectures.
Daniel Wagner [Mon, 31 Jan 2022 13:34:33 +0000 (14:34 +0100)]
nvme: Adapt to logging changes in libnvme
libnvme allows to define which file descriptor should be used for
logging. This is only for the fabric related interface relevant hence
this is attached to the nvme_root_r object.
Use common code for this into a helper which maps the verbose command
line levels to the correct log levels.
Daniel Wagner [Fri, 28 Jan 2022 17:58:45 +0000 (18:58 +0100)]
tree: Do not map status to errno codes
The caller of the commands is not interersted in any mapping
of status codes to error codes. It only wants to know success(0) or
failure (!=0). Remove all nvme_status_to_errno() calls.
Daniel Wagner [Fri, 28 Jan 2022 13:35:50 +0000 (14:35 +0100)]
nvme: Return 0 on success and 1 on error
main() should return 0 on success and 1 on error. Generally there are
not fixed rules. Though SUSv3 specifies EXIT_SUCCESS(0) and
EXIT_FAILURE(1).
The main reason why we should avoid anything but 0/1 is the shell
interpretes those return codes. Values above 128 can cause confusion
in shell scripts. When a command is terminated by a signal, the
shell indicates this fact by setting the value of the variable $?
to 128 plus the signal number.
See also
https://stackoverflow.com/questions/1101957/are-there-any-standard-exit-status-codes-in-linux
https://tldp.org/LDP/abs/html/exitcodes.html
Daniel Wagner [Thu, 27 Jan 2022 10:06:39 +0000 (11:06 +0100)]
nvme: Call nvme_identify_*list with correct nsid offset
Commit 81bb8289f642 ("nvme: update list-ns nsid option") changed the
start index for the namespace argument. But the merge back from the
monolithic branch was incomplete and missed to update the index offset
when calling nvme_identify_allocated_ns_list and
nvme_identify_active_ns_list.
Tokunori Ikegami [Thu, 27 Jan 2022 08:31:30 +0000 (09:31 +0100)]
nvme: Use canonical types
Use the more common type names.
Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
[dwagner: carved this change from other independ change] Signed-off-by: Daniel Wagner <dwagner@suse.de>
Daniel Wagner [Fri, 21 Jan 2022 17:01:33 +0000 (18:01 +0100)]
fabrics: Stop using nvme_msg from libnvme
nvme_msg() is logging function from libnvme. The cli should not use
the logging infrastructure from the library instead it should use it's
own infrastructure. At this point nvme-cli doesn't have one, so just
use the default stderr for all error messages.
This is a preperation step to unexport the nvme_msg() from libnvme.
projects / users / sagi / nvme-cli.git / log