plugins/ocp: Add Device capability(LID: 0xC4) log page

Signed-off-by: Arunpandian J <arun.j@samsung.com>

udev: fix warning reported by udevadm verify

Fix the following warning reported by udevadm verify:

nvmf-autoconnect/udev-rules/70-nvmf-autoconnect.rules.in:18 Whitespace after comma is expected.
nvmf-autoconnect/udev-rules/70-nvmf-autoconnect.rules.in: udev rules check failed

Signed-off-by: Dmitry V. Levin <ldv@strace.io>

fabrics: fix conditions in nvmf-autoconnect.service

The unit should be started if either config.json or discovery.conf
exists. The current syntax would start it if either one does not
exist. Fix it.

Fixes: eec7634 ("fabrics: Trigger auto connect if config.json exists")
Signed-off-by: Martin Wilck <mwilck@suse.com>

fabrics: Change NVMF_OPTS as NVMF_ARGS to fix linux kernel check patch error

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme: Split passthru commands read output

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme: Fix io-passthru command read metadata output

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

build: Install missing s390 library

libjson-c-dev:s390x depends on the libgcc-s1 library.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

plugin/ocp: Added implementation for 0xC1 log page

Reviewed-by: Karthik Balan <karthik.b82@samsung.com>
Reviewed-by: Arunpandian J <arun.j@samsung.com>
Signed-off-by: Jayakanthan Rajendran <jaya.ganthan@samsung.com>

util: Fix suffix_si_parse to parse no decimal point but suffix value correctly

For example create-ns command --ncap-si paramter value 800G parsed to 0 as invalid value.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

completions: Add zsh option values handling for sanitize command action

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

completions: Add ocp sub commands zsh completion

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

completions: Add ocp commands zsh completion

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

completions: Add ocp commands bash completion

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvmf-autoconnect: restart service to avoid dropping AEN

If another discovery log page change AEN is received while the
autoconnect service is already running for a previous AEN,
the autoconnect service is not being relaunched.
For example, if some of the entries in the log page are not reachable,
attempting to connect to them may take a long time before timing out,
so AENs received while waiting for the connections have no effect.
The AEN is effectively dropped: we ignore the new discovery log entries
and worse, the controller won't send more AENs because it's waiting
for the log page to be fetched in response to the previous AEN.

Use systemctl restart instead of systemctl start
to ensure nvme connect-all is run in response to each AEN.
If a previous instance of the service is already running,
it will be interrupted and the new log page will be fetched.

Fixes: 391d3b12248a ("nvme-cli: nvmf auto-connect scripts")
Signed-off-by: Caleb Sander <csander@purestorage.com>

solidigm: Reduce memory usage in supported log pages feature

solidigm: Changes to supported log pages feature requested by review

- Retrieve supported logs for all known UUIDs
- Update 'normal' output to table format

solidigm: Add supported log pages log feature to Solidigm plugin

plugins/ocp: Added ocp unsupported requirements log page

Reviewed-by: Karthik Balan <karthik.b82@samsung.com>
Reviewed-by: Arunpandian J <arun.j@samsung.com>
Signed-off-by: Vigneshwaran Saravanan <s.vignesh@samsung.com>

completions: Add bash option values handling for sanitize command action

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

doc: Correct nvme-show-hostnqn command NAME description

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

completions: Add missing zsh commands descriptions

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

plugins/wdc: Extend SN530 support.

Extend SN530 SSD support for alternate PCI device IDs.

Fix incorrect article 'an' as 'a' to use for descriptions and message

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme: Set effects-log command csi option help message string

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

completions: bash: Delete unsupported id-iocs command options

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

completions: bash: Add id-domain command

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

completions: Fix nvm-id-ns-lba-format command zsh definition

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

completions: Add json command option

It was introduced by the change 6aab9e49e but not added for command completion.
  Note: The changes included some completion script files indentation fixes.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme: Fix get-feature command sel parameter check to allow value 8

The parameter was changed to use value 8 also by the change 30b89e5ef.
  Note: The value is used only for the command functionality to limit feature
        output changed from default but not passed to the driver.

Fixes: 63dcb68c6 ("nvme: Fix parameter limit range")
Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

util: Delete unnecessary argconfig definitions OPT_VAL and CFG_VAL

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

util: Delete argconfig value type to add option value as va lists instead

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

util: Split to set argconfig option value

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

util: Delete argconfig value length to calcurate instead

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme: Change sanitize command action option to use argconfig parse value

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

util: Add argconfig parse value function

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

util: Delete unused argconfig subopts type

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

util: Delete unused argconfig file types

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

util: Delete unused argconfig help function

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-wrap: do_admin_args_op should not clear args timeout

if set with NVME_DEFAULT_IOCTL_TIMEOUT, timeout parameter always ignored

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
Reported-by: Daseul Lee <daseul.lee@samsung.com>

nvme: Fix linux kernel check patch warnings

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme: Fix linux kernel check patch errors

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

plugins/ocp: Add telemetry-log command to OCP plugin

plugins/ocp: Add OCP set latency monitor feature command

plugins/ocp: Fix endianness in Latency Monitor Log output

OCP 2.0 spec changed the endianness for some of the fields in the C3 LM Log. Fixed this when outputting the values.

plugins/ocp: Add missing fields in Latency Monitor Log

Changes include:
- Added Debug Log Measured Latency, Debug Log Latency Time Stamp, Debug Log Pointer, Debug Counter Trigger Source, Debug Log Stamp Units, Log Page Version, and Log Page GUID, as required by OCP 2.0 spec.
- Reorganized some of the output so that it (mostly) matches the order in which they show up in the spec.

plugins/ocp: Fix typos in Latency Monitor Log

Changes include:
- Fixed the naming of some log page C3 constants that were incorrectly labelled as C0.
- Fixed a typo in the JSON output: 'lantency' -> 'latency'

plugins/ocp: Reorganize OCP plugin source code

Shifted the location of some functions around so they're grouped together better. Also added separators in the comments so it's easy to distinguish which block of functions pertain to what command.

tests: Add tests for controller reset

Signed-off-by: Arunpandian J <arun.j@samsung.com>

plugin/solidigm: Added vs-internal-log command.

nvme: Add nvme_show_perror to use instead of perror for json output

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Use vasprintf instead of vsnprintf to allocate string

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme: fix rnlpt to_string() values.

"Reservation Notification Log Page Type" values do not start
from 0x1 but from 0x0.

Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>

build: Bump libnvme wrap to fix io_mgmt apis

TP4146 Flexible Data Placement 2022.11.30 Ratified Command Dword 10
Bits[31:16] : Management Operation Specific (MOS)
Bits[07:00] : Management Operation (MO)
https://github.com/linux-nvme/libnvme/pull/626

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>

nvme: fix io_mgmt args parse error

Since mos defined __u16, it should be parsed with OPT_SHRT
if mos given right after mo, it cause parse error
mo always set as 0

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
Co-authored-by: Minsik Jeon <hmi.jeon@samsung.com>
Reported-by: Youngjin Jung <yj4369.jung@samsung.com>

fdp: set-events feature is saveable

TP4146 Flexible Data Placement 2022.11.30 Ratified
5.27.1.TBD1 Flexible Data Placement Events (Feature Identifier 1Eh)
mentioned as below
This Feature shall be saveable (refer to section 4.2).

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
Reported-by: Youngjin Jung <yj4369.jung@samsung.com>

fabrics: Return errno value as negative

Changes for linux kernel check patch warnings remained.
Change to use `//` instead for proper SPDX comment style.
And also change symbolic permissions `S_IRUSR | S_IWUSR' as '0600'.
  Note: Still remaining a check patch error.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

fabrics: Fix linux kernel check patch errors and warnings

Note: Still remaining some errors warnings.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nbft: add the nbft show plugin

Display contents of the ACPI NBFT files.

Usage: nvme nbft show <device> [OPTIONS]

Options:
  [  --output-format=<FMT>, -o <FMT> ]  --- Output format: normal|json
  [  --subsystem, -s ]                  --- show NBFT subsystems
  [  --hfi, -H ]                        --- show NBFT HFIs
  [  --discovery, -d ]                  --- show NBFT discovery controllers
  [  --nbft-path=<STR> ]                --- user-defined path for NBFT tables

Signed-off-by: Stuart Hayes <stuart_hayes@dell.com>
Signed-off-by: Martin Wilck <mwilck@suse.com>
Signed-off-by: John Meneghini <jmeneghi@redhat.com>

nbft: added NBFT v1.0 table support

Added support for parsing the contents of the NBFT table (per NVMe-oF
boot specification v1.0) with the connect-all and discover commands.

nvme discover/connect-all --nbft ignore /etc/nvme config and use NBFT tables
nvme discover/connect-all --no-nbft ignore NBFT tables and use /etc/nvme config
nvme discover/connect-all --nbft-path=<STR> user-defined path for NBFT tables

Signed-off-by: Stuart Hayes <stuart_hayes@dell.com>
Signed-off-by: Martin Belanger <martin.belanger@dell.com>
Use the new nbft public API.

Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>
Signed-off-by: Martin Wilck <mwilck@suse.com>
Signed-off-by: John Meneghini <jmeneghi@redhat.com>

nbft: make lookup_ctrl function public

To prepare for the addition of nbft functionality fixup the fabrics
declarations.

Signed-off-by: John Meneghini <jmeneghi@redhat.com>

nvme: Fix indentation errors around nvme show error API

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme: Check validate output format err value instead of flags

Since the nvme print flags enum value not set to the negative value.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme: Use nvme show error API to outptu stderr messages for json format

Multiple lines std error messages are remained yet since unsupported by the API.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

util: Check output format json for json error message output

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-printf: Add show error function for nvme list command json output

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

build: Extend static linked binary build test

So far, the binary was still linking against the libc dynamically.
The final step to link completely statically can be achieved by setting
the LDFLAGS environment variable.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

build: Fix appimage configuration

Typo in the arguments to the ftp upload stage. The default mode is
already correct, so just drop it.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

doc: Update REAMDE

Update the build from source section and shorten the distro install
section.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

build: Update wrap mode defaults

We switched the default of the wrap mode to nofallback. Update the CI
builds accordingly.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

build: Extend summary section

List also the dependencies and the user configuration in the summary.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

build: Make json-c dependency lookup not fail

Let's relax the dependency on json-c, when the comman line option is set
to auto. It will just ignore the dependency if not found.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

build: Disable fallback on default

meson's default setting for wrap mode is to attempt to download missing
dependencies. Disable this feature as the community is unhappy with
this default behavior.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

build: Bump libnvme wrap

Get the wrap mode disable settings

Signed-off-by: Daniel Wagner <dwagner@suse.de>

build: Bump libnvme.wrap to align create ns args

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>

nvme: Add zns specfic field for create ns

nvme_ns_mgmt_host_sw_specified_zns from TP4115 ZNS Namespace Management Enhancements 2022.03.15 Ratified

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>

nvme: Add ns-mgmt host software specified fields

nphndls, phndl from TP4146 Flexible Data Placement 2022.11.30 Ratified

Reported-by: Youngjin Jung <yj4369.jung@samsung.com>
Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>

nvme: Add dtype, dspec on write-zeroes, write-uncor

Based on TP4146 Flexible Data Placement 2022.11.30 Ratified

Reported-by: Youngjin Jung <yj4369.jung@samsung.com>
Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>

nvme-print: Add new fields print on id directive

Identify Directive – Return Parameters Data Structure
From TP4146 Flexible Data Placement 2022.11.30 Ratified

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>

nvme-print: Add VWCNP on NSFEAT of id-ns

Identify – I/O Command Set Independent Identify Namespace Data Structure
From TP4146 Flexible Data Placement 2022.11.30 Ratified

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>

nvme: Fix format command to skip to reread NSID all block device

Since if NSID all specified NS data is not identified so the reread failed.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

plugins/solidigm: Fixes and clean-up of Telemetry parse code.
Fixed parsing of 64 bit values.
Fixed COD field name.
Fixed compilation warnings when compiling for 32 bit.
Added missing free().
Consolidated single entry function to telemetry parser.
Consolidated use of integer types.

doc: Documentations maintenance changes

Change the following commands documentations.
  1. admin-passthru
  2. get-feature
  3. set-feature
  4. clear-fw-activate-history

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

doc: Add nvme-mi-send command documentation

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

doc: Add nvme-mi-recv command documentation

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

doc: Add clear-pcie-correctable-error-counters command documentation

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

doc: Add eol-plp-failure-mode command documentation

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

plugins/solidigm: Add firmware activation history log to Solidigm plugin

plugins/ocp: Add firmware activation history log to OCP plugin

nvme-print: Use enum nvme_print_flags for nvme_show_id_ctrl

gcc is complaining that the function declaration and definition do not
match. Update the declaration accordingly.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

nvme: Add support for NVMe-MI send command

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme: Use stdout for passthru and submit_io commands success messages

Also fix submit_io command indentation errors.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme: Fix passthru command function indentation errors

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme: Add support for NVMe-MI receive command

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

fabrics: fix fc config JSON file handling

Unlike other nvme transports, nvme/fc connection requires a valid
host_traddr in addition to traddr and transport type. Current fc
config JSON handling is broken due to the host_traddr not getting
updated even if explicitly listed in the JSON file, as shown below:

nvme connect-all -J /usr/local/etc/nvme/config.json
Failed to write to /dev/nvme-fabrics: Invalid argument

And the below error is logged in the messages file for the same:

nvme_fabrics: missing parameter 'host_traddr=%s'

Fix this by ensuring the relevant host_traddr string is appropriately
passed to the respective nvme controller structure. And while we are
at it, ensure the host_iface string is updated too but noting that it
is only applicable to tcp alone, and not rdma or fc.

Signed-off-by: Martin George <marting@netapp.com>

build: Fetch all references before using git describe

The release script is using git describe to get the references string of
the library. The returned string validated if it is a valid release
string, e.g. v1.4. If not we abort the operation.

Thus we need to make sure that we have all references including the
tags, thus do a git fetch --all first.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

build: Deploy AppImage only for push on master

Signed-off-by: Daniel Wagner <dwagner@suse.de>

build(deps): bump sand4rt/ftp-deployer from 1.4 to 1.7

Bumps [sand4rt/ftp-deployer](https://github.com/sand4rt/ftp-deployer) from 1.4 to 1.7.
- [Release notes](https://github.com/sand4rt/ftp-deployer/releases)
- [Commits](https://github.com/sand4rt/ftp-deployer/compare/v1.4...v1.7)

---
updated-dependencies:
- dependency-name: sand4rt/ftp-deployer
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

build: Use sftp transport for AppImage deploy step

Also split deploy strep from build step.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

build: Add external AppImage upload workflow

After building the AppImage upload it to an external server.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

doc: Regenerate all docs for v2.4

Signed-off-by: Daniel Wagner <dwagner@suse.de>