Spencer E. Olson [Mon, 10 Oct 2016 14:14:19 +0000 (08:14 -0600)]
staging: comedi: ni_mio_common: split out ao arming from ni_ao_inttrig
AO device arming was previously done as a part of ni_ao_inttrig which is
called as a result of the user calling comedi_internal_trigger. For
start_src == TRIG_EXT, this does not make very much sense since external
triggers should not conceptually need to be software triggered also. This
patch splits out the arming functionality to allow arming to specifically
and separately be done via the CONFIG_INSN_ARM ioctl command.
In order to provide backwards compatibility, this patch also provides
automatic arming if ni_ao_inttrig is simply called.
Signed-off-by: Spencer E. Olson <olsonse@umich.edu> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Spencer E. Olson [Sat, 8 Oct 2016 21:38:43 +0000 (15:38 -0600)]
staging: comedi: make constants slightly more consistent
This makes INSN_CONFIG_DIO_{INPUT,OUTPUT,OPENDRAIN} simply be copies of the
already-existing constants COMEDI_INPUT, COMEDI_OUTPUT, and
COMEDI_OPENDRAIN.
This change also ensures that if a user happens to use, for example,
COMEDI_INPUT in place of where INSN_CONFIG_DIO_INPUT, the result will
always be the same and also acceptable and correct usage.
Signed-off-by: Spencer E. Olson <olsonse@umich.edu> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Spencer E. Olson [Sat, 8 Oct 2016 21:37:29 +0000 (15:37 -0600)]
staging: comedi: porting NI_GPCT constants from comedi.org module
Information pertaining to the NI_GPCT_ARM* registers were added to the
comedi.org version of the comedi kernel. This adds this information to
the staging-tree version of the comedi kernel. Relevant comments are also
copied over.
Signed-off-by: Spencer E. Olson <olsonse@umich.edu> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Tue, 11 Oct 2016 13:16:55 +0000 (15:16 +0200)]
staging: vc04_services: fix up rpi firmware functions
The raspberrypi-firmware.h file should provide empty functions if we
aren't building in that option. This makes it easier to test-build
code, and not have odd warnings about unused variables if you just try
to #define away the functions.
Cc: Daniel Stone <daniels@collabora.com> Cc: "Noralf Trønnes" <noralf@tronnes.org> Cc: Pranith Kumar <bobby.prani@gmail.com> Cc: popcornmix <popcornmix@gmail.com> Cc: Eric Anholt <eric@anholt.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel pointers should be printed with %pK and are not unsigned int big
on all architectures. So fix this up to get rid of a bunch of warning
messages.
Note, there are other assumptions in this code that a pointer fits into
an int that need to be fixed up later.
Cc: Daniel Stone <daniels@collabora.com> Cc: "Noralf Trønnes" <noralf@tronnes.org> Cc: Pranith Kumar <bobby.prani@gmail.com> Cc: popcornmix <popcornmix@gmail.com> Cc: Eric Anholt <eric@anholt.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
You don't define a function prototype on one line as a #define, and then
the next declare it as an external C function, without expecting a C
compiler to complain loudly.
So fix up this mess.
Cc: Daniel Stone <daniels@collabora.com> Cc: "Noralf Trønnes" <noralf@tronnes.org> Cc: Pranith Kumar <bobby.prani@gmail.com> Cc: popcornmix <popcornmix@gmail.com> Cc: Eric Anholt <eric@anholt.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Harman Kalra [Sun, 9 Oct 2016 15:35:03 +0000 (21:05 +0530)]
Staging: i4l: icn: prefer pr_* instead of printk
This patch replaces call to printk with appropriate pr_*
function thus addressing the following warning generated by the
checkpatch script:
Prefer [subsystem eg: netdev]_dbg([subsystem]dev, ... then
dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ...
Sabitha George [Mon, 10 Oct 2016 06:33:12 +0000 (12:03 +0530)]
staging: ks7010: use netdev_* instead of printk()
1. Fixes checkpatch warning on printk usage in ks_hostif.c
2. Dropped "ks_wlan" prefix from the messages
3. Removed the "Memory squeeze,dropping packet" messages
Signed-off-by: Sabitha George <sabitha.george@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Akshay Mariyanna [Sun, 9 Oct 2016 19:12:20 +0000 (00:42 +0530)]
staging: ks7010: fix space related style issues in ks7010_sdio.c
This fixes the following checkpatch warnings:
WARNING: Unnecessary space before function pointer arguments
WARNING: unnecessary whitespace before a quoted newline
Sergio Paracuellos [Sun, 9 Oct 2016 15:10:32 +0000 (17:10 +0200)]
staging: wlan-ng: fix block comment warnings in prism2fw.c
This patch fix the following checkpatch.pl warnings in prism2fw.c
WARNING: Block comments should align the * on each line
WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Sun, 9 Oct 2016 15:10:28 +0000 (17:10 +0200)]
staging: wlan-ng: fix block comment warnings in prism2mgmt.c
This patch fix the following checkpatch.pl warnings in prism2mgmt.c:
WARNING: Block comments should align the * on each line
WARNING: Block comments use a trailing */ on a separate line
Sergio Paracuellos [Sun, 9 Oct 2016 15:10:24 +0000 (17:10 +0200)]
staging: wlan-ng: fix block comment warnings in p80211req.c
This patch fix the following checkpatch.pl warnings in p80211req.c:
WARNING: Block comments should align the * on each line
WARNING: Block comments use a trailing */ on a separate line
Sergio Paracuellos [Sun, 9 Oct 2016 15:10:22 +0000 (17:10 +0200)]
staging: wlan-ng: fix block comment warnings in p80211netdev.c
This patch fix the following checkpatch.pl warnings in p80211netdev.c:
WARNING: Block comments should align the * on each line
WARNING: Block comments use a trailing */ on a separate line
Sergio Paracuellos [Sun, 9 Oct 2016 15:10:19 +0000 (17:10 +0200)]
staging: wlan-ng: fix block comment warnings in hfa384x_usb.c
This patch fix the following checkpatch.pl warnings in hfa384x_usb.c:
WARNING: Block comments should align the * on each line
WARNING: Block comments use a trailing */ on a separate line
Andrey Shvetsov [Tue, 4 Oct 2016 15:10:21 +0000 (17:10 +0200)]
staging: most: hdm-usb: fix mbo buffer leak
This patch fixes an MBO leak by replacing the proprietary
free_anchored_buffers() function with the usb_kill_anchored_urbs() function
of the USB subsystem and guarantees that the mbo->complete() completion
function is being called for each URB.
Andrey Shvetsov [Tue, 4 Oct 2016 15:10:19 +0000 (17:10 +0200)]
staging: most: hdm-usb: remove filtering of networking state
In case the networking interface goes down and up again, the USB HDM does
not report the state the MOST networking interface controller is in. This
might lead to nonfunctional network.
Since the networking AIM already takes care of hardware address checking
and tracing it can be removed from the HDM USB, which is what this patch is
doing.
Andrey Shvetsov [Tue, 4 Oct 2016 15:10:17 +0000 (17:10 +0200)]
staging: most: aim-network: setup mac address before ifup has finished
The networking AIM implements a non-standard behavior as it starts the
networking interface with an invalid MAC address and changes it by the time
a valid one is available.
This patch introduces a completion object to set the MAC address of the
networking interface before the .ndo_open callback (ifup) of the net_device
returns.
Andrey Shvetsov [Tue, 4 Oct 2016 15:10:16 +0000 (17:10 +0200)]
staging: most: aim-network: fix startup scenario.
In case the networking interface (running on MediaLB) is being started
before the MOST network is, it remains disabled even after the MOST network
has transitioned to active mode.
This patch removes the dependency on the MOST link status to keep the
networking queue active and the networking interface working for the
case described above.
Andrey Shvetsov [Tue, 4 Oct 2016 15:10:14 +0000 (17:10 +0200)]
staging: most: core: remove processing of deprecated names
The USB HDM does not use the "@" character for channel names anymore. This
patch cleans up the code processing such names and adapts the corresponding
examples on how to use the properties "add_link" and "remove_link".
Andrey Shvetsov [Tue, 4 Oct 2016 15:10:13 +0000 (17:10 +0200)]
staging: most: core: remove read option from remove_link
The attribute "remove_link" returns the latest link that has been removed
of a certain channel. Since this piece information isn't particulary
useful this patch is going to remove it.
Bhumika Goyal [Sun, 9 Oct 2016 07:56:28 +0000 (13:26 +0530)]
Staging: emxx_udc: constify usb_ep_ops structure
Declare the structure usb_ep_ops as constant as it is only stored in the
ops field of a usb_ep structure which is a field of a nbu2ss_ep structure.
The ops field is of type const struct usb_ep_ops *, so usb_ep_ops
structures having this property can be decalared as const.
Done using coccinelle:
Bhumika Goyal [Sat, 8 Oct 2016 09:59:54 +0000 (15:29 +0530)]
Staging: emxx_udc: Remove useless type conversion
Some type conversions like casting a pointer to a pointer of same type,
casting to the original type using addressof(&) operator etc. are not
needed. Therefore, remove them. Done using coccinelle:
@@
type t;
t *p;
t a;
@@
(
- (t)(a)
+ a
|
- (t *)(p)
+ p
|
- (t *)(&a)
+ &a
)
Bhumika Goyal [Sat, 8 Oct 2016 10:28:04 +0000 (15:58 +0530)]
Staging: skein: skein_api: Remove useless type conversion
Some type conversions like casting a pointer to a pointer of same type,
casting to the original type using addressof(&) operator etc. are not
needed. Therefore, remove them. Done using coccinelle:
@@
type t;
t *p;
t a;
@@
(
- (t)(a)
+ a
|
- (t *)(p)
+ p
|
- (t *)(&a)
+ &a
)
projects / users / jedix / linux-maple.git / log