Merge pull request #175 from igaw/fix-tests

Fix tests

tree: Skip invalid pointer when scanning topology

Do not try to dereference a NULL pointer. Just ignore it.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ioctl: Set provided timestamp nvme_set_features_timestamp

The argument order for memcpy is clearly the wrong way around. The
provided timestamp should be stored into the ts variable. The
compiler was warning about ts not being initialized.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

Merge pull request #108 from hreinecke/scan-rework

Rework scanning logic

Merge pull request #171 from igaw/struct-layout-v2

Fill holes in ioctl's argument structs (alternative version)

Merge pull request #173 from igaw/add-error-codes

log: Introduce libnvme error codes

log: Introduce libnvme error codes

Add libnvme specific error codes which map to a specific error
message. The system error codes in errno are too overloaded to figure
out what is going wrong.

With this we can remove the nvme_log_message buffer. This avoids
having a global library buffer.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ioctl: Rearrange members in nvme_zns_append_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_zns_append_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u64 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        __u32                      nsid;                 /*    20     4 */
        __u64                      zslba;                /*    24     8 */
        __u16                      nlb;                  /*    32     2 */
        __u16                      control;              /*    34     2 */
        __u32                      ilbrt;                /*    36     4 */
        __u16                      lbat;                 /*    40     2 */
        __u16                      lbatm;                /*    42     2 */
        __u32                      data_len;             /*    44     4 */
        void *                     data;                 /*    48     8 */
        void *                     metadata;             /*    56     8 */
        /* --- cacheline 1 boundary (64 bytes) --- */
        __u32                      metadata_len;         /*    64     4 */

        /* size: 72, cachelines: 2, members: 15 */
        /* padding: 4 */
        /* last cacheline: 8 bytes */
} __attribute__((__aligned__(8)));

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ioctl: Rearrange members in nvme_zns_mgmt_recv_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_zns_mgmt_recv_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u32 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        __u32                      nsid;                 /*    20     4 */
        __u64                      slba;                 /*    24     8 */
        enum nvme_zns_recv_action  zra;                  /*    32     4 */
        __u32                      data_len;             /*    36     4 */
        void *                     data;                 /*    40     8 */
        __u16                      zrasf;                /*    48     2 */
        _Bool                      zras_feat;            /*    50     1 */

        /* size: 56, cachelines: 1, members: 11 */
        /* padding: 5 */
        /* last cacheline: 56 bytes */
} __attribute__((__aligned__(8)));

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ioctl: Rearrange members in nvme_zns_mgmt_send_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_zns_mgmt_send_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u32 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        __u32                      nsid;                 /*    20     4 */
        __u64                      slba;                 /*    24     8 */
        enum nvme_zns_send_action  zsa;                  /*    32     4 */
        __u32                      data_len;             /*    36     4 */
        void *                     data;                 /*    40     8 */
        _Bool                      select_all;           /*    48     1 */
        __u8                       zsaso;                /*    49     1 */

        /* size: 56, cachelines: 1, members: 11 */
        /* padding: 6 */
        /* last cacheline: 56 bytes */
} __attribute__((__aligned__(8)));

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ioctl: Rearrange members in nvme_resv_report_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_resv_report_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u32 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        __u32                      nsid;                 /*    20     4 */
        struct nvme_resv_status *  report;               /*    24     8 */
        __u32                      len;                  /*    32     4 */
        _Bool                      eds;                  /*    36     1 */

        /* size: 40, cachelines: 1, members: 8 */
        /* padding: 3 */
        /* last cacheline: 40 bytes */
} __attribute__((__aligned__(8)));

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ioctl: Rearrange members in nvme_resv_release_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_resv_release_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u32 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        __u32                      nsid;                 /*    20     4 */
        enum nvme_resv_rtype       rtype;                /*    24     4 */
        enum nvme_resv_rrela       rrela;                /*    28     4 */
        __u64                      crkey;                /*    32     8 */
        _Bool                      iekey;                /*    40     1 */

        /* size: 48, cachelines: 1, members: 9 */
        /* padding: 7 */
        /* last cacheline: 48 bytes */
} __attribute__((__aligned__(8)));

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ioctl: Rearrange members in nvme_resv_register_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_resv_register_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u32 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        __u32                      nsid;                 /*    20     4 */
        enum nvme_resv_rrega       rrega;                /*    24     4 */
        enum nvme_resv_cptpl       cptpl;                /*    28     4 */
        __u64                      crkey;                /*    32     8 */
        __u64                      nrkey;                /*    40     8 */
        _Bool                      iekey;                /*    48     1 */

        /* size: 56, cachelines: 1, members: 10 */
        /* padding: 7 */
        /* last cacheline: 56 bytes */
} __attribute__((__aligned__(8)));

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ioctl: Rearrange members in nvme_resv_acquire_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_resv_acquire_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u32 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        __u32                      nsid;                 /*    20     4 */
        enum nvme_resv_rtype       rtype;                /*    24     4 */
        enum nvme_resv_racqa       racqa;                /*    28     4 */
        __u64                      crkey;                /*    32     8 */
        __u64                      nrkey;                /*    40     8 */
        _Bool                      iekey;                /*    48     1 */

        /* size: 56, cachelines: 1, members: 10 */
        /* padding: 7 */
        /* last cacheline: 56 bytes */
} __attribute__((__aligned__(8)));

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ioctl: Rearrange members in nvme_copy_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_copy_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u32 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        __u32                      nsid;                 /*    20     4 */
        struct nvme_copy_range *   copy;                 /*    24     8 */
        __u64                      sdlba;                /*    32     8 */
        __u16                      nr;                   /*    40     2 */
        __u16                      dspec;                /*    42     2 */
        __u8                       prinfor;              /*    44     1 */
        __u8                       prinfow;              /*    45     1 */
        __u8                       dtype;                /*    46     1 */
        __u8                       format;               /*    47     1 */
        int                        lr;                   /*    48     4 */
        int                        fua;                  /*    52     4 */
        __u32                      ilbrt;                /*    56     4 */
        __u16                      lbatm;                /*    60     2 */
        __u16                      lbat;                 /*    62     2 */

        /* size: 64, cachelines: 1, members: 18 */
} __attribute__((__aligned__(8)));

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ioctl: Rearrange members in nvme_dsm_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_dsm_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u32 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        __u32                      nsid;                 /*    20     4 */
        struct nvme_dsm_range *    dsm;                  /*    24     8 */
        __u32                      attrs;                /*    32     4 */
        __u16                      nr_ranges;            /*    36     2 */

        /* size: 40, cachelines: 1, members: 8 */
        /* padding: 2 */
        /* last cacheline: 40 bytes */
} __attribute__((__aligned__(8)));

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ioctl: Rearrange members in nvme_io_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_io_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u32 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        __u32                      nsid;                 /*    20     4 */
        void *                     data;                 /*    24     8 */
        void *                     metadata;             /*    32     8 */
        __u64                      slba;                 /*    40     8 */
        __u16                      nlb;                  /*    48     2 */
        __u16                      control;              /*    50     2 */
        __u16                      apptag;               /*    52     2 */
        __u16                      appmask;              /*    54     2 */
        __u32                      reftag;               /*    56     4 */
        __u32                      data_len;             /*    60     4 */
        /* --- cacheline 1 boundary (64 bytes) --- */
        __u64                      storage_tag;          /*    64     8 */
        __u32                      metadata_len;         /*    72     4 */
        __u8                       dsm;                  /*    76     1 */
        __u8                       dspec;                /*    77     1 */

        /* size: 80, cachelines: 2, members: 18 */
        /* padding: 2 */
        /* last cacheline: 16 bytes */
} __attribute__((__aligned__(8)));

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ioctl: Rearrange members in nvme_virtual_mgmt_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_virtual_mgmt_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u32 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        enum nvme_virt_mgmt_act    act;                  /*    20     4 */
        enum nvme_virt_mgmt_rt     rt;                   /*    24     4 */
        __u16                      cntlid;               /*    28     2 */
        __u16                      nr;                   /*    30     2 */

        /* size: 32, cachelines: 1, members: 8 */
        /* last cacheline: 32 bytes */
} __attribute__((__aligned__(8)));

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ioctl: Rearrange members in nvme_sanitize_nvm_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_sanitize_nvm_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u32 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        enum nvme_sanitize_sanact  sanact;               /*    20     4 */
        _Bool                      ause;                 /*    24     1 */
        __u8                       owpass;               /*    25     1 */
        _Bool                      oipbp;                /*    26     1 */
        _Bool                      nodas;                /*    27     1 */
        __u32                      ovrpat;               /*    28     4 */

        /* size: 32, cachelines: 1, members: 6 */
        /* padding: 4 */
        /* last cacheline: 32 bytes */
} __attribute__((__aligned__(8)));

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ioctl: Rearrange members in nvme_get_property_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_get_property_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u64 *                    value;                /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        int                        offset;               /*    20     4 */

       /* size: 24, cachelines: 1, members: 5 */
        /* last cacheline: 24 bytes */
} __attribute__((__aligned__(8)));

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ioctl: Rearrange members in nvme_set_property_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_set_property_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u32 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        int                        offset;               /*    20     4 */
        __u64                      value;                /*    24     8 */

        /* size: 32, cachelines: 1, members: 6 */
        /* last cacheline: 32 bytes */
} __attribute__((__aligned__(8)));

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ioctl: Rearrange members in nvme_lockdown_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_lockdown_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u32 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        __u8                       scp;                  /*    20     1 */
        __u8                       prhbt;                /*    21     1 */
        __u8                       ifc;                  /*    22     1 */
        __u8                       ofi;                  /*    23     1 */
        __u8                       uuidx;                /*    24     1 */

        /* size: 32, cachelines: 1, members: 8 */
        /* padding: 1 */
        /* last cacheline: 32 bytes */
} __attribute__((__aligned__(8)));

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ioctl: Rearrange members in nvme_capacity_mgmt_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_capacity_mgmt_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u32 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        __u32                      cdw11;                /*    20     4 */
        __u32                      cdw12;                /*    24     4 */
        __u16                      element_id;           /*    28     2 */
        __u8                       op;                   /*    30     1 */

        /* size: 56, cachelines: 1, members: 11 */
        /* padding: 6 */
        /* last cacheline: 56 bytes */
} __attribute__((__aligned__(8)));

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ioctl: Rearrange members in nvme_directive_recv_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_directive_recv_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u32 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        __u32                      nsid;                 /*    20     4 */
        enum nvme_directive_receive_doper doper;         /*    24     4 */
        enum nvme_directive_dtype  dtype;                /*    28     4 */
        __u32                      cdw12;                /*    32     4 */
        __u32                      data_len;             /*    36     4 */
        void *                     data;                 /*    40     8 */
        __u16                      dspec;                /*    48     2 */

        /* size: 56, cachelines: 1, members: 11 */
        /* padding: 6 */
        /* last cacheline: 56 bytes */
} __attribute__((__aligned__(8)));

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ioctl: Rearrange members in nvme_directive_send_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_directive_send_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u32 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        __u32                      nsid;                 /*    20     4 */
        enum nvme_directive_send_doper doper;            /*    24     4 */
        enum nvme_directive_dtype  dtype;                /*    28     4 */
        __u32                      cdw12;                /*    32     4 */
        __u32                      data_len;             /*    36     4 */
        void *                     data;                 /*    40     8 */
        __u16                      dspec;                /*    48     2 */

        /* size: 56, cachelines: 1, members: 10 */
        /* padding: 6 */
        /* last cacheline: 56 bytes */
} __attribute__((__aligned__(8)));

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ioctl: Rearrange members in nvme_get_lba_status_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_get_lba_status_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u32 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        __u32                      nsid;                 /*    20     4 */
        __u32                      mndw;                 /*    24     4 */
        enum nvme_lba_status_atype atype;                /*    28     4 */
        __u64                      slba;                 /*    32     8 */
        struct nvme_lba_status *   lbas;                 /*    40     8 */
        __u16                      rl;                   /*    48     2 */

        /* size: 50, cachelines: 1, members: 10 */
        /* last cacheline: 50 bytes */
} __attribute__((__packed__));

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ioctl: Rearrange members in nvme_security_receive_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_security_receive_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u32 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        __u32                      nsid;                 /*    20     4 */
        __u8                       nssf;                 /*    24     1 */
        __u8                       spsp0;                /*    25     1 */
        __u8                       spsp1;                /*    26     1 */
        __u8                       secp;                 /*    27     1 */
        __u32                      al;                   /*    28     4 */
        void *                     data;                 /*    32     8 */
        __u32                      data_len;             /*    40     4 */

        /* size: 48, cachelines: 1, members: 12 */
        /* padding: 4 */
        /* last cacheline: 48 bytes */
} __attribute__((__aligned__(8)));

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ioctl: Rearrange members in nvme_security_send_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_security_send_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u32 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        __u32                      nsid;                 /*    20     4 */
        __u8                       nssf;                 /*    24     1 */
        __u8                       spsp0;                /*    25     1 */
        __u8                       spsp1;                /*    26     1 */
        __u8                       secp;                 /*    27     1 */
        __u32                      tl;                   /*    28     4 */
        void *                     data;                 /*    32     8 */
        __u32                      data_len;             /*    40     4 */

        /* size: 48, cachelines: 1, members: 12 */
        /* padding: 4 */
        /* last cacheline: 48 bytes */
} __attribute__((__aligned__(8)));

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ioctl: Rearrange members in nvme_fw_commit_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_fw_commit_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u32 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        enum nvme_fw_commit_ca     action;               /*    20     4 */
        __u8                       slot;                 /*    24     1 */
        _Bool                      bpid;                 /*    25     1 */

        /* size: 32, cachelines: 1, members: 7 */
        /* padding: 6 */
        /* last cacheline: 32 bytes */
} __attribute__((__aligned__(8)));

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ioctl: Rearrange members in nvme_fw_download_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_fw_download_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u32 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        __u32                      offset;               /*    20     4 */
        void *                     data;                 /*    24     8 */
        __u32                      data_len;             /*    32     4 */

        /* size: 40, cachelines: 1, members: 7 */
        /* padding: 4 */
        /* last cacheline: 40 bytes */
} __attribute__((__aligned__(8)));

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ioctl: Rearrange members in nvme_ns_attach_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_ns_attach_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u32 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        __u32                      nsid;                 /*    20     4 */
        struct nvme_ctrl_list *    ctrlist;              /*    24     8 */
        enum nvme_ns_attach_sel    sel;                  /*    32     4 */

        /* size: 40, cachelines: 1, members: 7 */
        /* padding: 4 */
        /* last cacheline: 40 bytes */
} __attribute__((__aligned__(8)));

While at it also introduce the result member.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ioctl: Rearrange members in nvme_ns_mgmt_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_ns_mgmt_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u32 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        __u32                      nsid;                 /*    20     4 */
        struct nvme_id_ns *        ns;                   /*    24     8 */
        enum nvme_ns_mgmt_sel      sel;                  /*    32     4 */
        __u8                       csi;                  /*    36     1 */

        /* size: 40, cachelines: 1, members: 8 */
        /* padding: 3 */
        /* last cacheline: 40 bytes */
} __attribute__((__aligned__(8)));

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ioctl: Rearrange members in nvme_format_nvm_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_format_nvm_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u32 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        __u32                      nsid;                 /*    20     4 */
        enum nvme_cmd_format_mset  mset;                 /*    24     4 */
        enum nvme_cmd_format_pi    pi;                   /*    28     4 */
        enum nvme_cmd_format_pil   pil;                  /*    32     4 */
        enum nvme_cmd_format_ses   ses;                  /*    36     4 */
        __u8                       lbaf;                 /*    40     1 */

        /* size: 48, cachelines: 1, members: 10 */
        /* padding: 7 */
        /* last cacheline: 48 bytes */
} __attribute__((__aligned__(8)));

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ioctl: Rearrange members in nvme_get_features_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_get_features_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u32 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        __u32                      nsid;                 /*    20     4 */
        enum nvme_get_features_sel sel;                  /*    24     4 */
        __u32                      cdw11;                /*    28     4 */
        __u32                      data_len;             /*    32     4 */
        void *                     data;                 /*    36     8 */
        __u8                       fid;                  /*    44     1 */
        __u8                       uuidx;                /*    45     1 */

        /* size: 48, cachelines: 1, members: 11 */
        /* padding: 2 */
        /* last cacheline: 48 bytes */
} __attribute__((__aligned__(8)));

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ioctl: Rearrange members in nvme_set_features_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_set_features_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u32 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        __u32                      nsid;                 /*    20     4 */
        __u32                      cdw11;                /*    24     4 */
        __u32                      cdw12;                /*    28     4 */
        __u32                      cdw15;                /*    32     4 */
        __u32                      data_len;             /*    36     4 */
        void *                     data;                 /*    40     8 */
        _Bool                      save;                 /*    48     1 */
        __u8                       uuidx;                /*    49     1 */
        __u8                       fid;                  /*    50     1 */

        /* size: 56, cachelines: 1, members: 13 */
        /* padding: 5 */
        /* last cacheline: 56 bytes */
} __attribute__((__aligned__(8)));

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ioctl: Rearrange members in nvme_get_log_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_get_log_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u32 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        enum nvme_cmd_get_log_lid  lid;                  /*    20     4 */
        __u64                      lpo;                  /*    24     8 */
        void *                     log;                  /*    32     8 */
        __u32                      len;                  /*    40     4 */
        __u32                      nsid;                 /*    44     4 */
        enum nvme_csi              csi;                  /*    48     4 */
        __u16                      lsi;                  /*    52     2 */
        __u8                       lsp;                  /*    54     1 */
        __u8                       uuidx;                /*    55     1 */
        _Bool                      rae;                  /*    56     1 */
        _Bool                      ot;                   /*    57     1 */

        /* size: 64, cachelines: 1, members: 15 */
        /* padding: 6 */
} __attribute__((__aligned__(8)));

Signed-off-by: Daniel Wagner <dwagner@suse.de>

ioctl: Rearrange members in nvme_identify_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_identify_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u32 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        enum nvme_identify_cns     cns;                  /*    20     4 */
        void *                     data;                 /*    24     8 */
        enum nvme_csi              csi;                  /*    32     4 */
        __u32                      nsid;                 /*    36     4 */
        __u16                      cntid;                /*    40     2 */
        __u16                      nvmsetid;             /*    42     2 */
        __u16                      domid;                /*    44     2 */
        __u8                       uuidx;                /*    46     1 */

        /* size: 48, cachelines: 1, members: 12 */
        /* padding: 1 */
        /* last cacheline: 48 bytes */
} __attribute__((__aligned__(8)));

Signed-off-by: Daniel Wagner <dwagner@suse.de>

Merge pull request #172 from hreinecke/host_traddr

Move 'host_traddr' and 'host_iface' into fabrics configuration

ioctl: Remove declration of nvme_set_features_iocs_profile()

There is no implemenation for this function. Remove it.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

Move 'host_traddr' and 'host_iface' into fabrics configuration

Having 'host_traddr' and 'host_iface' as part of the controller
structure is technically correct, but won't work for 'connect-all'.
There we evaluate the contents of the discovery log page, and create
new controllers based on that information.
But as 'host_traddr' and 'host_iface' are Linux-only constructs, the
spec (and the discovery log page) doesn't know about them, and can't
provide us with that information.

Signed-off-by: Hannes Reinecke <hare@suse.de>

tree: scan controllers before scanning subsystems in nvme_scan_topology()

The linux sysfs hierarchy only knows about 'controllers' and 'subsystems',
so when scanning the topology we should follow this structure and scan
first for controllers and then for subsystems.
Just scanning for subsystems and all controllers attached to them has
the problem that the hostnqn can only be derived from the controller,
but by the time the controller is scanned the subsystem has already
been created and attached to the default host.
Scanning for controllers first will setup the correct hosts
(and subsystems), so the subsequent scan for subsystems is primarily
there to find all namespaces attached to the subsystems.

Signed-off-by: Hannes Reinecke <hare@suse.de>

tree: lookup correct subsystem in nvme_scan_ctrl()

Looking subsystems by subsys NQN only might yield wrong results
(eg for discovery controllers), as there might be several subsystem
instances all having the same subsystem NQN.

Signed-off-by: Hannes Reinecke <hare@suse.de>

tree: drop 'path' argument from nvme_init_subsystem()

The 'path' argument for nvme_init_subsystem() can be derived from
the name.

Signed-off-by: Hannes Reinecke <hare@suse.de>

tree: use name as argument to nvme_ctrl_lookup_subsystem_name()

When looking up the subsystem in ctrl_lookup_subsystem_name() we
only need the controller name, not the entire controller structure.

Signed-off-by: Hannes Reinecke <hare@suse.de>

Merge pull request #150 from hreinecke/api-rework

Rework the libnvme ioctl API

libnvme.map: Export nvme_io

Add missing export.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

Inline nvme_flush()

nvme_flush() is a trivial wrapper around nvme_submit_io_passthru(),
so inline it instead of carrying a function in the library.

Signed-off-by: Hannes Reinecke <hare@suse.de>

Use argument structure for nvme_zns_append()

Use an argument structure instead of passing all arguments one by one.
This allows for a future expansion of the argument list without having
to change the library ABI.

Signed-off-by: Hannes Reinecke <hare@suse.de>

Use argument structure for nvme_zns_mgmt_send() and nvme_zns_mgmt_recv()

Use an argument structure instead of passing all arguments one by one.
This allows for a future expansion of the argument list without having
to change the library ABI.
Also convert zns.c to use nvme_zns_report_zones() instead of calling
nvme_zns_mgmt_recv() directly.

Signed-off-by: Hannes Reinecke <hare@suse.de>

Use argument structure for NVMe reservation commands

Use an argument structure for NVMe reservation commands like
nvme_resv_acquire() or nvme_resv_release() instead of passing all
arguments one by one.
This allows for a future expansion of the argument list without having
to change the library ABI.

Signed-off-by: Hannes Reinecke <hare@suse.de>

Use argument structure for nvme_copy()

Use an argument structure instead of passing all arguments one by one.
This allows for a future expansion of the argument list without having
to change the library ABI.

Signed-off-by: Hannes Reinecke <hare@suse.de>

Use argument structure for nvme_dsm()

Use an argument structure instead of passing all arguments one by one.
This allows for a future expansion of the argument list without having
to change the library ABI.

Signed-off-by: Hannes Reinecke <hare@suse.de>

Use argument structure for NVMe I/O commands

Use an argument structure for NVMe I/O commands like nvme_read() or
nvme_write() instead of passing all arguments one by one.
This allows for a future expansion of the argument list without having
to change the library ABI.

Signed-off-by: Hannes Reinecke <hare@suse.de>

Use argument structure for nvme_virtual_mgmt()

Use an argument structure instead of passing all arguments one by one.
This allows for a future expansion of the argument list without having
to change the library ABI.

Signed-off-by: Hannes Reinecke <hare@suse.de>

Use argument structure for nvme_dev_self_test()

Use an argument structure instead of passing all arguments one by one.
This allows for a future expansion of the argument list without having
to change the library ABI.

Signed-off-by: Hannes Reinecke <hare@suse.de>

Use argument structure for nvme_sanize_nvm()

Use an argument structure instead of passing all arguments one by one.
This allows for a future expansion of the argument list without having
to change the library ABI.

Signed-off-by: Hannes Reinecke <hare@suse.de>

Use argument structure for nvme_set_property() and nvme_get_property()

Use an argument structure instead of passing all arguments one by one.
This allows for a future expansion of the argument list without having
to change the library ABI.

Signed-off-by: Hannes Reinecke <hare@suse.de>

Use argument structure for nvme_lockdown()

Use an argument structure instead of passing all arguments one by one.
This allows for a future expansion of the argument list without having
to change the library ABI.

Signed-off-by: Hannes Reinecke <hare@suse.de>

Use argument structure for nvme_capacity_mgmt()

Use an argument structure instead of passing all arguments one by one.
This allows for a future expansion of the argument list without having
to change the library ABI.

Signed-off-by: Hannes Reinecke <hare@suse.de>

Use argument structure for nvme_directive_send() and nvme_directive_receive()

Use an argument structure instead of passing all arguments one by one.
This allows for a future expansion of the argument list without having
to change the library ABI.

Signed-off-by: Hannes Reinecke <hare@suse.de>

Use argument structure for nvme_get_lba_status()

Use an argument structure instead of passing all arguments one by one.
This allows for a future expansion of the argument list without having
to change the library ABI.

Signed-off-by: Hannes Reinecke <hare@suse.de>

Use argument structure for nvme_security_send() and nvme_security_receive()

Use an argument structure instead of passing all arguments one by one.
This allows for a future expansion of the argument list without having
to change the library ABI.

Signed-off-by: Hannes Reinecke <hare@suse.de>

Use argument structure for nvme_fw_commit()

Use an argument structure instead of passing all arguments one by one.
This allows for a future expansion of the argument list without having
to change the library ABI.

Signed-off-by: Hannes Reinecke <hare@suse.de>

Use argument structure for nvme_fw_download()

Use an argument structure instead of passing all arguments one by one.
This allows for a future expansion of the argument list without having
to change the library ABI.

Signed-off-by: Hannes Reinecke <hare@suse.de>

Use argument structure for nvme_format_nvm() and nvme_ns_mgmt()

Use an argument structure instead of passing all arguments one by one.
This allows for a future expansion of the argument list without having
to change the library ABI.

Signed-off-by: Hannes Reinecke <hare@suse.de>

Inline nvme_identify() wrapper functions

No point in having wrapper functions as part of the libnvme library.

Signed-off-by: Hannes Reinecke <hare@suse.de>

Use argument structure for nvme_identify()

Use an argument structure instead of passing all arguments one by one.
This allows for a future expansion of the argument list without having
to change the library ABI.

Signed-off-by: Hannes Reinecke <hare@suse.de>

Use argument structure for nvme_set_features() and nvme_get_features()

Use an argument structure instead of passing all arguments one by one.
This allows for a future expansion of the argument list without having
to change the library ABI.
Also convert zns.c to use nvme_zns_report_zones() instead of calling
nvme_zns_mgmt_recv() directly.

Signed-off-by: Hannes Reinecke <hare@suse.de>

Inline nvme_get_log() wrapper functions

No point in having wrapper functions as part of the libnvme library.

Signed-off-by: Hannes Reinecke <hare@suse.de>

Use argument structure for nvme_get_log()

Use an argument structure instead of passing all arguments one by one.
This allows for a future expansion of the argument list without having
to change the library ABI.

Signed-off-by: Hannes Reinecke <hare@suse.de>

Merge pull request #167 from martin-belanger/fix-the-docs

Fix error building the man pages

fix error building the man pages

build: Remove more in tree build artifacts

meson doesn't do any in tree builds. Remove the old Makefile generated
config files from gitignore.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

build: Fix *.wrap exclude pattern in .gitignore

The current rules trigger git to to complain with

 $ git add subprojects/openssl.wrap
 The following paths are ignored by one of your .gitignore files:
 subprojects

We need to keep the parent directory in the tracking domain and just
filter out all sub directories and files except the wrap files.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

Merge pull request #163 from igaw/build-check-python-devel

build: Detect if Python.h header is present

build: Detect if Python.h header is present

Make sure the devel package is also installed not just the the Python
interpreter.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

build: Remove in-tree config files from gitignore

meson doesn't do any in tree builds. Remove the old Makefile generated
config files from gitignore.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

Merge pull request #151 from igaw/logical-block-size

linux: Add nvme_get_logical_block_size()

Merge pull request #158 from igaw/nvme_gen_dhchap_key

linux: Add support to generate DH-HMAC-CHAP keys

linux: Add support to generate DH-HMAC-CHAP keys

Initially the DH-HMAC-CHAP key generation code was part of the
nvme-cli repository and depended on OpenSSL 1. Move the key generation
code into the library. While at it also add support for OpenSSL 3.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

linux: Add nvme_get_logical_block_size()

Add helper to retrieve logical block size using nvme_identify_ns().

Signed-off-by: Daniel Wagner <dwagner@suse.de>

Merge pull request #162 from igaw/build-cleanup-makefile-drop

build: Remove unused configurator

build: Remove unused configurator

The configurator tool was used for the Makefile based build. Not
needed for meson builds. Remove it.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

Merge pull request #155 from martin-belanger/replace-make-by-meson

Replace make by meson

Merge pull request #159 from igaw/build-cleanups

Build cleanups

build: Set C dialect and warning level

Currently, the Makefile is not setting the C dialect but the code was
carved out from the nvme-cli code base which relies on gnu99.
Let's define the C dialect to avoid any confusion and make the build
more consistent.

Without defining the default warning level the build system will use
the default level, which is implementation depended.  For example muon
sets it to 3 which includes '-Wpendantic'.  This results in a lot of
ISO-C non compliant warnings.

Let's define the warning level so that all build systems are using the
same values.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

build: Use _dep postfix for all dependency objects

Use consistently _dep postfix for all dependency objects.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

build: Avoid including wrong config.h as subpackage

In case the consuming project also uses a config.h we need to hide our
config.h file. By using the path to our config.h we avoid this
confusion. Obviously, 'src' is a bit too generic, thus move the
generated config.h under libnvme.

Introduce also a private include path because ccan has '#include
"config.h"' in its sources. So we need to present a config.h in the
lookup path but it needs to be the one from this project and not the
one from the consuming project.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

lib: Resort libnvme.map

Signed-off-by: Daniel Wagner <dwagner@suse.de>

Merge pull request #156 from igaw/build-static-inline

util: Define inline function as static inline

util: Define inline function as static inline

The gcc in Centos 6.10 complains with

  src/nvme/util.h:120: multiple definition of `nvme_feature_decode_arbitration'

'inline' alone does not guarantee that the function gets inlined. The
compiler is still free to decide, thus in this case it doesn't inline
and that's why we having multiple implementation with the same
name (in different compile units). 'static inline' forces the inline
which was the indent of this code.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

Replacing make by meson.

This involves replacing all Makefiles by meson.build files.
Also the top-level configure script now simply invokes meson.
The top-level Makefile is just a wrapper for meson. It supports
the following operations:

make
make test
make install
make clean    # Remove build artifacts but keep configuration
make purge    # Remove build artifacts and configuration

Signed-off-by: Martin Belanger <martin.belanger@dell.com>

Merge pull request #153 from igaw/build-fix-fabrics

fabrics: Declare loop index at the beginning of the block

fabrics: Declare loop index at the beginning of the block

The gcc in Centos 6.10 complains with

nvme/fabrics.c:909: error: ‘for’ loop initial declarations are only allowed in C99 mode
nvme/fabrics.c:909: note: use option -std=c99 or -std=gnu99 to compileyour code

Let's declare the index at the beginning of the basic block.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

Merge pull request #152 from hreinecke/tsas

Decode TLS1.3 transport security

Decode TLS1.3 transport security

Add the definition for TLS1.3 in the transport security attribute
settings (tsas) field.

Signed-off-by: Hannes Reinecke <hare@suse.de>

Merge pull request #146 from igaw/add-ctrl-metadata-and-ns-metadata

types: Add Controller Metadata and Namespace Metadata

Merge pull request #147 from sc108-lee/add/gitignore

build: Add subpackages contents to .gitignore

build: Add subpackages contents to .gitignore

we just need to maintain .wrap files for dependencies

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>

types: Add Controller Metadata and Namespace Metadata

Port and extent the libnvme part from the commit "Add NVMe MI
Features: Controller Metadata (0x7E) and Namespace Metadata (0x7F)."
from the nvme-cli monolithic branch.

While at it add the missing definitions and add some documentation.

This is based on Tokunori Ikegami first port attempt.

Signed-off-by: Daniel Wagner <dwagner@suse.de>