Johan Hovold [Wed, 19 Feb 2025 13:41:18 +0000 (14:41 +0100)]
arm64: dts: qcom: x1e80100: enable rtc
On many Qualcomm platforms the PMIC RTC control and time registers are
read-only so that the RTC time can not be updated. Instead an offset
needs be stored in some machine-specific non-volatile memory, which a
driver can take into account.
On X1E based Windows on Arm machines the offset is stored in a Qualcomm
specific UEFI variable.
Unlike on previous platforms the alarm registers are also unaccessible
on X1E as they are owned by the ADSP.
Assume all X1E machines use similar firmware and enable the RTC in the
PMIC dtsi for now.
Johan Hovold [Wed, 19 Feb 2025 13:41:17 +0000 (14:41 +0100)]
arm64: dts: qcom: sc8280xp-x13s: switch to uefi rtc offset
On many Qualcomm platforms the PMIC RTC control and time registers are
read-only so that the RTC time can not be updated. Instead an offset
needs be stored in some machine-specific non-volatile memory, which a
driver can take into account.
Switch to using the Qualcomm specific UEFI variable that is used by the
UEFI firmware (and Windows) to store the RTC offset.
This specifically means that the RTC time will be synchronised between
the UEFI firmware setup (or UEFI shell), Windows and Linux.
Note however that Windows stores the RTC time in local time by default,
while Linux typically uses UTC (i.e. as on X86).
Tingguo Cheng [Fri, 17 Jan 2025 03:24:31 +0000 (11:24 +0800)]
arm64: dts: qcom: qcs615: remove disallowed property in spmi bus node
Remove the unevaluated 'cell-index' property from qcs615-ride.dtb
spmi@c440000 to fix the Devicetree validation error reported by the
kernel test robot.
Varadarajan Narayanan [Fri, 7 Feb 2025 07:35:45 +0000 (13:05 +0530)]
arm64: dts: qcom: ipq9574: Fix USB vdd info
USB phys in ipq9574 use the 'L5' regulator. The commit ec4f047679d5
("arm64: dts: qcom: ipq9574: Enable USB") incorrectly specified it as
'L2'. Because of this when the phy module turns off/on its regulators,
the wrong regulator is turned off/on resulting in 2 issues, namely the
correct regulator related to the USB phy is not turned off/on and the
module powered by the incorrect regulator is affected.
Add the missing HID supplies to avoid relying on other consumers to keep
them on.
This also avoids the following warnings on boot:
i2c_hid_of 0-0010: supply vdd not found, using dummy regulator
i2c_hid_of 0-0010: supply vddl not found, using dummy regulator
i2c_hid_of 1-0015: supply vdd not found, using dummy regulator
i2c_hid_of 1-002c: supply vdd not found, using dummy regulator
i2c_hid_of 1-0015: supply vddl not found, using dummy regulator
i2c_hid_of 1-002c: supply vddl not found, using dummy regulator
i2c_hid_of 1-003a: supply vdd not found, using dummy regulator
i2c_hid_of 1-003a: supply vddl not found, using dummy regulator
Note that VCC3B is also used for things like the modem which are not yet
described so mark the regulator as always-on for now.
Fixes: 7d1cbe2f4985 ("arm64: dts: qcom: Add X1E78100 ThinkPad T14s Gen 6") Cc: stable@vger.kernel.org # 6.12 Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Link: https://lore.kernel.org/r/20250314145440.11371-9-johan+linaro@kernel.org Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Stephan Gerhold [Tue, 3 Dec 2024 17:44:03 +0000 (18:44 +0100)]
arm64: dts: qcom: x1e80100-crd: Drop duplicate DMIC supplies
The WCD938x codec provides two controls for each of the MIC_BIASn outputs:
- "MIC BIASn" enables an internal regulator to generate the output
with a configurable voltage (qcom,micbiasN-microvolt).
- "VA MIC BIASn" enables "pull-up mode" that bypasses the internal
regulator and directly outputs fixed 1.8V from the VDD_PX pin.
This is intended for low-power VA (voice activation) use cases.
The audio-routing setup for the X1E80100 CRD currently specifies both
as power supplies for the DMICs, but only one of them can be active
at the same time. In practice, only the internal regulator is used
with the current setup because the driver prefers it over pull-up mode.
Make this more clear by dropping the redundant routes to the pull-up
"VA MIC BIASn" supply. There is no functional difference except that we
skip briefly switching to pull-up mode when shutting down the microphone.
Stephan Gerhold [Tue, 3 Dec 2024 17:44:02 +0000 (18:44 +0100)]
arm64: dts: qcom: sc8280xp-x13s: Drop duplicate DMIC supplies
The WCD938x codec provides two controls for each of the MIC_BIASn outputs:
- "MIC BIASn" enables an internal regulator to generate the output
with a configurable voltage (qcom,micbiasN-microvolt).
- "VA MIC BIASn" enables "pull-up mode" that bypasses the internal
regulator and directly outputs fixed 1.8V from the VDD_PX pin.
This is intended for low-power VA (voice activation) use cases.
The audio-routing setup for the ThinkPad X13s currently specifies both
as power supplies for the DMICs, but only one of them can be active
at the same time. In practice, only the internal regulator is used
with the current setup because the driver prefers it over pull-up mode.
Make this more clear by dropping the redundant routes to the pull-up
"VA MIC BIASn" supply. There is no functional difference except that we
skip briefly switching to pull-up mode when shutting down the microphone.
Abel Vesa [Fri, 14 Mar 2025 14:03:24 +0000 (16:03 +0200)]
arm64: dts: qcom: x1e78100-t14s: Add LCD variant with backlight support
Due to the fact that Lenovo Thinkpad T14s Gen6 is available with both
OLED and LCD, the backlight control differs HW-wise. For the LCD variant,
the panel's backlight is controlled via one of the PWMs provided by the
PMK8550 PMIC. For the OLED variant, the backlight is internal to the
panel and therefore it is not described in devicetree.
For this reason, create a generic dtsi for the T14s by renaming the
existing dts. While at it, add a node name to panel and drop the enable
gpio and pinctrl properties from the panel node. Then add the LCD variant
dts file with the old name and describe all backlight related nodes.
So the existing dts will now be used for LCD variant while for OLED new
dts will be added.
Manikanta Mylavarapu [Wed, 12 Mar 2025 09:49:48 +0000 (15:19 +0530)]
arm64: dts: qcom: ipq5424: add reserved memory region for bootloader
In IPQ5424, the bootloader collects the system RAM contents upon a crash
for post-morterm analysis. If we don't reserve the memory region used by
the bootloader, linux will consume it. Upon the next boot after a crash,
the bootloader will be loaded in the same region, which could lead to the
loss of some data. sometimes, we may miss out critical information.
Therefore, let's reserve the region used by the bootloader.
Manish Nagar [Mon, 10 Mar 2025 10:47:43 +0000 (16:17 +0530)]
arm64: dts: qcom: qcs8300-ride: Enable second USB controller on QCS8300 Ride
Enable secondary USB controller on QCS8300 Ride platform. Since it is a
Type-A port, the dr_mode has been set to "host". The VBUS to connected
peripherals is provided by TPS2559QWDRCTQ1 regulator connected to the
port. The regulator has an enable pin controlled by PMM8650. Model it as
fixed regulator and keep it Always-On at boot, since the regulator is
GPIO controlled regulator.
Konrad Dybcio [Thu, 6 Mar 2025 18:11:20 +0000 (19:11 +0100)]
arm64: dts: qcom: sc8180x: Rename AOSS_QMP to power-management
The node is currently named power-controller, which requires the device
underneath is a power domain provider. Rename it to align with other
SoCs and resolve this sort of warnings:
power-controller@c310000: '#power-domain-cells' is a required property
Konrad Dybcio [Thu, 6 Mar 2025 18:11:19 +0000 (19:11 +0100)]
arm64: dts: qcom: qcs615: Rename AOSS_QMP to power-management
The node is currently named power-controller, which requires the device
underneath is a power domain provider. Rename it to align with other
SoCs and resolve this sort of warnings:
power-controller@c300000: '#power-domain-cells' is a required property
Konrad Dybcio [Thu, 6 Mar 2025 18:11:18 +0000 (19:11 +0100)]
arm64: dts: qcom: sdx75: Rename AOSS_QMP to power-management
The node is currently named power-controller, which requires the device
underneath is a power domain provider. Rename it to align with other
SoCs and resolve this sort of warnings:
power-controller@c310000: '#power-domain-cells' is a required property
Vikash Garodia [Mon, 3 Mar 2025 12:37:01 +0000 (18:07 +0530)]
arm64: dts: qcom: sc7280: drop video decoder and encoder nodes
Decoder and encoder nodes are already deprecated from bindings. Update
the venus node to align with bindings. The nodes were deprecated with
commit 459997e8990d9 ("media: dt-bindings: qcom-venus: Deprecate
video-decoder and video-encoder where applicable") and is part of
v6.14-rc1 and onwards.
Neil Armstrong [Fri, 28 Feb 2025 08:40:26 +0000 (09:40 +0100)]
arm64: dts: qcom: sm8650: add PPI interrupt partitions for the ARM PMUs
The PMUs shares the same per-cpu (PPI) interrupt, so declare the proper
interrupt partition maps and use the 4th interrupt cell to pass the
partition phandle for each ARM PMU node.
Neil Armstrong [Fri, 28 Feb 2025 08:40:25 +0000 (09:40 +0100)]
arm64: dts: qcom: sm8650: switch to interrupt-cells 4 to add PPI partitions
The ARM PMUs shares the same per-cpu (PPI) interrupt, so we need to switch
to interrupt-cells = <4> in the GIC node to allow adding an interrupt
partition map phandle as the 4th cell value for GIC_PPI interrupts.
Maulik Shah [Wed, 26 Feb 2025 06:51:27 +0000 (12:21 +0530)]
arm64: dts: qcom: sm8750: Fix cluster hierarchy for idle states
SM8750 have two different clusters. cluster0 have CPU 0-5 as child and
cluster1 have CPU 6-7 as child. Each cluster requires its own idle state
and power domain in order to achieve complete domain sleep state.
However only single cluster idle state is added mapping CPU 0-7 to the
same power domain. Fix this by correctly mapping each CPU to respective
cluster power domain and make cluster1 power domain use same domain idle
state as cluster0 since both use same idle state parameters.
Manikanta Mylavarapu [Thu, 13 Mar 2025 07:14:22 +0000 (12:44 +0530)]
arm64: dts: qcom: ipq9574: fix the msi interrupt numbers of pcie3
The MSI interrupt numbers of the PCIe3 controller are incorrect. Due
to this, the functional bring up of the QDSP6 processor on the PCIe
endpoint has failed. Correct the MSI interrupt numbers to properly
bring up the QDSP6 processor on the PCIe endpoint.
Stephan Gerhold [Wed, 12 Feb 2025 17:03:52 +0000 (18:03 +0100)]
arm64: dts: qcom: ipq9574: Add missing properties for cryptobam
num-channels and qcom,num-ees are required for BAM nodes without clock,
because the driver cannot ensure the hardware is powered on when trying to
obtain the information from the hardware registers. Specifying the node
without these properties is unsafe and has caused early boot crashes for
other SoCs before [1, 2].
Add the missing information from the hardware registers to ensure the
driver can probe successfully without causing crashes.
Stephan Gerhold [Wed, 12 Feb 2025 17:03:51 +0000 (18:03 +0100)]
arm64: dts: qcom: sa8775p: Add missing properties for cryptobam
num-channels and qcom,num-ees are required for BAM nodes without clock,
because the driver cannot ensure the hardware is powered on when trying to
obtain the information from the hardware registers. Specifying the node
without these properties is unsafe and has caused early boot crashes for
other SoCs before [1, 2].
Add the missing information from the hardware registers to ensure the
driver can probe successfully without causing crashes.
Stephan Gerhold [Wed, 12 Feb 2025 17:03:50 +0000 (18:03 +0100)]
arm64: dts: qcom: sm8650: Add missing properties for cryptobam
num-channels and qcom,num-ees are required for BAM nodes without clock,
because the driver cannot ensure the hardware is powered on when trying to
obtain the information from the hardware registers. Specifying the node
without these properties is unsafe and has caused early boot crashes for
other SoCs before [1, 2].
Add the missing information from the hardware registers to ensure the
driver can probe successfully without causing crashes.
Stephan Gerhold [Wed, 12 Feb 2025 17:03:49 +0000 (18:03 +0100)]
arm64: dts: qcom: sm8550: Add missing properties for cryptobam
num-channels and qcom,num-ees are required for BAM nodes without clock,
because the driver cannot ensure the hardware is powered on when trying to
obtain the information from the hardware registers. Specifying the node
without these properties is unsafe and has caused early boot crashes for
other SoCs before [1, 2].
Add the missing information from the hardware registers to ensure the
driver can probe successfully without causing crashes.
Stephan Gerhold [Wed, 12 Feb 2025 17:03:48 +0000 (18:03 +0100)]
arm64: dts: qcom: sm8450: Add missing properties for cryptobam
num-channels and qcom,num-ees are required for BAM nodes without clock,
because the driver cannot ensure the hardware is powered on when trying to
obtain the information from the hardware registers. Specifying the node
without these properties is unsafe and has caused early boot crashes for
other SoCs before [1, 2].
Add the missing information from the hardware registers to ensure the
driver can probe successfully without causing crashes.
When num-channels and qcom,num-ees is not provided in devicetree, the
driver will try to read these values from the registers during probe but
this fails if the interconnect is not on and then crashes the system.
So we can provide these properties in devicetree (queried after patching
BAM driver to enable the necessary interconnect) so we can probe
cryptobam without reading registers and then also use the QCE as
expected.
Krzysztof Kozlowski [Wed, 8 Jan 2025 12:05:30 +0000 (13:05 +0100)]
arm64: dts: qcom: Use recommended MBN firmware path
All Qualcomm firmwares uploaded to linux-firmware are in MBN format,
instead of split MDT. Firmware for boards here is not yet in
linux-firmware, but if it gets accepted it will be MBN, not MDT.
Change might affect users of DTS which rely on manually placed firmware
files, not coming from linux-firmware package.
Abel Vesa [Tue, 4 Mar 2025 10:57:49 +0000 (12:57 +0200)]
arm64: dts: qcom: x1e80100-t14s: Enable external DisplayPort support
The Lenovo ThinkPad T14s Gen6 provides external DisplayPort on all
2 USB Type-C ports. Each one of this ports is connected to a dedicated
DisplayPort controller.
Due to support missing in the USB/DisplayPort combo PHY driver,
the external DisplayPort is limited to 2 lanes.
So enable the first and second DisplayPort controllers and limit their
data lanes number to 2.
Abel Vesa [Tue, 4 Mar 2025 10:57:48 +0000 (12:57 +0200)]
arm64: dts: qcom: x1e80100-t14s: Describe the Parade PS8830 retimers
The Lenovo ThinkPad T14s Gen6 laptop comes with 3 Parade PS8830 retimers,
one for each Type-C port. These handle the orientation and altmode
switching and are controlled over I2C. In the connection chain, they sit
between the USB/DisplayPort combo PHY and the Type-C connector.
Describe the retimers and all gpio controlled voltage regulators used by
each retimer. Also, modify the pmic glink graph to include the retimers in
between the SuperSpeed/Sideband in endpoints and the QMP PHY out
endpoints.
Abel Vesa [Tue, 4 Mar 2025 10:57:46 +0000 (12:57 +0200)]
arm64: dts: qcom: x1e80100-crd: Describe the Parade PS8830 retimers
The X Elite CRD board comes with 3 Parade PS8830 retimers, one for each
Type-C port. These handle the orientation and altmode switching and are
controlled over I2C. In the connection chain, they sit between the
USB/DisplayPort combo PHY and the Type-C connector.
Describe the retimers and all gpio controlled voltage regulators used by
each retimer. Also, modify the pmic glink graph to include the retimers in
between the SuperSpeed/Sideband in endpoints and the QMP PHY out endpoints.
Konrad Dybcio [Tue, 4 Mar 2025 17:10:46 +0000 (18:10 +0100)]
arm64: dts: qcom: x1e80100-romulus: Keep L12B and L15B always on
These regulators power some electronic components onboard. They're
most likely kept online by other pieces of firmware, but you can never
be sure enough.
Fixes: 09d77be56093 ("arm64: dts: qcom: Add support for X1-based Surface Laptop 7 devices") Reported-by: Johan Hovold <johan+linaro@kernel.org> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Reviewed-by: Johan Hovold <johan+linaro@kernel.org> Link: https://lore.kernel.org/r/20250304-topic-sl7_vregs_aon-v1-1-b2dc706e4157@oss.qualcomm.com Signed-off-by: Bjorn Andersson <andersson@kernel.org>
projects / users / jedix / linux-maple.git / log