bpf samples

bpf program support

add argconfig_parse_comma_sep_string

Signed-off-by: Christoph Hellwig <hch@lst.de>

Update supported devices in man page

Corrected vs-internal-log support status for some devices

id-ctrl vs for Amazon Elastic Block Store

This allows the user to extract useful information from the
vendor-specific field when querying Elastic Block Storage
devices attached by Amazon Web Services. In particular, this
field is populated with the block device that was requested
by the user in the API call, which is of the form `/dev/sdc`
or `/dev/xvdc` rather than `/dev/nvme2`. This plugin reduces
the need for operating system maintainers to include vendor-
specific packages in their distribution.

https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/nvme-ebs-volumes.html
https://github.com/aws/amazon-ec2-utils/blob/master/ebsnvme-id

fix '< 0' comparisons of unsigned expressions

Fix the error handling of nvme_get_nsid().

Signed-off-by: Klaus Jensen <k.jensen@samsung.com>

{get,set}_feature: get nsid from device node

If the given device is the controller device, set nsid to 0xFFFFFFFF.
This allows something like

  nvme set-feature /dev/nvme0 -f 0x5 -v $((1 << 16))

to work as expected.

Since we cannot use S_ISCHR/S_ISBLK to differentiate between controller
and namespace devices since commit e77046661509 ("remove block device
checking for namespace"), just try the NVME_IOCTL_ID ioctl and if it
fails with ENOTTY, assume that it is the controller device.

Signed-off-by: Klaus Jensen <k.jensen@samsung.com>

nvme: add support for non shared namespaces

Currently, nvme-cli assume that all the namespaces in an NVM subsystem
are shared between all the controllers. There is an option to create
both shared and non-shared namespaces among the controllers in the same
NVM subsystem. For example, in SR-IOV environment, one can attach 1
namespace to each controller that will be private and also 1 namespace
that will be shared among the secondary controllers only. In this case,
the output of "nvme list -v" will be wrong:

NVM Express Subsystems

Subsystem        Subsystem-NQN                                                                                    Controllers
---------------- ------------------------------------------------------------------------------------------------ ----------------
nvme-subsys5     nqn.1994-11.com.samsung:nvme:PM1733:2.5-inch:S4YNNE0N700448                                      nvme18, nvme19, nvme20, nvme21, nvme5

NVM Express Controllers

Device   SN                   MN                                       FR       TxPort Address        Subsystem    Namespaces
-------- -------------------- ---------------------------------------- -------- ------ -------------- ------------ ----------------
nvme18   S4YNNE0N700448       SAMSUNG MZWLJ1T9HBJR-00007               EPK98B5Q pcie   0000:0a:00.1   nvme-subsys5 nvme5n1, nvme5n2, nvme5n3, nvme5n4, nvme5n5, nvme5n6
nvme19   S4YNNE0N700448       SAMSUNG MZWLJ1T9HBJR-00007               EPK98B5Q pcie   0000:0a:00.2   nvme-subsys5 nvme5n1, nvme5n2, nvme5n3, nvme5n4, nvme5n5, nvme5n6
nvme20   S4YNNE0N700448       SAMSUNG MZWLJ1T9HBJR-00007               EPK98B5Q pcie   0000:0a:00.3   nvme-subsys5 nvme5n1, nvme5n2, nvme5n3, nvme5n4, nvme5n5, nvme5n6
nvme21   S4YNNE0N700448       SAMSUNG MZWLJ1T9HBJR-00007               EPK98B5Q pcie   0000:0a:00.4   nvme-subsys5 nvme5n1, nvme5n2, nvme5n3, nvme5n4, nvme5n5, nvme5n6
nvme5    S4YNNE0N700448       SAMSUNG MZWLJ1T9HBJR-00007               EPK98B5Q pcie   0000:0a:00.0   nvme-subsys5 nvme5n1, nvme5n2, nvme5n3, nvme5n4, nvme5n5, nvme5n6

NVM Express Namespaces

Device       NSID     Usage                      Format           Controllers
------------ -------- -------------------------- ---------------- ----------------
nvme5n1      1        343.60  GB / 343.60  GB    512   B +  0 B   nvme18, nvme19, nvme20, nvme21, nvme5
nvme5n2      2        274.88  GB / 274.88  GB    512   B +  0 B   nvme18, nvme19, nvme20, nvme21, nvme5
nvme5n3      3        283.47  GB / 283.47  GB    512   B +  0 B   nvme18, nvme19, nvme20, nvme21, nvme5
nvme5n4      4        292.06  GB / 292.06  GB    512   B +  0 B   nvme18, nvme19, nvme20, nvme21, nvme5
nvme5n5      5        317.83  GB / 317.83  GB    512   B +  0 B   nvme18, nvme19, nvme20, nvme21, nvme5
nvme5n6      6        137.44  GB / 137.44  GB    512   B +  0 B   nvme18, nvme19, nvme20, nvme21, nvme5

After the fix we'll get the following right topology:

NVM Express Subsystems

Subsystem        Subsystem-NQN                                                                                    Controllers
---------------- ------------------------------------------------------------------------------------------------ ----------------
nvme-subsys5     nqn.1994-11.com.samsung:nvme:PM1733:2.5-inch:S4YNNE0N700448                                      nvme18, nvme19, nvme20, nvme21, nvme5

NVM Express Controllers

Device   SN                   MN                                       FR       TxPort Address        Subsystem    Namespaces
-------- -------------------- ---------------------------------------- -------- ------ -------------- ------------ ----------------
nvme18   S4YNNE0N700448       SAMSUNG MZWLJ1T9HBJR-00007               EPK98B5Q pcie   0000:0a:00.1   nvme-subsys5 nvme5n2, nvme5n6
nvme19   S4YNNE0N700448       SAMSUNG MZWLJ1T9HBJR-00007               EPK98B5Q pcie   0000:0a:00.2   nvme-subsys5 nvme5n3, nvme5n6
nvme20   S4YNNE0N700448       SAMSUNG MZWLJ1T9HBJR-00007               EPK98B5Q pcie   0000:0a:00.3   nvme-subsys5 nvme5n4, nvme5n6
nvme21   S4YNNE0N700448       SAMSUNG MZWLJ1T9HBJR-00007               EPK98B5Q pcie   0000:0a:00.4   nvme-subsys5 nvme5n5, nvme5n6
nvme5    S4YNNE0N700448       SAMSUNG MZWLJ1T9HBJR-00007               EPK98B5Q pcie   0000:0a:00.0   nvme-subsys5 nvme5n1

NVM Express Namespaces

Device       NSID     Usage                      Format           Controllers
------------ -------- -------------------------- ---------------- ----------------
nvme5n1      1        343.60  GB / 343.60  GB    512   B +  0 B   nvme5
nvme5n2      2        274.88  GB / 274.88  GB    512   B +  0 B   nvme18
nvme5n3      3        283.47  GB / 283.47  GB    512   B +  0 B   nvme19
nvme5n4      4        292.06  GB / 292.06  GB    512   B +  0 B   nvme20
nvme5n5      5        317.83  GB / 317.83  GB    512   B +  0 B   nvme21
nvme5n6      6        137.44  GB / 137.44  GB    512   B +  0 B   nvme18, nvme19, nvme20, nvme21

Cc: Max Gurtovoy <maxg@mellanox.com>
Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>

Update capabilities command for some alternate command versions

[nvme-cli] WDC plugin name change ZN345 to ZN355
  Add drive info capability to ZN355

fix cross compile print formats

use print compiler specific print formats

Link: https://github.com/linux-nvme/nvme-cli/issues/784
Signed-off-by: Keith Busch <kbusch@kernel.org>

fix 64-bit print formats

Signed-off-by: Keith Busch <kbusch@kernel.org>

fabrics: fix passing ctrl_loss_tmo=0 by default

cfg.ctrl_loss_tmo will be cleared to zero even if it wasn't set
at all, we must not pass ctrl_loss_tmo in the connection string.

This fixes a regression caused by allowing ctrl_loss_tmo to be
zero at all, by setting it to be a sane default (which currently
matches the kernel default).

Fixes: a6105a30a39a ("nvme-cli/fabrics: Add tos param to connect cmd")
Fixes: 4b607779af71 ("Allow 0 value of ctrl_loss_tmo.")
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>

fabrics: fix segfault when -t <transport> is not passed

Need to check if transport was provided before we derefernce
it.

Fixes: 9da606b4afcc ("fabrics: allow traddr to be host name for ip based transports")
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>

fabrics: fix infinite loop is discovery recursion contains a loop

It's possible that different discovery controllers may refer to
each other. In this case, we will get into an infinite loop as
we don't track that we have already connected and seen this.

The kernel doesn't protect us from this for discovery controllers
because it always allows duplicate discovery controllers.

Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Keith Busch <kbusch@kernel.org>

fabrics: move connect_args extraction to a dedicated routine

We will need it to track controllers as we are iterating over
nested discovery log pages recursion.

Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Keith Busch <kbusch@kernel.org>

nvme: add fabrics discovery controller default port number

The IANA port number for a discovery controller is 8009
for NVMe/TCP and 4420 for any NVMe/RDMA port number. So make
sure to fill it and pass it down, it will help us as we
track and match connection arguments for filtering purposes.

Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Keith Busch <kbusch@kernel.org>

Print human readable output for get_features test

Printing human readable output for get_features selftest.

Signed-off-by: Narasimhan V <sim@linux.vnet.ibm.com>

Getting interrupt list only for current controller

Recently there was a fix for getting the interrupt vector list in
get_features selftest. That gets the list for all nvme controllers
in the system. Fixing it by getting the list for only current
controller.

Signed-off-by: Narasimhan V <sim@linux.vnet.ibm.com>

[nvme-cli] Updated documentation files for vs-smart-add-log wdc plugin command

[nvme-cli] Add log page mask parameter to vs-smart-add-log wdc plugin command.

add support for issuing simple copy commands

Add support for NVMe TP 4065a ("Simple Copy Command"), v2020.05.04
("Ratified").

Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Co-authored-by: Steven Seungcheol Lee <sc108.lee@samsung.com>

[NVMe-CLI] Add support for vs-fw-activate-history and clear-fw-activate-history
      in wdc plugins for SN345

[NVMe-CLI] Add support for clear-pcie-correctable-error in wdc plugins
  for SN345

Micron plugin and documentation updates

Micron plugin and documentation updates

Improve pretty print of the ZNS Command Set Identify Namespace command

- Add pretty print for mar, mor, rrl, and frl fields.
- Clarity Zone Size that value is reported in hex.
- Add header text for the zoc and ozcs fields.

Signed-off-by: Matias Bjørling <matias.bjorling@wdc.com>

Handling system error #768

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>

Add missing dependencies on systemd & systemd-udev

For /usr/bin/udevadm and /usr/bin/systemctl

Add rpm build output on gitignore

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>

Added documentation for capabilities command

Finished implementing capabilities checks

Spacing fix

Initial coding for new command 'capabilities', also create PCIE_CLEAR_MASK

use normal alloc for fw download

Huge pages are only helpful for large transfers that may exceed the
driver's max segment limit. Unless a fw download wants to exceed that
transfer length, use normal allocation.

Link: https://github.com/linux-nvme/nvme-cli/issues/775
Signed-off-by: Keith Busch <kbusch@kernel.org>

format: rescan after format for character device linux-nvme #709

re-read partition table is only vaild for block device
so do namespaces rescan for character device

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>

Added global namespace and device id display

Reformatted text output to match other plugins

nvme-print: zns mar/mor fields are 32 bits

Fix the conversion from 16 to 32 bits.

Signed-off-by: Klaus Jensen <k.jensen@samsung.com>

Fixed some spacing

Added support for device 0x5006 to clear-pcie-correctable-error

Added missing semicolon

Added DITT explanation and cleaned up spacing

Added documentation for temperature stats function

Added device support check for temp stats command

Corrected the output of TMT1 and 2

Implemented additional statistics to display

Added temperature information getting and text formatting

Initial coding

correct some prompt

Signed-off-by: Wei Hou <wei.hou@scaleflux.com>

correct some prompt

Signed-off-by: Wei Hou <wei.hou@scaleflux.com>

do capacity change check

Signed-off-by: Wei Hou <wei.hou@scaleflux.com>

sfx: add set/get-feature sub cmd

Signed-off-by: Wei Hou <wei.hou@scaleflux.com>

Add zone-mgmt-recv parameters to issue command

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>

nvme zns: close device fd in id_ctrl() func

closed fd in id_ctrl() function.
added le32_to_cpu conversion to frl and rrl fields in print functions.

Signed-off-by: Aravind Ramesh <Aravind.Ramesh@wdc.com>

nvme zns: segmentation fault in cmd "nvme zns zone-mgmt-send"

zone_mgmt_send function calls strlen() on a null ptr causing the
segmentation fault. Check the pointer instead of len.

Signed-off-by: Aravind Ramesh <Aravind.Ramesh@wdc.com>

Merge branch 'master' of https://github.com/linux-nvme/nvme-cli

iocs fixes

Remove bit fields. We can't rely on their byte order.

Remove iocs feature payload, since there isn't one with this feature.
The iocs profile points to an entry in the identify iocs array.

Signed-off-by: Keith Busch <kbusch@kernel.org>

start continuous integration

Help reduce compile breakage

fix compile errors from recent pr

Signed-off-by: Keith Busch <kbusch@kernel.org>

Fix spacing issue.

Add support for ZN345 drive.

zns: getting zdes logic using exist function, data_len should be in bytes

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>

zns: nsid is used for zone-mgmt-send exception handling

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>

nvme-print: streamline show-regs output

Fix mixed tabs/spaces use in show-regs pretty print and align tabulated
output.

Signed-off-by: Klaus Jensen <k.jensen@samsung.com>

Updates from pull request review

Signed-off-by: Randy Bates <randall.bates@wdc.com>

Update and Parse FB log page

Signed-off-by: Randy Bates <randall.bates@wdc.com>

Add Debian installation instructions

Signed-off-by: Stephen Kitt <steve@sk2.org>

fix 32-bit build

sizeof() is different on 32 and 64 bit.

Signed-off-by: Keith Busch <kbusch@kernel.org>

Merge branch 'MatiasBjorling-prettifyzns'

Add latency check for zone-append

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
Co-authored-by: Klaus Jensen <k.jensen@samsung.com>

Modify changed zone list command to issue get-log

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
Co-authored-by: Klaus Jensen <k.jensen@samsung.com>

Add exception for zone management send command

Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Co-authored-by: Steven Seungcheol Lee <sc108.lee@samsung.com>

zone-mgmt-recv report size bug fix

if extended report issued, then report will be zone descriptor + zone descriptor extention
zdes value  is  reported  in  64B  units

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
Co-authored-by: Klaus Jensen <k.jensen@samsung.com>

Add zoned namespaces identify human readable print

Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Co-authored-by: Steven Seungcheol Lee <sc108.lee@samsung.com>

add fields and types for zoned namespaces

zamds renamed as zasl(Zone Append Size Limit)

Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Co-authored-by: Steven Seungcheol Lee <sc108.lee@samsung.com>

Align print of zns id_ctrl with nvm id_ctrl

Signed-off-by: Matias Bjørling <matias.bjorling@wdc.com>

Add support for printing vs area in zns id ns

Signed-off-by: Matias Bjørling <matias.bjorling@wdc.com>

Align print of zns id_ns with nvm id_ns

Signed-off-by: Matias Bjørling <matias.bjorling@wdc.com>

Add latency check for zone-append

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
Co-authored-by: Klaus Jensen <k.jensen@samsung.com>

Modify changed zone list command to issue get-log

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
Co-authored-by: Klaus Jensen <k.jensen@samsung.com>

Add exception for zone management send command

Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Co-authored-by: Steven Seungcheol Lee <sc108.lee@samsung.com>

zone-mgmt-recv report size bug fix

if extended report issued, then report will be zone descriptor + zone descriptor extention
zdes value  is  reported  in  64B  units

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
Co-authored-by: Klaus Jensen <k.jensen@samsung.com>

Add zoned namespaces identify human readable print

Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Co-authored-by: Steven Seungcheol Lee <sc108.lee@samsung.com>

add fields and types for zoned namespaces

zamds renamed as zasl(Zone Append Size Limit)

Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Co-authored-by: Steven Seungcheol Lee <sc108.lee@samsung.com>

Remove lx text from reporting

When reporting zones, the lx text was not removed when the type was
changed to be PRIx64.

Signed-off-by: Matias Bjørling <matias.bjorling@wdc.com>

Capitalize LBA in descriptions within the ZNS plugin

Signed-off-by: Matias Bjørling <matias.bjorling@wdc.com>

[NVMe-CLI] WDC Plugin update documentation for vs-smart-add-log command

[NVME CLI] WDC Plugin Command Updates
Add support for using uuid index when retrieving the 0xC2 Log Page
Add support for parsing the 0xC0 log page

Various cleanups in the ZNS plugin

Changed verbose option to be the human readable option, such that it
aligns with the behavior of NVM id-ns and NVM id-ctrl.

Fix typos.

Signed-off-by: Matias Bjørling <matias.bjorling@wdc.com>

Add really pretty print for ZNS Command Set specific Identify Namespace data structure

Updated the printing of the zone list to be a lot prettier.

Also added extension support.

Signed-off-by: Matias Bjørling <matias.bjorling@wdc.com>
Signed-off-by: Aravind Ramesh <aravind.ramesh@wdc.com>

Allow 0 value of ctrl_loss_tmo.

Add warning if not all zone changed list entries are retrieved.

The Changed Zone List only support reporting of a maximum of 511 entries.

Signed-off-by: Hans Holmberg <hans.holmberg@wdc.com>
Signed-off-by: Matias Bjørling <matias.bjorling@wdc.com>

Added new namespace list command on list-ns, 4056 modification added

feature added for I/O Command Set Profile
create ns need to use command set identifier
nvscc renamed as icsvscc

Spec : NVMe - TP 4056 Namespace Types 2020.06.15 - Ratified

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
Co-authored-by: Klaus Jensen <k.jensen@samsung.com>

Identify I/O Command Set data structure command added

Spec : NVMe - TP 4056 Namespace Types 2020.06.15 - Ratified

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
Co-authored-by: Klaus Jensen <k.jensen@samsung.com>

Prevent compiler from optimizing mmio_read64 to single 64b read

Add support for DUI data header version 4.

DRV-1050 Update SN730 to support DUI data header version 4
  Added version 4 structs and version checking logic

ioctl: fix missing addrof

Submit the address, not the value in the zone append ioctl.

Signed-off-by: Klaus Jensen <k.jensen@samsung.com>