nvme-print-json: use human helper everywhere

If we have this helper let's use it.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

nvme-print-json: remove obj_print helper

This tiny helper has no real functionality. The json_object is always
valid. Thus drop it and call the other helper directly.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

plugins/ocp: update nvme_show_select_result call

The recent nvme-print-json refactoring/exstension changed the
nvme_show_select_result function signature but missed to update the ocp
plugin. Pass in the fid to the show function.

Fixes: 28a3a0975a33 ("nvme-print-json: Change to report feature select in array")
Signed-off-by: Daniel Wagner <dwagner@suse.de>

mailmap: only show contributer's name

When looking at git history don't clutter the overview. Just list the
name.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

nvme-print-json: Change to report status and message in array

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Change to report feature select in array

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Change to report error and data in array

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add show_init/finish calls to report features in array

Note: Still error and data reported separately so will be fixed later.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print: Add nvme_show_error_status() to merge error message and status

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Use r instead of root and use obj_add_***(r, ..., ...)

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Delete static const char string global variables

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add remaining controller registers readable format

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add readable format cap, vs, cc, csts, nssr and crto registers

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Combine duplicated json key and val string variables

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Replase json_array_add_value_string() to array_add_str()

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Replase json_object_add_value_uint128() to obj/root_add_uint128()

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Replase json_object_add_value_object() to obj/root_add_obj()

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Replase json_array_add_value_object() to array_add_obj()

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Replase json_object_add_value_array() to obj/root_add_array()

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Replase json_object_add_value_uint() to obj/root_add_uint()

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Replase json_object_add_value_int() to obj/root_add_int()

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Replase json_object_add_value_uint64() to obj/root_add_uint64()

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Replase json_object_add_value_string() to obj/root_add_str()

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Update feature_show_fields_*** to use root/obj_add_***()

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Update lba_status_log to use root_add_***() and obj_add_***()

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Replace lba_status_log printf() to root_add_result()

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add list_item print function

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add lba_status_info print function

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add lba_range print function

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add id_ctrl_rpmbs print function

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Unify json_list and jroot object names to root

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add json_zns_changed print function

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add root_add_result() to output result message

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Split persistent_event_log print function

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Remove unnecessary string newline code

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Replace effects_log_list print to use json_print()

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Print persistent_event_log no log data result correctly

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add static "result" and "erorr" strings variables

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add single_property printf function

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme: Replace get feature command stderr output to nvme_show_error()

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Change d() output to use d_json()

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme: Fix get-feature command mixed stdout and json outputs

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add remaining feature fields print functions

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Update formatting and codying style

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

build: Add -std=c99 to CFLAGS for muon on CentOS 7

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

fabrics: add udev rule to avoid renaming nbft interfaces

In the initramfs, the interface naming is taken care of by dracut.
But there are various network-interface-naming policies in place which
may attempt to rename the interface, causing confusion and possibly
wrong interface parameters.

Add an udev rule that avoids renaming any network interface that
has been assigned a name nbft$N, which is by convention the naming
scheme that is used for NBFT device in the initramfs.

Note: The simpler 'NAME:="%k"' directive doesn't work because udev rejects
it ('Ignoring NAME="%k", as it will take no effect.'). The ":=" syntax makes
sure the interface isn't renamed any more by later rules. "INTERFACE" is set
by the kernel in the "add" uevent for a network interface.

Signed-off-by: Martin Wilck <mwilck@suse.com>

fabrics: autoconnect: add service unit for connecting NBFT subsystems

Create a separate unit file for connecting to NBFT-defined subsystems.
This unit is intended to be called in "post-up" scripts from network
management software if an interface defined in the HFI section of the
NBFT is brought up (L3-configured).

In simple scenarios with just one HFI, this won't be necessary because the
interface must be brought up in the initramfs already. But in multipath
scenarios, the initramfs may choose not to wait for every HFI to come up, and
thus it may be necessary to bring up the secondary connection(s) later on.

Signed-off-by: Martin Wilck <mwilck@suse.com>
[dwagner: use unit options instead of ExecStartPre
          update nvme command line]
Signed-off-by: Daniel Wagner <dwagner@suse.de>

fabrics: autoconnect: explicitly express module dependency

Use Wants/After to let systemd handle loading the kernel module, which
is the preferred way.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

Updates to codeql config

* Split c-cpp and python init sections
* Add paths-ignore config for pythin init
* Add json-c wrap during build - increases c codeql coverage

README: Add make static explanation

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>

libnvme-wrap: exit on VOID_FN lookup failure

libnvme-wrap provides fallbacks for missing libnvme functions.
For functions that return a value, the FN() macro can be used
to define a default return value if the function isn't found.
This isn't possible for functions returning void,
so VOID_FN() currently is a no-op if the function can't be found.
For nvme_init_copy_range_f1(), the only current VOID_FN() user,
this will result in silently sending a Copy command
with a zeroed range, which is not what the user requested.
Instead, exit the process immediately if the function can't be found.

Signed-off-by: Caleb Sander <csander@purestorage.com>

plugins/ocp:Added the ocp C6h feature api
Reviewed-by: Karthik Balan karthik.b82@samsung.com, Arunpandian J arun.j@samsung.com
Signed-off-by: Vigneshwaran Saravanan/SSD TS Dev /SSIR/Engineer/Samsung Electronics <s.vignesh@samsung.com>

plugin/ocp_fid_c6h:Added the ocp C6h feature api
Reviewed-by: Karthik Balan karthik.b82@samsung.com, Arunpandian J arun.j@samsung.com
Signed-off-by: Vigneshwaran Saravanan/SSD TS Dev /SSIR/Engineer/Samsung Electronics <s.vignesh@samsung.com>

nvme-copy: support cross-namespace copy

Add support for NVMe TP4130 ("Cross-Namespace Copy")
- Add Copy Descriptor Formats 2h and 3h
- Add "--snsids" option to specify source namespaces to copy from
- Add "--sopts" option to specify source options (Fast Copy Only)
- Print new Host Behavior Support bits, new ONCS bits, and new Optional
  Copy Formats Supported bits
- Extend unit test case to test cross-namespace copy formats

build(deps): bump actions/checkout from 3 to 4

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

nvme/plugins: fix mismatch operator

Signed-off-by: jinhua.huang <jinhua.huang@memblaze.com>

nvme: fix overflow possiblity

The implicit type conversion will expand both operands to the type
int and not unsigned long long as the result expects. Promote
the first operand to the target type. Obviously the multiplication
can still overflow, but this is a different problem.

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
[dwagner: added commit message]
Signed-off-by: Daniel Wagner <dwagner@suse.de>

nvme: reduce identify cmd issue

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>

nvme: allow set-features to take input from stdin

Fixes: fed9e5ee04cd ("nvme: auto free nvme_dev resource")

Fix common misspellings from codespell project

Signed-off-by: Yi Zhang <yi.zhang@redhat.com>
[dwagner: dropped auto generated documentation
          dropped ccan changed]
Signed-off-by: Daniel Wagner <dwagner@suse.de>

nvme-print: Correct to print correct ascii character string length

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

print-stdout: print Host Behavior Support correctly

In nvme-cli 1.16, printing the Host Behavior Support feature
logged the values of the 3 fields ACRE, ETDAS, and LBAFEE.
This appears to have regressed in nvme-cli 2.0,
and now only the value of ACRE is printed, without any description.
Log all 3 fields with proper descriptions.
Drop "Host Behavior Support" from their names,
as it's redundant with the feature name.

Signed-off-by: Caleb Sander <csander@purestorage.com>

build: Bump libnvme wrap

Get ETDAS and LBAFEE definitions.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

plugins/solidigm: Added support for temperature statistics log page

Signed-off-by: leonardo.da.cunha <leonardo.da.cunha@solidigm.com>

Add support for codeql sweeps

Update codeql.yml

doc: Add virt-mgmt command

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

doc: Add id-uuid command

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

doc: Add list-secondary command

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

doc: Add id-ns-granularity command

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

doc: Add nvme commands --output-format and --verbose options

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

completions: Add nvme-mi-recv nad nvme-mi-send commands completions

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

completions: Change short option -o and -v duplicated to upper case

The nvme-mi-recv and nvme-mi-send commands completions are not added.
All nvme commands doc/completions not added output-format/verbose options.
So for those will be added and updated doc/completions later separately.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

doc: Change short option -o and -v duplicated to upper case

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme: Change short option -o and -v duplicated to upper case

The output-format and verbose options are added by NVMF_ARGS() macro.
So some commands short option duplicated with the option added.
Change the command short options duplicated to upper case -O and -v.
But only the get-log command lpo option changed to -L not upper case.
Sicne already upper case -O option also is used for the ot option.
  Note: Documentation and completions will be updated separately.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

build(deps): bump actions/checkout from 3 to 4

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

nvme: Change phy-rx-eom-log command to use NVME_ARGS instead

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

plugins/memblaze: Add smart-log-add and latency-feature functions

1. add smart-log-add, latency-feature functions
2. convert code style to align with linux kernel code style
3. using __packed instead of pragma style

Signed-off-by: jinhua.huang <jinhua.huang@memblaze.com>

plugins/solidigm: internal-logs Telemetry auto detect last data area.
Faster telemetry retrieval using large buffers.

Signed-off-by: leonardo.da.cunha <leonardo.da.cunha@solidigm.com>

nvme: Change to use NVME_FLBAS_META_EXT() macro to check flbas value

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add host memory buffer and timestamp features print functions

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add feature fields print functions

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add TMPTH feature print function

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add show_feature_fields print function

Note: Only partial features are supported yet since still under
      implementing for remaining features.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add select_result print function

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Use json_print to print and free object

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add lba_status print function

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Combine variable definition and setting value

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add id_iocs print function

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-stdout: Fix coding style errors

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme-print-json: Add directive print function

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>

nvme: Fixed segmentation fault when getting host initiated telemetry

Signed-off-by: leonardo.da.cunha <leonardo.da.cunha@solidigm.com>

plugins/wdc: enhanced SN861 device support

This commit enables several commands to work with this device properly
and adds a new plugin command set-latency-monitor-feature.

Reviewed-by: Jeffrey Lien <jeff.lien@wdc.com>
Signed-off-by: Brandon Paupore <brandon.paupore@wdc.com>

plugins/wdc: cleanup line lengths

Signed-off-by: Brandon Paupore <brandon.paupore@wdc.com>

nvme: do not include meta data for PRACT=1 and MD=8

No meta data is transfered for PRACT=1 and MD=8:
   5.2.2.1 Protection Information and Write Commands
   5.2.2.2 Protection Informatio and Read Commands

Signed-off-by: Daniel Wagner <dwagner@suse.de>

nvme: use block-count arg if provided

When the user provides the --block-count argument use this value and
don't be clever and try to calculate the value. This is not what
the user asked us to do.

Signed-off-by: Daniel Wagner <dwagner@suse.de>

build: bump libnvme to disable tests option

it occur multiple definition error with static build
project use successful build of subproject revision (no need to build tests)

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>

build: Add static build on CI target

Update container image as debian:latest(targets run on ubuntu-latest)

Co-authored-by: Daniel Wagner <dwagner@suse.de>
Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>

meson: Add libhugetlbfs option to not included in static

libhugetlbfs does not support static library
https://github.com/libhugetlbfs/libhugetlbfs/issues/11

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>

Makefile: add standalone build

To handover build binary for different environment users
Build result checked with ldd below
[root@localhost .build]# ldd nvme
        not a dynamic executable
Do not run libnvme tests(set subproject revision successful build)
Disable keyutils on libnvme(pkgconfig always find shared first when -llib is given)

Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>

build: upload artifacts only for upstream repo

Only upload any artifacts to linux-nvme organization if it's NOT a fork.

Signed-off-by: Daniel Wagner <dwagner@suse.de>