From: Darrick J. Wong Date: Mon, 29 Feb 2016 05:03:07 +0000 (+1100) Subject: mkfs: fix crash when initializing rbmip X-Git-Tag: v4.7.0-rc1~64^2 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=refs%2Fheads%2Flibxfs-4.6-sync;p=users%2Fhch%2Fxfsprogs.git mkfs: fix crash when initializing rbmip Initialize rbmip, log the inode, /then/ assign it to the xfs_mount. Don't try to access rbmip in the xfs_mount before that, or it'll crash. Signed-off-by: Darrick J. Wong Reviewed-by: Christoph Hellwig Signed-off-by: Dave Chinner --- diff --git a/mkfs/proto.c b/mkfs/proto.c index 933924ef2..d99e96589 100644 --- a/mkfs/proto.c +++ b/mkfs/proto.c @@ -653,7 +653,7 @@ rtinit( mp->m_sb.sb_rbmino = rbmip->i_ino; rbmip->i_d.di_size = mp->m_sb.sb_rbmblocks * mp->m_sb.sb_blocksize; rbmip->i_d.di_flags = XFS_DIFLAG_NEWRTBM; - *(__uint64_t *)&VFS_I(mp->m_rbmip)->i_atime = 0; + *(__uint64_t *)&VFS_I(rbmip)->i_atime = 0; libxfs_trans_log_inode(tp, rbmip, XFS_ILOG_CORE); libxfs_log_sb(tp); mp->m_rbmip = rbmip;