From: Simon Schricker Date: Tue, 16 Apr 2019 13:27:40 +0000 (-0700) Subject: nvme-cli: Increase size of ONTAP namespace path variable X-Git-Tag: v1.9~83 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=fefedba848578c83ccefcb9be0b71f13e9913481;p=users%2Fsagi%2Fnvme-cli.git nvme-cli: Increase size of ONTAP namespace path variable nspath's size is ONTAP_NS_PATHLEN and is written to by: snprintf(nspath, ONTAP_NS_PATHLEN, "%s%s%s%s", ontap_vol, vol_name, "/", ns_name); Required bytes: - ontap_vol is a constant char pointer, set to "/vol/", so 5 bytes - vol_name's size is ONTAP_LABEL_LEN, which is 260, deducting the null-byte for termination makes 259 required bytes - "/" is 1 byte - ns_name's size is also ONTAP_LABEL_LEN, which is 260, deducting the null-byte for termination makes 259 required bytes - the final null-byte: 1 That makes in total 5 + 259 + 1 + 259 + 1 = 525 required bytes Signed-off-by: Simon Schricker --- diff --git a/plugins/netapp/netapp-nvme.c b/plugins/netapp/netapp-nvme.c index 29513113..aa5a94d9 100644 --- a/plugins/netapp/netapp-nvme.c +++ b/plugins/netapp/netapp-nvme.c @@ -35,7 +35,7 @@ #define ONTAP_C2_LOG_ID 0xC2 #define ONTAP_C2_LOG_SIZE 4096 #define ONTAP_LABEL_LEN 260 -#define ONTAP_NS_PATHLEN 520 +#define ONTAP_NS_PATHLEN 525 enum { NNORMAL,