From: Heiner Kallweit Date: Sun, 24 Jun 2018 16:40:23 +0000 (+0200) Subject: r8169: don't check WoL when powering down PHY and interface is down X-Git-Tag: v4.19-rc1~140^2~553^2 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=fe87bef01f9be5d968badb35648a527fa37888c1;p=users%2Fwilly%2Flinux.git r8169: don't check WoL when powering down PHY and interface is down We can power down the PHY irregardless of WOL settings if interface is down. So far we would have left the PHY enabled if WOL options are set and the interface is brought down. Signed-off-by: Heiner Kallweit Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index f8a1309a6494..1d33672c650d 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -4635,7 +4635,7 @@ static void rtl_wol_suspend_quirk(struct rtl8169_private *tp) static bool rtl_wol_pll_power_down(struct rtl8169_private *tp) { - if (!tp->saved_wolopts) + if (!netif_running(tp->dev) || !tp->saved_wolopts) return false; rtl_speed_down(tp);