From: Julia Lawall Date: Sun, 8 Jul 2012 01:37:43 +0000 (+0000) Subject: drivers/net/cnic.c: remove invalid reference to list iterator variable X-Git-Tag: v2.6.39-400.9.0~338^2~119 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=fda5c7e55a50f26e4ad263da6169d48b13b8e68f;p=users%2Fjedix%2Flinux-maple.git drivers/net/cnic.c: remove invalid reference to list iterator variable If list_for_each_entry, etc complete a traversal of the list, the iterator variable ends up pointing to an address at an offset from the list head, and not a meaningful structure. Thus this value should not be used after the end of the iterator. There does not seem to be a meaningful value to provide to netdev_warn. Replace with pr_warn, since pr_err is used elsewhere. This problem was found using Coccinelle (http://coccinelle.lip6.fr/). (cherry picked from commit 022f09784b85396b4ceba954ce28e50de4882281) Signed-off-by: Julia Lawall Signed-off-by: David S. Miller Signed-off-by: Joe Jin --- diff --git a/drivers/net/cnic.c b/drivers/net/cnic.c index ebbf19fcae71..e2c06642ea1d 100644 --- a/drivers/net/cnic.c +++ b/drivers/net/cnic.c @@ -537,7 +537,8 @@ int cnic_unregister_driver(int ulp_type) } if (atomic_read(&ulp_ops->ref_count) != 0) - netdev_warn(dev->netdev, "Failed waiting for ref count to go to zero\n"); + pr_warn("%s: Failed waiting for ref count to go to zero\n", + __func__); return 0; out_unlock: