From: Markus Elfring Date: Tue, 10 Jun 2025 12:14:09 +0000 (+0200) Subject: RDMA/cxgb4: Delete an unnecessary check before kfree() in c4iw_rdev_open() X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=fd383bf8b6954d3ce46c27a1ed55fea226369b86;p=users%2Fjedix%2Flinux-maple.git RDMA/cxgb4: Delete an unnecessary check before kfree() in c4iw_rdev_open() It can be known that the function “kfree” performs a null pointer check for its input parameter. It is therefore not needed to repeat such a check before its call. Thus remove a redundant pointer check. The source code was transformed by using the Coccinelle software. Signed-off-by: Markus Elfring Link: https://patch.msgid.link/cdc577a5-cebd-404a-b762-cc6fee0870dc@web.de Signed-off-by: Leon Romanovsky --- diff --git a/drivers/infiniband/hw/cxgb4/device.c b/drivers/infiniband/hw/cxgb4/device.c index 034b85c422555..b67747ae6a688 100644 --- a/drivers/infiniband/hw/cxgb4/device.c +++ b/drivers/infiniband/hw/cxgb4/device.c @@ -905,8 +905,7 @@ static int c4iw_rdev_open(struct c4iw_rdev *rdev) return 0; err_free_status_page_and_wr_log: - if (c4iw_wr_log && rdev->wr_log) - kfree(rdev->wr_log); + kfree(rdev->wr_log); free_page((unsigned long)rdev->status_page); destroy_ocqp_pool: c4iw_ocqp_pool_destroy(rdev);