From: Niklas Söderlund Date: Mon, 8 Sep 2025 15:44:26 +0000 (+0200) Subject: net: ethernet: renesas: rcar_gen4_ptp: Use lockdep to verify internal usage X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=fd2b2429fbc859b398385da69c85515851f2c0e5;p=users%2Fhch%2Fmisc.git net: ethernet: renesas: rcar_gen4_ptp: Use lockdep to verify internal usage Instead of a having a comment that the lock must be held when calling the internal helper add a lockdep check to enforce it. Signed-off-by: Niklas Söderlund Reviewed-by: Simon Horman Link: https://patch.msgid.link/20250908154426.3062861-4-niklas.soderlund+renesas@ragnatech.se Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/ethernet/renesas/rcar_gen4_ptp.c b/drivers/net/ethernet/renesas/rcar_gen4_ptp.c index cf13eba9b65e..d0979abd36de 100644 --- a/drivers/net/ethernet/renesas/rcar_gen4_ptp.c +++ b/drivers/net/ethernet/renesas/rcar_gen4_ptp.c @@ -42,12 +42,13 @@ static int rcar_gen4_ptp_adjfine(struct ptp_clock_info *ptp, long scaled_ppm) return 0; } -/* Caller must hold the lock */ static void _rcar_gen4_ptp_gettime(struct ptp_clock_info *ptp, struct timespec64 *ts) { struct rcar_gen4_ptp_private *ptp_priv = ptp_to_priv(ptp); + lockdep_assert_held(&ptp_priv->lock); + ts->tv_nsec = ioread32(ptp_priv->addr + PTPGPTPTM00_REG); ts->tv_sec = ioread32(ptp_priv->addr + PTPGPTPTM10_REG) | ((s64)ioread32(ptp_priv->addr + PTPGPTPTM20_REG) << 32);