From: Thomas Huth Date: Wed, 2 Aug 2023 13:57:21 +0000 (+0200) Subject: hw/i386/intel_iommu: Fix index calculation in vtd_interrupt_remap_msi() X-Git-Tag: pull-xenfv-stable-20231106~152^2~4 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=fcd8027423300b201b37842b88393dc5c6c8ee9e;p=users%2Fdwmw2%2Fqemu.git hw/i386/intel_iommu: Fix index calculation in vtd_interrupt_remap_msi() The values in "addr" are populated locally in this function in host endian byte order, so we must not swap the index_l field here. Signed-off-by: Thomas Huth Message-Id: <20230802135723.178083-5-thuth@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Xu --- diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 4028e32701..3ca71df369 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -3459,7 +3459,7 @@ static int vtd_interrupt_remap_msi(IntelIOMMUState *iommu, goto out; } - index = addr.addr.index_h << 15 | le16_to_cpu(addr.addr.index_l); + index = addr.addr.index_h << 15 | addr.addr.index_l; #define VTD_IR_MSI_DATA_SUBHANDLE (0x0000ffff) #define VTD_IR_MSI_DATA_RESERVED (0xffff0000)