From: Kevin Cernekee <cernekee@gmail.com>
Date: Fri, 26 Oct 2012 04:16:57 +0000 (-0700)
Subject: auth: Remove obsolete trace message from parse_form()
X-Git-Tag: v4.99~26^2~19
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=fc8d8a5cad2c021d71bafdb3a7adf3372a00e448;p=users%2Fdwmw2%2Fopenconnect.git

auth: Remove obsolete trace message from parse_form()

parse_form() used to add hidden form fields to the query string on
the spot, but since it doesn't anymore, it should not display the
"Fixed options" trace message.

After making this change, we can remove the request / request_body
arguments.

Signed-off-by: Kevin Cernekee <cernekee@gmail.com>
---

diff --git a/auth.c b/auth.c
index 4c9d623d..45507ce4 100644
--- a/auth.c
+++ b/auth.c
@@ -172,7 +172,7 @@ static int parse_auth_choice(struct openconnect_info *vpninfo, struct oc_auth_fo
  *  = 1, when form was parsed
  */
 static int parse_form(struct openconnect_info *vpninfo, struct oc_auth_form *form,
-		      xmlNode *xml_node, char *body, int bodylen)
+		      xmlNode *xml_node)
 {
 	char *input_type, *input_name, *input_label;
 
@@ -255,8 +255,6 @@ static int parse_form(struct openconnect_info *vpninfo, struct oc_auth_form *for
 		*p = opt;
 	}
 
-	vpn_progress(vpninfo, PRG_TRACE, _("Fixed options give %s\n"), body);
-
 	return 0;
 }
 
@@ -395,7 +393,7 @@ int parse_xml_response(struct openconnect_info *vpninfo, char *response,
 			}
 			vpninfo->redirect_url = strdup(form->action);
 
-			ret = parse_form(vpninfo, form, xml_node, request_body, req_len);
+			ret = parse_form(vpninfo, form, xml_node);
 			if (ret < 0)
 				goto out;
 		} else if (!vpninfo->csd_scriptname && !strcmp((char *)xml_node->name, "csd")) {