From: Vincent Guittot <vincent.guittot@linaro.org>
Date: Thu, 7 Jan 2021 10:33:23 +0000 (+0100)
Subject: sched/fair: Skip idle cfs_rq
X-Git-Tag: xarray-5.12~296^2~45
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=fc488ffd4297f661b3e9d7450dcdb9089a53df7c;p=users%2Fwilly%2Fxarray.git

sched/fair: Skip idle cfs_rq

Don't waste time checking whether an idle cfs_rq could be the busiest
queue. Furthermore, this can end up selecting a cfs_rq with a high load
but being idle in case of migrate_load.

Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>
Acked-by: Mel Gorman <mgorman@suse.de>
Link: https://lkml.kernel.org/r/20210107103325.30851-2-vincent.guittot@linaro.org
---

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 40d3ebfb5a48..13de7aede74f 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -9402,8 +9402,11 @@ static struct rq *find_busiest_queue(struct lb_env *env,
 		if (rt > env->fbq_type)
 			continue;
 
-		capacity = capacity_of(i);
 		nr_running = rq->cfs.h_nr_running;
+		if (!nr_running)
+			continue;
+
+		capacity = capacity_of(i);
 
 		/*
 		 * For ASYM_CPUCAPACITY domains, don't pick a CPU that could