From: Pan Nengyuan <pannengyuan@huawei.com>
Date: Thu, 27 Feb 2020 01:29:50 +0000 (+0800)
Subject: qemu-img: free memory before re-assign
X-Git-Tag: v5.0.0-rc0~43^2~10
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=fc124ea1dbfac2a1d5b851596831c9da746b7b66;p=users%2Fdwmw2%2Fqemu.git

qemu-img: free memory before re-assign

collect_image_check() is called twice in img_check(), the filename/format will be alloced without free the original memory.
It is not a big deal since the process will exit anyway, but seems like a clean code and it will remove the warning spotted by asan.

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
Message-Id: <20200227012950.12256-3-pannengyuan@huawei.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
---

diff --git a/qemu-img.c b/qemu-img.c
index 4bc40df6d2..7b7087dd60 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -817,6 +817,8 @@ static int img_check(int argc, char **argv)
                     check->corruptions_fixed);
         }
 
+        qapi_free_ImageCheck(check);
+        check = g_new0(ImageCheck, 1);
         ret = collect_image_check(bs, check, filename, fmt, 0);
 
         check->leaks_fixed          = leaks_fixed;