From: Stephen Boyd Date: Mon, 9 Jan 2017 19:47:44 +0000 (-0800) Subject: gpio: Remove impossible checks on container_of() result X-Git-Tag: v4.11-rc1~101^2~48 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=fb505747c06b8894bccb18457fd11bad047384f4;p=linux.git gpio: Remove impossible checks on container_of() result container_of() does pointer math on the pointer that's passed in. If it were to return a NULL pointer the value passed in would need to be perfectly offset from 0 to make that so. Remove these checks because they don't make sense. Signed-off-by: Stephen Boyd Signed-off-by: Linus Walleij --- diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 7f51c9bf5533..c76fa4ffb59c 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -983,7 +983,7 @@ static int gpio_chrdev_open(struct inode *inode, struct file *filp) struct gpio_device, chrdev); /* Fail on open if the backing gpiochip is gone */ - if (!gdev || !gdev->chip) + if (!gdev->chip) return -ENODEV; get_device(&gdev->dev); filp->private_data = gdev; @@ -1002,8 +1002,6 @@ static int gpio_chrdev_release(struct inode *inode, struct file *filp) struct gpio_device *gdev = container_of(inode->i_cdev, struct gpio_device, chrdev); - if (!gdev) - return -ENODEV; put_device(&gdev->dev); return 0; }