From: Dan Carpenter Date: Thu, 9 May 2024 11:02:11 +0000 (+0300) Subject: dmaengine: qcom: gpi: clean up the IRQ disable/enable in gpi_reset_chan() X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=f8f530ba429a334fe1a28714787f8a98e90777ec;p=users%2Fjedix%2Flinux-maple.git dmaengine: qcom: gpi: clean up the IRQ disable/enable in gpi_reset_chan() The calls write_lock/unlock_irq() disables and re-enables the IRQs. Calling spin_lock_irqsave() and spin_lock_restore() when the IRQs are already disabled doesn't do anything and just makes the code confusing. Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/8be473eb-65e0-42b4-b574-e61c3a7f62d8@moroto.mountain Signed-off-by: Vinod Koul --- diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c index 639ab304db9b1..e6ebd688d7463 100644 --- a/drivers/dma/qcom/gpi.c +++ b/drivers/dma/qcom/gpi.c @@ -1191,7 +1191,6 @@ static int gpi_reset_chan(struct gchan *gchan, enum gpi_cmd gpi_cmd) { struct gpii *gpii = gchan->gpii; struct gpi_ring *ch_ring = &gchan->ch_ring; - unsigned long flags; LIST_HEAD(list); int ret; @@ -1214,9 +1213,9 @@ static int gpi_reset_chan(struct gchan *gchan, enum gpi_cmd gpi_cmd) gpi_mark_stale_events(gchan); /* remove all async descriptors */ - spin_lock_irqsave(&gchan->vc.lock, flags); + spin_lock(&gchan->vc.lock); vchan_get_all_descriptors(&gchan->vc, &list); - spin_unlock_irqrestore(&gchan->vc.lock, flags); + spin_unlock(&gchan->vc.lock); write_unlock_irq(&gpii->pm_lock); vchan_dma_desc_free_list(&gchan->vc, &list);