From: Zou Wei Date: Tue, 3 Nov 2020 11:57:54 +0000 (+0800) Subject: IB/isert: Do not excplicitly check == false for bool X-Git-Tag: howlett/maple_spf/20210104~297^2~95 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=f7a95c902b020c7fe6781f0814187c2e2266a689;p=users%2Fjedix%2Flinux-maple.git IB/isert: Do not excplicitly check == false for bool It is not the kernel style, warning reported by coccicheck: ./ib_isert.c:1104:12-24: WARNING: Comparison to bool Link: https://lore.kernel.org/r/1604404674-32998-1-git-send-email-zou_wei@huawei.com Reported-by: Hulk Robot Signed-off-by: Zou Wei Reviewed-by: Sagi Grimberg Signed-off-by: Jason Gunthorpe --- diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c index bd478947b93a..e47cd0291a7e 100644 --- a/drivers/infiniband/ulp/isert/ib_isert.c +++ b/drivers/infiniband/ulp/isert/ib_isert.c @@ -1101,7 +1101,7 @@ isert_handle_scsi_cmd(struct isert_conn *isert_conn, sequence_cmd: rc = iscsit_sequence_cmd(conn, cmd, buf, hdr->cmdsn); - if (!rc && dump_payload == false && unsol_data) + if (!rc && !dump_payload && unsol_data) iscsit_set_unsolicited_dataout(cmd); else if (dump_payload && imm_data) target_put_sess_cmd(&cmd->se_cmd);