From: Ben Guthro Date: Thu, 3 Nov 2011 15:06:56 +0000 (-0400) Subject: x86/microcode: check proper return code. X-Git-Tag: v2.6.39-400.9.0~830^2~2^2 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=f6c958ff0d00ffbf1cdc8fcf2f2a82f06fbbb5f4;p=users%2Fjedix%2Flinux-maple.git x86/microcode: check proper return code. After pulling in this change from your tree, I found the following bug, when checking an enum value, which should be considered before inclusion: Signed-off-by: Konrad Rzeszutek Wilk --- diff --git a/arch/x86/kernel/microcode_xen.c b/arch/x86/kernel/microcode_xen.c index 9d2a06b5bf10..6a73957dd187 100644 --- a/arch/x86/kernel/microcode_xen.c +++ b/arch/x86/kernel/microcode_xen.c @@ -157,7 +157,7 @@ static enum ucode_state xen_request_microcode_user(int cpu, ret = UCODE_OK; out: - if (ret == 0) + if (ret == UCODE_OK) uci->mc = uc; else vfree(uc);