From: Wei Yongjun Date: Wed, 13 Nov 2019 02:17:20 +0000 (+0000) Subject: rtc: mt6397: drop free_irq of devm_ allocated irq X-Git-Tag: v5.5.4~74 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=f698c219481726166b09121e5e636b0ed3ba0edc;p=users%2Fdwmw2%2Flinux.git rtc: mt6397: drop free_irq of devm_ allocated irq commit 751438bc0f10f75633144acd6ff145f7260706d5 upstream. The devm_request_threaded_irq function allocates irq that is released when a driver detaches. Thus, there is no reason to explicitly call free_irq in probe function. Fixes: 851b87148aa2 ("rtc: mt6397: improvements of rtc driver") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun Link: https://lore.kernel.org/r/20191113021720.9527-1-weiyongjun1@huawei.com Signed-off-by: Alexandre Belloni Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c index 9135e21017523..cda238dfe69b6 100644 --- a/drivers/rtc/rtc-mt6397.c +++ b/drivers/rtc/rtc-mt6397.c @@ -297,15 +297,7 @@ static int mtk_rtc_probe(struct platform_device *pdev) rtc->rtc_dev->ops = &mtk_rtc_ops; - ret = rtc_register_device(rtc->rtc_dev); - if (ret) - goto out_free_irq; - - return 0; - -out_free_irq: - free_irq(rtc->irq, rtc); - return ret; + return rtc_register_device(rtc->rtc_dev); } #ifdef CONFIG_PM_SLEEP